Unverified Commit e2a619b5 authored by Neelay Shah's avatar Neelay Shah Committed by GitHub
Browse files

fix: remove environment variable passing (#1911)


Signed-off-by: default avatarNeelay Shah <neelays@nvidia.com>
Co-authored-by: default avatarNeelay Shah <neelays@a4u8g-0057.ipp2u2.colossus.nvidia.com>
parent 3d17a49a
...@@ -265,19 +265,18 @@ class DynamoServeProcess(ManagedProcess): ...@@ -265,19 +265,18 @@ class DynamoServeProcess(ManagedProcess):
if graph.config: if graph.config:
command.extend(["-f", os.path.join(graph.directory, graph.config)]) command.extend(["-f", os.path.join(graph.directory, graph.config)])
command.extend(["--Frontend.port", str(port)])
if args: if args:
for k, v in args.items(): for k, v in args.items():
command.extend([f"{k}", f"{v}"]) command.extend([f"{k}", f"{v}"])
health_check_urls = [] health_check_urls = []
health_check_ports = [] health_check_ports = []
env = None
# Handle multimodal deployments differently # Handle multimodal deployments differently
if "multimodal" in graph.directory: if "multimodal" in graph.directory:
# port is currently required to be 8000 env = os.environ.copy()
assert port == 8000 env["DYNAMO_PORT"] = str(port)
else: else:
# Regular LLM deployments # Regular LLM deployments
command.extend(["--Frontend.port", str(port)]) command.extend(["--Frontend.port", str(port)])
...@@ -304,6 +303,7 @@ class DynamoServeProcess(ManagedProcess): ...@@ -304,6 +303,7 @@ class DynamoServeProcess(ManagedProcess):
"from multiprocessing.spawn", "from multiprocessing.spawn",
], ],
log_dir=request.node.name, log_dir=request.node.name,
env=env,
) )
def _check_model(self, response): def _check_model(self, response):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment