fix(operator): add back injection of DYN_SYSTEM_ENABLED env var (#4282)

deploy/cloud/operator/docs/footer.md

@@ -137,6 +137,7 @@ The operator automatically injects environment variables based on component type
 
 - **`DYN_SYSTEM_PORT`**: `9090` (automatically enables the system metrics server)
 - **`DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS`**: `["generate"]`
+- **`DYN_SYSTEM_ENABLED`**: `true` (needed for runtime images 0.6.1 and older)
 
 ### Planner Components
 

deploy/cloud/operator/internal/controller/dynamocomponentdeployment_controller_test.go

@@ -828,6 +828,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing.
 											{Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"},
 											{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"},
 											{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
+											{Name: "DYN_SYSTEM_ENABLED", Value: "true"},
 											{Name: "DYN_SYSTEM_PORT", Value: "9090"},
 											{Name: "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS", Value: "[\"generate\"]"},
 											{Name: "POD_NAME", ValueFrom: &corev1.EnvVarSource{
@@ -952,6 +953,7 @@ func TestDynamoComponentDeploymentReconciler_generateLeaderWorkerSet(t *testing.
 											{Name: commonconsts.DynamoNamespaceEnvVar, Value: "default"},
 											{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-lws-deploy"},
 											{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
+											{Name: "DYN_SYSTEM_ENABLED", Value: "true"},
 											{Name: "DYN_SYSTEM_PORT", Value: "9090"},
 											{Name: "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS", Value: "[\"generate\"]"},
 											{Name: "POD_NAME", ValueFrom: &corev1.EnvVarSource{

deploy/cloud/operator/internal/dynamo/component_worker.go

@@ -74,6 +74,10 @@ func (w *WorkerDefaults) GetBaseContainer(context ComponentContext) (corev1.Cont
 	}
 
 	container.Env = append(container.Env, []corev1.EnvVar{
+		{
+			Name:  "DYN_SYSTEM_ENABLED",
+			Value: "true",
+		},
 		{
 			Name:  "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS",
 			Value: "[\"generate\"]",

deploy/cloud/operator/internal/dynamo/graph_test.go

@@ -1930,6 +1930,10 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
 														Name:  "DYNAMO_POD_GANG_SET_REPLICAS",
 														Value: "1",
 													},
+													{
+														Name:  "DYN_SYSTEM_ENABLED",
+														Value: "true",
+													},
 													{
 														Name:  "DYN_SYSTEM_PORT",
 														Value: "9090",
@@ -2099,6 +2103,10 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
 														Name:  "DYNAMO_POD_GANG_SET_REPLICAS",
 														Value: "1",
 													},
+													{
+														Name:  "DYN_SYSTEM_ENABLED",
+														Value: "true",
+													},
 													{
 														Name:  "DYN_SYSTEM_PORT",
 														Value: "9090",
@@ -2811,6 +2819,10 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
 														Name:  "DYN_SYSTEM_PORT",
 														Value: "9090",
 													},
+													{
+														Name:  "DYN_SYSTEM_ENABLED",
+														Value: "true",
+													},
 													{
 														Name:  "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS",
 														Value: "[\"generate\"]",
@@ -2967,6 +2979,10 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
 														Name:  "DYN_SYSTEM_PORT",
 														Value: "9090",
 													},
+													{
+														Name:  "DYN_SYSTEM_ENABLED",
+														Value: "true",
+													},
 													{
 														Name:  "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS",
 														Value: "[\"generate\"]",
@@ -4937,6 +4953,7 @@ func TestGenerateBasePodSpec_Worker(t *testing.T) {
 							{Name: commonconsts.DynamoNamespaceEnvVar, Value: ""},
 							{Name: "DYN_PARENT_DGD_K8S_NAME", Value: "test-deployment"},
 							{Name: "DYN_PARENT_DGD_K8S_NAMESPACE", Value: "default"},
+							{Name: "DYN_SYSTEM_ENABLED", Value: "true"},
 							{Name: "DYN_SYSTEM_PORT", Value: "9090"},
 							{Name: "DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS", Value: "[\"generate\"]"},
 							{Name: "POD_NAME", ValueFrom: &corev1.EnvVarSource{

deploy/helm/chart/templates/deployment.yaml

@@ -113,6 +113,8 @@ spec:
         - name: DYN_HTTP_PORT
           value: "{{ $.Values.dynamoPort | default 8000 }}"
         {{- else if $serviceSpec.componentType | eq "worker" }}
+        - name: DYN_SYSTEM_ENABLED
+          value: "true"
         - name: DYN_SYSTEM_PORT
           value: "{{ $.Values.dynamoSystemPort | default 9090 }}"
         - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS

deploy/helm/chart/templates/grove-podgangset.yaml

@@ -105,6 +105,8 @@ spec:
             - name: DYN_HTTP_PORT
               value: "{{ $.Values.dynamoPort | default 8000 }}"
             {{- else if $serviceSpec.componentType | eq "worker" }}
+            - name: DYN_SYSTEM_ENABLED
+              value: "true"
             - name: DYN_SYSTEM_PORT
               value: "{{ $.Values.dynamoSystemPort | default 9090 }}"
             - name: DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS

docs/kubernetes/api_reference.md

@@ -732,6 +732,7 @@ The operator automatically injects environment variables based on component type
 
 - **`DYN_SYSTEM_PORT`**: `9090` (automatically enables the system metrics server)
 - **`DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS`**: `["generate"]`
+- **`DYN_SYSTEM_ENABLED`**: `true` (needed for runtime images 0.6.1 and older)
 
 ### Planner Components