Unverified Commit cdb7218a authored by Tushar Sharma's avatar Tushar Sharma Committed by GitHub
Browse files

fix: address sglang failures on pre-merge/post-merge workflows (#7255)


Co-authored-by: default avatarClaude Opus 4.6 (1M context) <noreply@anthropic.com>
parent 535ba421
...@@ -7,6 +7,8 @@ sglang-specific health check configuration. ...@@ -7,6 +7,8 @@ sglang-specific health check configuration.
This module defines the default health check payload for sglang backends. This module defines the default health check payload for sglang backends.
""" """
from __future__ import annotations
import logging import logging
from typing import Optional from typing import Optional
......
...@@ -9,6 +9,7 @@ from pathlib import Path ...@@ -9,6 +9,7 @@ from pathlib import Path
import pytest import pytest
import yaml import yaml
from sglang.srt.disaggregation.utils import FAKE_BOOTSTRAP_HOST
from dynamo.sglang.args import parse_args from dynamo.sglang.args import parse_args
from dynamo.sglang.health_check import ( from dynamo.sglang.health_check import (
...@@ -274,7 +275,7 @@ async def test_disagg_config_rejects_dynamo_keys(tmp_path, mock_sglang_cli, capf ...@@ -274,7 +275,7 @@ async def test_disagg_config_rejects_dynamo_keys(tmp_path, mock_sglang_cli, capf
def test_disagg_health_check_payload_includes_bootstrap_info(): def test_disagg_health_check_payload_includes_bootstrap_info():
payload = SglangDisaggHealthCheckPayload().to_dict() payload = SglangDisaggHealthCheckPayload().to_dict()
assert payload["bootstrap_info"]["bootstrap_host"] == "fake_bootstrap_host" assert payload["bootstrap_info"]["bootstrap_host"] == FAKE_BOOTSTRAP_HOST
assert payload["bootstrap_info"]["bootstrap_port"] == 0 assert payload["bootstrap_info"]["bootstrap_port"] == 0
assert payload["bootstrap_info"]["bootstrap_room"] == 0 assert payload["bootstrap_info"]["bootstrap_room"] == 0
assert payload["token_ids"] == [1] assert payload["token_ids"] == [1]
...@@ -284,5 +285,5 @@ def test_prefill_health_check_payload_is_disagg_compatible_alias(): ...@@ -284,5 +285,5 @@ def test_prefill_health_check_payload_is_disagg_compatible_alias():
payload = SglangPrefillHealthCheckPayload().to_dict() payload = SglangPrefillHealthCheckPayload().to_dict()
assert "request" not in payload assert "request" not in payload
assert payload["bootstrap_info"]["bootstrap_host"] == "fake_bootstrap_host" assert payload["bootstrap_info"]["bootstrap_host"] == FAKE_BOOTSTRAP_HOST
assert payload["stop_conditions"]["max_tokens"] == 1 assert payload["stop_conditions"]["max_tokens"] == 1
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment