Unverified Commit ac4fd87b authored by Ryan McCormick's avatar Ryan McCormick Committed by GitHub
Browse files

refactor: Log subprocess stderr as WARN (#1563)

parent 84454ab4
...@@ -98,7 +98,11 @@ pub async fn start( ...@@ -98,7 +98,11 @@ pub async fn start(
tokio::spawn(async move { tokio::spawn(async move {
let mut lines = stderr.lines(); let mut lines = stderr.lines();
while let Ok(Some(line)) = lines.next_line().await { while let Ok(Some(line)) = lines.next_line().await {
tracing::error!("{}", strip_log_prefix(&line)); // FIXME: always logging INFO/DEBUG will hide real errors, but
// some libraries log non-errors to stderr, which confuses users
// when we log those as ERROR. Using WARN as a middle ground for
// now, but we can probably be smarter here.
tracing::warn!("{}", strip_log_prefix(&line));
} }
}); });
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment