Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
97fee502
Unverified
Commit
97fee502
authored
Sep 30, 2025
by
Chia-Wei
Committed by
GitHub
Sep 30, 2025
Browse files
fix: fail fast custom template not found & more verbose vllm engine error (#3278)
Signed-off-by:
Chia-Wei Chen
<
cchen562@wisc.edu
>
parent
cacac9b9
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
0 deletions
+16
-0
components/backends/vllm/src/dynamo/vllm/args.py
components/backends/vllm/src/dynamo/vllm/args.py
+14
-0
components/backends/vllm/src/dynamo/vllm/engine_monitor.py
components/backends/vllm/src/dynamo/vllm/engine_monitor.py
+2
-0
No files found.
components/backends/vllm/src/dynamo/vllm/args.py
View file @
97fee502
...
...
@@ -156,6 +156,20 @@ def parse_args() -> Config:
config
.
tool_call_parser
=
args
.
dyn_tool_call_parser
config
.
reasoning_parser
=
args
.
dyn_reasoning_parser
config
.
custom_jinja_template
=
args
.
custom_jinja_template
# Validate custom Jinja template file exists if provided
if
config
.
custom_jinja_template
is
not
None
:
# Expand environment variables and user home (~) before validation
expanded_template_path
=
os
.
path
.
expanduser
(
os
.
path
.
expandvars
(
config
.
custom_jinja_template
)
)
config
.
custom_jinja_template
=
expanded_template_path
if
not
os
.
path
.
isfile
(
expanded_template_path
):
raise
FileNotFoundError
(
f
"Custom Jinja template file not found:
{
expanded_template_path
}
. "
f
"Please ensure the file exists and the path is correct."
)
# Check for conflicting flags
has_kv_transfer_config
=
(
hasattr
(
engine_args
,
"kv_transfer_config"
)
...
...
components/backends/vllm/src/dynamo/vllm/engine_monitor.py
View file @
97fee502
...
...
@@ -4,6 +4,7 @@
import
asyncio
import
logging
import
os
import
traceback
from
vllm.v1.engine.async_llm
import
AsyncLLM
from
vllm.v1.engine.exceptions
import
EngineDeadError
...
...
@@ -49,6 +50,7 @@ class VllmEngineMonitor:
await
self
.
engine_client
.
check_health
()
await
asyncio
.
sleep
(
HEALTH_CHECK_INTERVAL
)
except
EngineDeadError
as
e
:
logger
.
error
(
f
"Traceback:
{
traceback
.
format_exc
()
}
"
)
logger
.
error
(
f
"vLLM AsyncLLM health check failed:
{
e
}
"
)
logger
.
warning
(
"Initiating Dynamo Runtime shutdown."
)
self
.
runtime
.
shutdown
()
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment