Unverified Commit 895fb216 authored by hhzhang16's avatar hhzhang16 Committed by GitHub
Browse files

test: update planner docs with requirements that are needed; point users to...


test: update planner docs with requirements that are needed; point users to readme for installation (#3032)
Signed-off-by: default avatarHannah Zhang <hannahz@nvidia.com>
parent aa80ac41
...@@ -246,15 +246,3 @@ The table below shows the performance improvement of SLA planner across differen ...@@ -246,15 +246,3 @@ The table below shows the performance improvement of SLA planner across differen
| Inefficient parallelization mapping | 311% | 249% | | Inefficient parallelization mapping | 311% | 249% |
| Best static deployment | 52% | 29% |` | Best static deployment | 52% | 29% |`
### Prerequisites
**For Unit Tests:**
- Python dependencies installed
- PYTHONPATH set to include `components/planner/src` (see unit test examples above)
**For E2E Tests:**
- Kubernetes cluster with GPU nodes
- kubectl configured and accessible
- genai-perf available in PATH
- Python dependencies installed
- PYTHONPATH properly configured for planner imports
...@@ -48,7 +48,7 @@ check_prerequisites() { ...@@ -48,7 +48,7 @@ check_prerequisites() {
log_info "Checking prerequisites..." log_info "Checking prerequisites..."
if ! command -v kubectl &> /dev/null; then if ! command -v kubectl &> /dev/null; then
log_error "kubectl not found. Please install kubectl." log_error "kubectl not found. Please ensure it is installed and in your PATH."
exit 1 exit 1
fi fi
...@@ -62,29 +62,11 @@ check_prerequisites() { ...@@ -62,29 +62,11 @@ check_prerequisites() {
exit 1 exit 1
fi fi
if [ ! -f "test_scaling_e2e.py" ]; then
log_error "test_scaling_e2e.py not found. Make sure you're in the tests/planner directory."
exit 1
fi
# Check for genai-perf # Check for genai-perf
if ! command -v genai-perf &> /dev/null; then if ! command -v genai-perf &> /dev/null; then
log_warning "genai-perf not found. This tool is required for load generation." log_error "genai-perf not found. This tool is required for load generation."
echo -n "Would you like us to install it for you? (y/n): " log_error "Please install the required dependencies by following the instructions in tests/planner/README.md"
read -r response exit 1
if [[ "$response" =~ ^[Yy]$ ]]; then
log_info "Installing genai-perf and perf_analyzer..."
# Install specific versions for reproducibility and security
if pip install 'nvidia-ml-py3>=12.0.0' 'genai-perf>=0.0.4' 'tritonclient[all]>=2.48.0'; then
log_success "genai-perf and perf_analyzer installed successfully"
else
log_error "Failed to install genai-perf. Please install it manually: pip install 'nvidia-ml-py3>=12.0.0' 'genai-perf>=0.0.4' 'tritonclient[all]>=2.48.0'"
exit 1
fi
else
log_error "genai-perf is required for the scaling test. Please install it: pip install 'nvidia-ml-py3>=12.0.0' 'genai-perf>=0.0.4' 'tritonclient[all]>=2.48.0'"
exit 1
fi
fi fi
log_success "Prerequisites check passed" log_success "Prerequisites check passed"
......
...@@ -52,6 +52,7 @@ def planner(): ...@@ -52,6 +52,7 @@ def planner():
args.itl = 10 # ms args.itl = 10 # ms
args.backend = "vllm" args.backend = "vllm"
args.no_operation = True # Don't actually scale args.no_operation = True # Don't actually scale
args.no_correction = False # Allow correction factors
args.prometheus_port = 0 # 0 means disabled args.prometheus_port = 0 # 0 means disabled
args.load_predictor = "constant" args.load_predictor = "constant"
args.load_prediction_window_size = 10 args.load_prediction_window_size = 10
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment