Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
7ffc699f
Unverified
Commit
7ffc699f
authored
Apr 21, 2026
by
MatejKosec
Committed by
GitHub
Apr 21, 2026
Browse files
fix(discovery): send ModelUpdate::Added after add_worker_set completes (#8242)
Signed-off-by:
Matej Kosec
<
mkosec@nvidia.com
>
parent
1c9412d2
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
4 deletions
+8
-4
lib/llm/src/discovery/watcher.rs
lib/llm/src/discovery/watcher.rs
+8
-4
No files found.
lib/llm/src/discovery/watcher.rs
View file @
7ffc699f
...
@@ -665,10 +665,6 @@ impl ModelWatcher {
...
@@ -665,10 +665,6 @@ impl ModelWatcher {
self
.manager
self
.manager
.save_model_card
(
&
mcid
.to_path
(),
card
.clone
())
?
;
.save_model_card
(
&
mcid
.to_path
(),
card
.clone
())
?
;
if
let
Some
(
tx
)
=
&
self
.model_update_tx
{
tx
.send
(
ModelUpdate
::
Added
(
card
.clone
()))
.await
.ok
();
}
let
checksum
=
card
.mdcsum
();
let
checksum
=
card
.mdcsum
();
let
namespace
=
mcid
.namespace
.clone
();
let
namespace
=
mcid
.namespace
.clone
();
let
ws_key
=
worker_set_key
(
&
namespace
,
card
.model_type
);
let
ws_key
=
worker_set_key
(
&
namespace
,
card
.model_type
);
...
@@ -1018,6 +1014,10 @@ impl ModelWatcher {
...
@@ -1018,6 +1014,10 @@ impl ModelWatcher {
self
.manager
self
.manager
.add_worker_set
(
card
.name
(),
&
ws_key
,
worker_set
);
.add_worker_set
(
card
.name
(),
&
ws_key
,
worker_set
);
if
let
Some
(
tx
)
=
&
self
.model_update_tx
{
tx
.send
(
ModelUpdate
::
Added
(
card
.clone
()))
.await
.ok
();
}
// Note: activate_prefill_router is keyed by deployment namespace (not ws_key)
// Note: activate_prefill_router is keyed by deployment namespace (not ws_key)
// because it coordinates between decode and prefill WorkerSets that share
// because it coordinates between decode and prefill WorkerSets that share
// the same deployment namespace but have different ws_keys ("ns" vs "ns:prefill").
// the same deployment namespace but have different ws_keys ("ns" vs "ns:prefill").
...
@@ -1052,6 +1052,10 @@ impl ModelWatcher {
...
@@ -1052,6 +1052,10 @@ impl ModelWatcher {
self
.manager
self
.manager
.add_worker_set
(
card
.name
(),
&
ws_key
,
worker_set
);
.add_worker_set
(
card
.name
(),
&
ws_key
,
worker_set
);
if
let
Some
(
tx
)
=
&
self
.model_update_tx
{
tx
.send
(
ModelUpdate
::
Added
(
card
.clone
()))
.await
.ok
();
}
Ok
(())
Ok
(())
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment