Unverified Commit 7ffc699f authored by MatejKosec's avatar MatejKosec Committed by GitHub
Browse files

fix(discovery): send ModelUpdate::Added after add_worker_set completes (#8242)


Signed-off-by: default avatarMatej Kosec <mkosec@nvidia.com>
parent 1c9412d2
...@@ -665,10 +665,6 @@ impl ModelWatcher { ...@@ -665,10 +665,6 @@ impl ModelWatcher {
self.manager self.manager
.save_model_card(&mcid.to_path(), card.clone())?; .save_model_card(&mcid.to_path(), card.clone())?;
if let Some(tx) = &self.model_update_tx {
tx.send(ModelUpdate::Added(card.clone())).await.ok();
}
let checksum = card.mdcsum(); let checksum = card.mdcsum();
let namespace = mcid.namespace.clone(); let namespace = mcid.namespace.clone();
let ws_key = worker_set_key(&namespace, card.model_type); let ws_key = worker_set_key(&namespace, card.model_type);
...@@ -1018,6 +1014,10 @@ impl ModelWatcher { ...@@ -1018,6 +1014,10 @@ impl ModelWatcher {
self.manager self.manager
.add_worker_set(card.name(), &ws_key, worker_set); .add_worker_set(card.name(), &ws_key, worker_set);
if let Some(tx) = &self.model_update_tx {
tx.send(ModelUpdate::Added(card.clone())).await.ok();
}
// Note: activate_prefill_router is keyed by deployment namespace (not ws_key) // Note: activate_prefill_router is keyed by deployment namespace (not ws_key)
// because it coordinates between decode and prefill WorkerSets that share // because it coordinates between decode and prefill WorkerSets that share
// the same deployment namespace but have different ws_keys ("ns" vs "ns:prefill"). // the same deployment namespace but have different ws_keys ("ns" vs "ns:prefill").
...@@ -1052,6 +1052,10 @@ impl ModelWatcher { ...@@ -1052,6 +1052,10 @@ impl ModelWatcher {
self.manager self.manager
.add_worker_set(card.name(), &ws_key, worker_set); .add_worker_set(card.name(), &ws_key, worker_set);
if let Some(tx) = &self.model_update_tx {
tx.send(ModelUpdate::Added(card.clone())).await.ok();
}
Ok(()) Ok(())
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment