Unverified Commit 771d8c02 authored by Kyle McGill's avatar Kyle McGill Committed by GitHub
Browse files

fix: TENSORRTLLM_PIP_WHEEL_DIR has reasonable default set when building and...

fix: TENSORRTLLM_PIP_WHEEL_DIR has reasonable default set when building and installing TRTLLM from source (#4414)
parent fc2ad4eb
...@@ -84,7 +84,7 @@ TRTLLM_BASE_IMAGE_TAG=25.06-py3 ...@@ -84,7 +84,7 @@ TRTLLM_BASE_IMAGE_TAG=25.06-py3
# By default, we will use option 1. If you want to use option 2, you can set # By default, we will use option 1. If you want to use option 2, you can set
# TENSORRTLLM_PIP_WHEEL to the TensorRT-LLM wheel on artifactory. # TENSORRTLLM_PIP_WHEEL to the TensorRT-LLM wheel on artifactory.
# #
# DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR="/tmp/trtllm_wheel/" DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR="/tmp/trtllm_wheel/"
# TensorRT-LLM commit to use for building the trtllm wheel if not provided. # TensorRT-LLM commit to use for building the trtllm wheel if not provided.
# Important Note: This commit is not used in our CI pipeline. See the CI # Important Note: This commit is not used in our CI pipeline. See the CI
...@@ -750,6 +750,8 @@ if [[ $FRAMEWORK == "TRTLLM" ]]; then ...@@ -750,6 +750,8 @@ if [[ $FRAMEWORK == "TRTLLM" ]]; then
BUILD_CONTEXT_ARG+=" --build-context trtllm_wheel=${TENSORRTLLM_PIP_WHEEL_DIR}" BUILD_CONTEXT_ARG+=" --build-context trtllm_wheel=${TENSORRTLLM_PIP_WHEEL_DIR}"
PRINT_TRTLLM_WHEEL_FILE=$(find $TENSORRTLLM_PIP_WHEEL_DIR -name "*.whl" | head -n 1) PRINT_TRTLLM_WHEEL_FILE=$(find $TENSORRTLLM_PIP_WHEEL_DIR -name "*.whl" | head -n 1)
elif [[ "$TRTLLM_INTENTION" == "build" ]]; then elif [[ "$TRTLLM_INTENTION" == "build" ]]; then
TENSORRTLLM_PIP_WHEEL_DIR=${TENSORRTLLM_PIP_WHEEL_DIR:=$DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR}
echo "TRTLLM pip wheel output directory is: ${TENSORRTLLM_PIP_WHEEL_DIR}"
if [ "$DRY_RUN" != "true" ]; then if [ "$DRY_RUN" != "true" ]; then
GIT_URL_ARG="" GIT_URL_ARG=""
if [ -n "${TRTLLM_GIT_URL}" ]; then if [ -n "${TRTLLM_GIT_URL}" ]; then
......
...@@ -283,6 +283,7 @@ class TestBuildShTRTLLMBuild: ...@@ -283,6 +283,7 @@ class TestBuildShTRTLLMBuild:
assert "Intent to Download TRTLLM: false" in stdout assert "Intent to Download TRTLLM: false" in stdout
assert "Intent to Install TRTLLM: false" in stdout assert "Intent to Install TRTLLM: false" in stdout
assert "Intent to Build TRTLLM: true" in stdout assert "Intent to Build TRTLLM: true" in stdout
assert "TRTLLM pip wheel output directory is: /tmp/trtllm_wheel/"
def test_build_with_git_url_and_wheel_dir(self, build_script_path, temp_wheel_dir): def test_build_with_git_url_and_wheel_dir(self, build_script_path, temp_wheel_dir):
"""Test build with --tensorrtllm-git-url and --tensorrtllm-pip-wheel-dir""" """Test build with --tensorrtllm-git-url and --tensorrtllm-pip-wheel-dir"""
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment