Unverified Commit 5cbfc27e authored by Keiven C's avatar Keiven C Committed by GitHub
Browse files

docs: Add deprecation notices for unused Docker build arguments (no code change at all) (#3568)


Co-authored-by: default avatarKeiven Chang <keivenchang@users.noreply.github.com>
parent 4a55fa99
...@@ -591,6 +591,13 @@ if [[ $TARGET == "local-dev" ]]; then ...@@ -591,6 +591,13 @@ if [[ $TARGET == "local-dev" ]]; then
TARGET_STR="--target dev" TARGET_STR="--target dev"
fi fi
# DEPRECATION: The following build args are not currently used by any Dockerfile and will be removed soon:
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN
# BUILD DEV IMAGE # BUILD DEV IMAGE
BUILD_ARGS+=" --build-arg BASE_IMAGE=$BASE_IMAGE --build-arg BASE_IMAGE_TAG=$BASE_IMAGE_TAG --build-arg FRAMEWORK=$FRAMEWORK --build-arg ${FRAMEWORK}_FRAMEWORK=1 --build-arg VERSION=$VERSION --build-arg PYTHON_PACKAGE_VERSION=$PYTHON_PACKAGE_VERSION" BUILD_ARGS+=" --build-arg BASE_IMAGE=$BASE_IMAGE --build-arg BASE_IMAGE_TAG=$BASE_IMAGE_TAG --build-arg FRAMEWORK=$FRAMEWORK --build-arg ${FRAMEWORK}_FRAMEWORK=1 --build-arg VERSION=$VERSION --build-arg PYTHON_PACKAGE_VERSION=$PYTHON_PACKAGE_VERSION"
...@@ -752,11 +759,27 @@ if [[ -z "${DEV_IMAGE_INPUT:-}" ]]; then ...@@ -752,11 +759,27 @@ if [[ -z "${DEV_IMAGE_INPUT:-}" ]]; then
echo "======================================" echo "======================================"
echo "Starting Build 1: Base Image" echo "Starting Build 1: Base Image"
echo "======================================" echo "======================================"
# Build 1 (container/Dockerfile) does NOT use (will be removed soon):
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN
# - MAX_JOBS
$RUN_PREFIX docker build -f "${SOURCE_DIR}/Dockerfile" --target dev $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO --tag $DYNAMO_BASE_IMAGE $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE $RUN_PREFIX docker build -f "${SOURCE_DIR}/Dockerfile" --target dev $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO --tag $DYNAMO_BASE_IMAGE $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE
# Start framework build # Start framework build
echo "======================================" echo "======================================"
echo "Starting Build 2: Framework Image" echo "Starting Build 2: Framework Image"
echo "======================================" echo "======================================"
# Build 2 (container/Dockerfile.vllm or .trtllm, .sglang) does NOT use (will be removed soon):
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN
# - NIXL_REF
# - NIXL_UCX_REF
# - ENABLE_KVBM
BUILD_ARGS+=" --build-arg DYNAMO_BASE_IMAGE=${DYNAMO_BASE_IMAGE}" BUILD_ARGS+=" --build-arg DYNAMO_BASE_IMAGE=${DYNAMO_BASE_IMAGE}"
$RUN_PREFIX docker build -f $DOCKERFILE $TARGET_STR $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO $TAG $LATEST_TAG $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE $RUN_PREFIX docker build -f $DOCKERFILE $TARGET_STR $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO $TAG $LATEST_TAG $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE
else else
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment