Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
dynamo
Commits
4a73b3c6
Unverified
Commit
4a73b3c6
authored
Sep 08, 2025
by
Ayush Agarwal
Committed by
GitHub
Sep 08, 2025
Browse files
chore: add preference logic for using tool-call and reasoning parsers for sglang (#2922)
Signed-off-by:
ayushag
<
ayushag@nvidia.com
>
parent
b929e134
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
46 additions
and
2 deletions
+46
-2
components/backends/sglang/src/dynamo/sglang/args.py
components/backends/sglang/src/dynamo/sglang/args.py
+46
-2
No files found.
components/backends/sglang/src/dynamo/sglang/args.py
View file @
4a73b3c6
...
...
@@ -15,8 +15,11 @@ from typing import Any, Dict, Optional
from
sglang.srt.server_args
import
ServerArgs
from
dynamo._core
import
get_reasoning_parser_names
,
get_tool_parser_names
from
dynamo.runtime.logging
import
configure_dynamo_logging
from
dynamo.sglang
import
__version__
configure_dynamo_logging
()
DEFAULT_ENDPOINT
=
"dyn://dynamo.backend.generate"
DYNAMO_ARGS
:
Dict
[
str
,
Dict
[
str
,
Any
]]
=
{
"endpoint"
:
{
...
...
@@ -80,6 +83,36 @@ class Config:
return
DisaggregationMode
.
DECODE
def
_set_parser
(
sglang_str
:
Optional
[
str
],
dynamo_str
:
Optional
[
str
],
arg_name
:
str
=
"tool-call-parser"
,
)
->
Optional
[
str
]:
# If both are present, give preference to dynamo_str
if
sglang_str
is
not
None
and
dynamo_str
is
not
None
:
logging
.
warning
(
f
"--dyn-
{
arg_name
}
and --
{
arg_name
}
are both set. Giving preference to --dyn-
{
arg_name
}
"
)
return
dynamo_str
# If dynamo_str is not set, use try to use sglang_str if it matches with the allowed parsers
elif
sglang_str
is
not
None
:
logging
.
warning
(
f
"--dyn-
{
arg_name
}
is not set. Using --
{
arg_name
}
."
)
if
arg_name
==
"tool-call-parser"
and
sglang_str
not
in
get_tool_parser_names
():
raise
ValueError
(
f
"--
{
arg_name
}
is not a valid tool call parser. Valid parsers are:
{
get_tool_parser_names
()
}
"
)
elif
(
arg_name
==
"reasoning-parser"
and
sglang_str
not
in
get_reasoning_parser_names
()
):
raise
ValueError
(
f
"--
{
arg_name
}
is not a valid reasoning parser. Valid parsers are:
{
get_reasoning_parser_names
()
}
"
)
return
sglang_str
else
:
return
dynamo_str
def
parse_args
(
args
:
list
[
str
])
->
Config
:
"""
Parse all arguments and return Config with server_args and dynamo_args
...
...
@@ -138,13 +171,24 @@ def parse_args(args: list[str]) -> Config:
parsed_namespace
,
parsed_component_name
,
parsed_endpoint_name
=
endpoint_parts
tool_call_parser
=
_set_parser
(
parsed_args
.
tool_call_parser
,
parsed_args
.
dyn_tool_call_parser
,
"tool-call-parser"
,
)
reasoning_parser
=
_set_parser
(
parsed_args
.
reasoning_parser
,
parsed_args
.
dyn_reasoning_parser
,
"reasoning-parser"
,
)
dynamo_args
=
DynamoArgs
(
namespace
=
parsed_namespace
,
component
=
parsed_component_name
,
endpoint
=
parsed_endpoint_name
,
migration_limit
=
parsed_args
.
migration_limit
,
tool_call_parser
=
parsed_args
.
dyn_
tool_call_parser
,
reasoning_parser
=
parsed_args
.
dyn_
reasoning_parser
,
tool_call_parser
=
tool_call_parser
,
reasoning_parser
=
reasoning_parser
,
)
logging
.
debug
(
f
"Dynamo args:
{
dynamo_args
}
"
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment