Unverified Commit 4a71926d authored by Tanmay Verma's avatar Tanmay Verma Committed by GitHub
Browse files

chore: Decouple TLLM_LOG_LEVEL with DYN_LOG (#6606)

parent 06fc5d5e
......@@ -3,19 +3,7 @@
import asyncio
import logging
import os
# Configure TLLM_LOG_LEVEL before importing tensorrt_llm
# This must happen before any tensorrt_llm imports
if "TLLM_LOG_LEVEL" not in os.environ and os.getenv(
"DYN_SKIP_TRTLLM_LOG_FORMATTING"
) not in ("1", "true", "TRUE"):
# This import is safe because it doesn't trigger tensorrt_llm imports
from dynamo.runtime.logging import map_dyn_log_to_tllm_level
dyn_log = os.environ.get("DYN_LOG", "info")
tllm_level = map_dyn_log_to_tllm_level(dyn_log)
os.environ["TLLM_LOG_LEVEL"] = tllm_level
import uvloop
from dynamo.common.utils.graceful_shutdown import install_signal_handlers
......
......@@ -49,9 +49,7 @@ def _clean_env(monkeypatch):
"VLLM_CONFIGURE_LOGGING",
"VLLM_LOGGING_CONFIG_PATH",
"DYN_SKIP_SGLANG_LOG_FORMATTING",
"DYN_SKIP_TRTLLM_LOG_FORMATTING",
"SGLANG_LOGGING_CONFIG_PATH",
"TLLM_LOG_LEVEL",
]:
monkeypatch.delenv(var, raising=False)
......
......@@ -149,8 +149,6 @@ def configure_dynamo_logging(
configure_vllm_logging(dyn_level)
if not get_bool_env_var("DYN_SKIP_SGLANG_LOG_FORMATTING"):
configure_sglang_logging(dyn_level)
if not get_bool_env_var("DYN_SKIP_TRTLLM_LOG_FORMATTING"):
configure_trtllm_logging(dyn_level)
# loggers that should be configured to ERROR
error_loggers = ["tag"]
......@@ -272,43 +270,6 @@ def configure_vllm_logging(dyn_level: int):
async_llm_logger.addFilter(_HealthCheckFilter())
def map_dyn_log_to_tllm_level(dyn_log_value: str) -> str:
"""
Map DYN_LOG string value to TensorRT-LLM log level.
Args:
dyn_log_value: The DYN_LOG environment variable value (e.g., "debug", "info,module::path=trace")
Returns:
The corresponding TLLM_LOG_LEVEL value (e.g., "VERBOSE", "INFO")
"""
# Extract the base level (handle cases like "debug,module::path=trace")
base_level = dyn_log_value.lower().split(",")[0].strip()
# Map DYN_LOG levels to TLLM_LOG_LEVEL
level_mapping = {
"debug": "DEBUG",
"info": "INFO",
"warn": "WARNING",
"warning": "WARNING",
"error": "ERROR",
"critical": "ERROR",
"trace": "TRACE",
}
return level_mapping.get(base_level, "INFO")
def configure_trtllm_logging(dyn_level: int):
# Only set TLLM_LOG_LEVEL if it's not already set
# This allows users to override it explicitly if needed
if "TLLM_LOG_LEVEL" not in os.environ:
dyn_level_name = logging.getLevelName(dyn_level)
tllm_level = map_dyn_log_to_tllm_level(dyn_level_name)
os.environ["TLLM_LOG_LEVEL"] = tllm_level
logging.debug(f"Set TLLM_LOG_LEVEL to {tllm_level} based on DYN_LOG")
def get_bool_env_var(name: str, default: str = "false") -> bool:
value = os.getenv(name, default)
value = value.lower()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment