Commit 1dd20902 authored by ishandhanani's avatar ishandhanani Committed by GitHub
Browse files

fix: unify and enable dynamo logging (#520)


Signed-off-by: default avatarishandhanani <82981111+ishandhanani@users.noreply.github.com>
Co-authored-by: default avatarNeelay Shah <neelays@nvidia.com>
parent ec2e7307
......@@ -17,13 +17,12 @@ import logging
import logging.config
import os
from dynamo.runtime.logging import configure_logger
from dynamo.runtime.logging import configure_logger as configure_dynamo_logger
# Create a replacement for BentoML's configure_server_logging
def configure_server_logging():
"""
A single place to configure logging for Dynamo that can be used to replace BentoML's logging configuration.
A single place to configure logging for Dynamo.
"""
# First, remove any existing handlers to avoid duplication
root_logger = logging.getLogger()
......@@ -31,35 +30,23 @@ def configure_server_logging():
root_logger.removeHandler(handler)
# Configure the logger with Dynamo's handler
configure_logger()
configure_dynamo_logger()
# Make sure bentoml's loggers use the same configuration
bentoml_logger = logging.getLogger("bentoml")
# Disable VLLM's default configuration
os.environ["VLLM_CONFIGURE_LOGGING"] = "0"
# Configure vllm loggers to use our format
os.environ["VLLM_CONFIGURE_LOGGING"] = "0" # Disable VLLM's default configuration
# Get all vllm loggers and configure them
vllm_logger = logging.getLogger("vllm")
vllm_logger.handlers = []
vllm_logger.setLevel(logging.INFO)
vllm_logger.propagate = True
# Also handle any root loggers that VLLM might be using without the vllm prefix
other_loggers = ["__init__", "nixl"]
for logger_name in other_loggers:
# loggers that should be configured to INFO
info_loggers = ["vllm", "nixl", "__init__"]
for logger_name in info_loggers:
logger = logging.getLogger(logger_name)
logger.handlers = []
logger.setLevel(logging.INFO)
logger.propagate = True
# Bento Logger
bentoml_logger.setLevel(logging.ERROR)
bentoml_logger.propagate = True
# Override internal BentoML loggers
aux_bento_loggers = ["tag"]
for logger_name in aux_bento_loggers:
# loggers that should be configured to ERROR
error_loggers = ["bentoml", "tag"]
for logger_name in error_loggers:
logger = logging.getLogger(logger_name)
logger.handlers = []
logger.setLevel(logging.ERROR)
logger.propagate = True
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment