Unverified Commit 146eb3b4 authored by KrishnanPrash's avatar KrishnanPrash Committed by GitHub
Browse files

fix: pass through extra args in trtllm agg.sh launch script (#6787)


Signed-off-by: default avatarKrishnan Prashanth <kprashanth@nvidia.com>
parent 1bb28d6f
...@@ -21,6 +21,7 @@ cleanup() { ...@@ -21,6 +21,7 @@ cleanup() {
trap cleanup EXIT INT TERM trap cleanup EXIT INT TERM
ENABLE_OTEL=false ENABLE_OTEL=false
EXTRA_ARGS=()
while [[ $# -gt 0 ]]; do while [[ $# -gt 0 ]]; do
case $1 in case $1 in
--enable-otel) --enable-otel)
...@@ -33,12 +34,12 @@ while [[ $# -gt 0 ]]; do ...@@ -33,12 +34,12 @@ while [[ $# -gt 0 ]]; do
echo " --enable-otel Enable OpenTelemetry tracing" echo " --enable-otel Enable OpenTelemetry tracing"
echo " -h, --help Show this help message" echo " -h, --help Show this help message"
echo "" echo ""
echo "Any additional options are passed through to dynamo.trtllm."
exit 0 exit 0
;; ;;
*) *)
echo "Unknown option: $1" EXTRA_ARGS+=("$1")
echo "Use --help for usage information" shift
exit 1
;; ;;
esac esac
done done
...@@ -67,4 +68,4 @@ python3 -m dynamo.trtllm \ ...@@ -67,4 +68,4 @@ python3 -m dynamo.trtllm \
--modality "$MODALITY" \ --modality "$MODALITY" \
--extra-engine-args "$AGG_ENGINE_ARGS" \ --extra-engine-args "$AGG_ENGINE_ARGS" \
"${TRACE_ARGS[@]}" \ "${TRACE_ARGS[@]}" \
"$@" "${EXTRA_ARGS[@]}"
...@@ -271,7 +271,6 @@ trtllm_configs = { ...@@ -271,7 +271,6 @@ trtllm_configs = {
pytest.mark.gpu_1, pytest.mark.gpu_1,
pytest.mark.trtllm, pytest.mark.trtllm,
pytest.mark.post_merge, pytest.mark.post_merge,
pytest.mark.skip(reason="DYN-2262"),
pytest.mark.timeout( pytest.mark.timeout(
480 480
), # 3x measured time (83.85s) + download time (210s) for 7B model ), # 3x measured time (83.85s) + download time (210s) for 7B model
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment