Unverified Commit 0abebe38 authored by Qi Wang's avatar Qi Wang Committed by GitHub
Browse files

ci: add known_third_party to avoid pre-commit isort failure (#6292)

parent 94fad479
...@@ -139,6 +139,13 @@ balanced_wrapping = true ...@@ -139,6 +139,13 @@ balanced_wrapping = true
indent = " " indent = " "
skip = ["build"] skip = ["build"]
known_first_party = ["dynamo"] known_first_party = ["dynamo"]
# isort may confuse what is 1st or 3rd library. e.g.
# when dynamo/vllm/omni/xx.py import vllm, local isort may treat this `vllm` as first
# party heuristically. This causes local sort differs from GitHub sort and pre-commit
# failure. To mitigate 1) one can install 3rd party lib so that isort is aware of it,
# 2) hardcode 3rd party lib here, 3) add "# isort: skip_file" to problematic files
# as the last resort.
known_third_party = ["vllm", "tensorrt_llm", "sglang"]
[tool.pytest.ini_options] [tool.pytest.ini_options]
minversion = "8.0" minversion = "8.0"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment