Unverified Commit 037cc35d authored by Biswa Panda's avatar Biswa Panda Committed by GitHub
Browse files

fix: fix devcontainer build to work across shells (#3576)

parent 855d9a95
...@@ -426,7 +426,8 @@ If you see errors like "container is not running" or "An error occurred setting ...@@ -426,7 +426,8 @@ If you see errors like "container is not running" or "An error occurred setting
# If missing, build the dev image first, then build local-dev # If missing, build the dev image first, then build local-dev
export FRAMEWORK=VLLM # Replace with VLLM, SGLANG, or TRTLLM export FRAMEWORK=VLLM # Replace with VLLM, SGLANG, or TRTLLM
./container/build.sh --framework $FRAMEWORK ./container/build.sh --framework $FRAMEWORK
./container/build.sh --dev-image dynamo:latest-${FRAMEWORK,,} --framework $FRAMEWORK # change to lower case portable way across shells
./container/build.sh --dev-image dynamo:latest-$(echo "$FRAMEWORK" | tr '[:upper:]' '[:lower:]') --framework "$FRAMEWORK"
# Now you have dynamo:latest-vllm-local-dev # Now you have dynamo:latest-vllm-local-dev
``` ```
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment