migration.rs 34.4 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
// SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

use std::sync::Arc;

use anyhow::{Error, Result};
use futures::{stream, stream::StreamExt};

use async_nats::client::{
    RequestError as NatsRequestError, RequestErrorKind::NoResponders as NatsNoResponders,
};

use crate::{
14
    http::service::metrics::Metrics, model_card::ModelDeploymentCard, preprocessor::BackendOutput,
15
    protocols::common::llm_backend::PreprocessedRequest,
16
17
};

18
19
20
use dynamo_runtime::pipeline::{
    AsyncEngineContext, AsyncEngineContextProvider, Context, ManyOut, Operator, ResponseStream,
    ServerStreamingEngine, SingleIn, async_trait, network::STREAM_ERR_MSG,
21
};
22
use dynamo_runtime::protocols::{annotated::Annotated, maybe_error::MaybeError};
23
24
25

pub struct Migration {
    migration_limit: u32,
26
27
    model_name: Arc<String>,
    metrics: Arc<Metrics>,
28
29
30
}

impl Migration {
31
    pub fn from_mdc(mdc: &ModelDeploymentCard, metrics: Arc<Metrics>) -> Arc<Self> {
32
33
34
35
36
        tracing::debug!(
            "model {} migration limit {}",
            mdc.display_name,
            mdc.migration_limit
        );
37
        Arc::new(Self {
38
            migration_limit: mdc.migration_limit,
39
40
            model_name: Arc::new(mdc.display_name.clone()),
            metrics,
41
        })
42
43
44
45
46
47
48
    }
}

#[async_trait]
impl
    Operator<
        SingleIn<PreprocessedRequest>,
49
        ManyOut<Annotated<BackendOutput>>,
50
        SingleIn<PreprocessedRequest>,
51
        ManyOut<Annotated<BackendOutput>>,
52
53
54
55
56
    > for Migration
{
    async fn generate(
        &self,
        request: SingleIn<PreprocessedRequest>,
57
58
        next: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
    ) -> Result<ManyOut<Annotated<BackendOutput>>> {
59
60
        let (preprocessed_request, context) = request.transfer(());
        let engine_ctx = context.context();
61
        let engine_ctx_ = engine_ctx.clone();
62
63
64
65
66
67
68
69
70
        let retry_manager = RetryManager::build(
            engine_ctx,
            preprocessed_request,
            next,
            self.migration_limit,
            self.model_name.clone(),
            self.metrics.clone(),
        )
        .await?;
71
72
73
74
75
        let response_stream = stream::unfold(retry_manager, move |mut retry_manager| async move {
            retry_manager
                .next()
                .await
                .map(|response| (response, retry_manager))
76
        });
77
        Ok(ResponseStream::new(Box::pin(response_stream), engine_ctx_))
78
79
80
81
    }
}

struct RetryManager {
82
    context: Arc<dyn AsyncEngineContext>,
83
    request: PreprocessedRequest,
84
85
    next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
    next_stream: Option<ManyOut<Annotated<BackendOutput>>>,
86
    retries_left: u32,
87
88
    model_name: Arc<String>,
    metrics: Arc<Metrics>,
89
90
91
92
}

impl RetryManager {
    pub async fn build(
93
        context: Arc<dyn AsyncEngineContext>,
94
        preprocessed_request: PreprocessedRequest,
95
        next: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
96
        retries_left: u32,
97
98
        model_name: Arc<String>,
        metrics: Arc<Metrics>,
99
100
    ) -> Result<Self> {
        let mut slf = Self {
101
            context,
102
103
104
105
            request: preprocessed_request,
            next_generate: next,
            next_stream: None,
            retries_left: retries_left + 1, // +1 to account for the initial attempt
106
107
            model_name,
            metrics,
108
109
110
111
112
        };
        slf.new_stream().await?;
        Ok(slf)
    }

113
    pub async fn next(&mut self) -> Option<Annotated<BackendOutput>> {
114
115
116
117
118
119
120
121
122
123
124
        loop {
            let response_stream = match self.next_stream.as_mut() {
                Some(stream) => stream,
                None => {
                    tracing::error!("next() called with next_stream is None - should not happen");
                    return Some(Annotated::from_err(
                        Error::msg("next_stream is None").into(),
                    ));
                }
            };
            if let Some(response) = response_stream.next().await {
125
126
                if let Some(err) = response.err()
                    && err
127
128
                        .chain()
                        .any(|e| e.to_string().starts_with(STREAM_ERR_MSG))
129
130
                {
                    tracing::warn!("Stream disconnected... recreating stream...");
131
                    self.metrics.inc_migration_ongoing_request(&self.model_name);
132
133
134
135
                    if let Err(err) = self.new_stream().await {
                        tracing::warn!("Cannot recreate stream: {:#}", err);
                    } else {
                        continue;
136
137
138
139
140
141
142
143
144
145
                    }
                }
                self.track_response(&response);
                return Some(response);
            }
            return None;
        }
    }

    async fn new_stream(&mut self) -> Result<()> {
146
        let mut response_stream: Option<Result<ManyOut<Annotated<BackendOutput>>>> = None;
147
148
        while self.retries_left > 0 {
            self.retries_left -= 1;
149
150
            let request = Context::with_id(self.request.clone(), self.context.id().to_string());
            self.context.link_child(request.context());
151
152
153
154
155
156
157
            if self.context.is_stopped() || self.context.is_killed() {
                tracing::debug!("Abort creating new stream after context is stopped or killed");
                return Err(Error::msg(format!(
                    "Context id {} is stopped or killed",
                    self.context.id()
                )));
            }
158
            response_stream = Some(self.next_generate.generate(request).await);
159
160
161
162
163
            if let Some(err) = response_stream.as_ref().unwrap().as_ref().err()
                && let Some(req_err) = err.downcast_ref::<NatsRequestError>()
                && matches!(req_err.kind(), NatsNoResponders)
            {
                tracing::warn!("Creating new stream... retrying...");
164
                self.metrics.inc_migration_new_request(&self.model_name);
165
                continue;
166
167
168
169
170
171
172
173
            }
            break;
        }
        match response_stream {
            Some(Ok(next_stream)) => {
                self.next_stream = Some(next_stream);
                Ok(())
            }
174
            Some(Err(err)) => Err(err), // should propagate original error if any
175
            None => Err(Error::msg(
176
                "Migration limit exhausted", // should propagate original error if any
177
178
179
180
            )),
        }
    }

181
    fn track_response(&mut self, response: &Annotated<BackendOutput>) {
182
183
184
185
186
187
188
        if self.retries_left == 0 {
            return;
        }
        let llm_engine_output = match response.data.as_ref() {
            Some(output) => output,
            None => return,
        };
189
190
191
192
        if let Some(max_tokens) = self.request.stop_conditions.max_tokens {
            self.request.stop_conditions.max_tokens =
                Some(max_tokens.saturating_sub(llm_engine_output.token_ids.len() as u32));
        }
193
194
195
196
197
198
199
200
201
        for token_id in llm_engine_output.token_ids.iter() {
            self.request.token_ids.push(*token_id);
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
202
    use crate::http::service::metrics::Metrics;
Greg Clark's avatar
Greg Clark committed
203
    use crate::protocols::common::{OutputOptions, SamplingOptions, StopConditions};
204
    use dynamo_runtime::pipeline::AsyncEngine;
205
    use dynamo_runtime::pipeline::context::Controller;
206
207
208
    use std::sync::atomic::{AtomicU32, Ordering};
    use tokio::sync::mpsc;

209
210
    const TEST_MODEL: &str = "test-model";

211
    // Helper to create a mock preprocessed request
212
    fn create_mock_request(max_tokens: u32) -> PreprocessedRequest {
213
214
215
216
        PreprocessedRequest::builder()
            .model("mock".to_string())
            .token_ids(vec![1, 2, 3])
            .stop_conditions(StopConditions {
217
218
                max_tokens: Some(max_tokens),
                ..Default::default()
219
220
221
222
223
224
225
            })
            .sampling_options(SamplingOptions::default())
            .output_options(OutputOptions::default())
            .eos_token_ids(vec![])
            .annotations(vec![])
            .build()
            .unwrap()
226
227
228
    }

    // Helper to create mock LLM engine output
229
230
    fn create_mock_output(token_id: u32) -> Annotated<BackendOutput> {
        Annotated::from_data(BackendOutput {
231
            token_ids: vec![token_id],
232
233
            tokens: vec![],
            text: Some(format!("token_{token_id}")),
234
235
            cum_log_probs: None,
            log_probs: None,
Greg Clark's avatar
Greg Clark committed
236
            top_logprobs: None,
237
            finish_reason: None,
238
            stop_reason: None,
239
            index: None,
240
            disaggregated_params: None,
241
            completion_usage: None,
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
        })
    }

    #[derive(Debug, Clone)]
    enum MockBehavior {
        /// Always succeeds with all responses
        Success,
        /// Fails on first call with NoResponders error, then succeeds on subsequent calls
        FailThenSuccess,
        /// Succeeds initially, fails mid-stream with specific error, then succeeds on retry
        MidStreamFail { fail_after: usize },
        /// Succeeds initially, fails mid-stream with specific error, then always fails on retry attempts
        MidStreamFailAlways { fail_after: usize },
        /// Succeeds initially, fails mid-stream, then always fails with stream error on retry attempts
        MidStreamFailAlwaysStreamError { fail_after: usize },
        /// Always fails with NoResponders error (same as FailThenSuccess first call)
        AlwaysFail,
    }

    // Unified mock server streaming engine that can simulate different scenarios
    struct MockEngine {
        behavior: MockBehavior,
        num_responses: usize,
        token_offset: u32,
        call_count: Arc<AtomicU32>,
267
        context_id: String,
268
269
270
    }

    impl MockEngine {
271
272
273
274
275
276
        fn new(
            behavior: MockBehavior,
            num_responses: usize,
            token_offset: u32,
            context_id: String,
        ) -> Self {
277
278
279
280
281
            Self {
                behavior,
                num_responses,
                token_offset,
                call_count: Arc::new(AtomicU32::new(0)),
282
                context_id,
283
284
285
286
287
288
            }
        }
    }

    #[async_trait]
    impl
289
290
        AsyncEngine<SingleIn<PreprocessedRequest>, ManyOut<Annotated<BackendOutput>>, anyhow::Error>
        for MockEngine
291
292
293
294
    {
        async fn generate(
            &self,
            request: SingleIn<PreprocessedRequest>,
295
        ) -> Result<ManyOut<Annotated<BackendOutput>>> {
296
            let call_num = self.call_count.fetch_add(1, Ordering::SeqCst);
297
298
299
300
301
302
303
304
            let (preprocessed_request, context) = request.transfer(());

            // Assert that the context_id matches the expected one
            assert_eq!(
                context.id().to_string(),
                self.context_id,
                "Context ID mismatch"
            );
305
306
307
308
309
310
311
312

            // Calculate how many responses we've already generated based on request token_ids
            // Initial request has [1, 2, 3], so anything beyond that are generated responses
            let initial_tokens = 3; // [1, 2, 3]
            let responses_already_generated = preprocessed_request
                .token_ids
                .len()
                .saturating_sub(initial_tokens);
313
314
315
316
317
318
319
320
321
322
323
324

            // Assert that max_tokens reflects the expected remaining tokens
            let expected_max_tokens =
                self.num_responses
                    .saturating_sub(responses_already_generated) as u32;
            assert_eq!(
                preprocessed_request.stop_conditions.max_tokens,
                Some(expected_max_tokens),
                "max_tokens should be {} but got {:?}",
                expected_max_tokens,
                preprocessed_request.stop_conditions.max_tokens
            );
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359

            match &self.behavior {
                MockBehavior::Success => {
                    // Always succeed with remaining responses
                    self.send_responses(responses_already_generated, self.num_responses)
                        .await
                }
                MockBehavior::FailThenSuccess => {
                    if call_num == 0 {
                        // First call - return "No responders available" error to trigger retry
                        let nats_error: NatsRequestError = NatsNoResponders.into();
                        return Err(nats_error.into());
                    } else {
                        // Subsequent calls - succeed with remaining responses
                        self.send_responses(responses_already_generated, self.num_responses)
                            .await
                    }
                }
                MockBehavior::MidStreamFail { fail_after } => {
                    let (tx, rx) = mpsc::channel(1);
                    let token_offset = self.token_offset;
                    let fail_after = *fail_after;
                    let num_responses = self.num_responses;

                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
360
361
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
                            let _ = tx.send(error_response).await;
                        });
                    } else {
                        // Second call - send remaining responses from where we left off
                        tokio::spawn(async move {
                            for i in responses_already_generated..num_responses {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                        });
                    }

                    let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
377
                    let ctx = Arc::new(Controller::new(self.context_id.clone()));
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
                    Ok(dynamo_runtime::pipeline::ResponseStream::new(
                        Box::pin(stream),
                        ctx,
                    ))
                }
                MockBehavior::MidStreamFailAlways { fail_after } => {
                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        let (tx, rx) = mpsc::channel(1);
                        let token_offset = self.token_offset;
                        let fail_after = *fail_after;
                        let num_responses = self.num_responses;

                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
400
401
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
402
403
404
405
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
406
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    } else {
                        // Subsequent calls - always fail with NoResponders error (same as AlwaysFail)
                        let nats_error: NatsRequestError = NatsNoResponders.into();
                        Err(nats_error.into())
                    }
                }
                MockBehavior::MidStreamFailAlwaysStreamError { fail_after } => {
                    let (tx, rx) = mpsc::channel(1);
                    let token_offset = self.token_offset;
                    let fail_after = *fail_after;
                    let num_responses = self.num_responses;

                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
434
435
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
436
437
438
439
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
440
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
441
442
443
444
445
446
447
448
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    } else {
                        // Subsequent calls - immediately send stream error (no successful responses)
                        tokio::spawn(async move {
                            // Send the stream error immediately
449
450
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
451
452
453
454
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
455
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    }
                }
                MockBehavior::AlwaysFail => {
                    // Always fail with NoResponders error (same as FailThenSuccess first call)
                    let nats_error: NatsRequestError = NatsNoResponders.into();
                    Err(nats_error.into())
                }
            }
        }
    }

    impl MockEngine {
        async fn send_responses(
            &self,
            start: usize,
            end: usize,
476
        ) -> Result<ManyOut<Annotated<BackendOutput>>> {
477
478
479
480
481
482
483
484
485
486
487
488
489
            let (tx, rx) = mpsc::channel(1);
            let token_offset = self.token_offset;

            tokio::spawn(async move {
                for i in start..end {
                    let response = create_mock_output(token_offset + 1 + i as u32);
                    if tx.send(response).await.is_err() {
                        break;
                    }
                }
            });

            let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
490
            let ctx = Arc::new(Controller::new(self.context_id.clone()));
491
492
493
494
495
496
497
498
499
500
501
502
503
            Ok(dynamo_runtime::pipeline::ResponseStream::new(
                Box::pin(stream),
                ctx,
            ))
        }
    }

    /// Test case 1: No migration needed
    /// Tests the normal case where the RetryManager successfully processes all responses
    /// from a single stream without any failures or need for retries/migration.
    /// Expected behavior: All 10 responses should be received successfully.
    #[tokio::test]
    async fn test_retry_manager_no_migration() {
504
        dynamo_runtime::logging::init();
505
        let context_id = uuid::Uuid::new_v4().to_string();
506
        let request = create_mock_request(10);
507
508
509
510
511
512
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::Success,
            10,
            100,
            context_id.clone(),
        ));
513
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
514
515
            mock_engine;

516
        let ctx = Arc::new(Controller::new(context_id.clone()));
517
518
519
520
521
522
523
524
525
526
527
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            0,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
528
529
530
531
532
533
534
535
536
537
538
539
540

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        assert_eq!(responses.len(), 10);
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
541
542
543

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
544
545
546
547
548
549
550
551
552
553
    }

    /// Test case 2: New request migration
    /// Tests the scenario where a worker becomes unreachable for new requests initially,
    /// triggering the RetryManager to retry the request. The MockEngine with FailThenSuccess
    /// fails on the first call with a "No responders available" error, then succeeds
    /// on subsequent calls, simulating a worker becoming available after initial failure.
    /// Expected behavior: All 10 responses should be received successfully after retry.
    #[tokio::test]
    async fn test_retry_manager_new_request_migration() {
554
        dynamo_runtime::logging::init();
555
        let context_id = uuid::Uuid::new_v4().to_string();
556
        let request = create_mock_request(10);
557
558
559
560
561
562
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::FailThenSuccess,
            10,
            100,
            context_id.clone(),
        ));
563
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
564
565
            mock_engine;

566
        let ctx = Arc::new(Controller::new(context_id.clone()));
567
568
569
570
571
572
573
574
575
576
577
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
578
579
580
581
582
583
584
585
586
587
588
589
590

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        assert_eq!(responses.len(), 10);
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
591
592
593

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 1);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
594
595
596
597
598
599
600
601
602
603
    }

    /// Test case 3: Ongoing request migration
    /// Tests the scenario where a worker fails mid-stream during an ongoing request.
    /// This simulates a connection being lost after partial response delivery, requiring
    /// the RetryManager to detect the failure (via "Stream ended before generation completed" error),
    /// create a new stream, and continue from where it left off.
    /// Expected behavior: 5 responses from first stream + 5 responses from retry stream = 10 total.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration() {
604
605
        dynamo_runtime::logging::init();

606
        let context_id = uuid::Uuid::new_v4().to_string();
607
        let request = create_mock_request(10);
608
609
610
611
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFail { fail_after: 5 },
            10,
            100,
612
            context_id.clone(),
613
        ));
614
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
615
616
            mock_engine;

617
        let ctx = Arc::new(Controller::new(context_id.clone()));
618
619
620
621
622
623
624
625
626
627
628
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received all 10 responses (5 from first stream + 5 from second stream)
        assert_eq!(responses.len(), 10);

        // Check that we received responses from both streams
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
645
646
647

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 1);
648
649
650
651
652
653
654
655
    }

    /// Test case 4: New request migration - indefinite failure
    /// Tests the scenario where a worker becomes unreachable for new requests indefinitely.
    /// The RetryManager should exhaust all retries and return the original error from the first attempt.
    /// Expected behavior: Should receive an error after all retries are exhausted, with the original error.
    #[tokio::test]
    async fn test_retry_manager_new_request_migration_indefinite_failure() {
656
        dynamo_runtime::logging::init();
657
        let context_id = uuid::Uuid::new_v4().to_string();
658
        let request = create_mock_request(0);
659
660
661
662
663
664
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::AlwaysFail,
            0,
            100,
            context_id.clone(),
        ));
665
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
666
667
668
            mock_engine;

        // Should fail to build due to initial stream creation failure after exhausting all 3 retries
669
        let ctx = Arc::new(Controller::new(context_id.clone()));
670
671
672
673
674
675
676
677
678
679
        let metrics = Arc::new(Metrics::new());
        let retry_manager_result = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await;
680
681
682
683
684

        assert!(retry_manager_result.is_err());
        if let Err(error) = retry_manager_result {
            assert!(error.to_string().contains("no responders"));
        }
685
686
687

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 4); // 3 retries + 1 final failure
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
688
689
690
691
692
693
694
695
    }

    /// Test case 5: Ongoing request migration - indefinite failure
    /// Tests the scenario where a worker fails mid-stream indefinitely during ongoing requests.
    /// The RetryManager should exhaust all retries and return the original stream disconnection error.
    /// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration_indefinite_failure() {
696
        dynamo_runtime::logging::init();
697
        let context_id = uuid::Uuid::new_v4().to_string();
698
        let request = create_mock_request(10);
699
700
701
702
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFailAlways { fail_after: 3 },
            10,
            100,
703
            context_id.clone(),
704
        ));
705
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
706
707
            mock_engine;

708
        let ctx = Arc::new(Controller::new(context_id.clone()));
709
710
711
712
713
714
715
716
717
718
719
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        ) // 3 retries
        .await
        .expect("Failed to build RetryManager");
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742

        let mut responses = Vec::new();

        // Collect all responses (both successful and error responses)
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received 4 total responses: 3 successful + 1 error
        assert_eq!(responses.len(), 4);

        // First 3 responses should be successful with tokens 101, 102, 103
        for (i, response) in responses[0..3].iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103
            }
        }

        // 4th response should be an error after retries are exhausted
        let error_response = &responses[3];
        assert!(error_response.err().is_some());
        if let Some(error) = error_response.err() {
743
            assert!(error.to_string().contains(STREAM_ERR_MSG));
744
        }
745
746
747

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 3); // 2 retries + 1 final failure
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 1); // initial ongoing failure retry
748
749
750
751
752
753
754
755
    }

    /// Test case 6: Ongoing request migration - indefinite failure with stream errors
    /// Tests the scenario where a worker fails mid-stream indefinitely during ongoing requests,
    /// and all retry attempts also fail with stream errors instead of NATS errors.
    /// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration_indefinite_failure_stream_error() {
756
        dynamo_runtime::logging::init();
757
        let context_id = uuid::Uuid::new_v4().to_string();
758
        let request = create_mock_request(10);
759
760
761
762
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFailAlwaysStreamError { fail_after: 3 },
            10,
            100,
763
            context_id.clone(),
764
        ));
765
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
766
767
            mock_engine;

768
        let ctx = Arc::new(Controller::new(context_id.clone()));
769
770
771
772
773
774
775
776
777
778
779
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        ) // 3 retries
        .await
        .expect("Failed to build RetryManager");
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802

        let mut responses = Vec::new();

        // Collect all responses (both successful and error responses)
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received 4 total responses: 3 successful + 1 error
        assert_eq!(responses.len(), 4);

        // First 3 responses should be successful with tokens 101, 102, 103
        for (i, response) in responses[0..3].iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103
            }
        }

        // 4th response should be an error after retries are exhausted
        let error_response = &responses[3];
        assert!(error_response.err().is_some());
        if let Some(error) = error_response.err() {
803
            assert!(error.to_string().contains(STREAM_ERR_MSG));
804
        }
805
806
807

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 4); // 3 retries + 1 final failure
808
    }
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824

    /// Test case 7: Request cancelled when creating new stream
    /// Tests the scenario where context.stop_generating() is called when creating a new stream.
    /// The RetryManager should detect that the context is stopped and abort creating new streams.
    /// Expected behavior: Should fail to build RetryManager with "Context is stopped or killed" error.
    #[tokio::test]
    async fn test_retry_manager_context_stopped_before_stream() {
        dynamo_runtime::logging::init();
        let context_id = uuid::Uuid::new_v4().to_string();
        let request = create_mock_request(10);
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::Success,
            10,
            100,
            context_id.clone(),
        ));
825
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
826
827
828
829
830
831
832
833
            mock_engine;

        let ctx = Arc::new(Controller::new(context_id.clone()));

        // Stop the context before building RetryManager
        ctx.stop_generating();

        // Should fail to build due to stopped context
834
835
836
837
838
839
840
841
842
843
        let metrics = Arc::new(Metrics::new());
        let retry_manager_result = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await;
844
845
846
847
848
849
850
851
852

        assert!(retry_manager_result.is_err());
        if let Err(error) = retry_manager_result {
            assert!(
                error
                    .to_string()
                    .contains(&format!("Context id {} is stopped or killed", context_id))
            );
        }
853
854
855

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
856
    }
857
}