shared_test.go 9.44 KB
Newer Older
1
/*
2
 * SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * SPDX-License-Identifier: Apache-2.0
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package validation

import (
	"testing"

23
	nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
24
25
26
	"k8s.io/apimachinery/pkg/api/resource"
)

27
28
29
30
31
// ptr is a helper function to create a pointer to a string
func ptr(s string) *string {
	return &s
}

32
33
34
35
36
37
38
func TestSharedSpecValidator_Validate(t *testing.T) {
	var (
		negativeReplicas = int32(-1)
		validReplicas    = int32(3)
	)

	tests := []struct {
39
40
41
42
43
44
		name                string
		spec                *nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec
		fieldPath           string
		calculatedNamespace string
		wantErr             bool
		errMsg              string
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
	}{
		{
			name: "valid spec with all fields",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas: &validReplicas,
				Ingress: &nvidiacomv1alpha1.IngressSpec{
					Enabled: true,
					Host:    "example.com",
				},
				VolumeMounts: []nvidiacomv1alpha1.VolumeMount{
					{
						Name:       "cache",
						MountPoint: "/cache",
					},
					{
						Name:                  "compilation",
						UseAsCompilationCache: true,
					},
				},
				SharedMemory: &nvidiacomv1alpha1.SharedMemorySpec{
					Disabled: false,
					Size:     resource.MustParse("1Gi"),
				},
			},
69
70
71
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
72
73
74
75
76
77
		},
		{
			name: "negative replicas",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas: &negativeReplicas,
			},
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             true,
			errMsg:              "spec.replicas must be non-negative",
		},
		{
			name: "nil dynamoNamespace is allowed",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				DynamoNamespace: nil,
			},
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
		},
		{
			name: "empty string dynamoNamespace is allowed",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				DynamoNamespace: ptr(""),
			},
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
100
101
102
103
104
105
106
107
108
		},
		{
			name: "ingress enabled without host",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Ingress: &nvidiacomv1alpha1.IngressSpec{
					Enabled: true,
					Host:    "",
				},
			},
109
110
111
112
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             true,
			errMsg:              "spec.ingress.host is required when ingress is enabled",
113
114
115
116
117
118
119
120
121
		},
		{
			name: "ingress disabled - no validation",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Ingress: &nvidiacomv1alpha1.IngressSpec{
					Enabled: false,
					Host:    "",
				},
			},
122
123
124
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
125
126
127
128
129
130
131
132
133
134
135
136
		},
		{
			name: "volume mount without mountPoint and not compilation cache",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				VolumeMounts: []nvidiacomv1alpha1.VolumeMount{
					{
						Name:                  "data",
						MountPoint:            "",
						UseAsCompilationCache: false,
					},
				},
			},
137
138
139
140
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             true,
			errMsg:              "spec.volumeMounts[0].mountPoint is required when useAsCompilationCache is false",
141
142
143
144
145
146
147
148
149
150
151
		},
		{
			name: "volume mount with mountPoint",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				VolumeMounts: []nvidiacomv1alpha1.VolumeMount{
					{
						Name:       "data",
						MountPoint: "/data",
					},
				},
			},
152
153
154
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
155
156
157
158
159
160
161
162
163
164
165
		},
		{
			name: "volume mount as compilation cache without mountPoint",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				VolumeMounts: []nvidiacomv1alpha1.VolumeMount{
					{
						Name:                  "cache",
						UseAsCompilationCache: true,
					},
				},
			},
166
167
168
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
169
170
171
172
173
174
175
176
177
		},
		{
			name: "shared memory enabled without size",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				SharedMemory: &nvidiacomv1alpha1.SharedMemorySpec{
					Disabled: false,
					Size:     resource.Quantity{},
				},
			},
178
179
180
181
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             true,
			errMsg:              "spec.sharedMemory.size is required when disabled is false",
182
183
184
185
186
187
188
189
190
		},
		{
			name: "shared memory enabled with size",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				SharedMemory: &nvidiacomv1alpha1.SharedMemorySpec{
					Disabled: false,
					Size:     resource.MustParse("2Gi"),
				},
			},
191
192
193
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
194
195
196
197
198
199
200
201
202
		},
		{
			name: "shared memory disabled without size",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				SharedMemory: &nvidiacomv1alpha1.SharedMemorySpec{
					Disabled: true,
					Size:     resource.Quantity{},
				},
			},
203
204
205
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantErr:             false,
206
207
208
209
210
211
		},
		{
			name: "custom field path for service validation",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas: &negativeReplicas,
			},
212
213
214
215
			fieldPath:           "spec.services[main]",
			calculatedNamespace: "default-my-dgd",
			wantErr:             true,
			errMsg:              "spec.services[main].replicas must be non-negative",
216
217
218
219
220
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
221
			validator := NewSharedSpecValidator(tt.spec, tt.fieldPath, tt.calculatedNamespace)
222
			_, err := validator.Validate()
223
224
225
226
227
228
229
230
231
232
233
234

			if (err != nil) != tt.wantErr {
				t.Errorf("SharedSpecValidator.Validate() error = %v, wantErr %v", err, tt.wantErr)
				return
			}

			if tt.wantErr && err.Error() != tt.errMsg {
				t.Errorf("SharedSpecValidator.Validate() error message = %v, want %v", err.Error(), tt.errMsg)
			}
		})
	}
}
235
236
237
238
239

func TestSharedSpecValidator_Validate_Warnings(t *testing.T) {
	validReplicas := int32(3)

	tests := []struct {
240
241
242
243
244
245
		name                string
		spec                *nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec
		fieldPath           string
		calculatedNamespace string
		wantWarnings        int
		wantWarningContains string // optional substring to check in warning
246
247
248
249
250
251
	}{
		{
			name: "no warnings for spec without autoscaling",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas: &validReplicas,
			},
252
253
254
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantWarnings:        0,
255
256
257
258
259
260
261
262
263
264
265
266
		},
		{
			name: "warning for deprecated autoscaling field enabled",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas: &validReplicas,
				//nolint:staticcheck // SA1019: Intentionally testing deprecated field
				Autoscaling: &nvidiacomv1alpha1.Autoscaling{
					Enabled:     true,
					MinReplicas: 1,
					MaxReplicas: 10,
				},
			},
267
268
269
270
271
272
273
274
275
276
277
278
279
280
			fieldPath:           "spec",
			calculatedNamespace: "default-my-dgd",
			wantWarnings:        1,
		},
		{
			name: "warning for deprecated dynamoNamespace field shows calculated namespace",
			spec: &nvidiacomv1alpha1.DynamoComponentDeploymentSharedSpec{
				Replicas:        &validReplicas,
				DynamoNamespace: ptr("my-custom-namespace"),
			},
			fieldPath:           "spec.services[Frontend]",
			calculatedNamespace: "hannahz-trtllm-disagg",
			wantWarnings:        1,
			wantWarningContains: "Value 'my-custom-namespace' will be replaced with 'hannahz-trtllm-disagg'",
281
282
283
284
285
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
286
			validator := NewSharedSpecValidator(tt.spec, tt.fieldPath, tt.calculatedNamespace)
287
288
289
290
291
292
293
294
295
296
			warnings, err := validator.Validate()

			if err != nil {
				t.Errorf("SharedSpecValidator.Validate() unexpected error = %v", err)
				return
			}

			if len(warnings) != tt.wantWarnings {
				t.Errorf("SharedSpecValidator.Validate() warnings count = %d, want %d", len(warnings), tt.wantWarnings)
			}
297
298
299
300
301
302
303
304
305
306
307
308
309

			if tt.wantWarningContains != "" && len(warnings) > 0 {
				found := false
				for _, w := range warnings {
					if contains(w, tt.wantWarningContains) {
						found = true
						break
					}
				}
				if !found {
					t.Errorf("SharedSpecValidator.Validate() warnings = %v, want warning containing %q", warnings, tt.wantWarningContains)
				}
			}
310
311
312
		})
	}
}
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327

// contains checks if s contains substr
func contains(s, substr string) bool {
	return len(s) >= len(substr) && (s == substr || len(substr) == 0 ||
		(len(s) > 0 && len(substr) > 0 && findSubstring(s, substr)))
}

func findSubstring(s, substr string) bool {
	for i := 0; i <= len(s)-len(substr); i++ {
		if s[i:i+len(substr)] == substr {
			return true
		}
	}
	return false
}