completions.rs 16.8 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
4
// SPDX-License-Identifier: Apache-2.0

use derive_builder::Builder;
5
use dynamo_runtime::protocols::annotated::AnnotationsProvider;
6
use serde::{Deserialize, Serialize};
7
use utoipa::ToSchema;
8
9
use validator::Validate;

10
11
use crate::engines::ValidateRequest;

12
use super::{
13
14
    ContentProvider, OpenAIOutputOptionsProvider, OpenAISamplingOptionsProvider,
    OpenAIStopConditionsProvider,
Greg Clark's avatar
Greg Clark committed
15
    common::{self, OutputOptionsProvider, SamplingOptionsProvider, StopConditionsProvider},
16
    common_ext::{CommonExt, CommonExtProvider},
17
    nvext::{NvExt, NvExtProvider},
18
    validate,
19
20
};

21
22
23
24
25
mod aggregator;
mod delta;

pub use aggregator::DeltaAggregator;
pub use delta::DeltaGenerator;
Biswa Panda's avatar
Biswa Panda committed
26

27
#[derive(ToSchema, Serialize, Deserialize, Validate, Debug, Clone)]
28
pub struct NvCreateCompletionRequest {
29
    #[serde(flatten)]
30
    pub inner: dynamo_async_openai::types::CreateCompletionRequest,
31

32
33
34
    #[serde(flatten)]
    pub common: CommonExt,

35
36
    #[serde(skip_serializing_if = "Option::is_none")]
    pub nvext: Option<NvExt>,
37
38
39
40

    // metadata - passthrough parameter without restrictions
    #[serde(skip_serializing_if = "Option::is_none")]
    pub metadata: Option<serde_json::Value>,
41
42
43
44

    /// Catch-all for unsupported fields - checked during validation
    #[serde(flatten, default, skip_serializing)]
    pub unsupported_fields: std::collections::HashMap<String, serde_json::Value>,
45
46
}

47
#[derive(ToSchema, Serialize, Deserialize, Validate, Debug, Clone)]
48
49
pub struct NvCreateCompletionResponse {
    #[serde(flatten)]
50
    pub inner: dynamo_async_openai::types::CreateCompletionResponse,
51
52
}

53
impl ContentProvider for dynamo_async_openai::types::Choice {
54
55
56
57
58
    fn content(&self) -> String {
        self.text.clone()
    }
}

59
pub fn prompt_to_string(prompt: &dynamo_async_openai::types::Prompt) -> String {
60
    match prompt {
61
62
63
        dynamo_async_openai::types::Prompt::String(s) => s.clone(),
        dynamo_async_openai::types::Prompt::StringArray(arr) => arr.join(" "), // Join strings with spaces
        dynamo_async_openai::types::Prompt::IntegerArray(arr) => arr
64
65
66
67
            .iter()
            .map(|&num| num.to_string())
            .collect::<Vec<_>>()
            .join(" "),
68
        dynamo_async_openai::types::Prompt::ArrayOfIntegerArray(arr) => arr
69
70
71
72
73
74
75
76
77
78
79
80
81
            .iter()
            .map(|inner| {
                inner
                    .iter()
                    .map(|&num| num.to_string())
                    .collect::<Vec<_>>()
                    .join(" ")
            })
            .collect::<Vec<_>>()
            .join(" | "), // Separate arrays with a delimiter
    }
}

82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
/// Get the batch size from a prompt (1 for single prompts, array length for batch prompts)
pub fn get_prompt_batch_size(prompt: &dynamo_async_openai::types::Prompt) -> usize {
    match prompt {
        dynamo_async_openai::types::Prompt::String(_) => 1,
        dynamo_async_openai::types::Prompt::IntegerArray(_) => 1,
        dynamo_async_openai::types::Prompt::StringArray(arr) => arr.len(),
        dynamo_async_openai::types::Prompt::ArrayOfIntegerArray(arr) => arr.len(),
    }
}

/// Extract a single prompt from a batch at the given index.
/// For single prompts, returns a clone regardless of index.
/// For batch prompts, returns the prompt at the specified index.
pub fn extract_single_prompt(
    prompt: &dynamo_async_openai::types::Prompt,
    index: usize,
) -> dynamo_async_openai::types::Prompt {
    match prompt {
        dynamo_async_openai::types::Prompt::String(s) => {
            dynamo_async_openai::types::Prompt::String(s.clone())
        }
        dynamo_async_openai::types::Prompt::IntegerArray(arr) => {
            dynamo_async_openai::types::Prompt::IntegerArray(arr.clone())
        }
        dynamo_async_openai::types::Prompt::StringArray(arr) => {
            dynamo_async_openai::types::Prompt::String(arr[index].clone())
        }
        dynamo_async_openai::types::Prompt::ArrayOfIntegerArray(arr) => {
            dynamo_async_openai::types::Prompt::IntegerArray(arr[index].clone())
        }
    }
}

115
impl NvExtProvider for NvCreateCompletionRequest {
116
117
118
119
120
    fn nvext(&self) -> Option<&NvExt> {
        self.nvext.as_ref()
    }

    fn raw_prompt(&self) -> Option<String> {
121
122
123
124
125
        if let Some(nvext) = self.nvext.as_ref()
            && let Some(use_raw_prompt) = nvext.use_raw_prompt
            && use_raw_prompt
        {
            return Some(prompt_to_string(&self.inner.prompt));
126
127
128
129
130
        }
        None
    }
}

131
impl AnnotationsProvider for NvCreateCompletionRequest {
Biswa Panda's avatar
Biswa Panda committed
132
133
134
135
136
137
138
139
140
141
142
143
144
145
    fn annotations(&self) -> Option<Vec<String>> {
        self.nvext
            .as_ref()
            .and_then(|nvext| nvext.annotations.clone())
    }

    fn has_annotation(&self, annotation: &str) -> bool {
        self.nvext
            .as_ref()
            .and_then(|nvext| nvext.annotations.as_ref())
            .map(|annotations| annotations.contains(&annotation.to_string()))
            .unwrap_or(false)
    }
}
146

147
impl OpenAISamplingOptionsProvider for NvCreateCompletionRequest {
148
    fn get_temperature(&self) -> Option<f32> {
149
        self.inner.temperature
150
151
152
    }

    fn get_top_p(&self) -> Option<f32> {
153
        self.inner.top_p
154
155
156
    }

    fn get_frequency_penalty(&self) -> Option<f32> {
157
        self.inner.frequency_penalty
158
159
160
    }

    fn get_presence_penalty(&self) -> Option<f32> {
161
        self.inner.presence_penalty
162
163
164
165
166
    }

    fn nvext(&self) -> Option<&NvExt> {
        self.nvext.as_ref()
    }
167
168
169
170
171
172
173
174
175
176
177
178

    fn get_seed(&self) -> Option<i64> {
        self.inner.seed
    }

    fn get_n(&self) -> Option<u8> {
        self.inner.n
    }

    fn get_best_of(&self) -> Option<u8> {
        self.inner.best_of
    }
179
180
}

181
182
183
184
185
186
impl CommonExtProvider for NvCreateCompletionRequest {
    fn common_ext(&self) -> Option<&CommonExt> {
        Some(&self.common)
    }

    /// Guided Decoding Options
187
188
    fn get_guided_json(&self) -> Option<serde_json::Value> {
        self.common.guided_json.clone()
189
190
191
    }

    fn get_guided_regex(&self) -> Option<String> {
192
        self.common.guided_regex.clone()
193
194
195
    }

    fn get_guided_grammar(&self) -> Option<String> {
196
        self.common.guided_grammar.clone()
197
198
199
    }

    fn get_guided_choice(&self) -> Option<Vec<String>> {
200
        self.common.guided_choice.clone()
201
202
203
    }

    fn get_guided_decoding_backend(&self) -> Option<String> {
204
        self.common.guided_decoding_backend.clone()
205
    }
206

207
    fn get_guided_whitespace_pattern(&self) -> Option<String> {
208
        self.common.guided_whitespace_pattern.clone()
209
210
    }

211
    fn get_top_k(&self) -> Option<i32> {
212
        self.common.top_k
213
214
    }

215
    fn get_min_p(&self) -> Option<f32> {
216
        self.common.min_p
217
218
    }

219
    fn get_repetition_penalty(&self) -> Option<f32> {
220
        self.common.repetition_penalty
221
    }
222
223
224
225

    fn get_include_stop_str_in_output(&self) -> Option<bool> {
        self.common.include_stop_str_in_output
    }
226
227
228
229

    fn get_skip_special_tokens(&self) -> Option<bool> {
        self.common.skip_special_tokens
    }
230
231
}

232
impl OpenAIStopConditionsProvider for NvCreateCompletionRequest {
Paul Hendricks's avatar
Paul Hendricks committed
233
    fn get_max_tokens(&self) -> Option<u32> {
234
        self.inner.max_tokens
235
236
    }

Paul Hendricks's avatar
Paul Hendricks committed
237
    fn get_min_tokens(&self) -> Option<u32> {
238
        self.common.min_tokens
239
240
241
    }

    fn get_stop(&self) -> Option<Vec<String>> {
242
243
244
245
246
        use dynamo_async_openai::types::Stop;
        self.inner.stop.as_ref().map(|s| match s {
            Stop::String(s) => vec![s.clone()],
            Stop::StringArray(arr) => arr.clone(),
        })
247
248
249
250
251
    }

    fn nvext(&self) -> Option<&NvExt> {
        self.nvext.as_ref()
    }
252
253
254
255

    fn get_common_ignore_eos(&self) -> Option<bool> {
        self.common.ignore_eos
    }
256

257
    /// Get the effective ignore_eos value from CommonExt.
258
    fn get_ignore_eos(&self) -> Option<bool> {
259
        self.common.ignore_eos
260
    }
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
}

#[derive(Builder)]
pub struct ResponseFactory {
    #[builder(setter(into))]
    pub model: String,

    #[builder(default)]
    pub system_fingerprint: Option<String>,

    #[builder(default = "format!(\"cmpl-{}\", uuid::Uuid::new_v4())")]
    pub id: String,

    #[builder(default = "\"text_completion\".to_string()")]
    pub object: String,

277
278
    #[builder(default = "chrono::Utc::now().timestamp() as u32")]
    pub created: u32,
279
280
281
282
283
284
285
286
287
}

impl ResponseFactory {
    pub fn builder() -> ResponseFactoryBuilder {
        ResponseFactoryBuilder::default()
    }

    pub fn make_response(
        &self,
288
289
        choice: dynamo_async_openai::types::Choice,
        usage: Option<dynamo_async_openai::types::CompletionUsage>,
290
    ) -> NvCreateCompletionResponse {
291
        let inner = dynamo_async_openai::types::CreateCompletionResponse {
292
293
            id: self.id.clone(),
            object: self.object.clone(),
294
            created: self.created,
295
296
297
298
            model: self.model.clone(),
            choices: vec![choice],
            system_fingerprint: self.system_fingerprint.clone(),
            usage,
299
            nvext: None, // Will be populated by router layer if needed
300
301
        };
        NvCreateCompletionResponse { inner }
302
303
304
305
    }
}

/// Implements TryFrom for converting an OpenAI's CompletionRequest to an Engine's CompletionRequest
306
impl TryFrom<NvCreateCompletionRequest> for common::CompletionRequest {
307
308
    type Error = anyhow::Error;

309
    fn try_from(request: NvCreateCompletionRequest) -> Result<Self, Self::Error> {
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
        // openai_api_rs::v1::completion::CompletionRequest {
        // NA  pub model: String,
        //     pub prompt: String,
        // **  pub suffix: Option<String>,
        //     pub max_tokens: Option<i32>,
        //     pub temperature: Option<f32>,
        //     pub top_p: Option<f32>,
        //     pub n: Option<i32>,
        //     pub stream: Option<bool>,
        //     pub logprobs: Option<i32>,
        //     pub echo: Option<bool>,
        //     pub stop: Option<Vec<String, Global>>,
        //     pub presence_penalty: Option<f32>,
        //     pub frequency_penalty: Option<f32>,
        //     pub best_of: Option<i32>,
        //     pub logit_bias: Option<HashMap<String, i32, RandomState>>,
        //     pub user: Option<String>,
        // }
        //
        // ** no supported

331
        if request.inner.suffix.is_some() {
332
333
334
335
336
337
338
339
340
341
342
            return Err(anyhow::anyhow!("suffix is not supported"));
        }

        let stop_conditions = request
            .extract_stop_conditions()
            .map_err(|e| anyhow::anyhow!("Failed to extract stop conditions: {}", e))?;

        let sampling_options = request
            .extract_sampling_options()
            .map_err(|e| anyhow::anyhow!("Failed to extract sampling options: {}", e))?;

Greg Clark's avatar
Greg Clark committed
343
344
345
346
        let output_options = request
            .extract_output_options()
            .map_err(|e| anyhow::anyhow!("Failed to extract output options: {}", e))?;

347
        let prompt = common::PromptType::Completion(common::CompletionContext {
348
            prompt: prompt_to_string(&request.inner.prompt),
349
350
351
352
353
354
355
            system_prompt: None,
        });

        Ok(common::CompletionRequest {
            prompt,
            stop_conditions,
            sampling_options,
Greg Clark's avatar
Greg Clark committed
356
            output_options,
357
358
359
360
361
362
            mdc_sum: None,
            annotations: None,
        })
    }
}

363
impl TryFrom<common::StreamingCompletionResponse> for dynamo_async_openai::types::Choice {
364
365
366
    type Error = anyhow::Error;

    fn try_from(response: common::StreamingCompletionResponse) -> Result<Self, Self::Error> {
367
368
369
370
371
        let text = response
            .delta
            .text
            .ok_or(anyhow::anyhow!("No text in response"))?;

372
        // SAFETY: we're downcasting from u64 to u32 here but u32::MAX is 4_294_967_295
373
        // so we're fairly safe knowing we won't generate that many Choices
374
375
376
377
378
379
        let index: u32 = response
            .delta
            .index
            .unwrap_or(0)
            .try_into()
            .expect("index exceeds u32::MAX");
380
381
382
383

        // TODO handle aggregating logprobs
        let logprobs = None;

384
        let finish_reason: Option<dynamo_async_openai::types::CompletionFinishReason> =
385
386
            response.delta.finish_reason.map(Into::into);

387
        let choice = dynamo_async_openai::types::Choice {
388
389
390
391
            text,
            index,
            logprobs,
            finish_reason,
392
393
394
395
396
        };

        Ok(choice)
    }
}
397

Greg Clark's avatar
Greg Clark committed
398
399
400
401
402
403
404
405
406
407
408
409
impl OpenAIOutputOptionsProvider for NvCreateCompletionRequest {
    fn get_logprobs(&self) -> Option<u32> {
        self.inner.logprobs.map(|logprobs| logprobs as u32)
    }

    fn get_prompt_logprobs(&self) -> Option<u32> {
        self.inner
            .echo
            .and_then(|echo| if echo { Some(1) } else { None })
    }

    fn get_skip_special_tokens(&self) -> Option<bool> {
410
        CommonExtProvider::get_skip_special_tokens(self)
Greg Clark's avatar
Greg Clark committed
411
412
413
414
415
416
417
    }

    fn get_formatted_prompt(&self) -> Option<bool> {
        None
    }
}

418
419
420
421
/// Implements `ValidateRequest` for `NvCreateCompletionRequest`,
/// allowing us to validate the data.
impl ValidateRequest for NvCreateCompletionRequest {
    fn validate(&self) -> Result<(), anyhow::Error> {
422
        validate::validate_no_unsupported_fields(&self.unsupported_fields)?;
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
        validate::validate_model(&self.inner.model)?;
        validate::validate_prompt(&self.inner.prompt)?;
        validate::validate_suffix(self.inner.suffix.as_deref())?;
        validate::validate_max_tokens(self.inner.max_tokens)?;
        validate::validate_temperature(self.inner.temperature)?;
        validate::validate_top_p(self.inner.top_p)?;
        validate::validate_n(self.inner.n)?;
        // none for stream
        // none for stream_options
        validate::validate_logprobs(self.inner.logprobs)?;
        // none for echo
        validate::validate_stop(&self.inner.stop)?;
        validate::validate_presence_penalty(self.inner.presence_penalty)?;
        validate::validate_frequency_penalty(self.inner.frequency_penalty)?;
        validate::validate_best_of(self.inner.best_of, self.inner.n)?;
        validate::validate_logit_bias(&self.inner.logit_bias)?;
        validate::validate_user(self.inner.user.as_deref())?;
        // none for seed
441
        // none for metadata
442

443
444
        // Common Ext
        validate::validate_repetition_penalty(self.get_repetition_penalty())?;
445
446
        validate::validate_min_p(self.get_min_p())?;
        validate::validate_top_k(self.get_top_k())?;
447
448
        // Cross-field validation
        validate::validate_n_with_temperature(self.inner.n, self.inner.temperature)?;
449
450
451
452
453
        // total choices validation for completions batch requests
        validate::validate_total_choices(
            get_prompt_batch_size(&self.inner.prompt),
            self.inner.n.unwrap_or(1),
        )?;
454
455
456
        Ok(())
    }
}
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501

#[cfg(test)]
mod tests {
    use super::*;
    use crate::protocols::common::OutputOptionsProvider;
    use serde_json::json;

    #[test]
    fn test_skip_special_tokens_none() {
        let json_str = json!({
            "model": "test-model",
            "prompt": "Hello, world!"
        });

        let request: NvCreateCompletionRequest =
            serde_json::from_value(json_str).expect("Failed to deserialize request");

        assert_eq!(request.common.skip_special_tokens, None);

        let output_options = request
            .extract_output_options()
            .expect("Failed to extract output options");

        assert_eq!(output_options.skip_special_tokens, None);
    }

    #[test]
    fn test_skip_special_tokens_propagates() {
        for skip_value in [true, false] {
            let json_str = json!({
                "model": "test-model",
                "prompt": "Hello, world!",
                "skip_special_tokens": skip_value
            });

            let request: NvCreateCompletionRequest =
                serde_json::from_value(json_str).expect("Failed to deserialize request");

            let output_options = request
                .extract_output_options()
                .expect("Failed to extract output options");

            assert_eq!(output_options.skip_special_tokens, Some(skip_value));
        }
    }
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533

    #[test]
    fn test_stop() {
        let null_stop = json!({
            "model": "test-model",
            "prompt": "Hello, world!"
        });
        let request: NvCreateCompletionRequest =
            serde_json::from_value(null_stop).expect("Failed to deserialize request");
        assert_eq!(request.get_stop(), None);

        let one_stop = json!({
            "model": "test-model",
            "prompt": "Hello, world!",
            "stop": "foo"
        });
        let request: NvCreateCompletionRequest =
            serde_json::from_value(one_stop).expect("Failed to deserialize request");
        assert_eq!(request.get_stop(), Some(vec!["foo".to_string()]));

        let many_stops = json!({
            "model": "test-model",
            "prompt": "Hello, world!",
            "stop": ["foo", "bar"]
        });
        let request: NvCreateCompletionRequest =
            serde_json::from_value(many_stops).expect("Failed to deserialize request");
        assert_eq!(
            request.get_stop(),
            Some(vec!["foo".to_string(), "bar".to_string()])
        );
    }
534
}