prefill_router.rs 28.3 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
// SPDX-License-Identifier: Apache-2.0

4
use std::collections::HashSet;
5
6
use std::sync::{Arc, OnceLock};

7
use anyhow::Result;
8
use futures::StreamExt;
9
use tokio::sync::{OwnedSemaphorePermit, oneshot};
10
use tokio_util::sync::CancellationToken;
11
use tracing::Instrument;
12
13
14
15

use dynamo_runtime::{
    component::Endpoint,
    pipeline::{
16
17
        AsyncEngine, AsyncEngineContextProvider, Context, ManyOut, Operator, PushRouter,
        RouterMode, ServerStreamingEngine, SingleIn, async_trait,
18
    },
19
    protocols::{EndpointId, annotated::Annotated, maybe_error::MaybeError},
20
21
22
23
};

use crate::{
    discovery::ModelManager,
24
    kv_router::protocols::WorkerId,
25
    kv_router::{KvPushRouter, KvRouterConfig, RouterConfigOverride, protocols::BlockExtraInfo},
26
    protocols::common::llm_backend::{LLMEngineOutput, PreprocessedRequest},
27
    protocols::common::preprocessor::{BootstrapInfo, PrefillResult},
28
    protocols::common::timing::{RequestPhase, RequestTracker, WORKER_TYPE_PREFILL},
29
30
};

31
32
33
34
35
36
37
38
/// Errors that can occur during prefill routing
#[derive(Debug, thiserror::Error)]
pub enum PrefillError {
    /// Prefill router has not been activated yet
    #[error("Prefill router not yet activated")]
    NotActivated,

    /// TODO: Separate prefill worker error from prefill router error
39
    /// Error during prefill execution
40
    #[error("Prefill execution failed: {0}")]
41
42
43
44
    PrefillError(
        String,
        #[source] Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
    ),
45
46
47
48
49
50

    /// Disaggregated params not found in prefill response
    #[error("No disaggregated params in prefill response: {0}")]
    NoDisaggregatedParams(String),
}

51
52
53
54
55
56
57
58
/// Result of the prefill phase in `generate()`.
enum PrefillOutcome {
    /// Bootstrap optimization: prefill spawned in background, bootstrap info ready
    Bootstrap(BootstrapInfo),
    /// Synchronous prefill completed with result
    Completed(PrefillResult),
}

59
/// The inner router used by PrefillRouter
60
#[derive(Clone)]
61
62
63
64
enum InnerPrefillRouter {
    /// KV-aware routing using KvPushRouter
    KvRouter(Arc<KvPushRouter>),
    /// Simple routing (RoundRobin, Random, Direct)
65
66
    /// Note: Per-worker metrics (active_prefill_tokens, active_decode_blocks) are only
    /// available in KV routing mode where the router has actual bookkeeping.
67
68
69
    SimpleRouter(Arc<PushRouter<PreprocessedRequest, Annotated<LLMEngineOutput>>>),
}

70
impl InnerPrefillRouter {
71
72
73
74
    /// Generate with optional direct routing to specific worker.
    /// For KvRouter, target_worker is ignored since prefill_worker_id is already set on the request.
    /// For SimpleRouter, target_worker triggers direct routing via router.direct().
    async fn generate_to_worker(
75
76
        &self,
        request: SingleIn<PreprocessedRequest>,
77
        target_worker: Option<u64>,
78
    ) -> Result<ManyOut<Annotated<LLMEngineOutput>>> {
79
80
81
82
83
84
85
86
87
88
89
90
        match (self, target_worker) {
            // KvRouter: prefill_worker_id already set on request, KvPushRouter::select_worker uses it
            (InnerPrefillRouter::KvRouter(router), _) => router.generate(request).await,
            (InnerPrefillRouter::SimpleRouter(router), Some(worker_id)) => {
                router.direct(request, worker_id).await
            }
            (InnerPrefillRouter::SimpleRouter(router), None) => router.generate(request).await,
        }
    }

    /// Select next worker (for non-KV modes only)
    fn select_next_worker(&self) -> Option<u64> {
91
        match self {
92
93
            InnerPrefillRouter::SimpleRouter(router) => router.select_next_worker(),
            InnerPrefillRouter::KvRouter(_) => None,
94
95
96
97
        }
    }
}

98
99
100
/// PrefillRouter is a forward-only operator that sits between Migration and the decode router.
/// It optionally calls a prefill worker before routing to decode, extracting disaggregated_params
/// from the prefill response and injecting them into the decode request.
101
///
102
103
104
105
/// Modes:
/// - Query-only: `query_instance_id` annotation present → returns worker IDs without execution
/// - Pre-routed: `prefill_worker_id`/`decode_worker_id` set → routes to specified workers
/// - Normal: Worker IDs determined by router based on KV cache state
106
107
pub struct PrefillRouter {
    prefill_router: OnceLock<InnerPrefillRouter>,
108
109
    model_manager: Arc<ModelManager>,
    endpoint_id: OnceLock<EndpointId>,
110
111
    cancel_token: CancellationToken,
    router_mode: RouterMode,
112
    enforce_disagg: bool,
113
114
    /// Model name used to look up the worker monitor for prefill client registration
    model_name: String,
115
116
    /// Namespace used to look up the correct WorkerSet's worker monitor
    namespace: String,
117
118
119
120
}

impl PrefillRouter {
    /// Create a disabled prefill router that will never activate (passthrough only)
121
122
123
    pub fn disabled(
        model_manager: Arc<ModelManager>,
        router_mode: RouterMode,
124
        enforce_disagg: bool,
125
    ) -> Arc<Self> {
126
127
        Arc::new(Self {
            prefill_router: OnceLock::new(),
128
129
            model_manager,
            endpoint_id: OnceLock::new(),
130
131
            cancel_token: CancellationToken::new(),
            router_mode,
132
            enforce_disagg,
133
            model_name: String::new(), // Not used for disabled router
134
            namespace: String::new(),  // Not used for disabled router
135
136
137
        })
    }

138
    #[expect(clippy::too_many_arguments)]
139
140
141
142
143
144
    pub fn new(
        activation_rx: oneshot::Receiver<Endpoint>,
        model_manager: Arc<ModelManager>,
        router_mode: RouterMode,
        kv_cache_block_size: u32,
        kv_router_config: Option<KvRouterConfig>,
145
        enforce_disagg: bool,
146
        model_name: String,
147
        namespace: String,
148
149
150
151
152
153
    ) -> Arc<Self> {
        let prefill_router = OnceLock::new();
        let cancel_token = CancellationToken::new();

        let router = Arc::new(Self {
            prefill_router,
154
155
            model_manager: model_manager.clone(),
            endpoint_id: OnceLock::new(),
156
157
            cancel_token: cancel_token.clone(),
            router_mode,
158
            enforce_disagg,
159
            model_name,
160
            namespace,
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
        });

        // Spawn background task to wait for activation
        let router_clone = router.clone();
        tokio::spawn(async move {
            tokio::select! {
                result = activation_rx => {
                    let Ok(endpoint) = result else {
                        tracing::debug!("Prefill router activation channel closed without receiving endpoint");
                        return;
                    };

                    if let Err(e) = router_clone.activate(
                        endpoint,
                        model_manager,
                        kv_cache_block_size,
                        kv_router_config,
                    ).await {
                        tracing::error!(error = %e, "Failed to activate prefill router");
                    }
                }
                _ = cancel_token.cancelled() => {
                    tracing::debug!("Prefill router activation cancelled");
                }
            }
        });

        router
    }

    /// Activate the prefill router with the provided endpoint
    async fn activate(
        &self,
        endpoint: Endpoint,
        model_manager: Arc<ModelManager>,
        kv_cache_block_size: u32,
        kv_router_config: Option<KvRouterConfig>,
    ) -> Result<()> {
        tracing::info!(
            router_mode = ?self.router_mode,
            "Activating prefill router"
        );

204
        // Store endpoint_id for later use in resolve_prefill_worker
205
206
207
208
209
210
211
212
        let _ = self.endpoint_id.set(endpoint.id());

        // Start runtime config watcher for this endpoint (needed for get_disaggregated_endpoint)
        // This must be done before creating the router so bootstrap info is available
        model_manager
            .get_or_create_runtime_config_watcher(&endpoint)
            .await?;

213
        let inner_router = if self.router_mode.is_kv_routing() {
214
            // Create KV chooser using the endpoint (this is a prefill router)
215
            let kv_chooser = model_manager
216
217
218
219
220
                .kv_chooser_for(
                    &endpoint,
                    kv_cache_block_size,
                    kv_router_config,
                    WORKER_TYPE_PREFILL,
221
                    Some(self.model_name.clone()),
222
                )
223
224
                .await?;

225
226
227
            // Extract client from kv_chooser to ensure shared state
            let client = kv_chooser.client().clone();

228
            // Register prefill client with worker monitor for TTFT metric cleanup in disaggregated mode
229
230
231
            if let Some(monitor) =
                model_manager.get_worker_monitor_for_namespace(&self.model_name, &self.namespace)
            {
232
233
234
                monitor.set_prefill_client(client.clone());
            }

235
            // Build the PushRouter for prefill with KV mode using the shared client
236
237
238
239
240
241
242
243
244
245
246
            let push_router = PushRouter::<PreprocessedRequest, Annotated<LLMEngineOutput>>::from_client_with_threshold(
                client,
                RouterMode::KV,
                None, // busy_threshold
                None, // worker_monitor
            )
            .await?;

            // Wrap it in KvPushRouter
            InnerPrefillRouter::KvRouter(Arc::new(KvPushRouter::new(push_router, kv_chooser)))
        } else {
247
248
249
            // Create client for simple router
            let client = endpoint.client().await?;

250
            // Register prefill client with worker monitor for TTFT metric cleanup in disaggregated mode
251
252
253
            if let Some(monitor) =
                model_manager.get_worker_monitor_for_namespace(&self.model_name, &self.namespace)
            {
254
255
256
                monitor.set_prefill_client(client.clone());
            }

257
            // Create simple push router with the frontend's router mode
258
259
            // Note: Per-worker metrics (active_prefill_tokens, active_decode_blocks) are only
            // available in KV routing mode where the router has actual bookkeeping.
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
            let push_router = PushRouter::<PreprocessedRequest, Annotated<LLMEngineOutput>>::from_client_with_threshold(
                client,
                self.router_mode,
                None, // busy_threshold
                None, // worker_monitor
            )
            .await?;

            InnerPrefillRouter::SimpleRouter(Arc::new(push_router))
        };

        // Set the router (ignore error if already set)
        let _ = self.prefill_router.set(inner_router);

        tracing::info!(
            router_mode = ?self.router_mode,
            "Prefill router activated successfully"
        );

        Ok(())
    }

282
    /// Select a prefill worker and resolve its bootstrap connection info.
283
    /// If preselected_worker is provided (GAIE Stage 2), use it directly.
284
    /// Otherwise, query for the best worker (KV mode) or select next worker (non-KV modes).
285
    async fn resolve_prefill_worker(
286
        &self,
287
        req: &PreprocessedRequest,
288
        preselected_worker: Option<u64>,
289
    ) -> Option<(u64, u32, BootstrapInfo)> {
290
        let endpoint_id = self.endpoint_id.get()?;
291
        self.prefill_router.get()?;
292

293
        // Worker selection
294
        let (worker_id, dp_rank) = if let Some(id) = preselected_worker {
295
            let dp_rank = req.routing.as_ref().and_then(|r| r.dp_rank).unwrap_or(0);
296
297
298
299
300
301
            tracing::debug!(
                worker_id = id,
                dp_rank = dp_rank,
                "Using pre-selected prefill worker for bootstrap"
            );
            (id, dp_rank)
302
303
        } else {
            // Use shared worker selection logic (update_states=false for peek behavior)
304
            // Extract LORA name and priority jump from routing hints
305
            let lora_name = req.routing.as_ref().and_then(|r| r.lora_name.clone());
306
307
308
309
310
            let priority_jump = req
                .routing
                .as_ref()
                .and_then(|r| r.priority_jump)
                .unwrap_or(0.0);
311
312
313
314
            let allowed_worker_ids = req
                .routing
                .as_ref()
                .and_then(|r| r.allowed_worker_ids.clone());
315
            let (routing_token_ids, block_mm_infos) = req.block_mm_routing_info();
316
            match self
317
318
319
320
321
322
                .query_prefill_worker(
                    routing_token_ids,
                    block_mm_infos,
                    false,
                    lora_name,
                    priority_jump,
323
                    allowed_worker_ids,
324
                )
325
                .await
326
            {
327
                Ok((worker_id, dp_rank)) => (worker_id, dp_rank),
328
329
                Err(_) => return None,
            }
330
331
        };

332
333
334
335
        // Get bootstrap info from ModelManager (works for ANY mode)
        let endpoint = self
            .model_manager
            .get_disaggregated_endpoint(endpoint_id, worker_id)?;
336
337
338
        let host = endpoint.bootstrap_host?;
        let port = endpoint.bootstrap_port?;

339
        let bootstrap_room: u64 = rand::random_range(0..=i64::MAX.cast_unsigned());
340

341
        tracing::debug!(
342
343
344
345
346
            worker_id = worker_id,
            dp_rank = dp_rank,
            bootstrap_host = %host,
            bootstrap_port = port,
            bootstrap_room = bootstrap_room,
347
            router_mode = ?self.router_mode,
348
349
350
351
352
353
354
355
356
357
358
359
360
361
            "Built bootstrap_info upfront before prefill"
        );

        Some((
            worker_id,
            dp_rank,
            BootstrapInfo {
                bootstrap_host: host,
                bootstrap_port: port,
                bootstrap_room,
            },
        ))
    }

362
363
364
365
366
367
    /// Execute prefill with the given router and extract structured result.
    ///
    /// Uses direct routing to target_worker when specified (for non-KV modes with bootstrap optimization).
    ///
    /// If `phase_permit` is provided, it is dropped after the first output is received,
    /// allowing subsequent `set_phase` calls to proceed. This is used in the bootstrap
368
    /// optimization path to ensure `record_worker_full` completes before the phase changes.
369
370
    ///
    /// Returns (PrefillResult, Option<(worker_id, dp_rank)>).
371
372
373
    async fn execute_prefill(
        router: Option<InnerPrefillRouter>,
        request: SingleIn<PreprocessedRequest>,
374
        target_worker: Option<u64>,
375
        phase_permit: Option<OwnedSemaphorePermit>,
376
    ) -> Result<(PrefillResult, Option<(u64, u32)>), PrefillError> {
377
378
        let router = router.ok_or(PrefillError::NotActivated)?;
        let mut prefill_response = router
379
            .generate_to_worker(request, target_worker)
380
            .await
381
382
383
384
385
386
            .map_err(|e| {
                PrefillError::PrefillError(
                    "failed to route to prefill worker".to_string(),
                    Some(e.into()),
                )
            })?;
387

388
        // Drop phase permit now - routing is complete, record_worker_full was called in select_worker.
389
390
391
        // This unblocks set_phase(Decode) in the main task without waiting for prefill output.
        drop(phase_permit);

392
        let Some(first_output) = prefill_response.next().await else {
393
394
            return Err(PrefillError::PrefillError(
                "Prefill router returned no output (stream ended)".to_string(),
395
                None,
396
            ));
397
398
        };

399
400
401
402
403
404
405
        if let Some(err) = first_output.err() {
            return Err(PrefillError::PrefillError(
                "Prefill router returned error in output".to_string(),
                Some(Box::new(err)),
            ));
        }

406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
        let mut prompt_tokens_details = first_output
            .data
            .as_ref()
            .and_then(|o| o.completion_usage.as_ref())
            .and_then(|u| u.prompt_tokens_details.clone());

        while let Some(next) = prefill_response.next().await {
            if let Some(o) = next.data.as_ref()
                && prompt_tokens_details.is_none()
            {
                prompt_tokens_details = o
                    .completion_usage
                    .as_ref()
                    .and_then(|u| u.prompt_tokens_details.clone());
            }
        }
422

423
        let Some(output) = &first_output.data else {
424
425
426
            return Err(PrefillError::NoDisaggregatedParams(
                "Prefill router output has no data field".to_string(),
            ));
427
428
429
        };

        let Some(disaggregated_params) = output.disaggregated_params.clone() else {
430
431
432
            return Err(PrefillError::NoDisaggregatedParams(
                "Prefill router output missing disaggregated_params".to_string(),
            ));
433
434
        };

435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
        // Extract prefill worker ID and dp_rank from disaggregated_params
        let prefill_worker_info =
            disaggregated_params
                .get("worker_id")
                .and_then(|worker_id_json| {
                    let worker_id = worker_id_json
                        .get("prefill_worker_id")
                        .and_then(|v| v.as_u64())?;
                    let dp_rank = worker_id_json
                        .get("prefill_dp_rank")
                        .and_then(|v| v.as_u64())
                        .map(|r| r as u32)
                        .unwrap_or(0);
                    Some((worker_id, dp_rank))
                });
450
451
452
453
454
        Ok((
            PrefillResult {
                disaggregated_params,
                prompt_tokens_details,
            },
455
            prefill_worker_info,
456
457
458
        ))
    }

459
460
461
462
463
464
    /// Spawn prefill as a background task.
    ///
    /// Uses direct routing to target_worker when specified (for non-KV modes with bootstrap optimization).
    ///
    /// The `phase_permit` is passed to the spawned task and dropped after the first output,
    /// allowing the main task's `set_phase(Decode)` to proceed.
465
466
467
468
    fn spawn_prefill_task(
        &self,
        prefill_request: SingleIn<PreprocessedRequest>,
        target_worker: Option<u64>,
469
        phase_permit: OwnedSemaphorePermit,
470
    ) {
471
        let router = self.prefill_router.get().cloned();
472
473
474
475
476
477
478
479
480
481
482
        // Capture current span to propagate trace context to the spawned task
        let span = tracing::Span::current();

        tokio::spawn(
            async move {
                match Self::execute_prefill(
                    router,
                    prefill_request,
                    target_worker,
                    Some(phase_permit),
                )
483
                .await
484
485
486
487
488
489
490
                {
                    Ok(_) => {
                        tracing::debug!("Prefill background task completed");
                    }
                    Err(e) => {
                        tracing::warn!("Prefill background task error: {e:?}");
                    }
491
492
                }
            }
493
494
            .instrument(span),
        );
495
496
    }

497
498
499
    /// Query the best prefill worker without executing a request.
    /// Returns (worker_id, dp_rank).
    ///
500
    /// This is the shared worker selection logic used by both `resolve_prefill_worker`
501
    /// and `query_route`.
502
503
504
505
506
507
508
    /// Register externally-provided workers in the prefill router's slot tracker.
    pub fn register_workers(&self, worker_ids: &HashSet<WorkerId>) {
        if let Some(InnerPrefillRouter::KvRouter(r)) = self.prefill_router.get() {
            r.chooser.register_workers(worker_ids);
        }
    }

509
510
511
    pub async fn query_prefill_worker(
        &self,
        token_ids: &[u32],
512
        block_mm_infos: Option<&[Option<BlockExtraInfo>]>,
513
514
515
        update_states: bool,
        lora_name: Option<String>,
        priority_jump: f64,
516
        allowed_worker_ids: Option<HashSet<WorkerId>>,
517
518
519
520
521
522
523
524
525
526
527
528
529
    ) -> Result<(u64, u32)> {
        let prefill_router = self
            .prefill_router
            .get()
            .ok_or_else(|| anyhow::anyhow!(PrefillError::NotActivated))?;

        match prefill_router {
            InnerPrefillRouter::KvRouter(r) => {
                let (worker, _overlap) = r
                    .chooser
                    .find_best_match(
                        None,
                        token_ids,
530
                        block_mm_infos,
531
532
533
534
                        None,
                        update_states,
                        lora_name,
                        priority_jump,
535
                        None,
536
                        allowed_worker_ids,
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
                    )
                    .await?;
                Ok((worker.worker_id, worker.dp_rank))
            }
            InnerPrefillRouter::SimpleRouter(r) => {
                let worker_id = if update_states {
                    r.select_next_worker()
                } else {
                    r.peek_next_worker()
                }
                .ok_or_else(|| anyhow::anyhow!("No workers available for prefill"))?;
                Ok((worker_id, 0))
            }
        }
    }

    /// Check if disaggregated mode is currently active (prefill router activated)
    pub fn is_activated(&self) -> bool {
        self.prefill_router.get().is_some()
    }
557
558
}

559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
impl Drop for PrefillRouter {
    fn drop(&mut self) {
        tracing::debug!("Dropping PrefillRouter, cancelling background activation task");
        self.cancel_token.cancel();
    }
}

#[async_trait]
impl
    Operator<
        SingleIn<PreprocessedRequest>,
        ManyOut<Annotated<LLMEngineOutput>>,
        SingleIn<PreprocessedRequest>,
        ManyOut<Annotated<LLMEngineOutput>>,
    > for PrefillRouter
{
    async fn generate(
        &self,
        request: SingleIn<PreprocessedRequest>,
        next: ServerStreamingEngine<PreprocessedRequest, Annotated<LLMEngineOutput>>,
    ) -> Result<ManyOut<Annotated<LLMEngineOutput>>> {
        // Extract request data while preserving context
581
        let (mut req, context) = request.into_parts();
582
        let request_id = context.id().to_string();
583
        let engine_ctx = context.context();
584

Yan Ru Pei's avatar
Yan Ru Pei committed
585
586
587
        // Save original max_tokens for decode
        let original_max_tokens = req.stop_conditions.max_tokens;

588
589
        // If prefill router is not activated (no prefill workers discovered),
        // this is aggregated mode — route directly to decode.
590
        // With --enforce-disagg, fail instead of falling back.
591
        if self.prefill_router.get().is_none() {
592
593
594
            if self.enforce_disagg {
                return Err(anyhow::anyhow!(PrefillError::NotActivated));
            }
595
596
597
598
599
600
601
602
603
            return next.generate(context.map(|_| req)).await;
        }

        // Ensure tracker exists for routing decisions in disaggregated mode.
        // Create one if not provided by the upstream DeltaGenerator.
        if req.tracker.is_none() {
            req.tracker = Some(Arc::new(RequestTracker::new()));
        }
        let tracker = req.tracker.as_ref().unwrap();
604
        let prefill_phase_permit = tracker.set_phase(RequestPhase::Prefill).await;
605
606

        // Prepare prefill request with max_tokens = 1 (clone after tracker is set)
Yan Ru Pei's avatar
Yan Ru Pei committed
607
608
        let mut prefill_req = req.clone();
        prefill_req.stop_conditions.max_tokens = Some(1);
609

610
        // Try to resolve prefill worker upfront: if we can get bootstrap info early,
611
        // spawn prefill in background and proceed to decode immediately.
612
613
614
615
        let preselected_worker = prefill_req
            .routing
            .as_ref()
            .and_then(|r| r.prefill_worker_id);
616

617
618
619
620
621
622
623
        if self.router_mode.is_direct_routing() && preselected_worker.is_none() {
            return Err(anyhow::anyhow!(
                "Prefill worker ID required in Direct routing mode but none found in request. \
                 Expected prefill_worker_id to be set via x-prefill-instance-id header by external router (e.g., EPP)."
            ));
        }

624
625
        let prefill_result = async {
            if let Some((worker_id, dp_rank, bootstrap_info)) = self
626
                .resolve_prefill_worker(&prefill_req, preselected_worker)
627
                .await
628
            {
629
630
631
632
633
634
635
636
                // Bootstrap optimization path: spawn prefill in background
                // We successfully used the peeked worker, so we must now advance the router state
                // to ensure the next request gets a different worker.
                if !self.router_mode.is_kv_routing()
                    && let Some(router) = self.prefill_router.get()
                {
                    router.select_next_worker();
                }
637

638
639
640
641
                let routing = prefill_req.routing_mut();
                routing.prefill_worker_id = Some(worker_id);
                routing.dp_rank = Some(dp_rank);
                prefill_req.bootstrap_info = Some(bootstrap_info.clone());
642

643
644
                let prefill_context = Context::with_id(prefill_req, request_id.clone());
                engine_ctx.link_child(prefill_context.context());
645

646
                // Pass phase permit to spawned task - it drops after first output (record_worker_full complete)
647
648
                // This allows set_phase(Decode) below to proceed only after prefill routing is done
                self.spawn_prefill_task(prefill_context, Some(worker_id), prefill_phase_permit);
649

650
                Ok(PrefillOutcome::Bootstrap(bootstrap_info))
651
652
653
            } else {
                // Original prefill path: wait for prefill to complete
                tracing::debug!("Using original prefill path");
654

655
                // Drop the phase permit - we wait for completion
656
657
                // so there's no race with set_phase(Decode) below
                drop(prefill_phase_permit);
658

659
660
                let prefill_context = Context::with_id(prefill_req, request_id.clone());
                engine_ctx.link_child(prefill_context.context());
661

662
663
664
665
666
667
668
669
670
                // In Direct mode, pass preselected_worker so execute_prefill uses
                // router.direct() instead of router.generate() (which bails in Direct mode).
                let (result, _worker_info) = Self::execute_prefill(
                    self.prefill_router.get().cloned(),
                    prefill_context,
                    preselected_worker,
                    None,
                )
                .await?;
671

672
                Ok(PrefillOutcome::Completed(result))
673
674
675
            }
        }
        .await;
676
677
678
679
680
681
682
683
684
685
686
687

        // Abort if cancelled during prefill
        if engine_ctx.is_stopped() || engine_ctx.is_killed() {
            tracing::debug!("Abort entering decode after context is stopped or killed");
            return Err(anyhow::anyhow!(
                "Context id {} is stopped or killed",
                engine_ctx.id()
            ));
        }

        // Handle prefill result
        match prefill_result {
688
            Ok(outcome) => {
689
                tracing::debug!("Prefill completed, proceeding to decode");
690

691
692
                // Set phase to Decode for the decode request.
                // In bootstrap path, this blocks until the spawned prefill task drops its permit
693
                // (after first output / record_worker_full completes), ensuring correct phase for routing.
694
                if let Some(ref tracker) = req.tracker {
695
696
                    let _decode_permit = tracker.set_phase(RequestPhase::Decode).await;
                    // Permit is dropped immediately - decode proceeds, no need to hold it
697
698
                }

699
                let mut decode_req = req;
700

701
702
703
704
705
706
707
                match outcome {
                    PrefillOutcome::Bootstrap(info) => {
                        decode_req.bootstrap_info = Some(info);
                    }
                    PrefillOutcome::Completed(result) => {
                        decode_req.prefill_result = Some(result);
                    }
708
709
                }

Yan Ru Pei's avatar
Yan Ru Pei committed
710
711
                // Restore original max_tokens for decode
                decode_req.stop_conditions.max_tokens = original_max_tokens;
712

713
714
715
716
                // Set router_config_override for decode:
                // - overlap_score_weight = 0 (no KV cache overlap scoring for decode)
                // - assume_kv_reuse = false (generate random hashes since decode workers
                //   may already have blocks cached from prefill transfer)
717
718
719
                let existing_override = decode_req.router_config_override.take();
                decode_req.router_config_override = Some(RouterConfigOverride {
                    overlap_score_weight: Some(0.0),
720
                    assume_kv_reuse: Some(false),
721
722
723
724
                    ..existing_override.unwrap_or_default()
                });

                // Map the modified request through with preserved context
725
                let decode_request = context.map(|_| decode_req);
726
727
                next.generate(decode_request).await
            }
728
            Err(PrefillError::NotActivated) => {
729
730
                tracing::error!("Prefill router not activated, failing request");
                Err(anyhow::anyhow!(PrefillError::NotActivated))
731
            }
732
            Err(e) => {
733
734
                tracing::error!(error = %e, "Remote prefill failed, failing request");
                Err(anyhow::anyhow!(e))
735
736
737
738
            }
        }
    }
}