offset.rs 9.24 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
4
// SPDX-License-Identifier: Apache-2.0

use super::{
5
    Any, Buffer, MemoryDescriptor, Result, StorageError, StorageKind, nixl::NixlDescriptor,
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
};

/// An [`OffsetBuffer`] is a new [`Buffer`]-like object that represents a sub-region (still contiguous)
/// within an existing [`Buffer`].
#[derive(Clone)]
pub struct OffsetBuffer {
    base: Buffer,
    offset: usize,
    size: usize,
}

impl std::fmt::Debug for OffsetBuffer {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("OffsetBuffer")
            .field("base", &self.base)
            .field("offset", &self.offset)
            .field("size", &self.size)
            .finish()
    }
}

impl OffsetBuffer {
    /// Create a new offset view into an existing memory region.
    ///
    /// Returns an error if the offset and length exceed the bounds of the base region.
    pub fn new(base: Buffer, offset: usize, size: usize) -> Result<Self> {
        let end = offset
            .checked_add(size)
            .ok_or_else(|| StorageError::Unsupported("offset overflow".into()))?;
        if end > base.size() {
            return Err(StorageError::Unsupported(
                "offset region exceeds base allocation bounds".into(),
            ));
        }
        Ok(Self { base, offset, size })
    }

43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
    /// Creates an offset buffer from an absolute address within the base region.
    pub fn from_inner_address(base: Buffer, address: usize, size: usize) -> Result<Self> {
        // Use checked arithmetic to prevent overflow
        let end = address
            .checked_add(size)
            .ok_or_else(|| StorageError::Unsupported("address + size overflow".into()))?;
        let base_end = base
            .addr()
            .checked_add(base.size())
            .ok_or_else(|| StorageError::Unsupported("base address + size overflow".into()))?;

        // Verify address is within the base region
        if address < base.addr() || end > base_end {
            return Err(StorageError::Unsupported("address out of bounds".into()));
        }

        let offset = address - base.addr();
        Self::new(base, offset, size)
    }

63
64
65
66
67
68
69
70
71
72
73
    /// Get the offset relative to the base mapping.
    pub fn offset(&self) -> usize {
        self.offset
    }

    /// Access the underlying base region.
    pub fn base(&self) -> &Buffer {
        &self.base
    }
}

74
impl MemoryDescriptor for OffsetBuffer {
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
    fn addr(&self) -> usize {
        self.base.addr() + self.offset
    }

    fn size(&self) -> usize {
        self.size
    }

    fn storage_kind(&self) -> StorageKind {
        self.base.storage_kind()
    }

    fn as_any(&self) -> &dyn Any {
        self
    }

    fn nixl_descriptor(&self) -> Option<NixlDescriptor> {
        let mut descriptor = self.base.nixl_descriptor()?;
        descriptor.addr = self.addr() as u64;
        descriptor.size = self.size();
        Some(descriptor)
    }
}
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283

#[cfg(test)]
mod tests {
    use super::*;
    use crate::SystemStorage;

    fn create_test_buffer(size: usize) -> Buffer {
        Buffer::new(SystemStorage::new(size).expect("allocation failed"))
    }

    #[test]
    fn test_offset_buffer_new_valid() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");
        assert_eq!(offset_buf.offset(), 100);
        assert_eq!(offset_buf.size(), 200);
    }

    #[test]
    fn test_offset_buffer_new_zero_offset() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base.clone(), 0, 1024).expect("should succeed");
        assert_eq!(offset_buf.offset(), 0);
        assert_eq!(offset_buf.size(), 1024);
        assert_eq!(offset_buf.addr(), base.addr());
    }

    #[test]
    fn test_offset_buffer_new_at_end() {
        let base = create_test_buffer(1024);
        // Offset at exact end with zero size should succeed
        let offset_buf = OffsetBuffer::new(base, 1024, 0).expect("should succeed");
        assert_eq!(offset_buf.offset(), 1024);
        assert_eq!(offset_buf.size(), 0);
    }

    #[test]
    fn test_offset_buffer_new_invalid_offset() {
        let base = create_test_buffer(1024);
        // Offset beyond bounds
        let result = OffsetBuffer::new(base, 1025, 0);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_new_invalid_size() {
        let base = create_test_buffer(1024);
        // Size exceeds remaining space
        let result = OffsetBuffer::new(base, 100, 1000);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_new_size_overflow() {
        let base = create_test_buffer(1024);
        // offset + size would overflow usize
        let result = OffsetBuffer::new(base, usize::MAX, 1);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_from_inner_address_valid() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        let offset_buf =
            OffsetBuffer::from_inner_address(base, base_addr + 100, 200).expect("should succeed");
        assert_eq!(offset_buf.offset(), 100);
        assert_eq!(offset_buf.size(), 200);
    }

    #[test]
    fn test_offset_buffer_from_inner_address_at_start() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        let offset_buf = OffsetBuffer::from_inner_address(base.clone(), base_addr, 1024)
            .expect("should succeed");
        assert_eq!(offset_buf.offset(), 0);
        assert_eq!(offset_buf.addr(), base.addr());
    }

    #[test]
    fn test_offset_buffer_from_inner_address_overflow() {
        let base = create_test_buffer(1024);
        // address + size would overflow
        let result = OffsetBuffer::from_inner_address(base, usize::MAX, 1);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_from_inner_address_out_of_bounds_before() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        // Address before base region
        let result = OffsetBuffer::from_inner_address(base, base_addr.saturating_sub(1), 100);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_from_inner_address_out_of_bounds_after() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        // End address beyond base region
        let result = OffsetBuffer::from_inner_address(base, base_addr + 900, 200);
        assert!(result.is_err());
    }

    #[test]
    fn test_offset_buffer_accessors() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        let offset_buf = OffsetBuffer::new(base, 256, 512).expect("should succeed");

        assert_eq!(offset_buf.offset(), 256);
        assert_eq!(offset_buf.base().addr(), base_addr);
        assert_eq!(offset_buf.base().size(), 1024);
    }

    #[test]
    fn test_offset_buffer_memory_descriptor_addr() {
        let base = create_test_buffer(1024);
        let base_addr = base.addr();
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");

        // addr() should return base_addr + offset
        assert_eq!(offset_buf.addr(), base_addr + 100);
    }

    #[test]
    fn test_offset_buffer_memory_descriptor_size() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");
        assert_eq!(offset_buf.size(), 200);
    }

    #[test]
    fn test_offset_buffer_memory_descriptor_storage_kind() {
        let base = create_test_buffer(1024);
        let base_kind = base.storage_kind();
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");

        // storage_kind should match the base
        assert_eq!(offset_buf.storage_kind(), base_kind);
    }

    #[test]
    fn test_offset_buffer_as_any() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");

        // Should be able to downcast to OffsetBuffer
        let any_ref = offset_buf.as_any();
        assert!(any_ref.downcast_ref::<OffsetBuffer>().is_some());
    }

    #[test]
    fn test_offset_buffer_clone() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");
        let cloned = offset_buf.clone();

        assert_eq!(offset_buf.addr(), cloned.addr());
        assert_eq!(offset_buf.size(), cloned.size());
        assert_eq!(offset_buf.offset(), cloned.offset());
    }

    #[test]
    fn test_offset_buffer_debug() {
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");
        let debug_str = format!("{:?}", offset_buf);

        assert!(debug_str.contains("OffsetBuffer"));
        assert!(debug_str.contains("offset"));
        assert!(debug_str.contains("size"));
    }

    #[test]
    fn test_offset_buffer_nixl_descriptor_none() {
        // SystemStorage doesn't have a NIXL descriptor
        let base = create_test_buffer(1024);
        let offset_buf = OffsetBuffer::new(base, 100, 200).expect("should succeed");

        // Should return None since base has no NIXL descriptor
        assert!(offset_buf.nixl_descriptor().is_none());
    }
}