common.rs 14.2 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
// SPDX-License-Identifier: Apache-2.0

4
use std::pin::Pin;
5
use std::time::Duration;
6

7
use crate::{
8
    backend::{Backend, ExecutionContext},
9
    discovery::{KvWorkerMonitor, ModelManager, ModelWatcher},
10
    engines::StreamingEngineAdapter,
11
    entrypoint::{EngineConfig, RouterConfig},
12
    http::service::metrics::Metrics,
13
14
15
    kv_router::{
        DirectRoutingRouter, KvPushRouter, KvRouter, PrefillRouter, metrics::RouterRequestMetrics,
    },
16
    migration::Migration,
17
    model_card::ModelDeploymentCard,
18
    namespace::NamespaceFilter,
19
    preprocessor::{OpenAIPreprocessor, prompt::PromptFormatter},
20
    protocols::common::llm_backend::{BackendOutput, LLMEngineOutput, PreprocessedRequest},
21
    request_template::RequestTemplate,
22
    types::{
23
        Annotated,
24
25
26
27
28
29
        openai::chat_completions::{
            NvCreateChatCompletionRequest, NvCreateChatCompletionStreamResponse,
            OpenAIChatCompletionsStreamingEngine,
        },
    },
};
30

31
use anyhow::Context as _;
32
use dynamo_kv_router::config::min_initial_workers_from_env;
33
use dynamo_runtime::{
34
    DistributedRuntime,
35
    component::Client,
36
    engine::{AsyncEngineStream, Data},
37
38
39
40
    pipeline::{
        Context, ManyOut, Operator, PushRouter, RouterMode, SegmentSource, ServiceBackend,
        ServiceEngine, ServiceFrontend, SingleIn, Source,
    },
41
42
43
};
use std::sync::Arc;

44
45
46
47
pub struct PreparedEngine {
    pub service_name: String,
    pub engine: OpenAIChatCompletionsStreamingEngine,
    pub inspect_template: bool,
48
49
50
    pub request_template: Option<RequestTemplate>,
}

51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
async fn wait_for_min_initial_workers(
    client: &Client,
    min_initial_workers: usize,
) -> anyhow::Result<()> {
    if min_initial_workers == 0 {
        return Ok(());
    }

    if min_initial_workers == 1 {
        client.wait_for_instances().await?;
        return Ok(());
    }

    let mut watcher = client.instance_avail_watcher();
    loop {
        let available = watcher.borrow_and_update().len();
        if available >= min_initial_workers {
            return Ok(());
        }

        tokio::time::timeout(Duration::from_secs(120), watcher.changed())
            .await
            .map_err(|_| {
                anyhow::anyhow!(
                    "timed out waiting for {} initial workers for endpoint {}",
                    min_initial_workers,
                    client.endpoint.id()
                )
            })?
            .map_err(|_| {
                anyhow::anyhow!(
                    "instance watcher closed before {} workers appeared for endpoint {}",
                    min_initial_workers,
                    client.endpoint.id()
                )
            })?;
    }
}

90
/// Turns an EngineConfig into an OpenAI chat-completions and completions supported StreamingEngine.
91
pub async fn prepare_engine(
92
    distributed_runtime: DistributedRuntime,
93
    engine_config: EngineConfig,
94
) -> anyhow::Result<PreparedEngine> {
95
    match engine_config {
96
        EngineConfig::Dynamic {
97
98
99
            model: local_model,
            prefill_load_estimator,
            ..
100
        } => {
101
            let model_manager = Arc::new(ModelManager::new());
102
103
            // Create metrics for migration tracking (not exposed via /metrics in Dynamic engine mode)
            let metrics = Arc::new(Metrics::new());
104
            let watch_obj = Arc::new(ModelWatcher::new(
105
                distributed_runtime.clone(),
106
                model_manager.clone(),
107
                RouterConfig::default(),
108
                local_model.migration_limit(),
109
                local_model.migration_max_seq_len(),
110
                None,
111
                prefill_load_estimator,
112
                metrics,
113
            ));
114
115
116
117
118
119
120
            let discovery = distributed_runtime.discovery();
            let discovery_stream = discovery
                .list_and_watch(
                    dynamo_runtime::discovery::DiscoveryQuery::AllModels,
                    Some(distributed_runtime.primary_token().clone()),
                )
                .await?;
121
            let inner_watch_obj = watch_obj.clone();
122
123
124
125
            let namespace_filter = NamespaceFilter::from_namespace_and_prefix(
                local_model.namespace(),
                local_model.namespace_prefix(),
            );
126
            let _watcher_task = tokio::spawn(async move {
127
128
129
                inner_watch_obj
                    .watch(discovery_stream, namespace_filter)
                    .await;
130
            });
131
            tracing::info!("Waiting for remote model..");
132

133
134
135
136
137
            // TODO: We use the first model to appear, usually we have only one
            // We should add slash commands to text input `/model <name>` to choose,
            // '/models` to list, and notifications when models are added / removed.

            let model_service_name = watch_obj.wait_for_chat_model().await;
138
            tracing::info!("Connected to {model_service_name}");
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
            // In disaggregated deployments the model may be listed before the prefill
            // router is fully activated, causing a transient ModelUnavailable. Retry
            // with a timeout so the startup path doesn't fail during this cold-start
            // window, but also doesn't hang indefinitely on misconfiguration.
            let deadline = tokio::time::Instant::now() + Duration::from_secs(120);
            let engine = loop {
                match model_manager.get_chat_completions_engine(&model_service_name) {
                    Ok(engine) => break engine,
                    Err(crate::discovery::ModelManagerError::ModelUnavailable(_))
                        if tokio::time::Instant::now() < deadline =>
                    {
                        tracing::debug!(
                            model = %model_service_name,
                            "Model listed but not yet servable, waiting for prefill activation"
                        );
                        tokio::time::sleep(Duration::from_millis(500)).await;
                    }
                    Err(e) => return Err(e.into()),
                }
            };
159
            Ok(PreparedEngine {
160
                service_name: model_service_name,
161
162
                engine,
                inspect_template: false,
163
                request_template: local_model.request_template(),
164
            })
165
        }
166
        EngineConfig::InProcessText { engine, model, .. } => {
167
            let service_name = model.service_name().to_string();
168
            tracing::debug!("Model: {service_name} with engine pre-processing");
169
            let engine = Arc::new(StreamingEngineAdapter::new(engine));
170
171
172
173
            Ok(PreparedEngine {
                service_name,
                engine,
                inspect_template: false,
174
                request_template: model.request_template(),
175
            })
176
        }
177
        EngineConfig::InProcessTokens {
178
            engine: inner_engine,
179
            model,
180
            ..
181
        } => {
182
183
184
            let pipeline = build_pipeline::<
                NvCreateChatCompletionRequest,
                NvCreateChatCompletionStreamResponse,
Nikita's avatar
Nikita committed
185
            >(model.card(), inner_engine, model.card().tokenizer()?)
186
            .await?;
187

188
            let service_name = model.service_name().to_string();
189
190
191
192
193
            tracing::debug!("Model: {service_name} with Dynamo pre-processing");
            Ok(PreparedEngine {
                service_name,
                engine: pipeline,
                inspect_template: true,
194
                request_template: model.request_template(),
195
            })
196
197
198
        }
    }
}
199
200
201
202

pub async fn build_pipeline<Req, Resp>(
    card: &ModelDeploymentCard,
    engine: ExecutionContext,
Nikita's avatar
Nikita committed
203
    tokenizer: crate::tokenizers::Tokenizer,
204
205
206
207
208
) -> anyhow::Result<Arc<ServiceFrontend<SingleIn<Req>, ManyOut<Annotated<Resp>>>>>
where
    Req: Data,
    Resp: Data,
    OpenAIPreprocessor: Operator<
209
210
211
212
213
            Context<Req>,
            Pin<Box<dyn AsyncEngineStream<Annotated<Resp>>>>,
            Context<PreprocessedRequest>,
            Pin<Box<dyn AsyncEngineStream<Annotated<BackendOutput>>>>,
        >,
214
215
{
    let frontend = ServiceFrontend::<SingleIn<Req>, ManyOut<Annotated<Resp>>>::new();
216
217
    let PromptFormatter::OAI(formatter) = PromptFormatter::from_mdc(card)?;
    let preprocessor =
Nikita's avatar
Nikita committed
218
        OpenAIPreprocessor::new_with_parts(card.clone(), formatter, tokenizer.clone())?
219
            .into_operator();
Nikita's avatar
Nikita committed
220
    let backend = Backend::from_tokenizer(tokenizer).into_operator();
221
222
223
224
225
226
227
228
229
230
231
    let engine = ServiceBackend::from_engine(engine);

    Ok(frontend
        .link(preprocessor.forward_edge())?
        .link(backend.forward_edge())?
        .link(engine)?
        .link(backend.backward_edge())?
        .link(preprocessor.backward_edge())?
        .link(frontend)?)
}

232
#[allow(clippy::too_many_arguments)]
233
234
235
pub async fn build_routed_pipeline<Req, Resp>(
    card: &ModelDeploymentCard,
    client: &Client,
236
    model_manager: Arc<crate::discovery::ModelManager>,
237
    router_mode: RouterMode,
238
    worker_monitor: Option<KvWorkerMonitor>,
239
    chooser: Option<Arc<KvRouter>>,
Nikita's avatar
Nikita committed
240
    tokenizer: crate::tokenizers::Tokenizer,
241
    prefill_chooser: Option<Arc<PrefillRouter>>,
242
    enforce_disagg: bool,
243
    migration_limit: u32,
244
    migration_max_seq_len: Option<u32>,
245
    metrics: Arc<Metrics>,
246
) -> anyhow::Result<ServiceEngine<SingleIn<Req>, ManyOut<Annotated<Resp>>>>
247
248
249
250
251
252
253
254
255
256
where
    Req: Data,
    Resp: Data,
    OpenAIPreprocessor: Operator<
            Context<Req>,
            Pin<Box<dyn AsyncEngineStream<Annotated<Resp>>>>,
            Context<PreprocessedRequest>,
            Pin<Box<dyn AsyncEngineStream<Annotated<BackendOutput>>>>,
        >,
{
257
258
    let PromptFormatter::OAI(formatter) =
        PromptFormatter::from_mdc(card).context("PromptFormatter.from_mdc")?;
259
    let preprocessor =
Nikita's avatar
Nikita committed
260
        OpenAIPreprocessor::new_with_parts(card.clone(), formatter, tokenizer.clone())
261
            .context("OpenAIPreprocessor.new_with_parts")?;
262
263
264
    build_routed_pipeline_with_preprocessor(
        card,
        client,
265
        model_manager,
266
        router_mode,
267
        worker_monitor,
268
269
        chooser,
        preprocessor,
Nikita's avatar
Nikita committed
270
        tokenizer,
271
        prefill_chooser,
272
        enforce_disagg,
273
        migration_limit,
274
        migration_max_seq_len,
275
        metrics,
276
277
278
279
    )
    .await
}

280
#[allow(clippy::too_many_arguments)]
281
282
283
pub async fn build_routed_pipeline_with_preprocessor<Req, Resp>(
    card: &ModelDeploymentCard,
    client: &Client,
284
    model_manager: Arc<crate::discovery::ModelManager>,
285
    router_mode: RouterMode,
286
    worker_monitor: Option<KvWorkerMonitor>,
287
288
    chooser: Option<Arc<KvRouter>>,
    preprocessor: Arc<OpenAIPreprocessor>,
Nikita's avatar
Nikita committed
289
    tokenizer: crate::tokenizers::Tokenizer,
290
    prefill_chooser: Option<Arc<PrefillRouter>>,
291
    enforce_disagg: bool,
292
    migration_limit: u32,
293
    migration_max_seq_len: Option<u32>,
294
    metrics: Arc<Metrics>,
295
) -> anyhow::Result<ServiceEngine<SingleIn<Req>, ManyOut<Annotated<Resp>>>>
296
297
298
299
where
    Req: Data,
    Resp: Data,
    OpenAIPreprocessor: Operator<
300
301
302
303
304
            Context<Req>,
            Pin<Box<dyn AsyncEngineStream<Annotated<Resp>>>>,
            Context<PreprocessedRequest>,
            Pin<Box<dyn AsyncEngineStream<Annotated<BackendOutput>>>>,
        >,
305
306
{
    let frontend = SegmentSource::<SingleIn<Req>, ManyOut<Annotated<Resp>>>::new();
307
    let preprocessor_op = preprocessor.into_operator();
Nikita's avatar
Nikita committed
308
    let backend = Backend::from_tokenizer(tokenizer).into_operator();
309
310
    let migration =
        Migration::from_mdc(card, migration_limit, migration_max_seq_len, metrics).into_operator();
311
    let min_initial_workers = min_initial_workers_from_env()?;
312

313
314
315
316
317
318
319
320
321
322
    // For KV routing, use the client from the chooser to ensure shared state
    let router_client = if router_mode == RouterMode::KV {
        let Some(ref chooser) = chooser else {
            anyhow::bail!("RouterMode::KV requires KVRouter to not be null");
        };
        chooser.client().clone()
    } else {
        client.clone()
    };

323
324
    wait_for_min_initial_workers(&router_client, min_initial_workers).await?;

325
    // Get threshold value and wrap monitor for PushRouter
326
327
328
329
    // Note: PushRouter uses active_decode_blocks_threshold for its internal logic
    let threshold_value = worker_monitor
        .as_ref()
        .map(|m| m.active_decode_blocks_threshold());
330
331
    let monitor_arc =
        worker_monitor.map(|m| Arc::new(m) as Arc<dyn dynamo_runtime::pipeline::WorkerLoadMonitor>);
332

333
334
    let router =
        PushRouter::<PreprocessedRequest, Annotated<LLMEngineOutput>>::from_client_with_threshold(
335
            router_client,
336
            router_mode,
337
338
            threshold_value,
            monitor_arc,
339
340
        )
        .await?;
341

342
343
344
345
346
347
    // Eagerly register router request metrics so they appear as zeros even in
    // non-KV modes (Direct, Random, RoundRobin) where KvPushRouter is never created.
    // In KV mode, KvPushRouter::new() also calls from_component() (idempotent via
    // OnceLock), which covers the standalone router path as well.
    RouterRequestMetrics::from_component(client.endpoint.component());

348
    let service_backend = match router_mode {
349
350
351
        RouterMode::Direct => {
            ServiceBackend::from_engine(Arc::new(DirectRoutingRouter::new(router)))
        }
352
353
354
        RouterMode::Random
        | RouterMode::RoundRobin
        | RouterMode::PowerOfTwoChoices
355
356
        | RouterMode::LeastLoaded
        | RouterMode::DeviceAwareWeighted => ServiceBackend::from_engine(Arc::new(router)),
357
358
359
360
        RouterMode::KV => {
            let Some(chooser) = chooser else {
                anyhow::bail!("RouterMode::KV requires KVRouter to not be null");
            };
361
            ServiceBackend::from_engine(Arc::new(KvPushRouter::new(router, chooser)))
362
363
364
        }
    };

365
    // Use the provided prefill chooser, or create a disabled one if not provided
366
    let prefill_chooser = prefill_chooser
367
        .unwrap_or_else(|| PrefillRouter::disabled(model_manager, router_mode, enforce_disagg));
368
369
370
    let prefill_op = prefill_chooser.into_operator();

    // Link with prefill chooser including backward edge for response flow
371
    let engine = frontend
372
        .link(preprocessor_op.forward_edge())?
373
        .link(migration.forward_edge())?
374
        .link(backend.forward_edge())?
375
        .link(prefill_op.forward_edge())?
376
        .link(service_backend)?
377
        .link(prefill_op.backward_edge())?
378
        .link(backend.backward_edge())?
379
        .link(migration.backward_edge())?
380
        .link(preprocessor_op.backward_edge())?
381
        .link(frontend)?;
382

383
384
    Ok(engine)
}