minimax_append_think_parser.rs 7.17 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

use crate::{ParserResult, ReasoningParser};

use super::base_parser::BasicReasoningParser;

/// MiniMax Append-Think Reasoning Parser.
///
/// The MiniMax model starts generating reasoning content immediately WITHOUT
/// a `<think>` prefix. The model output looks like:
///   `reasoning content here...</think>actual response`
///
/// This parser prepends `<think>` to the first chunk, transforming the stream into:
///   `<think>reasoning content here...</think>actual response`
///
/// It then delegates to `BasicReasoningParser` for standard `<think>...</think>`
/// extraction, splitting output into `reasoning_text` and `normal_text`.
///
/// Reference: SGLang MiniMaxAppendThinkDetector
/// https://github.com/sgl-project/sglang/blob/main/python/sglang/srt/parser/reasoning_parser.py
#[derive(Debug)]
pub struct MiniMaxAppendThinkParser {
    inner: BasicReasoningParser,
    is_first_chunk: bool,
}

impl Default for MiniMaxAppendThinkParser {
    fn default() -> Self {
        Self {
            inner: BasicReasoningParser::new(
                "<think>".into(),
                "</think>".into(),
                false, // force_reasoning=false; we synthesize <think> ourselves
                true,  // stream_reasoning=true
            ),
            is_first_chunk: true,
        }
    }
}

impl MiniMaxAppendThinkParser {
    pub fn new() -> Self {
        Self::default()
    }
}

impl ReasoningParser for MiniMaxAppendThinkParser {
    fn detect_and_parse_reasoning(&mut self, text: &str, token_ids: &[u32]) -> ParserResult {
        // Prepend <think> and delegate to the inner parser
        let augmented = format!("<think>{}", text);
        self.inner.detect_and_parse_reasoning(&augmented, token_ids)
    }

    fn parse_reasoning_streaming_incremental(
        &mut self,
        text: &str,
        token_ids: &[u32],
    ) -> ParserResult {
        if self.is_first_chunk {
            self.is_first_chunk = false;
            let augmented = format!("<think>{}", text);
            self.inner
                .parse_reasoning_streaming_incremental(&augmented, token_ids)
        } else {
            self.inner
                .parse_reasoning_streaming_incremental(text, token_ids)
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_detect_and_parse_no_end_token() {
        let mut parser = MiniMaxAppendThinkParser::new();
        let result = parser.detect_and_parse_reasoning("reasoning content here", &[]);
        assert_eq!(result.reasoning_text, "reasoning content here");
        assert_eq!(result.normal_text, "");
    }

    #[test]
    fn test_detect_and_parse_with_end_token() {
        let mut parser = MiniMaxAppendThinkParser::new();
        let result =
            parser.detect_and_parse_reasoning("reasoning content</think>normal response", &[]);
        assert_eq!(result.reasoning_text, "reasoning content");
        assert_eq!(result.normal_text, "normal response");
    }

    #[test]
    fn test_streaming_basic_flow() {
        let mut parser = MiniMaxAppendThinkParser::new();

        // First chunk: model starts reasoning without <think>
        let r1 = parser.parse_reasoning_streaming_incremental("I need to ", &[]);
        assert_eq!(r1.reasoning_text, "I need to ");
        assert_eq!(r1.normal_text, "");

        // Middle chunk: still reasoning
        let r2 = parser.parse_reasoning_streaming_incremental("check the weather", &[]);
        assert_eq!(r2.reasoning_text, "check the weather");
        assert_eq!(r2.normal_text, "");

        // End of reasoning
        let r3 = parser.parse_reasoning_streaming_incremental("</think>The weather is sunny.", &[]);
        assert_eq!(r3.reasoning_text, "");
        assert_eq!(r3.normal_text, "The weather is sunny.");
    }

    #[test]
    fn test_streaming_end_token_split_across_chunks() {
        let mut parser = MiniMaxAppendThinkParser::new();

        // With stream_reasoning=true, reasoning is emitted immediately
        let r1 = parser.parse_reasoning_streaming_incremental("reasoning", &[]);
        assert_eq!(r1.reasoning_text, "reasoning");
        assert_eq!(r1.normal_text, "");

        // </think> split across chunks - partial match should buffer
        let r2 = parser.parse_reasoning_streaming_incremental("</thi", &[]);
        assert_eq!(r2.reasoning_text, "");
        assert_eq!(r2.normal_text, "");

        // Complete the end token - reasoning already streamed in r1,
        // so r3 only contains the normal text after </think>
        let r3 = parser.parse_reasoning_streaming_incremental("nk>normal text", &[]);
        assert_eq!(r3.reasoning_text, "");
        assert_eq!(r3.normal_text, "normal text");
    }

    #[test]
    fn test_streaming_only_reasoning_no_end() {
        let mut parser = MiniMaxAppendThinkParser::new();

        let r1 = parser.parse_reasoning_streaming_incremental("still thinking", &[]);
        assert_eq!(r1.reasoning_text, "still thinking");
        assert_eq!(r1.normal_text, "");

        let r2 = parser.parse_reasoning_streaming_incremental(" more thought", &[]);
        assert_eq!(r2.reasoning_text, " more thought");
        assert_eq!(r2.normal_text, "");
    }

    #[test]
    fn test_streaming_with_tool_call_after_reasoning() {
        let mut parser = MiniMaxAppendThinkParser::new();

        let r1 = parser.parse_reasoning_streaming_incremental("let me call a tool", &[]);
        assert_eq!(r1.reasoning_text, "let me call a tool");

        let r2 = parser.parse_reasoning_streaming_incremental(
            "</think><minimax:tool_call><invoke name=\"get_weather\">",
            &[],
        );
        assert_eq!(r2.reasoning_text, "");
        assert!(
            r2.normal_text
                .contains("<minimax:tool_call><invoke name=\"get_weather\">")
        );
    }

    #[test]
    fn test_streaming_tool_call_angle_bracket_split_tokens() {
        // Reproduces the bug where `<` before `<invoke` is consumed by the
        // reasoning parser's prefix matching after reasoning ends.
        let mut parser = MiniMaxAppendThinkParser::new();

        // Reasoning phase
        let r1 = parser.parse_reasoning_streaming_incremental("let me check the weather", &[]);
        assert_eq!(r1.reasoning_text, "let me check the weather");

        // End reasoning
        let r2 = parser.parse_reasoning_streaming_incremental("</think>", &[]);
        assert_eq!(r2.reasoning_text, "");
        assert_eq!(r2.normal_text, "");

        // Tool call start marker
        let r3 = parser.parse_reasoning_streaming_incremental("<minimax:tool_call>", &[]);
        assert_eq!(r3.normal_text, "<minimax:tool_call>");

        // Newline
        let r4 = parser.parse_reasoning_streaming_incremental("\n", &[]);
        assert_eq!(r4.normal_text, "\n");

        // `<` as a separate token must NOT be buffered after reasoning ends
        let r5 = parser.parse_reasoning_streaming_incremental("<", &[]);
        assert_eq!(r5.normal_text, "<");

        // Rest of the invoke tag
        let r6 = parser.parse_reasoning_streaming_incremental("invoke name=\"get_weather\">", &[]);
        assert_eq!(r6.normal_text, "invoke name=\"get_weather\">");
    }
}