"lib/vscode:/vscode.git/clone" did not exist on "658b0d5ac888ec8303d95487d1cd3f02cf62668b"
migration.rs 34.4 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
4
5
6
7
8
9
10
11
12
13
// SPDX-License-Identifier: Apache-2.0

use std::sync::Arc;

use anyhow::{Error, Result};
use futures::{stream, stream::StreamExt};

use async_nats::client::{
    RequestError as NatsRequestError, RequestErrorKind::NoResponders as NatsNoResponders,
};

use crate::{
14
    http::service::metrics::Metrics, model_card::ModelDeploymentCard, preprocessor::BackendOutput,
15
    protocols::common::llm_backend::PreprocessedRequest,
16
17
};

18
19
20
use dynamo_runtime::pipeline::{
    AsyncEngineContext, AsyncEngineContextProvider, Context, ManyOut, Operator, ResponseStream,
    ServerStreamingEngine, SingleIn, async_trait, network::STREAM_ERR_MSG,
21
};
22
use dynamo_runtime::protocols::{annotated::Annotated, maybe_error::MaybeError};
23
24
25

pub struct Migration {
    migration_limit: u32,
26
27
    model_name: Arc<String>,
    metrics: Arc<Metrics>,
28
29
30
}

impl Migration {
31
    pub fn from_mdc(mdc: &ModelDeploymentCard, metrics: Arc<Metrics>) -> Arc<Self> {
32
33
34
35
36
        tracing::debug!(
            "model {} migration limit {}",
            mdc.display_name,
            mdc.migration_limit
        );
37
        Arc::new(Self {
38
            migration_limit: mdc.migration_limit,
39
40
            model_name: Arc::new(mdc.display_name.clone()),
            metrics,
41
        })
42
43
44
45
46
47
48
    }
}

#[async_trait]
impl
    Operator<
        SingleIn<PreprocessedRequest>,
49
        ManyOut<Annotated<BackendOutput>>,
50
        SingleIn<PreprocessedRequest>,
51
        ManyOut<Annotated<BackendOutput>>,
52
53
54
55
56
    > for Migration
{
    async fn generate(
        &self,
        request: SingleIn<PreprocessedRequest>,
57
58
        next: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
    ) -> Result<ManyOut<Annotated<BackendOutput>>> {
59
60
        let (preprocessed_request, context) = request.transfer(());
        let engine_ctx = context.context();
61
        let engine_ctx_ = engine_ctx.clone();
62
63
64
65
66
67
68
69
70
        let retry_manager = RetryManager::build(
            engine_ctx,
            preprocessed_request,
            next,
            self.migration_limit,
            self.model_name.clone(),
            self.metrics.clone(),
        )
        .await?;
71
72
73
74
75
        let response_stream = stream::unfold(retry_manager, move |mut retry_manager| async move {
            retry_manager
                .next()
                .await
                .map(|response| (response, retry_manager))
76
77
        })
        .fuse();
78
        Ok(ResponseStream::new(Box::pin(response_stream), engine_ctx_))
79
80
81
82
    }
}

struct RetryManager {
83
    context: Arc<dyn AsyncEngineContext>,
84
    request: PreprocessedRequest,
85
86
    next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
    next_stream: Option<ManyOut<Annotated<BackendOutput>>>,
87
    retries_left: u32,
88
89
    model_name: Arc<String>,
    metrics: Arc<Metrics>,
90
91
92
93
}

impl RetryManager {
    pub async fn build(
94
        context: Arc<dyn AsyncEngineContext>,
95
        preprocessed_request: PreprocessedRequest,
96
        next: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>>,
97
        retries_left: u32,
98
99
        model_name: Arc<String>,
        metrics: Arc<Metrics>,
100
101
    ) -> Result<Self> {
        let mut slf = Self {
102
            context,
103
104
105
106
            request: preprocessed_request,
            next_generate: next,
            next_stream: None,
            retries_left: retries_left + 1, // +1 to account for the initial attempt
107
108
            model_name,
            metrics,
109
110
111
112
113
        };
        slf.new_stream().await?;
        Ok(slf)
    }

114
    pub async fn next(&mut self) -> Option<Annotated<BackendOutput>> {
115
116
117
118
119
120
121
122
123
124
125
        loop {
            let response_stream = match self.next_stream.as_mut() {
                Some(stream) => stream,
                None => {
                    tracing::error!("next() called with next_stream is None - should not happen");
                    return Some(Annotated::from_err(
                        Error::msg("next_stream is None").into(),
                    ));
                }
            };
            if let Some(response) = response_stream.next().await {
126
127
                if let Some(err) = response.err()
                    && err
128
129
                        .chain()
                        .any(|e| e.to_string().starts_with(STREAM_ERR_MSG))
130
131
                {
                    tracing::warn!("Stream disconnected... recreating stream...");
132
                    self.metrics.inc_migration_ongoing_request(&self.model_name);
133
134
135
136
                    if let Err(err) = self.new_stream().await {
                        tracing::warn!("Cannot recreate stream: {:#}", err);
                    } else {
                        continue;
137
138
139
140
141
142
143
144
145
146
                    }
                }
                self.track_response(&response);
                return Some(response);
            }
            return None;
        }
    }

    async fn new_stream(&mut self) -> Result<()> {
147
        let mut response_stream: Option<Result<ManyOut<Annotated<BackendOutput>>>> = None;
148
149
        while self.retries_left > 0 {
            self.retries_left -= 1;
150
151
            let request = Context::with_id(self.request.clone(), self.context.id().to_string());
            self.context.link_child(request.context());
152
153
154
155
156
157
158
            if self.context.is_stopped() || self.context.is_killed() {
                tracing::debug!("Abort creating new stream after context is stopped or killed");
                return Err(Error::msg(format!(
                    "Context id {} is stopped or killed",
                    self.context.id()
                )));
            }
159
            response_stream = Some(self.next_generate.generate(request).await);
160
161
162
163
164
            if let Some(err) = response_stream.as_ref().unwrap().as_ref().err()
                && let Some(req_err) = err.downcast_ref::<NatsRequestError>()
                && matches!(req_err.kind(), NatsNoResponders)
            {
                tracing::warn!("Creating new stream... retrying...");
165
                self.metrics.inc_migration_new_request(&self.model_name);
166
                continue;
167
168
169
170
171
172
173
174
            }
            break;
        }
        match response_stream {
            Some(Ok(next_stream)) => {
                self.next_stream = Some(next_stream);
                Ok(())
            }
175
            Some(Err(err)) => Err(err), // should propagate original error if any
176
            None => Err(Error::msg(
177
                "Migration limit exhausted", // should propagate original error if any
178
179
180
181
            )),
        }
    }

182
    fn track_response(&mut self, response: &Annotated<BackendOutput>) {
183
184
185
186
187
188
189
        if self.retries_left == 0 {
            return;
        }
        let llm_engine_output = match response.data.as_ref() {
            Some(output) => output,
            None => return,
        };
190
191
192
193
        if let Some(max_tokens) = self.request.stop_conditions.max_tokens {
            self.request.stop_conditions.max_tokens =
                Some(max_tokens.saturating_sub(llm_engine_output.token_ids.len() as u32));
        }
194
195
196
197
198
199
200
201
202
        for token_id in llm_engine_output.token_ids.iter() {
            self.request.token_ids.push(*token_id);
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
203
    use crate::http::service::metrics::Metrics;
Greg Clark's avatar
Greg Clark committed
204
    use crate::protocols::common::{OutputOptions, SamplingOptions, StopConditions};
205
    use dynamo_runtime::pipeline::AsyncEngine;
206
    use dynamo_runtime::pipeline::context::Controller;
207
208
209
    use std::sync::atomic::{AtomicU32, Ordering};
    use tokio::sync::mpsc;

210
211
    const TEST_MODEL: &str = "test-model";

212
    // Helper to create a mock preprocessed request
213
    fn create_mock_request(max_tokens: u32) -> PreprocessedRequest {
214
215
216
217
        PreprocessedRequest::builder()
            .model("mock".to_string())
            .token_ids(vec![1, 2, 3])
            .stop_conditions(StopConditions {
218
219
                max_tokens: Some(max_tokens),
                ..Default::default()
220
221
222
223
224
225
226
            })
            .sampling_options(SamplingOptions::default())
            .output_options(OutputOptions::default())
            .eos_token_ids(vec![])
            .annotations(vec![])
            .build()
            .unwrap()
227
228
229
    }

    // Helper to create mock LLM engine output
230
231
    fn create_mock_output(token_id: u32) -> Annotated<BackendOutput> {
        Annotated::from_data(BackendOutput {
232
            token_ids: vec![token_id],
233
234
            tokens: vec![],
            text: Some(format!("token_{token_id}")),
235
236
            cum_log_probs: None,
            log_probs: None,
Greg Clark's avatar
Greg Clark committed
237
            top_logprobs: None,
238
            finish_reason: None,
239
            stop_reason: None,
240
            index: None,
241
            disaggregated_params: None,
242
            completion_usage: None,
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
        })
    }

    #[derive(Debug, Clone)]
    enum MockBehavior {
        /// Always succeeds with all responses
        Success,
        /// Fails on first call with NoResponders error, then succeeds on subsequent calls
        FailThenSuccess,
        /// Succeeds initially, fails mid-stream with specific error, then succeeds on retry
        MidStreamFail { fail_after: usize },
        /// Succeeds initially, fails mid-stream with specific error, then always fails on retry attempts
        MidStreamFailAlways { fail_after: usize },
        /// Succeeds initially, fails mid-stream, then always fails with stream error on retry attempts
        MidStreamFailAlwaysStreamError { fail_after: usize },
        /// Always fails with NoResponders error (same as FailThenSuccess first call)
        AlwaysFail,
    }

    // Unified mock server streaming engine that can simulate different scenarios
    struct MockEngine {
        behavior: MockBehavior,
        num_responses: usize,
        token_offset: u32,
        call_count: Arc<AtomicU32>,
268
        context_id: String,
269
270
271
    }

    impl MockEngine {
272
273
274
275
276
277
        fn new(
            behavior: MockBehavior,
            num_responses: usize,
            token_offset: u32,
            context_id: String,
        ) -> Self {
278
279
280
281
282
            Self {
                behavior,
                num_responses,
                token_offset,
                call_count: Arc::new(AtomicU32::new(0)),
283
                context_id,
284
285
286
287
288
289
            }
        }
    }

    #[async_trait]
    impl
290
291
        AsyncEngine<SingleIn<PreprocessedRequest>, ManyOut<Annotated<BackendOutput>>, anyhow::Error>
        for MockEngine
292
293
294
295
    {
        async fn generate(
            &self,
            request: SingleIn<PreprocessedRequest>,
296
        ) -> Result<ManyOut<Annotated<BackendOutput>>> {
297
            let call_num = self.call_count.fetch_add(1, Ordering::SeqCst);
298
299
300
301
302
303
304
305
            let (preprocessed_request, context) = request.transfer(());

            // Assert that the context_id matches the expected one
            assert_eq!(
                context.id().to_string(),
                self.context_id,
                "Context ID mismatch"
            );
306
307
308
309
310
311
312
313

            // Calculate how many responses we've already generated based on request token_ids
            // Initial request has [1, 2, 3], so anything beyond that are generated responses
            let initial_tokens = 3; // [1, 2, 3]
            let responses_already_generated = preprocessed_request
                .token_ids
                .len()
                .saturating_sub(initial_tokens);
314
315
316
317
318
319
320
321
322
323
324
325

            // Assert that max_tokens reflects the expected remaining tokens
            let expected_max_tokens =
                self.num_responses
                    .saturating_sub(responses_already_generated) as u32;
            assert_eq!(
                preprocessed_request.stop_conditions.max_tokens,
                Some(expected_max_tokens),
                "max_tokens should be {} but got {:?}",
                expected_max_tokens,
                preprocessed_request.stop_conditions.max_tokens
            );
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360

            match &self.behavior {
                MockBehavior::Success => {
                    // Always succeed with remaining responses
                    self.send_responses(responses_already_generated, self.num_responses)
                        .await
                }
                MockBehavior::FailThenSuccess => {
                    if call_num == 0 {
                        // First call - return "No responders available" error to trigger retry
                        let nats_error: NatsRequestError = NatsNoResponders.into();
                        return Err(nats_error.into());
                    } else {
                        // Subsequent calls - succeed with remaining responses
                        self.send_responses(responses_already_generated, self.num_responses)
                            .await
                    }
                }
                MockBehavior::MidStreamFail { fail_after } => {
                    let (tx, rx) = mpsc::channel(1);
                    let token_offset = self.token_offset;
                    let fail_after = *fail_after;
                    let num_responses = self.num_responses;

                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
361
362
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
                            let _ = tx.send(error_response).await;
                        });
                    } else {
                        // Second call - send remaining responses from where we left off
                        tokio::spawn(async move {
                            for i in responses_already_generated..num_responses {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                        });
                    }

                    let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
378
                    let ctx = Arc::new(Controller::new(self.context_id.clone()));
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
                    Ok(dynamo_runtime::pipeline::ResponseStream::new(
                        Box::pin(stream),
                        ctx,
                    ))
                }
                MockBehavior::MidStreamFailAlways { fail_after } => {
                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        let (tx, rx) = mpsc::channel(1);
                        let token_offset = self.token_offset;
                        let fail_after = *fail_after;
                        let num_responses = self.num_responses;

                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
401
402
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
403
404
405
406
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
407
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    } else {
                        // Subsequent calls - always fail with NoResponders error (same as AlwaysFail)
                        let nats_error: NatsRequestError = NatsNoResponders.into();
                        Err(nats_error.into())
                    }
                }
                MockBehavior::MidStreamFailAlwaysStreamError { fail_after } => {
                    let (tx, rx) = mpsc::channel(1);
                    let token_offset = self.token_offset;
                    let fail_after = *fail_after;
                    let num_responses = self.num_responses;

                    if call_num == 0 {
                        // First call - send some responses then an error to simulate disconnection
                        tokio::spawn(async move {
                            // Send responses from current position to fail_after
                            for i in responses_already_generated..fail_after.min(num_responses) {
                                let response = create_mock_output(token_offset + 1 + i as u32);
                                if tx.send(response).await.is_err() {
                                    break;
                                }
                            }
                            // Send the specific error that triggers retry logic
435
436
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
437
438
439
440
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
441
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
442
443
444
445
446
447
448
449
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    } else {
                        // Subsequent calls - immediately send stream error (no successful responses)
                        tokio::spawn(async move {
                            // Send the stream error immediately
450
451
                            let error_response =
                                Annotated::from_err(anyhow::Error::msg(STREAM_ERR_MSG).into());
452
453
454
455
                            let _ = tx.send(error_response).await;
                        });

                        let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
456
                        let ctx = Arc::new(Controller::new(self.context_id.clone()));
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
                        Ok(dynamo_runtime::pipeline::ResponseStream::new(
                            Box::pin(stream),
                            ctx,
                        ))
                    }
                }
                MockBehavior::AlwaysFail => {
                    // Always fail with NoResponders error (same as FailThenSuccess first call)
                    let nats_error: NatsRequestError = NatsNoResponders.into();
                    Err(nats_error.into())
                }
            }
        }
    }

    impl MockEngine {
        async fn send_responses(
            &self,
            start: usize,
            end: usize,
477
        ) -> Result<ManyOut<Annotated<BackendOutput>>> {
478
479
480
481
482
483
484
485
486
487
488
489
490
            let (tx, rx) = mpsc::channel(1);
            let token_offset = self.token_offset;

            tokio::spawn(async move {
                for i in start..end {
                    let response = create_mock_output(token_offset + 1 + i as u32);
                    if tx.send(response).await.is_err() {
                        break;
                    }
                }
            });

            let stream = tokio_stream::wrappers::ReceiverStream::new(rx);
491
            let ctx = Arc::new(Controller::new(self.context_id.clone()));
492
493
494
495
496
497
498
499
500
501
502
503
504
            Ok(dynamo_runtime::pipeline::ResponseStream::new(
                Box::pin(stream),
                ctx,
            ))
        }
    }

    /// Test case 1: No migration needed
    /// Tests the normal case where the RetryManager successfully processes all responses
    /// from a single stream without any failures or need for retries/migration.
    /// Expected behavior: All 10 responses should be received successfully.
    #[tokio::test]
    async fn test_retry_manager_no_migration() {
505
        dynamo_runtime::logging::init();
506
        let context_id = uuid::Uuid::new_v4().to_string();
507
        let request = create_mock_request(10);
508
509
510
511
512
513
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::Success,
            10,
            100,
            context_id.clone(),
        ));
514
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
515
516
            mock_engine;

517
        let ctx = Arc::new(Controller::new(context_id.clone()));
518
519
520
521
522
523
524
525
526
527
528
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            0,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
529
530
531
532
533
534
535
536
537
538
539
540
541

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        assert_eq!(responses.len(), 10);
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
542
543
544

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
545
546
547
548
549
550
551
552
553
554
    }

    /// Test case 2: New request migration
    /// Tests the scenario where a worker becomes unreachable for new requests initially,
    /// triggering the RetryManager to retry the request. The MockEngine with FailThenSuccess
    /// fails on the first call with a "No responders available" error, then succeeds
    /// on subsequent calls, simulating a worker becoming available after initial failure.
    /// Expected behavior: All 10 responses should be received successfully after retry.
    #[tokio::test]
    async fn test_retry_manager_new_request_migration() {
555
        dynamo_runtime::logging::init();
556
        let context_id = uuid::Uuid::new_v4().to_string();
557
        let request = create_mock_request(10);
558
559
560
561
562
563
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::FailThenSuccess,
            10,
            100,
            context_id.clone(),
        ));
564
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
565
566
            mock_engine;

567
        let ctx = Arc::new(Controller::new(context_id.clone()));
568
569
570
571
572
573
574
575
576
577
578
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
579
580
581
582
583
584
585
586
587
588
589
590
591

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        assert_eq!(responses.len(), 10);
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
592
593
594

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 1);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
595
596
597
598
599
600
601
602
603
604
    }

    /// Test case 3: Ongoing request migration
    /// Tests the scenario where a worker fails mid-stream during an ongoing request.
    /// This simulates a connection being lost after partial response delivery, requiring
    /// the RetryManager to detect the failure (via "Stream ended before generation completed" error),
    /// create a new stream, and continue from where it left off.
    /// Expected behavior: 5 responses from first stream + 5 responses from retry stream = 10 total.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration() {
605
606
        dynamo_runtime::logging::init();

607
        let context_id = uuid::Uuid::new_v4().to_string();
608
        let request = create_mock_request(10);
609
610
611
612
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFail { fail_after: 5 },
            10,
            100,
613
            context_id.clone(),
614
        ));
615
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
616
617
            mock_engine;

618
        let ctx = Arc::new(Controller::new(context_id.clone()));
619
620
621
622
623
624
625
626
627
628
629
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await
        .expect("Failed to build RetryManager");
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645

        let mut responses = Vec::new();
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received all 10 responses (5 from first stream + 5 from second stream)
        assert_eq!(responses.len(), 10);

        // Check that we received responses from both streams
        for (i, response) in responses.iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103, ..., 110
            }
        }
646
647
648

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 1);
649
650
651
652
653
654
655
656
    }

    /// Test case 4: New request migration - indefinite failure
    /// Tests the scenario where a worker becomes unreachable for new requests indefinitely.
    /// The RetryManager should exhaust all retries and return the original error from the first attempt.
    /// Expected behavior: Should receive an error after all retries are exhausted, with the original error.
    #[tokio::test]
    async fn test_retry_manager_new_request_migration_indefinite_failure() {
657
        dynamo_runtime::logging::init();
658
        let context_id = uuid::Uuid::new_v4().to_string();
659
        let request = create_mock_request(0);
660
661
662
663
664
665
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::AlwaysFail,
            0,
            100,
            context_id.clone(),
        ));
666
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
667
668
669
            mock_engine;

        // Should fail to build due to initial stream creation failure after exhausting all 3 retries
670
        let ctx = Arc::new(Controller::new(context_id.clone()));
671
672
673
674
675
676
677
678
679
680
        let metrics = Arc::new(Metrics::new());
        let retry_manager_result = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await;
681
682
683
684
685

        assert!(retry_manager_result.is_err());
        if let Err(error) = retry_manager_result {
            assert!(error.to_string().contains("no responders"));
        }
686
687
688

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 4); // 3 retries + 1 final failure
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
689
690
691
692
693
694
695
696
    }

    /// Test case 5: Ongoing request migration - indefinite failure
    /// Tests the scenario where a worker fails mid-stream indefinitely during ongoing requests.
    /// The RetryManager should exhaust all retries and return the original stream disconnection error.
    /// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration_indefinite_failure() {
697
        dynamo_runtime::logging::init();
698
        let context_id = uuid::Uuid::new_v4().to_string();
699
        let request = create_mock_request(10);
700
701
702
703
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFailAlways { fail_after: 3 },
            10,
            100,
704
            context_id.clone(),
705
        ));
706
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
707
708
            mock_engine;

709
        let ctx = Arc::new(Controller::new(context_id.clone()));
710
711
712
713
714
715
716
717
718
719
720
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        ) // 3 retries
        .await
        .expect("Failed to build RetryManager");
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743

        let mut responses = Vec::new();

        // Collect all responses (both successful and error responses)
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received 4 total responses: 3 successful + 1 error
        assert_eq!(responses.len(), 4);

        // First 3 responses should be successful with tokens 101, 102, 103
        for (i, response) in responses[0..3].iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103
            }
        }

        // 4th response should be an error after retries are exhausted
        let error_response = &responses[3];
        assert!(error_response.err().is_some());
        if let Some(error) = error_response.err() {
744
            assert!(error.to_string().contains(STREAM_ERR_MSG));
745
        }
746
747
748

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 3); // 2 retries + 1 final failure
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 1); // initial ongoing failure retry
749
750
751
752
753
754
755
756
    }

    /// Test case 6: Ongoing request migration - indefinite failure with stream errors
    /// Tests the scenario where a worker fails mid-stream indefinitely during ongoing requests,
    /// and all retry attempts also fail with stream errors instead of NATS errors.
    /// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
    #[tokio::test]
    async fn test_retry_manager_ongoing_request_migration_indefinite_failure_stream_error() {
757
        dynamo_runtime::logging::init();
758
        let context_id = uuid::Uuid::new_v4().to_string();
759
        let request = create_mock_request(10);
760
761
762
763
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::MidStreamFailAlwaysStreamError { fail_after: 3 },
            10,
            100,
764
            context_id.clone(),
765
        ));
766
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
767
768
            mock_engine;

769
        let ctx = Arc::new(Controller::new(context_id.clone()));
770
771
772
773
774
775
776
777
778
779
780
        let metrics = Arc::new(Metrics::new());
        let mut retry_manager = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        ) // 3 retries
        .await
        .expect("Failed to build RetryManager");
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803

        let mut responses = Vec::new();

        // Collect all responses (both successful and error responses)
        while let Some(response) = retry_manager.next().await {
            responses.push(response);
        }

        // Should have received 4 total responses: 3 successful + 1 error
        assert_eq!(responses.len(), 4);

        // First 3 responses should be successful with tokens 101, 102, 103
        for (i, response) in responses[0..3].iter().enumerate() {
            assert!(response.err().is_none());
            if let Some(output) = &response.data {
                assert_eq!(output.token_ids, vec![101 + i as u32]); // 101, 102, 103
            }
        }

        // 4th response should be an error after retries are exhausted
        let error_response = &responses[3];
        assert!(error_response.err().is_some());
        if let Some(error) = error_response.err() {
804
            assert!(error.to_string().contains(STREAM_ERR_MSG));
805
        }
806
807
808

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 4); // 3 retries + 1 final failure
809
    }
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825

    /// Test case 7: Request cancelled when creating new stream
    /// Tests the scenario where context.stop_generating() is called when creating a new stream.
    /// The RetryManager should detect that the context is stopped and abort creating new streams.
    /// Expected behavior: Should fail to build RetryManager with "Context is stopped or killed" error.
    #[tokio::test]
    async fn test_retry_manager_context_stopped_before_stream() {
        dynamo_runtime::logging::init();
        let context_id = uuid::Uuid::new_v4().to_string();
        let request = create_mock_request(10);
        let mock_engine = Arc::new(MockEngine::new(
            MockBehavior::Success,
            10,
            100,
            context_id.clone(),
        ));
826
        let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<BackendOutput>> =
827
828
829
830
831
832
833
834
            mock_engine;

        let ctx = Arc::new(Controller::new(context_id.clone()));

        // Stop the context before building RetryManager
        ctx.stop_generating();

        // Should fail to build due to stopped context
835
836
837
838
839
840
841
842
843
844
        let metrics = Arc::new(Metrics::new());
        let retry_manager_result = RetryManager::build(
            ctx,
            request,
            next_generate,
            3,
            Arc::new(TEST_MODEL.to_string()),
            metrics.clone(),
        )
        .await;
845
846
847
848
849
850
851
852
853

        assert!(retry_manager_result.is_err());
        if let Err(error) = retry_manager_result {
            assert!(
                error
                    .to_string()
                    .contains(&format!("Context id {} is stopped or killed", context_id))
            );
        }
854
855
856

        assert_eq!(metrics.get_migration_new_request_count(TEST_MODEL), 0);
        assert_eq!(metrics.get_migration_ongoing_request_count(TEST_MODEL), 0);
857
    }
858
}