service_v2.rs 20.4 KB
Newer Older
1
2
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
3

4
use std::collections::HashMap;
5
use std::env::var;
Graham King's avatar
Graham King committed
6
use std::path::PathBuf;
7
use std::sync::Arc;
8
9
use std::sync::atomic::AtomicBool;
use std::sync::atomic::Ordering;
10
use std::time::Duration;
11

12
use super::Metrics;
13
use super::RouteDoc;
14
use super::metrics;
15
use crate::discovery::ModelManager;
16
use crate::endpoint_type::EndpointType;
17
use crate::request_template::RequestTemplate;
18
use anyhow::Result;
Graham King's avatar
Graham King committed
19
use axum_server::tls_rustls::RustlsConfig;
20
use derive_builder::Builder;
21
use dynamo_runtime::config::environment_names::llm as env_llm;
22
use dynamo_runtime::discovery::{Discovery, KVStoreDiscovery};
23
use dynamo_runtime::logging::make_request_span;
24
use dynamo_runtime::metrics::prometheus_names::name_prefix;
25
use dynamo_runtime::storage::kv;
Graham King's avatar
Graham King committed
26
use std::net::SocketAddr;
27
use tokio::task::JoinHandle;
28
use tokio_util::sync::CancellationToken;
29
use tower_http::trace::TraceLayer;
30

31
32
33
34
/// HTTP service shared state
pub struct State {
    metrics: Arc<Metrics>,
    manager: Arc<ModelManager>,
35
    store: kv::Manager,
36
    discovery_client: Arc<dyn Discovery>,
37
    flags: StateFlags,
38
    cancel_token: CancellationToken,
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
}

#[derive(Default, Debug)]
struct StateFlags {
    chat_endpoints_enabled: AtomicBool,
    cmpl_endpoints_enabled: AtomicBool,
    embeddings_endpoints_enabled: AtomicBool,
    responses_endpoints_enabled: AtomicBool,
}

impl StateFlags {
    pub fn get(&self, endpoint_type: &EndpointType) -> bool {
        match endpoint_type {
            EndpointType::Chat => self.chat_endpoints_enabled.load(Ordering::Relaxed),
            EndpointType::Completion => self.cmpl_endpoints_enabled.load(Ordering::Relaxed),
            EndpointType::Embedding => self.embeddings_endpoints_enabled.load(Ordering::Relaxed),
            EndpointType::Responses => self.responses_endpoints_enabled.load(Ordering::Relaxed),
        }
    }

    pub fn set(&self, endpoint_type: &EndpointType, enabled: bool) {
        match endpoint_type {
            EndpointType::Chat => self
                .chat_endpoints_enabled
                .store(enabled, Ordering::Relaxed),
            EndpointType::Completion => self
                .cmpl_endpoints_enabled
                .store(enabled, Ordering::Relaxed),
            EndpointType::Embedding => self
                .embeddings_endpoints_enabled
                .store(enabled, Ordering::Relaxed),
            EndpointType::Responses => self
                .responses_endpoints_enabled
                .store(enabled, Ordering::Relaxed),
        }
    }
75
76
77
}

impl State {
78
79
80
81
82
    pub fn new(
        manager: Arc<ModelManager>,
        store: kv::Manager,
        cancel_token: CancellationToken,
    ) -> Self {
83
84
85
        // Initialize discovery backed by KV store
        // Create a cancellation token for the discovery's watch streams
        let discovery_client = {
86
87
88
            let discovery_cancel_token = cancel_token.child_token();
            Arc::new(KVStoreDiscovery::new(store.clone(), discovery_cancel_token))
                as Arc<dyn Discovery>
89
90
        };

91
92
93
        Self {
            manager,
            metrics: Arc::new(Metrics::default()),
94
            store,
95
            discovery_client,
96
97
98
99
100
101
            flags: StateFlags {
                chat_endpoints_enabled: AtomicBool::new(false),
                cmpl_endpoints_enabled: AtomicBool::new(false),
                embeddings_endpoints_enabled: AtomicBool::new(false),
                responses_endpoints_enabled: AtomicBool::new(false),
            },
102
            cancel_token,
103
104
105
        }
    }

106
107
108
109
110
111
112
113
114
115
116
117
118
    /// Get the Prometheus [`Metrics`] object which tracks request counts and inflight requests
    pub fn metrics_clone(&self) -> Arc<Metrics> {
        self.metrics.clone()
    }

    pub fn manager(&self) -> &ModelManager {
        Arc::as_ref(&self.manager)
    }

    pub fn manager_clone(&self) -> Arc<ModelManager> {
        self.manager.clone()
    }

119
    pub fn store(&self) -> &kv::Manager {
120
        &self.store
121
122
    }

123
124
125
126
    pub fn discovery(&self) -> Arc<dyn Discovery> {
        self.discovery_client.clone()
    }

127
128
129
130
131
132
133
134
135
136
    /// Check if the service is shutting down
    pub fn is_cancelled(&self) -> bool {
        self.cancel_token.is_cancelled()
    }

    /// Get the cancellation token
    pub fn cancel_token(&self) -> &CancellationToken {
        &self.cancel_token
    }

137
138
139
140
141
142
    // TODO
    pub fn sse_keep_alive(&self) -> Option<Duration> {
        None
    }
}

143
144
#[derive(Clone)]
pub struct HttpService {
145
146
147
    // The state we share with every request handler
    state: Arc<State>,

148
149
    router: axum::Router,
    port: u16,
150
    host: String,
Graham King's avatar
Graham King committed
151
152
153
    enable_tls: bool,
    tls_cert_path: Option<PathBuf>,
    tls_key_path: Option<PathBuf>,
154
    route_docs: Vec<RouteDoc>,
155
156
157
158
159
160

    // DEPRECATED: To be removed after custom backends migrate to Dynamo backend.
    pub(crate) custom_backend_namespace_component_endpoint: Option<String>,
    pub(crate) custom_backend_metrics_polling_interval: Option<f64>,
    pub(crate) custom_backend_registry:
        Option<Arc<super::custom_backend_metrics::CustomBackendMetricsRegistry>>,
161
162
163
}

#[derive(Clone, Builder)]
164
#[builder(pattern = "owned", build_fn(private, name = "build_internal"))]
165
166
167
168
pub struct HttpServiceConfig {
    #[builder(default = "8787")]
    port: u16,

169
170
171
    #[builder(setter(into), default = "String::from(\"0.0.0.0\")")]
    host: String,

Graham King's avatar
Graham King committed
172
173
174
175
176
177
178
179
180
    #[builder(default = "false")]
    enable_tls: bool,

    #[builder(default = "None")]
    tls_cert_path: Option<PathBuf>,

    #[builder(default = "None")]
    tls_key_path: Option<PathBuf>,

181
182
    // #[builder(default)]
    // custom: Vec<axum::Router>
183
    #[builder(default = "false")]
184
185
    enable_chat_endpoints: bool,

186
    #[builder(default = "false")]
187
    enable_cmpl_endpoints: bool,
188

189
    #[builder(default = "true")]
190
191
    enable_embeddings_endpoints: bool,

192
193
194
    #[builder(default = "true")]
    enable_responses_endpoints: bool,

195
196
    #[builder(default = "None")]
    request_template: Option<RequestTemplate>,
197

198
    #[builder(default)]
199
    store: kv::Manager,
200
201
202
203
204
205
206

    // DEPRECATED: To be removed after custom backends migrate to Dynamo backend.
    #[builder(default = "None")]
    custom_backend_namespace_component_endpoint: Option<String>,

    #[builder(default = "None")]
    custom_backend_metrics_polling_interval: Option<f64>,
207
208
209
210
211
212
213
}

impl HttpService {
    pub fn builder() -> HttpServiceConfigBuilder {
        HttpServiceConfigBuilder::default()
    }

214
215
216
217
218
219
220
221
    pub fn state_clone(&self) -> Arc<State> {
        self.state.clone()
    }

    pub fn state(&self) -> &State {
        Arc::as_ref(&self.state)
    }

222
    pub fn model_manager(&self) -> &ModelManager {
223
        self.state().manager()
224
225
    }

226
227
228
229
230
231
    pub async fn spawn(&self, cancel_token: CancellationToken) -> JoinHandle<Result<()>> {
        let this = self.clone();
        tokio::spawn(async move { this.run(cancel_token).await })
    }

    pub async fn run(&self, cancel_token: CancellationToken) -> Result<()> {
232
        let address = format!("{}:{}", self.host, self.port);
Graham King's avatar
Graham King committed
233
234
        let protocol = if self.enable_tls { "HTTPS" } else { "HTTP" };
        tracing::info!(protocol, address, "Starting HTTP(S) service");
235
236
237
238

        let router = self.router.clone();
        let observer = cancel_token.child_token();

239
240
        let state_cancel = self.state.cancel_token().clone();

Graham King's avatar
Graham King committed
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
        let addr: SocketAddr = address
            .parse()
            .map_err(|e| anyhow::anyhow!("Invalid address '{}': {}", address, e))?;

        if self.enable_tls {
            let cert_path = self
                .tls_cert_path
                .as_ref()
                .ok_or_else(|| anyhow::anyhow!("TLS certificate path not provided"))?;
            let key_path = self
                .tls_key_path
                .as_ref()
                .ok_or_else(|| anyhow::anyhow!("TLS private key path not provided"))?;

            // aws_lc_rs is the default but other crates pull in `ring` also,
            // so rustls doesn't know which one to use. Tell it.
            if let Err(e) = rustls::crypto::aws_lc_rs::default_provider().install_default() {
                tracing::debug!("TLS crypto provider already installed: {e:?}");
            }

            let config = RustlsConfig::from_pem_file(cert_path, key_path)
                .await
                .map_err(|e| anyhow::anyhow!("Failed to create TLS config: {}", e))?;

            let handle = axum_server::Handle::new();
            let server = axum_server::bind_rustls(addr, config)
                .handle(handle.clone())
                .serve(router.into_make_service());

            tokio::select! {
                result = server => {
                    result.map_err(|e| anyhow::anyhow!("HTTPS server error: {}", e))?;
                }
                _ = observer.cancelled() => {
275
                    state_cancel.cancel();
Graham King's avatar
Graham King committed
276
                    tracing::info!("HTTPS server shutdown requested");
277
278
279
                    // accepting requests for 5 more seconds, to allow incorrectly routed requests to arrive
                    handle.graceful_shutdown(Some(Duration::from_secs(get_graceful_shutdown_timeout() as u64)));
                    // no longer accepting requests, draining all existing connections
Graham King's avatar
Graham King committed
280
281
282
                }
            }
        } else {
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
            let listener = tokio::net::TcpListener::bind(addr).await.map_err(|e| {
                tracing::error!(
                    protocol = %protocol,
                    address = %address,
                    error = %e,
                    "Failed to bind server to address"
                );
                match e.kind() {
                    std::io::ErrorKind::AddrInUse => anyhow::anyhow!(
                        "Failed to start {} server: port {} already in use. Use --http-port to specify a different port.",
                        protocol,
                        self.port
                    ),
                    _ => anyhow::anyhow!(
                        "Failed to start {} server on {}: {}",
                        protocol,
                        address,
                        e
                    ),
                }
            })?;
Graham King's avatar
Graham King committed
304
305

            axum::serve(listener, router)
306
307
308
309
310
311
312
313
314
                .with_graceful_shutdown(async move {
                    observer.cancelled_owned().await;
                    state_cancel.cancel();
                    tracing::info!("HTTP server shutdown requested");
                    // accepting requests for 5 more seconds, to allow incorrectly routed requests to arrive
                    tokio::time::sleep(Duration::from_secs(get_graceful_shutdown_timeout() as u64))
                        .await;
                    // no longer accepting requests, draining all existing connections
                })
Graham King's avatar
Graham King committed
315
316
317
                .await
                .inspect_err(|_| cancel_token.cancel())?;
        }
318
319

        Ok(())
320
    }
321
322
323
324
325

    /// Documentation of exposed HTTP endpoints
    pub fn route_docs(&self) -> &[RouteDoc] {
        &self.route_docs
    }
326

327
    pub fn enable_model_endpoint(&self, endpoint_type: EndpointType, enable: bool) {
328
329
330
331
332
333
334
        self.state.flags.set(&endpoint_type, enable);
        tracing::info!(
            "{} endpoints {}",
            endpoint_type.as_str(),
            if enable { "enabled" } else { "disabled" }
        );
    }
335
336
}

337
338
339
340
341
342
343
fn get_graceful_shutdown_timeout() -> usize {
    std::env::var(env_llm::DYN_HTTP_GRACEFUL_SHUTDOWN_TIMEOUT_SECS)
        .ok()
        .and_then(|s| s.parse::<usize>().ok())
        .unwrap_or(5)
}

344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
/// Environment variable to set the metrics endpoint path (default: `/metrics`)
static HTTP_SVC_METRICS_PATH_ENV: &str = "DYN_HTTP_SVC_METRICS_PATH";
/// Environment variable to set the models endpoint path (default: `/v1/models`)
static HTTP_SVC_MODELS_PATH_ENV: &str = "DYN_HTTP_SVC_MODELS_PATH";
/// Environment variable to set the health endpoint path (default: `/health`)
static HTTP_SVC_HEALTH_PATH_ENV: &str = "DYN_HTTP_SVC_HEALTH_PATH";
/// Environment variable to set the live endpoint path (default: `/live`)
static HTTP_SVC_LIVE_PATH_ENV: &str = "DYN_HTTP_SVC_LIVE_PATH";
/// Environment variable to set the chat completions endpoint path (default: `/v1/chat/completions`)
static HTTP_SVC_CHAT_PATH_ENV: &str = "DYN_HTTP_SVC_CHAT_PATH";
/// Environment variable to set the completions endpoint path (default: `/v1/completions`)
static HTTP_SVC_CMP_PATH_ENV: &str = "DYN_HTTP_SVC_CMP_PATH";
/// Environment variable to set the embeddings endpoint path (default: `/v1/embeddings`)
static HTTP_SVC_EMB_PATH_ENV: &str = "DYN_HTTP_SVC_EMB_PATH";
/// Environment variable to set the responses endpoint path (default: `/v1/responses`)
static HTTP_SVC_RESPONSES_PATH_ENV: &str = "DYN_HTTP_SVC_RESPONSES_PATH";

361
362
impl HttpServiceConfigBuilder {
    pub fn build(self) -> Result<HttpService, anyhow::Error> {
363
        let config: HttpServiceConfig = self.build_internal()?;
364

365
        let model_manager = Arc::new(ModelManager::new());
366
367
368
        // Create a temporary cancel token for building - will be replaced in spawn/run
        let temp_cancel_token = CancellationToken::new();
        let state = Arc::new(State::new(model_manager, config.store, temp_cancel_token));
369
370
371
372
373
374
375
376
377
378
379
380
381
        state
            .flags
            .set(&EndpointType::Chat, config.enable_chat_endpoints);
        state
            .flags
            .set(&EndpointType::Completion, config.enable_cmpl_endpoints);
        state
            .flags
            .set(&EndpointType::Embedding, config.enable_embeddings_endpoints);
        state
            .flags
            .set(&EndpointType::Responses, config.enable_responses_endpoints);

382
383
        // enable prometheus metrics
        let registry = metrics::Registry::new();
384
        state.metrics_clone().register(&registry)?;
385

386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
        // DEPRECATED: To be removed after custom backends migrate to Dynamo backend.
        // Setup custom backend metrics if configured
        let custom_backend_registry =
            if config.custom_backend_namespace_component_endpoint.is_some()
                && config.custom_backend_metrics_polling_interval.is_some()
            {
                Some(Arc::new(
                    super::custom_backend_metrics::CustomBackendMetricsRegistry::new(
                        name_prefix::COMPONENT.to_string(),
                        registry.clone(),
                    ),
                ))
            } else {
                None
            };
401

402
        let mut router = axum::Router::new();
403

404
405
406
        let mut all_docs = Vec::new();

        let mut routes = vec![
407
408
409
410
            metrics::router(registry, var(HTTP_SVC_METRICS_PATH_ENV).ok()),
            super::openai::list_models_router(state.clone(), var(HTTP_SVC_MODELS_PATH_ENV).ok()),
            super::health::health_check_router(state.clone(), var(HTTP_SVC_HEALTH_PATH_ENV).ok()),
            super::health::live_check_router(state.clone(), var(HTTP_SVC_LIVE_PATH_ENV).ok()),
411
            super::busy_threshold::busy_threshold_router(state.clone(), None),
412
413
        ];

414
415
416
417
        let endpoint_routes =
            HttpServiceConfigBuilder::get_endpoints_router(state.clone(), &config.request_template);
        routes.extend(endpoint_routes);
        for (route_docs, route) in routes {
418
419
420
421
            router = router.merge(route);
            all_docs.extend(route_docs);
        }

422
423
424
425
426
427
428
        // Add OpenAPI documentation routes (must be after all other routes so it can document them)
        // Note: The path parameter is currently unused as SwaggerUi requires static paths
        let (openapi_docs, openapi_route) =
            super::openapi_docs::openapi_router(all_docs.clone(), None);
        router = router.merge(openapi_route);
        all_docs.extend(openapi_docs);

429
430
431
        // Add span for tracing
        router = router.layer(TraceLayer::new_for_http().make_span_with(make_request_span));

432
        Ok(HttpService {
433
            state,
434
435
            router,
            port: config.port,
436
            host: config.host,
Graham King's avatar
Graham King committed
437
438
439
            enable_tls: config.enable_tls,
            tls_cert_path: config.tls_cert_path,
            tls_key_path: config.tls_key_path,
440
            route_docs: all_docs,
441
442
443
444
            custom_backend_namespace_component_endpoint: config
                .custom_backend_namespace_component_endpoint,
            custom_backend_metrics_polling_interval: config.custom_backend_metrics_polling_interval,
            custom_backend_registry,
445
446
        })
    }
447
448
449
450
451

    pub fn with_request_template(mut self, request_template: Option<RequestTemplate>) -> Self {
        self.request_template = Some(request_template);
        self
    }
452

453
454
455
456
457
458
459
460
461
462
463
    // DEPRECATED: To be removed after custom backends migrate to Dynamo backend.
    pub fn with_custom_backend_config(
        mut self,
        namespace_component_endpoint: Option<String>,
        polling_interval: Option<f64>,
    ) -> Self {
        self.custom_backend_namespace_component_endpoint = Some(namespace_component_endpoint);
        self.custom_backend_metrics_polling_interval = Some(polling_interval);
        self
    }

464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
    fn get_endpoints_router(
        state: Arc<State>,
        request_template: &Option<RequestTemplate>,
    ) -> Vec<(Vec<RouteDoc>, axum::Router)> {
        let mut routes = Vec::new();
        // Add chat completions route with conditional middleware
        let (chat_docs, chat_route) = super::openai::chat_completions_router(
            state.clone(),
            request_template.clone(),
            var(HTTP_SVC_CHAT_PATH_ENV).ok(),
        );
        let (cmpl_docs, cmpl_route) =
            super::openai::completions_router(state.clone(), var(HTTP_SVC_CMP_PATH_ENV).ok());
        let (embed_docs, embed_route) =
            super::openai::embeddings_router(state.clone(), var(HTTP_SVC_EMB_PATH_ENV).ok());
        let (responses_docs, responses_route) = super::openai::responses_router(
            state.clone(),
            request_template.clone(),
            var(HTTP_SVC_RESPONSES_PATH_ENV).ok(),
        );

        let mut endpoint_routes = HashMap::new();
        endpoint_routes.insert(EndpointType::Chat, (chat_docs, chat_route));
        endpoint_routes.insert(EndpointType::Completion, (cmpl_docs, cmpl_route));
        endpoint_routes.insert(EndpointType::Embedding, (embed_docs, embed_route));
        endpoint_routes.insert(EndpointType::Responses, (responses_docs, responses_route));

        for endpoint_type in EndpointType::all() {
            let state_route = state.clone();
            if !endpoint_routes.contains_key(&endpoint_type) {
                tracing::debug!("{} endpoints are disabled", endpoint_type.as_str());
                continue;
            }
            let (docs, route) = endpoint_routes.get(&endpoint_type).cloned().unwrap();
            let route = route.route_layer(axum::middleware::from_fn(
                move |req: axum::http::Request<axum::body::Body>, next: axum::middleware::Next| {
                    let state: Arc<State> = state_route.clone();
                    async move {
                        // Check if the endpoint is enabled
                        let enabled = state.flags.get(&endpoint_type);
                        if enabled {
                            Ok(next.run(req).await)
                        } else {
                            tracing::debug!("{} endpoints are disabled", endpoint_type.as_str());
508
                            Err(axum::http::StatusCode::NOT_FOUND)
509
510
511
512
513
514
515
516
                        }
                    }
                },
            ));
            routes.push((docs, route));
        }
        routes
    }
517
}
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562

#[cfg(test)]
mod tests {
    use super::*;
    use serial_test::serial;
    use std::sync::Arc;
    use tokio_util::sync::CancellationToken;

    #[tokio::test]
    #[serial]
    async fn test_liveness_endpoint_reflects_cancellation() {
        // 1. Setup service & token
        let cancel_token = Arc::new(CancellationToken::new());
        let service = HttpService::builder().build().unwrap();
        let port = service.port;

        // 2. Spawn service with shared token
        let service_token = cancel_token.clone();
        let handle = tokio::spawn(async move {
            service.run((*service_token).clone()).await.unwrap();
        });

        tokio::time::sleep(std::time::Duration::from_millis(1)).await;

        // 3. Cancel the token
        cancel_token.cancel();

        // 4. Wait a tiny bit for propagation
        tokio::time::sleep(std::time::Duration::from_millis(20)).await;

        // 5. Hit the endpoint
        let client = reqwest::Client::new();
        let resp = client
            .get(format!("http://localhost:{}/live", port))
            .send()
            .await
            .expect("Request failed");

        // 6. ASSERTION: Should be 503 Service Unavailable
        assert_eq!(resp.status(), reqwest::StatusCode::SERVICE_UNAVAILABLE);

        // Clean up
        handle.abort();
    }
}