test_jail.rs 142 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Ryan Olson's avatar
Ryan Olson committed
2
// SPDX-License-Identifier: Apache-2.0
3
use dynamo_llm::preprocessor::OpenAIPreprocessor;
Ryan Olson's avatar
Ryan Olson committed
4
5
use dynamo_llm::protocols::openai::chat_completions::NvCreateChatCompletionStreamResponse;
use dynamo_llm::protocols::openai::chat_completions::jail::JailedStream;
6
use dynamo_protocols::types::{
7
8
    ChatChoiceStream, ChatCompletionStreamResponseDelta, ChatCompletionToolChoiceOption,
    CompletionUsage, FinishReason, Role,
9
};
Ryan Olson's avatar
Ryan Olson committed
10
11
12
13
14
15
16
17
18
19
20
use dynamo_runtime::protocols::annotated::Annotated;

#[cfg(test)]
mod tests {
    use super::*;
    use futures::StreamExt;
    use futures::stream;

    // Test utilities module - shared test infrastructure
    pub(crate) mod test_utils {
        use super::*;
21
        use dynamo_protocols::types::ChatCompletionMessageContent;
22
23
24
25
26
27
28
29

        /// Helper to extract text from ChatCompletionMessageContent
        pub fn extract_text(content: &ChatCompletionMessageContent) -> &str {
            match content {
                ChatCompletionMessageContent::Text(text) => text.as_str(),
                ChatCompletionMessageContent::Parts(_) => "",
            }
        }
Ryan Olson's avatar
Ryan Olson committed
30
31
32
33
34
35
36
37
38
39
40

        /// Helper function to create a mock chat response chunk
        pub fn create_mock_response_chunk(
            content: String,
            index: u32,
        ) -> Annotated<NvCreateChatCompletionStreamResponse> {
            #[allow(deprecated)]
            let choice = ChatChoiceStream {
                index,
                delta: ChatCompletionStreamResponseDelta {
                    role: Some(Role::Assistant),
41
                    content: Some(ChatCompletionMessageContent::Text(content)),
Ryan Olson's avatar
Ryan Olson committed
42
43
44
45
46
47
                    tool_calls: None,
                    function_call: None,
                    refusal: None,
                    reasoning_content: None,
                },
                finish_reason: None,
48
                stop_reason: None,
Ryan Olson's avatar
Ryan Olson committed
49
50
51
52
                logprobs: None,
            };

            let response = NvCreateChatCompletionStreamResponse {
53
                inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
54
55
56
57
58
59
60
61
62
                    id: "test-id".to_string(),
                    choices: vec![choice],
                    created: 1234567890,
                    model: "test-model".to_string(),
                    system_fingerprint: Some("test-fingerprint".to_string()),
                    object: "chat.completion.chunk".to_string(),
                    usage: None,
                    service_tier: None,
                },
63
                nvext: None,
Ryan Olson's avatar
Ryan Olson committed
64
65
66
67
68
69
70
            };

            Annotated {
                data: Some(response),
                id: None,
                event: None,
                comment: None,
71
                error: None,
Ryan Olson's avatar
Ryan Olson committed
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
            }
        }

        /// Helper function to create a final response chunk with finish reason
        pub fn create_final_response_chunk(
            index: u32,
        ) -> Annotated<NvCreateChatCompletionStreamResponse> {
            #[allow(deprecated)]
            let choice = ChatChoiceStream {
                index,
                delta: ChatCompletionStreamResponseDelta {
                    role: None,
                    content: None,
                    tool_calls: None,
                    function_call: None,
                    refusal: None,
                    reasoning_content: None,
                },
                finish_reason: Some(FinishReason::Stop),
91
                stop_reason: None,
Ryan Olson's avatar
Ryan Olson committed
92
93
94
95
                logprobs: None,
            };

            let response = NvCreateChatCompletionStreamResponse {
96
                inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
97
98
99
100
101
102
103
104
105
                    id: "test-id".to_string(),
                    choices: vec![choice],
                    created: 1234567890,
                    model: "test-model".to_string(),
                    system_fingerprint: Some("test-fingerprint".to_string()),
                    object: "chat.completion.chunk".to_string(),
                    usage: None,
                    service_tier: None,
                },
106
                nvext: None,
Ryan Olson's avatar
Ryan Olson committed
107
108
109
110
111
112
113
            };

            Annotated {
                data: Some(response),
                id: None,
                event: None,
                comment: None,
114
                error: None,
Ryan Olson's avatar
Ryan Olson committed
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
            }
        }

        /// Helper function to create a mock chat response chunk with metadata
        pub fn create_annotated_chunk(
            content: String,
            index: u32,
            id: Option<String>,
            event: Option<String>,
            comment: Option<Vec<String>>,
        ) -> Annotated<NvCreateChatCompletionStreamResponse> {
            #[allow(deprecated)]
            let choice = ChatChoiceStream {
                index,
                delta: ChatCompletionStreamResponseDelta {
                    role: Some(Role::Assistant),
131
                    content: Some(ChatCompletionMessageContent::Text(content)),
Ryan Olson's avatar
Ryan Olson committed
132
133
134
135
136
137
                    tool_calls: None,
                    function_call: None,
                    refusal: None,
                    reasoning_content: None,
                },
                finish_reason: None,
138
                stop_reason: None,
Ryan Olson's avatar
Ryan Olson committed
139
140
141
142
                logprobs: None,
            };

            let response = NvCreateChatCompletionStreamResponse {
143
                inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
144
145
146
147
148
149
150
151
152
                    id: "test-id".to_string(),
                    choices: vec![choice],
                    created: 1234567890,
                    model: "test-model".to_string(),
                    system_fingerprint: Some("test-fingerprint".to_string()),
                    object: "chat.completion.chunk".to_string(),
                    usage: None,
                    service_tier: None,
                },
153
                nvext: None,
Ryan Olson's avatar
Ryan Olson committed
154
155
156
157
158
159
160
            };

            Annotated {
                data: Some(response),
                id,
                event,
                comment,
161
                error: None,
Ryan Olson's avatar
Ryan Olson committed
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
            }
        }

        /// Helper function to create a multi-choice chunk
        pub fn create_multi_choice_chunk(
            choices_content: Vec<(String, u32)>, // (content, index)
        ) -> Annotated<NvCreateChatCompletionStreamResponse> {
            let choices: Vec<ChatChoiceStream> = choices_content
                .into_iter()
                .map(|(content, index)| {
                    #[allow(deprecated)]
                    ChatChoiceStream {
                        index,
                        delta: ChatCompletionStreamResponseDelta {
                            role: Some(Role::Assistant),
177
                            content: Some(ChatCompletionMessageContent::Text(content)),
Ryan Olson's avatar
Ryan Olson committed
178
179
180
181
182
183
                            tool_calls: None,
                            function_call: None,
                            refusal: None,
                            reasoning_content: None,
                        },
                        finish_reason: None,
184
                        stop_reason: None,
Ryan Olson's avatar
Ryan Olson committed
185
186
187
188
189
190
                        logprobs: None,
                    }
                })
                .collect();

            let response = NvCreateChatCompletionStreamResponse {
191
                inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
192
193
194
195
196
197
198
199
200
                    id: "test-id".to_string(),
                    choices,
                    created: 1234567890,
                    model: "test-model".to_string(),
                    system_fingerprint: Some("test-fingerprint".to_string()),
                    object: "chat.completion.chunk".to_string(),
                    usage: None,
                    service_tier: None,
                },
201
                nvext: None,
Ryan Olson's avatar
Ryan Olson committed
202
203
204
205
206
207
208
            };

            Annotated {
                data: Some(response),
                id: None,
                event: None,
                comment: None,
209
                error: None,
Ryan Olson's avatar
Ryan Olson committed
210
211
212
            }
        }

213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
        /// Helper function to create a multi-choice finish_reason chunk
        pub fn create_multi_choice_finish_chunk(
            choice_indices: Vec<u32>,
        ) -> Annotated<NvCreateChatCompletionStreamResponse> {
            let choices: Vec<ChatChoiceStream> = choice_indices
                .into_iter()
                .map(|index| {
                    #[allow(deprecated)]
                    ChatChoiceStream {
                        index,
                        delta: ChatCompletionStreamResponseDelta {
                            role: None,
                            content: None,
                            tool_calls: None,
                            function_call: None,
                            refusal: None,
                            reasoning_content: None,
                        },
                        finish_reason: Some(FinishReason::Stop),
232
                        stop_reason: None,
233
234
235
236
237
238
                        logprobs: None,
                    }
                })
                .collect();

            let response = NvCreateChatCompletionStreamResponse {
239
                inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
240
241
242
243
244
245
246
247
248
                    id: "test-id".to_string(),
                    choices,
                    created: 1234567890,
                    model: "test-model".to_string(),
                    system_fingerprint: Some("test-fingerprint".to_string()),
                    object: "chat.completion.chunk".to_string(),
                    usage: None,
                    service_tier: None,
                },
249
                nvext: None,
250
251
252
253
254
255
256
            };

            Annotated {
                data: Some(response),
                id: None,
                event: None,
                comment: None,
257
                error: None,
258
259
260
            }
        }

Ryan Olson's avatar
Ryan Olson committed
261
262
263
264
265
266
267
268
        /// Helper to assert content in a result
        pub fn assert_content(
            result: &Annotated<NvCreateChatCompletionStreamResponse>,
            expected: &str,
        ) {
            let content = result
                .data
                .as_ref()
269
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
270
271
272
273
                .and_then(|c| c.delta.content.as_ref())
                .expect("Expected content in result");

            assert_eq!(
274
275
                extract_text(content),
                expected,
Ryan Olson's avatar
Ryan Olson committed
276
                "Content mismatch: expected '{}', got '{}'",
277
278
                expected,
                extract_text(content)
Ryan Olson's avatar
Ryan Olson committed
279
280
281
282
283
284
285
286
287
288
289
290
            );
        }

        /// Helper to assert a tool call in a result
        pub fn assert_tool_call(
            result: &Annotated<NvCreateChatCompletionStreamResponse>,
            name: &str,
            args: serde_json::Value,
        ) {
            let tool_calls = result
                .data
                .as_ref()
291
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
                .and_then(|c| c.delta.tool_calls.as_ref())
                .expect("Expected tool calls in result");

            assert!(!tool_calls.is_empty(), "Expected at least one tool call");

            let tool_call = &tool_calls[0];
            let function = tool_call
                .function
                .as_ref()
                .expect("Expected function in tool call");

            assert_eq!(
                function.name.as_deref(),
                Some(name),
                "Tool call name mismatch: expected '{}', got '{:?}'",
                name,
                function.name
            );

            if let Some(arguments_str) = &function.arguments {
                let parsed_args: serde_json::Value = serde_json::from_str(arguments_str)
                    .expect("Tool call arguments should be valid JSON");
                assert_eq!(
                    parsed_args, args,
                    "Tool call arguments mismatch: expected {}, got {}",
                    args, parsed_args
                );
            } else if !args.is_null() {
                panic!("Expected tool call arguments {} but got None", args);
            }
        }

        /// Helper to assert no content or tool calls (for accumulated chunks)
        #[allow(dead_code)]
        pub fn assert_empty_emission(result: &Annotated<NvCreateChatCompletionStreamResponse>) {
            if let Some(data) = &result.data
328
                && let Some(choice) = data.inner.choices.first()
Ryan Olson's avatar
Ryan Olson committed
329
330
331
            {
                assert!(
                    choice.delta.content.is_none()
332
                        || choice.delta.content.as_ref().is_none_or(|c| match c {
333
                            dynamo_protocols::types::ChatCompletionMessageContent::Text(t) =>
334
335
336
                                t.is_empty(),
                            _ => false,
                        }),
Ryan Olson's avatar
Ryan Olson committed
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
                    "Expected no content but got: {:?}",
                    choice.delta.content
                );
                assert!(
                    choice.delta.tool_calls.is_none()
                        || choice.delta.tool_calls.as_ref().unwrap().is_empty(),
                    "Expected no tool calls but got: {:?}",
                    choice.delta.tool_calls
                );
            }
        }

        /// Helper to reconstruct all content from results
        pub fn reconstruct_content(
            results: &[Annotated<NvCreateChatCompletionStreamResponse>],
        ) -> String {
            results
                .iter()
                .filter_map(|r| {
                    r.data
                        .as_ref()
358
                        .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
359
360
                        .and_then(|c| c.delta.content.as_ref())
                })
361
                .map(extract_text)
Ryan Olson's avatar
Ryan Olson committed
362
363
364
365
366
367
368
369
370
                .collect::<Vec<_>>()
                .join("")
        }

        /// Helper to extract content from a single result (for negative assertions)
        pub fn extract_content(result: &Annotated<NvCreateChatCompletionStreamResponse>) -> String {
            result
                .data
                .as_ref()
371
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
372
                .and_then(|c| c.delta.content.as_ref())
373
374
375
376
                .and_then(|content| match content {
                    ChatCompletionMessageContent::Text(text) => Some(text.clone()),
                    ChatCompletionMessageContent::Parts(_) => None,
                })
Ryan Olson's avatar
Ryan Olson committed
377
378
379
380
381
382
383
384
                .unwrap_or_default()
        }

        /// Helper to check if result contains a tool call
        pub fn has_tool_call(result: &Annotated<NvCreateChatCompletionStreamResponse>) -> bool {
            result
                .data
                .as_ref()
385
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
386
387
388
389
390
391
392
393
394
395
396
                .and_then(|c| c.delta.tool_calls.as_ref())
                .map(|tc| !tc.is_empty())
                .unwrap_or(false)
        }

        /// Helper to check if result contains content
        #[allow(dead_code)]
        pub fn has_content(result: &Annotated<NvCreateChatCompletionStreamResponse>) -> bool {
            result
                .data
                .as_ref()
397
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
398
                .and_then(|c| c.delta.content.as_ref())
399
                .map(|content| !extract_text(content).is_empty())
Ryan Olson's avatar
Ryan Olson committed
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
                .unwrap_or(false)
        }
    }

    use serde_json::json;
    use test_utils::*;

    #[tokio::test]
    async fn test_jailed_stream_with_start_end_sequences() {
        // Create chunks with jail start/end markers
        let chunks = vec![
            create_mock_response_chunk("Hello ".to_string(), 0),
            create_mock_response_chunk("<jail>".to_string(), 0),
            create_mock_response_chunk("This is jailed ".to_string(), 0),
            create_mock_response_chunk("content".to_string(), 0),
            create_mock_response_chunk("</jail>".to_string(), 0),
            create_mock_response_chunk(" World".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with start/end sequences
        let jail = JailedStream::builder()
            .jail_start_sequence("<jail>")
            .jail_end_sequence("</jail>")
            .build();

427
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
428
429
430
431
432
433
434
435
436

        // We should only get 3 chunks now:
        // 1. "Hello " (before jail)
        // 2. Accumulated jailed content when jail ends
        // 3. " World" (after jail)
        assert_eq!(results.len(), 3);

        // First chunk should pass through
        assert_eq!(
437
            results[0].data.as_ref().unwrap().inner.choices[0]
Ryan Olson's avatar
Ryan Olson committed
438
439
                .delta
                .content
440
441
                .as_ref()
                .map(extract_text),
Ryan Olson's avatar
Ryan Olson committed
442
443
444
445
            Some("Hello ")
        );

        // When jail ends, accumulated content should be released
446
447
448
        let unjailed_content = &results[1].data.as_ref().unwrap().inner.choices[0]
            .delta
            .content;
Ryan Olson's avatar
Ryan Olson committed
449
450
        assert!(unjailed_content.is_some());
        assert!(
451
            extract_text(unjailed_content.as_ref().unwrap())
Ryan Olson's avatar
Ryan Olson committed
452
453
454
455
456
                .contains("<jail>This is jailed content</jail>")
        );

        // Last chunk should pass through normally
        assert_eq!(
457
            results[2].data.as_ref().unwrap().inner.choices[0]
Ryan Olson's avatar
Ryan Olson committed
458
459
                .delta
                .content
460
461
                .as_ref()
                .map(extract_text),
Ryan Olson's avatar
Ryan Olson committed
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
            Some(" World")
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_with_tool_calls() {
        // Create chunks representing a tool call
        let chunks = vec![
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(
                "[{\"name\": \"get_weather\", \"arguments\": {\"location\": \"SF\"}}]".to_string(),
                0,
            ),
            create_mock_response_chunk("</TOOLCALL>".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with tool call parser
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

485
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
486
487
488
489
490
491
492

        // Should have jailed the content and parsed tool calls at the end
        assert!(!results.is_empty());

        // Check if tool calls were parsed
        if let Some(last_result) = results.last()
            && let Some(ref response_data) = last_result.data
493
            && let Some(ref tool_calls) = response_data.inner.choices[0].delta.tool_calls
Ryan Olson's avatar
Ryan Olson committed
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
        {
            assert!(!tool_calls.as_slice().is_empty());
            assert_eq!(
                tool_calls[0].function.as_ref().unwrap().name.as_deref(),
                Some("get_weather")
            );
        }
    }

    #[tokio::test]
    async fn test_jailed_stream_dual_entry_paths() {
        // Test that BOTH sequence AND tool call detection can trigger jail
        let chunks = vec![
            create_mock_response_chunk("Normal text ".to_string(), 0),
            create_mock_response_chunk("<jail><TOOLCALL>".to_string(), 0), // Both triggers
            create_mock_response_chunk("Jailed content".to_string(), 0),
            create_mock_response_chunk("</jail>".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Configure with both sequences AND tool call parser
        let jail = JailedStream::builder()
            .jail_start_sequence("<jail>")
            .jail_end_sequence("</jail>")
            .tool_call_parser("nemotron_deci")
            .build();

522
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
523
524
525
526
527
528
529
530

        // We should get 2 chunks:
        // 1. "Normal text " (before jail)
        // 2. Accumulated jailed content when jail ends via </jail>
        assert_eq!(results.len(), 2);

        // First chunk should pass through
        assert_eq!(
531
            results[0].data.as_ref().unwrap().inner.choices[0]
Ryan Olson's avatar
Ryan Olson committed
532
533
                .delta
                .content
534
535
                .as_ref()
                .map(extract_text),
Ryan Olson's avatar
Ryan Olson committed
536
537
538
539
            Some("Normal text ")
        );

        // Second chunk should contain the accumulated jailed content
540
        let jailed = results[1].data.as_ref().unwrap().inner.choices[0]
Ryan Olson's avatar
Ryan Olson committed
541
542
543
544
            .delta
            .content
            .as_ref()
            .expect("Expected accumulated jailed content");
545
        assert!(extract_text(jailed).contains("<jail><TOOLCALL>Jailed content</jail>"));
Ryan Olson's avatar
Ryan Olson committed
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
    }

    #[tokio::test]
    async fn test_jailed_stream_early_exit() {
        // Tests detection of complete tool call with unjail in same chunk as the end marker
        // Input: "<TOOLCALL>" + "[{\"name\": \"test\", " + "\"arguments\": {}}]" + "</TOOLCALL>More text"
        // Expected output: 2 chunks [ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk("[{\"name\": \"test\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {}}]".to_string(), 0),
            create_mock_response_chunk("</TOOLCALL>More text".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

566
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607

        // Should have exactly 2 chunks: tool call + trailing content
        assert_eq!(
            results.len(),
            2,
            "Should have tool call and trailing content"
        );

        // Verify exact output structure: [ToolCall(), Content()]
        test_utils::assert_tool_call(&results[0], "test", serde_json::json!({}));
        test_utils::assert_content(&results[1], "More text");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "More text");
    }

    #[tokio::test]
    async fn test_jailed_stream_no_jailing() {
        // Input chunks:
        // [0] "Hello "
        // [1] "World"
        // [2] [final chunk]
        //
        // Expected output (pass-through):
        // [0] Content("Hello ")
        // [1] Content("World")
        // [2] [final chunk]
        let chunks = vec![
            create_mock_response_chunk("Hello ".to_string(), 0),
            create_mock_response_chunk("World".to_string(), 0),
            create_final_response_chunk(0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with sequences that won't match
        let jail = JailedStream::builder()
            .jail_start_sequence("<NOTPRESENT>")
            .build();

608
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            3,
            "Should pass through all 3 chunks unchanged"
        );

        // === Verify individual chunks ===
        assert_content(&results[0], "Hello ");
        assert_content(&results[1], "World");
        // results[2] is the final chunk - no content to verify

        // === Verify negative assertions ===
        for (i, result) in results.iter().take(2).enumerate() {
            assert!(
                !has_tool_call(result),
                "Chunk {} should not contain tool calls when no patterns match",
                i
            );
        }

        // === Verify content reconstruction ===
        assert_eq!(
            reconstruct_content(&results),
            "Hello World",
            "Content should pass through unchanged when no jailing occurs"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_hermes_parser() {
        // Tests Hermes format tool call parsing with <tool_call> markers
        // Input: "I'll help you with that. " + "<tool_call>{\"name\": \"search_web\", \"arguments\": {\"query\": \"weather today\"}}</tool_call>" + " Let me search for that."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("I'll help you with that. ".to_string(), 0),
            create_mock_response_chunk("<tool_call>".to_string(), 0),
            create_mock_response_chunk("{\"name\": \"search_web\", ".to_string(), 0),
            create_mock_response_chunk(
                "\"arguments\": {\"query\": \"weather today\"}}".to_string(),
                0,
            ),
            create_mock_response_chunk("</tool_call>".to_string(), 0),
            create_mock_response_chunk(" Let me search for that.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Hermes parser
        let jail = JailedStream::builder().tool_call_parser("hermes").build();

661
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705

        // Should have exactly 3 chunks: content + tool call + content
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "I'll help you with that. ");
        test_utils::assert_tool_call(
            &results[1],
            "search_web",
            serde_json::json!({"query": "weather today"}),
        );
        test_utils::assert_content(&results[2], " Let me search for that.");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "I'll help you with that.  Let me search for that."
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_mistral_parser() {
        // Tests Mistral format tool call parsing with [{ pattern
        // Input: "Sure, I can help. " + "[{\"name\": \"calculate\", \"arguments\": {\"expression\": \"2+2\"}}]" + " The calculation is done."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("Sure, I can help. ".to_string(), 0),
            create_mock_response_chunk("[{".to_string(), 0),
            create_mock_response_chunk("\"name\": \"calculate\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {\"expression\": \"2+2\"}".to_string(), 0),
            create_mock_response_chunk("}]".to_string(), 0),
            create_mock_response_chunk(" The calculation is done.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Mistral parser
        let jail = JailedStream::builder().tool_call_parser("mistral").build();

706
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746

        // Should have exactly 3 chunks: content + tool call + content
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "Sure, I can help. ");
        test_utils::assert_tool_call(
            &results[1],
            "calculate",
            serde_json::json!({"expression": "2+2"}),
        );
        test_utils::assert_content(&results[2], " The calculation is done.");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "Sure, I can help.  The calculation is done.");
    }

    #[tokio::test]
    async fn test_jailed_stream_mistral_parser_with_tool_calls_marker() {
        // Tests Mistral format tool call parsing with explicit [TOOL_CALLS] marker
        // Input: "Let me check that for you. " + "[TOOL_CALLS][{\"name\": \"get_time\", \"arguments\": {\"timezone\": \"UTC\"}}]" + " Here's the time."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("Let me check that for you. ".to_string(), 0),
            create_mock_response_chunk("[TOOL_CALLS]".to_string(), 0),
            create_mock_response_chunk("[{\"name\": \"get_time\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {\"timezone\": \"UTC\"}}]".to_string(), 0),
            create_mock_response_chunk(" Here's the time.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Mistral parser
        let jail = JailedStream::builder().tool_call_parser("mistral").build();

747
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794

        // Should have exactly 3 chunks: content + tool call + content
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "Let me check that for you. ");
        test_utils::assert_tool_call(
            &results[1],
            "get_time",
            serde_json::json!({"timezone": "UTC"}),
        );
        test_utils::assert_content(&results[2], " Here's the time.");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "Let me check that for you.  Here's the time."
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_phi4_parser() {
        // Tests Phi4 format tool call parsing with functools[ pattern
        // Input: "I'll analyze this data. " + "functools[{\"name\": \"analyze_data\", \"arguments\": {\"dataset\": \"sales_data\"}}]" + " Analysis complete."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("I'll analyze this data. ".to_string(), 0),
            create_mock_response_chunk("functools[".to_string(), 0),
            create_mock_response_chunk("{\"name\": \"analyze_data\", ".to_string(), 0),
            create_mock_response_chunk(
                "\"arguments\": {\"dataset\": \"sales_data\"}}".to_string(),
                0,
            ),
            create_mock_response_chunk("]".to_string(), 0),
            create_mock_response_chunk(" Analysis complete.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Phi4 parser
        let jail = JailedStream::builder().tool_call_parser("phi4").build();

795
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840

        // Should have exactly 3 chunks: content + tool call + content
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "I'll analyze this data. ");
        test_utils::assert_tool_call(
            &results[1],
            "analyze_data",
            serde_json::json!({"dataset": "sales_data"}),
        );
        test_utils::assert_content(&results[2], " Analysis complete.");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "I'll analyze this data.  Analysis complete.");
    }

    #[tokio::test]
    async fn test_jailed_stream_llama3_json_parser() {
        // Tests Llama3 JSON format tool call parsing with <|python_tag|> pattern
        // Input: "Let me run some code. " + "<|python_tag|>{\"name\": \"execute_code\", \"arguments\": {\"code\": \"print('Hello')\"}}" + " Done executing."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("Let me run some code. ".to_string(), 0),
            create_mock_response_chunk("<|python_tag|>".to_string(), 0),
            create_mock_response_chunk("{\"name\": \"execute_code\", ".to_string(), 0),
            create_mock_response_chunk(
                "\"arguments\": {\"code\": \"print('Hello')\"}}".to_string(),
                0,
            ),
            create_mock_response_chunk(" Done executing.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with llama3_json parser
        let jail = JailedStream::builder()
            .tool_call_parser("llama3_json")
            .build();

841
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880

        // Should have exactly 3 chunks: content + tool call + content
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "Let me run some code. ");
        test_utils::assert_tool_call(
            &results[1],
            "execute_code",
            serde_json::json!({"code": "print('Hello')"}),
        );
        test_utils::assert_content(&results[2], " Done executing.");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "Let me run some code.  Done executing.");
    }

    #[tokio::test]
    async fn test_jailed_stream_false_positive_json() {
        // Tests that JSON-like content doesn't trigger false positive tool call detection
        // Input: "I can explain JSON format. " + "Here's an example: { \"key\": \"value\" }" + " is a simple JSON object. " + "Hope that helps!"
        // Expected output: 4 chunks [Content(), Content(), Content(), Content()] - no jailing
        let chunks = vec![
            create_mock_response_chunk("I can explain JSON format. ".to_string(), 0),
            create_mock_response_chunk("Here's an example: { \"key\": \"value\" }".to_string(), 0),
            create_mock_response_chunk(" is a simple JSON object. ".to_string(), 0),
            create_mock_response_chunk("Hope that helps!".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with mistral parser (which specifically looks for [{ or [TOOL_CALLS] patterns)
        let jail = JailedStream::builder().tool_call_parser("mistral").build();

881
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921

        // The "{" pattern triggers jailing, so some chunks get combined
        assert_eq!(results.len(), 2);

        // Verify exact output structure: content chunks
        test_utils::assert_content(&results[0], "I can explain JSON format. ");
        test_utils::assert_content(
            &results[1],
            "Here's an example: { \"key\": \"value\" } is a simple JSON object. Hope that helps!",
        );

        // Verify no tool calls were detected and all content preserved
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "I can explain JSON format. Here's an example: { \"key\": \"value\" } is a simple JSON object. Hope that helps!"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_malformed_tool_call() {
        // Tests graceful handling of malformed JSON within tool call markers
        // Input: "Let me call a function. " + "<TOOLCALL>[{\"name\": \"broken_func\", \"arguments\": {\"param\": incomplete</TOOLCALL>" + " Function call attempt finished."
        // Expected output: 3 chunks [Content(), Content(malformed), Content()] - parser fails gracefully
        let chunks = vec![
            create_mock_response_chunk("Let me call a function. ".to_string(), 0),
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk("[{\"name\": \"broken_func\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {\"param\": incomplete".to_string(), 0), // Malformed JSON
            create_mock_response_chunk("</TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(" Function call attempt finished.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with nemotron_deci parser
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

922
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965

        // Jailing combines the tool call content into fewer chunks
        assert_eq!(
            results.len(),
            3,
            "Should handle malformed JSON gracefully and jail appropriately"
        );

        // Verify exact output structure: [Content(), Content(complete jailed content)]
        test_utils::assert_content(&results[0], "Let me call a function. ");
        test_utils::assert_content(
            &results[1],
            "<TOOLCALL>[{\"name\": \"broken_func\", \"arguments\": {\"param\": incomplete</TOOLCALL>",
        );

        // Verify malformed content is preserved as text (including markers when parsing fails)
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "Let me call a function. <TOOLCALL>[{\"name\": \"broken_func\", \"arguments\": {\"param\": incomplete</TOOLCALL> Function call attempt finished."
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_partial_tool_call() {
        // Tests handling of incomplete tool call when stream ends abruptly
        // Input: "Starting function call. " + "<TOOLCALL>[{\"name\": \"incomplete_func\", \"arguments\": {" (no end marker)
        // Expected output: 2 chunks [Content(), Content(partial)] - partial accumulated content released on stream end
        let chunks = vec![
            create_mock_response_chunk("Starting function call. ".to_string(), 0),
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk("[{\"name\": \"incomplete_func\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {".to_string(), 0),
            // Stream ends abruptly without closing the tool call
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with nemotron_deci parser
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

966
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004

        // Should handle partial tool call gracefully - releases accumulated content on stream end
        assert_eq!(
            results.len(),
            2,
            "Should handle partial tool call and release content"
        );

        // Verify exact output structure: [Content(), Content(accumulated partial)]
        test_utils::assert_content(&results[0], "Starting function call. ");
        test_utils::assert_content(
            &results[1],
            "<TOOLCALL>[{\"name\": \"incomplete_func\", \"arguments\": {",
        );

        // Verify partial content is preserved as text since no valid tool call could be parsed
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "Starting function call. <TOOLCALL>[{\"name\": \"incomplete_func\", \"arguments\": {"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_empty_stream() {
        // Input chunks: []
        //
        // Expected output: []
        let chunks: Vec<Annotated<NvCreateChatCompletionStreamResponse>> = vec![];
        let input_stream = stream::iter(chunks);

        // Create JailedStream
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .jail_start_sequence("<jail>")
            .jail_end_sequence("</jail>")
            .build();

1005
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            0,
            "Empty stream should produce exactly 0 results"
        );

        // === Verify content reconstruction ===
        assert_eq!(
            reconstruct_content(&results),
            "",
            "Empty stream should reconstruct to empty string"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_multiple_tool_calls() {
        // Input chunks: 9 chunks for 2 tool calls with content between
        //
        // Expected output:
        // [0] Content("I'll help with multiple tasks. ")
        // [1] ToolCall("get_weather", {"city": "NYC"})
        // [2] Content(" Now let me get the time. ")
        // [3] ToolCall("get_time", {"timezone": "EST"})
        // [4] Content(" Both tasks completed!")
        let chunks = vec![
            create_mock_response_chunk("I'll help with multiple tasks. ".to_string(), 0),
            // First tool call
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(
                "[{\"name\": \"get_weather\", \"arguments\": {\"city\": \"NYC\"}}]".to_string(),
                0,
            ),
            create_mock_response_chunk("</TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(" Now let me get the time. ".to_string(), 0),
            // Second tool call
            create_mock_response_chunk("<TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(
                "[{\"name\": \"get_time\", \"arguments\": {\"timezone\": \"EST\"}}]".to_string(),
                0,
            ),
            create_mock_response_chunk("</TOOLCALL>".to_string(), 0),
            create_mock_response_chunk(" Both tasks completed!".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

1059
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            5,
            "Should emit exactly 5 chunks as documented above"
        );

        // === Verify individual chunks ===
        assert_content(&results[0], "I'll help with multiple tasks. ");
        assert_tool_call(&results[1], "get_weather", json!({"city": "NYC"}));
        assert_content(&results[2], " Now let me get the time. ");
        assert_tool_call(&results[3], "get_time", json!({"timezone": "EST"}));
        assert_content(&results[4], " Both tasks completed!");

        // === Verify content reconstruction ===
        let expected_content =
            "I'll help with multiple tasks.  Now let me get the time.  Both tasks completed!";
        assert_eq!(
            reconstruct_content(&results),
            expected_content,
            "Content reconstruction should exclude tool calls and preserve text flow"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_tool_call_across_many_chunks() {
        // Tests extreme fragmentation: tool call split across 65 individual character chunks
        // Input: "I'll process your request. " + "<TOOLCALL>[{"name": "process_data", "arguments": {}}]</TOOLCALL>" + " Processing complete!"
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("I'll process your request. ".to_string(), 0),
            create_mock_response_chunk("<".to_string(), 0),
            create_mock_response_chunk("T".to_string(), 0),
            create_mock_response_chunk("O".to_string(), 0),
            create_mock_response_chunk("O".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk("C".to_string(), 0),
            create_mock_response_chunk("A".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk(">".to_string(), 0),
            create_mock_response_chunk("[".to_string(), 0),
            create_mock_response_chunk("{".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk("n".to_string(), 0),
            create_mock_response_chunk("a".to_string(), 0),
            create_mock_response_chunk("m".to_string(), 0),
            create_mock_response_chunk("e".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk(":".to_string(), 0),
            create_mock_response_chunk(" ".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk("p".to_string(), 0),
            create_mock_response_chunk("r".to_string(), 0),
            create_mock_response_chunk("o".to_string(), 0),
            create_mock_response_chunk("c".to_string(), 0),
            create_mock_response_chunk("e".to_string(), 0),
            create_mock_response_chunk("s".to_string(), 0),
            create_mock_response_chunk("s".to_string(), 0),
            create_mock_response_chunk("_".to_string(), 0),
            create_mock_response_chunk("d".to_string(), 0),
            create_mock_response_chunk("a".to_string(), 0),
            create_mock_response_chunk("t".to_string(), 0),
            create_mock_response_chunk("a".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk(",".to_string(), 0),
            create_mock_response_chunk(" ".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk("a".to_string(), 0),
            create_mock_response_chunk("r".to_string(), 0),
            create_mock_response_chunk("g".to_string(), 0),
            create_mock_response_chunk("u".to_string(), 0),
            create_mock_response_chunk("m".to_string(), 0),
            create_mock_response_chunk("e".to_string(), 0),
            create_mock_response_chunk("n".to_string(), 0),
            create_mock_response_chunk("t".to_string(), 0),
            create_mock_response_chunk("s".to_string(), 0),
            create_mock_response_chunk("\"".to_string(), 0),
            create_mock_response_chunk(":".to_string(), 0),
            create_mock_response_chunk(" ".to_string(), 0),
            create_mock_response_chunk("{".to_string(), 0),
            create_mock_response_chunk("}".to_string(), 0),
            create_mock_response_chunk("}".to_string(), 0),
            create_mock_response_chunk("]".to_string(), 0),
            create_mock_response_chunk("<".to_string(), 0),
            create_mock_response_chunk("/".to_string(), 0),
            create_mock_response_chunk("T".to_string(), 0),
            create_mock_response_chunk("O".to_string(), 0),
            create_mock_response_chunk("O".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk("C".to_string(), 0),
            create_mock_response_chunk("A".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk("L".to_string(), 0),
            create_mock_response_chunk(">".to_string(), 0),
            create_mock_response_chunk(" Processing complete!".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

1166
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219

        // Should consolidate extreme fragmentation into 3 clean chunks
        // Input: "I'll process your request. " + 54-char tool call + " Processing complete!"
        // Expected output: [Content(), ToolCall(), Content()]
        assert_eq!(
            results.len(),
            3,
            "Should consolidate fragments into 3 chunks"
        );

        // Verify exact output structure
        test_utils::assert_content(&results[0], "I'll process your request. ");
        test_utils::assert_tool_call(&results[1], "process_data", serde_json::json!({}));
        test_utils::assert_content(&results[2], " Processing complete!");

        // Verify content reconstruction excludes tool calls
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "I'll process your request.  Processing complete!"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_preserves_metadata() {
        // Test metadata preservation through jail processing
        let test_id = Some("correlation-id-123".to_string());
        let test_event = Some("request-processing".to_string());
        let test_comment = Some(vec![
            "upstream-correlation".to_string(),
            "debug-info".to_string(),
        ]);

        // Create chunks with specific metadata for the jail trigger
        let chunks = vec![
            create_annotated_chunk(
                "I'll help you with that. ".to_string(),
                0,
                None, // No metadata on first chunk
                None,
                None,
            ),
            create_annotated_chunk(
                "<tool_call>".to_string(),
                0,
                test_id.clone(), // Metadata on jail trigger chunk
                test_event.clone(),
                test_comment.clone(),
            ),
            create_mock_response_chunk("{\"name\": \"search_web\", ".to_string(), 0),
            create_mock_response_chunk("\"arguments\": {\"query\": \"test\"}}".to_string(), 0),
            create_mock_response_chunk("</tool_call>".to_string(), 0),
            create_mock_response_chunk(" Processing complete.".to_string(), 0),
1220
            test_utils::create_final_response_chunk(0), // Backend finish_reason chunk
Ryan Olson's avatar
Ryan Olson committed
1221
1222
1223
1224
1225
1226
1227
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Hermes parser
        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1228
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1229
1230
1231
1232
1233
1234
1235
1236

        // Should get 3 chunks: before jail, tool call response, after jail
        assert!(
            results.len() >= 3,
            "Should have at least 3 chunks, got {}",
            results.len()
        );

1237
        // Find the tool call chunk (the one with tool_calls, not the finish_reason chunk)
Ryan Olson's avatar
Ryan Olson committed
1238
1239
1240
1241
1242
        let tool_call_chunk = results
            .iter()
            .find(|r| {
                r.data
                    .as_ref()
1243
                    .and_then(|d| d.inner.choices.first())
1244
                    .map(|c| c.delta.tool_calls.is_some())
Ryan Olson's avatar
Ryan Olson committed
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
                    .unwrap_or(false)
            })
            .expect("Should have a tool call response chunk");

        // Verify metadata is preserved
        assert_eq!(
            tool_call_chunk.id, test_id,
            "ID should be preserved from jail trigger chunk"
        );
        assert_eq!(
            tool_call_chunk.event, test_event,
            "Event should be preserved from jail trigger chunk"
        );
        assert_eq!(
            tool_call_chunk.comment, test_comment,
            "Comment should be preserved from jail trigger chunk"
        );

        // Verify tool call was parsed correctly
1264
        let tool_calls = &tool_call_chunk.data.as_ref().unwrap().inner.choices[0]
Ryan Olson's avatar
Ryan Olson committed
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
            .delta
            .tool_calls;
        assert!(tool_calls.is_some(), "Should have tool calls");
        let tool_calls = tool_calls.as_ref().unwrap();
        assert_eq!(tool_calls.len(), 1, "Should have exactly one tool call");
        assert_eq!(
            tool_calls[0]
                .function
                .as_ref()
                .unwrap()
                .name
                .as_ref()
                .unwrap(),
            "search_web"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_preserves_metadata_on_stream_end() {
        // Test metadata preservation when stream ends while jailed
        let test_id = Some("end-correlation-456".to_string());
        let test_event = Some("stream-termination".to_string());
        let test_comment = Some(vec!["incomplete-processing".to_string()]);

        // Create chunks that end while jailed (no explicit end marker)
        let chunks = vec![
            create_mock_response_chunk("Starting function call: ".to_string(), 0),
            create_annotated_chunk(
                "<tool_call>".to_string(), // This chunk triggers jail and has metadata
                0,
                test_id.clone(),
                test_event.clone(),
                test_comment.clone(),
            ),
            create_mock_response_chunk(
                "{\"name\": \"incomplete_call\"".to_string(), // No closing brace
                0,
            ),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream with Hermes parser
        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1310
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331

        // Should get 2 chunks: first chunk passes through, stream end releases accumulated
        assert_eq!(results.len(), 2, "Should have exactly 2 chunks");

        // The second chunk is the accumulated content released when stream ended
        let accumulated_chunk = &results[1];

        // Verify metadata is preserved from the jail trigger
        assert_eq!(
            accumulated_chunk.id, test_id,
            "ID should be preserved when stream ends while jailed"
        );
        assert_eq!(
            accumulated_chunk.event, test_event,
            "Event should be preserved when stream ends while jailed"
        );
        assert_eq!(
            accumulated_chunk.comment, test_comment,
            "Comment should be preserved when stream ends while jailed"
        );

1332
1333
1334
        // Verify inner response metadata carries forward real stream values (not placeholders)
        let inner = accumulated_chunk.data.as_ref().unwrap();
        assert_eq!(
1335
            inner.inner.id, "test-id",
1336
1337
1338
            "Inner response id should carry forward from real stream chunks, not be 'stream-end'"
        );
        assert_eq!(
1339
            inner.inner.model, "test-model",
1340
1341
1342
            "Inner response model should carry forward from real stream chunks, not be 'unknown'"
        );
        assert_eq!(
1343
            inner.inner.created, 1234567890,
1344
1345
1346
            "Inner response created should carry forward from real stream chunks, not be 0"
        );

Ryan Olson's avatar
Ryan Olson committed
1347
        // Verify accumulated content is returned
1348
        let content = &inner.inner.choices[0].delta.content;
Ryan Olson's avatar
Ryan Olson committed
1349
1350
1351
        assert!(content.is_some(), "Should have accumulated content");
        let content = content.as_ref().unwrap();
        assert!(
1352
            test_utils::extract_text(content).contains("<tool_call>"),
Ryan Olson's avatar
Ryan Olson committed
1353
1354
1355
            "Should contain jail start marker in accumulated content"
        );
        assert!(
1356
            test_utils::extract_text(content).contains("incomplete_call"),
Ryan Olson's avatar
Ryan Olson committed
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
            "Should contain accumulated incomplete content"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_metadata_edge_cases() {
        // Test edge cases: empty metadata, partial metadata, etc.
        let chunks = vec![
            create_annotated_chunk(
                "Text with ".to_string(),
                0,
                Some("".to_string()), // Empty string ID
                None,                 // No event
                Some(vec![]),         // Empty comment vector
            ),
            create_annotated_chunk(
                "<tool_call>".to_string(),
                0,
                None,                                 // No ID
                Some("partial-metadata".to_string()), // Only event
                None,                                 // No comment
            ),
            create_mock_response_chunk("{\"name\": \"test\", \"arguments\": {}}".to_string(), 0),
            create_mock_response_chunk("</tool_call>".to_string(), 0),
1381
            test_utils::create_final_response_chunk(0), // Backend finish_reason chunk
Ryan Olson's avatar
Ryan Olson committed
1382
1383
1384
1385
1386
1387
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1388
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1389

1390
        // Find the tool call chunk (the one with tool_calls, not the finish_reason chunk)
Ryan Olson's avatar
Ryan Olson committed
1391
1392
1393
1394
1395
        let tool_call_chunk = results
            .iter()
            .find(|r| {
                r.data
                    .as_ref()
1396
                    .and_then(|d| d.inner.choices.first())
1397
                    .map(|c| c.delta.tool_calls.is_some())
Ryan Olson's avatar
Ryan Olson committed
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
                    .unwrap_or(false)
            })
            .expect("Should have a tool call response chunk");

        // Verify partial metadata is preserved correctly
        assert_eq!(tool_call_chunk.id, None, "Should preserve None ID");
        assert_eq!(
            tool_call_chunk.event,
            Some("partial-metadata".to_string()),
            "Should preserve event"
        );
        assert_eq!(
            tool_call_chunk.comment, None,
            "Should preserve None comment"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_trailing_content_same_chunk() {
        // Input chunks:
        // [0] "I'll help you. "
        // [1] "<tool_call>"
        // [2] "{\"name\": \"search\", \"arguments\": {}}"
        // [3] "</tool_call>trailing text that should not be lost"
        //
        // Expected output:
        // [0] Content("I'll help you. ")
        // [1] ToolCall("search", {})
        // [2] Content("trailing text that should not be lost")
        let chunks = vec![
            create_mock_response_chunk("I'll help you. ".to_string(), 0),
            create_mock_response_chunk("<tool_call>".to_string(), 0),
            create_mock_response_chunk("{\"name\": \"search\", \"arguments\": {}}".to_string(), 0),
            // This chunk contains both the end marker AND trailing content
            create_mock_response_chunk(
                "</tool_call>trailing text that should not be lost".to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1442
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            3,
            "Should emit exactly 3 chunks as documented above"
        );

        // === Verify individual chunks ===
        assert_content(&results[0], "I'll help you. ");
        assert_tool_call(&results[1], "search", json!({}));
        assert_content(&results[2], "trailing text that should not be lost");

        // === Verify content reconstruction ===
        let expected_content = "I'll help you. trailing text that should not be lost";
        assert_eq!(
            reconstruct_content(&results),
            expected_content,
            "Content reconstruction should preserve initial and trailing text"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_early_exit_with_trailing() {
        // Tests early exit when complete tool call is detected in chunk that also contains trailing content
        // Input: "Starting task: " + "<tool_call>{\"name\": \"complete_task\", \"arguments\": {}}" + "</tool_call> Task completed successfully."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("Starting task: ".to_string(), 0),
            create_mock_response_chunk(
                "<tool_call>{\"name\": \"complete_task\", \"arguments\": {}}".to_string(),
                0,
            ),
            // Early exit should happen here, but we also have trailing content
            create_mock_response_chunk("</tool_call> Task completed successfully.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1484
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540

        // Should have exactly 3 chunks: content + tool call + trailing
        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()]
        test_utils::assert_content(&results[0], "Starting task: ");
        test_utils::assert_tool_call(&results[1], "complete_task", serde_json::json!({}));
        test_utils::assert_content(&results[2], " Task completed successfully.");

        // Verify content reconstruction excludes tool calls but preserves trailing
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(
            reconstructed,
            "Starting task:  Task completed successfully."
        );
    }

    #[tokio::test]
    async fn test_multiple_choices_independent_jailing() {
        // Test that different choices can jail and unjail independently
        // This test will FAIL with the current HashMap-based implementation
        let chunks = vec![
            // Chunk 1: All choices start normally
            create_multi_choice_chunk(vec![
                ("Starting task A. ".to_string(), 0),
                ("Starting task B. ".to_string(), 1),
                ("Starting task C. ".to_string(), 2),
            ]),
            // Chunk 2: Choice 0 starts tool call (gets jailed), others continue
            create_multi_choice_chunk(vec![
                ("<tool_call>".to_string(), 0),    // Choice 0 jailed
                ("Continuing B. ".to_string(), 1), // Choice 1 continues
                ("Continuing C. ".to_string(), 2), // Choice 2 continues
            ]),
            // Chunk 3: Choice 0 still jailed, Choice 2 starts tool call
            create_multi_choice_chunk(vec![
                ("{\"name\": \"tool_a\"".to_string(), 0), // Choice 0 still jailed
                ("More B content. ".to_string(), 1),      // Choice 1 continues
                ("<tool_call>".to_string(), 2),           // Choice 2 now jailed
            ]),
            // Chunk 4: Choice 0 finishes tool call, Choice 2 continues tool call
            create_multi_choice_chunk(vec![
                (", \"arguments\": {}}</tool_call>".to_string(), 0), // Choice 0 unjails
                ("Final B. ".to_string(), 1),                        // Choice 1 continues
                ("{\"name\": \"tool_c\", \"arguments\": {}}".to_string(), 2), // Choice 2 still jailed
            ]),
            // Chunk 5: Choice 2 finishes tool call
            create_multi_choice_chunk(vec![
                ("After tool A. ".to_string(), 0), // Choice 0 continues after unjail
                ("Done with B. ".to_string(), 1),  // Choice 1 continues
                ("</tool_call>".to_string(), 2),   // Choice 2 unjails
            ]),
1541
1542
            // Chunk 6: Backend finish_reason chunks for all choices
            test_utils::create_multi_choice_finish_chunk(vec![0, 1, 2]),
Ryan Olson's avatar
Ryan Olson committed
1543
1544
1545
1546
1547
1548
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1549
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560

        // EXPECTED BEHAVIOR (will fail with current implementation):
        // - Choice 1 should stream continuously (never jailed)
        // - Choice 0 should jail from chunk 2 until chunk 4
        // - Choice 2 should jail from chunk 3 until chunk 5
        // - Each choice should emit independently

        // Verify choice 1 was never interrupted (should have ~5 chunks of content)
        let choice_1_chunks: Vec<_> = results
            .iter()
            .filter_map(|r| r.data.as_ref())
1561
            .flat_map(|d| &d.inner.choices)
Ryan Olson's avatar
Ryan Olson committed
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
            .filter(|c| c.index == 1 && c.delta.content.is_some())
            .collect();

        assert!(
            choice_1_chunks.len() >= 4,
            "Choice 1 should have multiple continuous chunks, got {}",
            choice_1_chunks.len()
        );

        // Verify choice 0 has a tool call response
        let choice_0_tool_calls: Vec<_> = results
            .iter()
            .filter_map(|r| r.data.as_ref())
1575
            .flat_map(|d| &d.inner.choices)
Ryan Olson's avatar
Ryan Olson committed
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
            .filter(|c| c.index == 0 && c.finish_reason == Some(FinishReason::ToolCalls))
            .collect();

        assert!(
            !choice_0_tool_calls.is_empty(),
            "Choice 0 should have tool call response"
        );

        // Verify choice 2 has a tool call response
        let choice_2_tool_calls: Vec<_> = results
            .iter()
            .filter_map(|r| r.data.as_ref())
1588
            .flat_map(|d| &d.inner.choices)
Ryan Olson's avatar
Ryan Olson committed
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
            .filter(|c| c.index == 2 && c.finish_reason == Some(FinishReason::ToolCalls))
            .collect();

        assert!(
            !choice_2_tool_calls.is_empty(),
            "Choice 2 should have tool call response"
        );
    }

    #[tokio::test]
    async fn test_deterministic_choice_ordering() {
        // Test that choices are processed in deterministic order (0, 1, 2...)
        // This test will FAIL with the current HashMap implementation
        let chunks = vec![
            // All choices have tool calls that complete at the same time
            create_multi_choice_chunk(vec![
                (
                    "<tool_call>{\"name\": \"tool_0\", \"arguments\": {}}</tool_call>".to_string(),
                    0,
                ),
                (
                    "<tool_call>{\"name\": \"tool_1\", \"arguments\": {}}</tool_call>".to_string(),
                    1,
                ),
                (
                    "<tool_call>{\"name\": \"tool_2\", \"arguments\": {}}</tool_call>".to_string(),
                    2,
                ),
            ]),
1618
            test_utils::create_multi_choice_finish_chunk(vec![0, 1, 2]),
Ryan Olson's avatar
Ryan Olson committed
1619
1620
1621
1622
1623
1624
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("hermes").build();

1625
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1626
1627
1628
1629
1630

        // Find all tool call responses
        let mut tool_call_responses: Vec<_> = results
            .iter()
            .filter_map(|r| r.data.as_ref())
1631
            .flat_map(|d| &d.inner.choices)
Ryan Olson's avatar
Ryan Olson committed
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
            .filter(|c| c.finish_reason == Some(FinishReason::ToolCalls))
            .collect();

        // Sort by the order they appear in the results
        // With HashMap, this order will be non-deterministic
        // With Vec, this should always be [0, 1, 2]
        tool_call_responses.sort_by_key(|c| c.index);

        assert_eq!(
            tool_call_responses.len(),
            3,
            "Should have 3 tool call responses"
        );

        // Run this test multiple times to verify determinism
        for run in 0..5 {
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
            let chunks = vec![
                create_multi_choice_chunk(vec![
                    (
                        "<tool_call>{\"name\": \"tool_0\", \"arguments\": {}}</tool_call>"
                            .to_string(),
                        0,
                    ),
                    (
                        "<tool_call>{\"name\": \"tool_1\", \"arguments\": {}}</tool_call>"
                            .to_string(),
                        1,
                    ),
                    (
                        "<tool_call>{\"name\": \"tool_2\", \"arguments\": {}}</tool_call>"
                            .to_string(),
                        2,
                    ),
                ]),
                test_utils::create_multi_choice_finish_chunk(vec![0, 1, 2]),
            ];
Ryan Olson's avatar
Ryan Olson committed
1668
1669
1670

            let input_stream = stream::iter(chunks);
            let jail = JailedStream::builder().tool_call_parser("hermes").build();
1671
            let run_results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1672
1673
1674
1675

            let run_responses: Vec<_> = run_results
                .iter()
                .filter_map(|r| r.data.as_ref())
1676
                .flat_map(|d| &d.inner.choices)
Ryan Olson's avatar
Ryan Olson committed
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
                .filter(|c| c.finish_reason == Some(FinishReason::ToolCalls))
                .collect();

            // The order should be consistent across runs
            // This will fail with HashMap due to non-deterministic iteration
            let indices: Vec<u32> = run_responses.iter().map(|c| c.index).collect();
            assert_eq!(
                indices,
                vec![0, 1, 2],
                "Choice processing order should be deterministic on run {}",
                run
            );
        }
    }

1692
1693
1694
1695
1696
1697
1698
1699
    #[tokio::test]
    async fn test_usage_chunk_preserved() {
        // Create one chunk with choices (content) and one chunk with only usage/no choices.
        let content_chunk = create_mock_response_chunk("Hello, world!".to_string(), 0);
        let mut usage_chunk = content_chunk.clone();

        // Modify the inner data to be a usage-only chunk
        if let Some(ref mut data) = usage_chunk.data {
1700
1701
            data.inner.choices.clear();
            data.inner.usage = Some(CompletionUsage {
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
                prompt_tokens: 11,
                completion_tokens: 3,
                total_tokens: 14,
                prompt_tokens_details: None,
                completion_tokens_details: None,
            });
        }

        let input_chunks = vec![content_chunk, usage_chunk];
        let input_stream = stream::iter(input_chunks);
        let jail = JailedStream::builder().build();

        let results: Vec<_> = jail.apply(input_stream).collect().await;

        // Validate we have exactly 2 chunks
        assert_eq!(results.len(), 2, "Should have exactly 2 chunks");

        // First chunk should be content chunk
1720
        let content = results[0].data.as_ref().unwrap().inner.choices[0]
1721
1722
1723
1724
1725
            .delta
            .content
            .as_ref()
            .unwrap();
        assert_eq!(
1726
1727
            extract_text(content),
            "Hello, world!",
1728
1729
1730
1731
1732
            "Content chunk should have 'Hello, world!'"
        );

        // Second chunk should be usage-only chunk
        assert!(
1733
            results[1].data.as_ref().unwrap().inner.choices.is_empty(),
1734
1735
            "Usage chunk should have no choices"
        );
1736
1737
1738
1739
1740
1741
1742
1743
        let usage = results[1]
            .data
            .as_ref()
            .unwrap()
            .inner
            .usage
            .as_ref()
            .unwrap();
1744
1745
1746
1747
1748
        assert_eq!(usage.prompt_tokens, 11);
        assert_eq!(usage.completion_tokens, 3);
        assert_eq!(usage.total_tokens, 14);
    }

Ryan Olson's avatar
Ryan Olson committed
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
    #[tokio::test]
    async fn test_multiple_choices_usage_aggregation() {
        // Test that usage is correctly aggregated across multiple choices
        // This test demonstrates how usage should work with n>1

        // For now, this test just documents expected behavior
        // It will need to be expanded once usage aggregation is implemented

        let chunks = vec![create_multi_choice_chunk(vec![
            ("Response A with many tokens".to_string(), 0), // ~5 tokens
            ("Response B".to_string(), 1),                  // ~2 tokens
            ("Response C has even more tokens than A".to_string(), 2), // ~8 tokens
        ])];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().build();

1767
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801

        // TODO: Once usage aggregation is implemented, verify:
        // - Usage chunk has choices: [] (empty array)
        // - completion_tokens = sum of all choices (~15 total)
        // - prompt_tokens counted once
        // - total_tokens = prompt_tokens + completion_tokens

        // For now, just verify we got some results
        assert!(!results.is_empty(), "Should have some results");
    }

    #[tokio::test]
    async fn test_partial_matching_false_positive_prevention() {
        // Input chunks:
        // [0] "n "
        // [1] "<"
        // [2] " 5"
        //
        // Expected output:
        // [0] Content("n ")
        // [1] Content("< 5")  // "<" held as partial, then combined with " 5" when pattern doesn't match
        let chunks = vec![
            create_mock_response_chunk("n ".to_string(), 0),
            create_mock_response_chunk("<".to_string(), 0),
            create_mock_response_chunk(" 5".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Use nemotron parser which has <TOOLCALL> as a pattern
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

1802
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            2,
            "Should emit exactly 2 chunks: 'n ' and '< 5'"
        );

        // === Verify individual chunks ===
        assert_content(&results[0], "n ");
        assert_content(&results[1], "< 5");

        // === Verify negative assertions ===
        // Verify NO tool calls were detected
        for (i, result) in results.iter().enumerate() {
            assert!(
                !has_tool_call(result),
                "Chunk {} should not contain tool calls in mathematical expression",
                i
            );
        }

        // === Verify content reconstruction ===
        assert_eq!(
            reconstruct_content(&results),
            "n < 5",
            "Content reconstruction should preserve the complete mathematical expression"
        );
    }

    #[tokio::test]
    async fn test_partial_matching_suffix_detection() {
        // Input chunks:
        // [0] "text<TO"
        // [1] "OLCALL>[{\"name\": \"test\", \"arguments\": {}}]</TOOLCALL>"
        //
        // Expected output:
        // [0] Content("text")  // "<TO" held as partial
        // [1] ToolCall("test", {})
        let chunks = vec![
            create_mock_response_chunk("text<TO".to_string(), 0),
            create_mock_response_chunk(
                "OLCALL>[{\"name\": \"test\", \"arguments\": {}}]</TOOLCALL>".to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .jail_end_sequence("</TOOLCALL>")
            .build();

1857
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910

        // === Verify chunk count ===
        assert_eq!(
            results.len(),
            2,
            "Should emit exactly 2 chunks: [0] 'text' content, [1] tool call"
        );

        // === Verify individual chunks ===
        assert_content(&results[0], "text");
        assert_tool_call(&results[1], "test", json!({}));

        // === Verify negative assertions ===
        // Verify '<' was not emitted in first chunk (held as partial)
        let first_content = extract_content(&results[0]);
        assert!(
            !first_content.contains('<'),
            "First chunk should not contain '<' as it's part of partial match '<TO'"
        );

        // === Verify content reconstruction ===
        assert_eq!(
            reconstruct_content(&results),
            "text",
            "Content reconstruction should only include 'text' (tool call parsed separately)"
        );
    }

    #[tokio::test]
    async fn test_jailed_stream_harmony_parser() {
        // Harmony format with analysis text and a tool call encoded in special tags
        let chunks = vec![
            create_mock_response_chunk(
                "<|channel|>analysis<|message|>Need to use function get_current_weather.<|end|>"
                    .to_string(),
                0,
            ),
            create_mock_response_chunk("<|start|>".to_string(), 0),
            create_mock_response_chunk("assistant".to_string(), 0),
            create_mock_response_chunk("<|channel|>".to_string(), 0),
            create_mock_response_chunk(
                "commentary to=functions.get_current_weather <|constrain|>json".to_string(),
                0,
            ),
            create_mock_response_chunk(
                "<|message|>{\"location\":\"San Francisco\"}<|call|>".to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder().tool_call_parser("harmony").build();
1911
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
1912
1913
1914
1915
1916
1917
1918
1919

        // Should have at least one output containing both analysis text and parsed tool call
        assert!(!results.is_empty());

        // Verify the analysis text appears as content in one of the outputs
        let has_analysis_text = results.iter().any(|r| {
            r.data
                .as_ref()
1920
                .and_then(|d| d.inner.choices.first())
Ryan Olson's avatar
Ryan Olson committed
1921
                .and_then(|c| c.delta.content.as_ref())
1922
1923
1924
1925
                .map(|content| {
                    test_utils::extract_text(content)
                        .contains("Need to use function get_current_weather.")
                })
Ryan Olson's avatar
Ryan Olson committed
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
                .unwrap_or(false)
        });
        assert!(has_analysis_text, "Should contain extracted analysis text");

        // Verify a tool call was parsed with expected name and args
        let tool_call_idx = results
            .iter()
            .position(test_utils::has_tool_call)
            .expect("Should have a tool call result");
        test_utils::assert_tool_call(
            &results[tool_call_idx],
            "get_current_weather",
            json!({"location": "San Francisco"}),
        );
    }

    #[tokio::test]
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
    async fn test_deepseek_v3_1() {
        // DeepSeek v3.1 format with two tool calls encoded in special tags
        let text = r#"<|tool▁calls▁begin|><|tool▁call▁begin|>get_current_weather<|tool▁sep|>{"location": "Berlin", "units": "metric"}<|tool▁call▁end|><|tool▁call▁begin|>get_weather_forecast<|tool▁sep|>{"location": "Berlin", "days": 7, "units": "imperial"}<|tool▁call▁end|><|tool▁call▁begin|>get_air_quality<|tool▁sep|>{"location": "Berlin", "radius": 50}<|tool▁call▁end|><|tool▁calls▁end|><|end▁of▁sentence|>"#;

        let chunks = vec![create_mock_response_chunk(text.to_string(), 0)];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder()
            .tool_call_parser("deepseek_v3_1")
            .build();
1954
        let jailed_stream = jail.apply_with_finish_reason(input_stream);
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
        let results: Vec<_> = jailed_stream.collect().await;

        // Should have at least one output containing both analysis text and parsed tool call
        assert!(!results.is_empty());

        // Verify a tool call was parsed with expected name and args
        let tool_call_idx = results
            .iter()
            .position(test_utils::has_tool_call)
            .expect("Should have a tool call result");
        test_utils::assert_tool_call(
            &results[tool_call_idx],
            "get_current_weather",
            json!({"location": "Berlin", "units": "metric"}),
        );
        for result in results {
            let Some(data) = result.data else {
                continue;
            };
1974
            for choice in data.inner.choices {
1975
1976
                if let Some(content) = choice.delta.content {
                    assert!(
1977
                        !test_utils::extract_text(&content).contains("<|tool▁calls▁end|>"),
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
                        "Should not contain deepseek special tokens in content"
                    );
                }
            }
        }
    }

    #[tokio::test]
    async fn test_deepseek_v3_1_chunk() {
        // DeepSeek v3.1 format with two tool calls encoded in special tags
        let text = r#"<|tool▁calls▁begin|><|tool▁call▁begin|>get_current_weather<|tool▁sep|>{"location": "Berlin", "units": "metric"}<|tool▁call▁end|><|tool▁call▁begin|>get_weather_forecast<|tool▁sep|>{"location": "Berlin", "days": 7, "units": "imperial"}<|tool▁call▁end|><|tool▁call▁begin|>get_air_quality<|tool▁sep|>{"location": "Berlin", "radius": 50}<|tool▁call▁end|><|tool▁calls▁end|><|end▁of▁sentence|>"#;

        // Split text into words, treating angle-bracketed tokens as one word
        let mut words = Vec::new();
        let mut i = 0;
        let chars: Vec<char> = text.chars().collect();
        while i < chars.len() {
            if chars[i] == '<' {
                // Find the next '>'
                if let Some(end) = chars[i..].iter().position(|&c| c == '>') {
                    let word: String = chars[i..=i + end].iter().collect();
                    words.push(word);
                    i += end + 1;
                } else {
                    // Malformed, just push the rest
                    words.push(chars[i..].iter().collect());
                    break;
                }
            } else if chars[i].is_whitespace() {
                i += 1;
            } else {
                // Collect until next whitespace or '<'
                let start = i;
                while i < chars.len() && !chars[i].is_whitespace() && chars[i] != '<' {
                    i += 1;
                }
                words.push(chars[start..i].iter().collect());
            }
        }

        let chunks = words
            .into_iter()
            .map(|word| create_mock_response_chunk(word, 0))
            .collect::<Vec<_>>();

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder()
            .tool_call_parser("deepseek_v3_1")
            .build();
2028
        let jailed_stream = jail.apply_with_finish_reason(input_stream);
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
        let results: Vec<_> = jailed_stream.collect().await;

        // Should have at least one output containing both analysis text and parsed tool call
        assert!(!results.is_empty());

        // Verify a tool call was parsed with expected name and args
        let tool_call_idx = results
            .iter()
            .position(test_utils::has_tool_call)
            .expect("Should have a tool call result");
        test_utils::assert_tool_call(
            &results[tool_call_idx],
            "get_current_weather",
            json!({"location": "Berlin", "units": "metric"}),
        );
        for result in results {
            let Some(data) = result.data else {
                continue;
            };
2048
            for choice in data.inner.choices {
2049
2050
                if let Some(content) = choice.delta.content {
                    assert!(
2051
                        !test_utils::extract_text(&content).contains("<|tool▁calls▁end|>"),
2052
2053
2054
2055
2056
2057
2058
                        "Should not contain deepseek special tokens in content"
                    );
                }
            }
        }
    }

2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
    #[tokio::test]
    async fn test_jailed_stream_qwen3_coder_parser() {
        // Input:
        // "I'll call a function. "
        // + "<tool_call><function=get_weather><parameter=location>San Francisco</parameter><parameter=unit>celsius</parameter></function></tool_call>"
        // + " Done."
        // Expected output: 3 chunks [Content(), ToolCall(), Content()]
        let chunks = vec![
            create_mock_response_chunk("I'll call a function. ".to_string(), 0),
            create_mock_response_chunk("<tool_call>".to_string(), 0),
            create_mock_response_chunk("<function=get_weather>".to_string(), 0),
            create_mock_response_chunk(
                "<parameter=location>San Francisco</parameter>".to_string(),
                0,
            ),
            create_mock_response_chunk("<parameter=unit>celsius</parameter>".to_string(), 0),
            create_mock_response_chunk("</function>".to_string(), 0),
            create_mock_response_chunk("</tool_call>".to_string(), 0),
            create_mock_response_chunk(" Done.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        let jail = JailedStream::builder()
            .tool_call_parser("qwen3_coder")
            .build();

        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        // Verify exact output structure: [Content(), ToolCall(), Content()].
        test_utils::assert_content(&results[0], "I'll call a function. ");
        test_utils::assert_tool_call(
            &results[1],
            "get_weather",
            serde_json::json!({"location": "San Francisco", "unit": "celsius"}),
        );
        test_utils::assert_content(&results[2], " Done.");

        // Verify content reconstruction excludes tool calls.
        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "I'll call a function.  Done.");
    }

    #[tokio::test]
    async fn test_jailed_stream_qwen3_coder_multiple_params() {
2110
2111
        use dynamo_parsers::tool_calling::ToolDefinition;

2112
2113
2114
2115
2116
2117
2118
2119
2120
        let chunks = vec![
            create_mock_response_chunk("Let me search for that. ".to_string(), 0),
            create_mock_response_chunk(
                "<tool_call><function=web_search><parameter=query>Rust programming</parameter><parameter=max_results>10</parameter><parameter=filter>recent</parameter></function></tool_call>".to_string(),
                0,
            ),
            create_mock_response_chunk(" Searching now.".to_string(), 0),
        ];

2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
        // Define the web_search tool with its parameters
        let tool_defs = vec![ToolDefinition {
            name: "web_search".to_string(),
            parameters: Some(serde_json::json!({
                "type": "object",
                "properties": {
                    "query": {"type": "string"},
                    "max_results": {"type": "integer"},
                    "filter": {"type": "string"},
                },
            })),
        }];

2134
2135
2136
        let input_stream = stream::iter(chunks);
        let jail = JailedStream::builder()
            .tool_call_parser("qwen3_coder")
2137
            .tool_definitions(tool_defs)
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
            .build();

        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        assert_eq!(results.len(), 3, "Should have 3 chunks");

        test_utils::assert_content(&results[0], "Let me search for that. ");
        test_utils::assert_tool_call(
            &results[1],
            "web_search",
            serde_json::json!({
                "query": "Rust programming",
                "max_results": 10,
                "filter": "recent"
            }),
        );
        test_utils::assert_content(&results[2], " Searching now.");
    }

    #[tokio::test]
    async fn test_jailed_stream_xml_parser_config_tokens_auto_population() {
        // Tests that parser config tokens are auto-populated when using `.tool_call_parser()`.
        // This verifies the jail system reads `tool_call_start_token` and `tool_call_end_token`
        // from the `qwen3_coder` parser config.
        let chunks = vec![
            create_mock_response_chunk("Before tool call. ".to_string(), 0),
            create_mock_response_chunk("<tool_call>".to_string(), 0), // Default qwen3_coder token
            create_mock_response_chunk("<function=get_weather>".to_string(), 0),
            create_mock_response_chunk("<parameter=city>Seattle</parameter>".to_string(), 0),
            create_mock_response_chunk("</function>".to_string(), 0),
            create_mock_response_chunk("</tool_call>".to_string(), 0), // Default qwen3_coder token
            create_mock_response_chunk(" After tool call.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Create JailedStream using ONLY `.tool_call_parser()`.
        // This should auto-populate jail sequences from the qwen3_coder config
        let jail = JailedStream::builder()
            .tool_call_parser("qwen3_coder")
            .build();

        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        assert_eq!(
            results.len(),
            3,
            "Should have content, tool call, and trailing content"
        );

        test_utils::assert_content(&results[0], "Before tool call. ");
        test_utils::assert_tool_call(
            &results[1],
            "get_weather",
            serde_json::json!({"city": "Seattle"}),
        );
        test_utils::assert_content(&results[2], " After tool call.");

        let reconstructed = test_utils::reconstruct_content(&results);
        assert_eq!(reconstructed, "Before tool call.  After tool call.");
    }

    #[tokio::test]
    async fn test_jailed_stream_xml_manual_sequences_prevent_auto_population() {
        // Tests that manually setting jail sequences prevents auto-population.
        // This verifies the builder respects manual configuration over auto-population.
        //
        // When custom sequences are set, the default parser tokens (<tool_call>) should
        // NOT trigger jailing and should pass through as regular content.
        let chunks = vec![
            create_mock_response_chunk("Text with ".to_string(), 0),
            // Default qwen3_coder token - should NOT trigger jailing.
            create_mock_response_chunk("<tool_call>".to_string(), 0),
            create_mock_response_chunk("should not jail".to_string(), 0),
            create_mock_response_chunk("</tool_call>".to_string(), 0),
            create_mock_response_chunk(" because custom ".to_string(), 0),
            // Custom marker - this SHOULD trigger jailing since we register it below.
            create_mock_response_chunk("[[START]]".to_string(), 0),
            create_mock_response_chunk("jailed content".to_string(), 0),
            create_mock_response_chunk("[[END]]".to_string(), 0),
            create_mock_response_chunk(" text.".to_string(), 0),
        ];

        let input_stream = stream::iter(chunks);

        // Set custom jail sequences - this should prevent auto-population.
        // The default <tool_call> tokens should NOT trigger jailing.
        let jail = JailedStream::builder()
            .jail_start_sequence("[[START]]")
            .jail_end_sequence("[[END]]")
            .tool_call_parser("qwen3_coder")
            .build();

        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        // The exact number of chunks depends on emission mode (packed vs single-choice-per-chunk)
        // but we can verify the key behaviors:
        // 1. Default <tool_call> tokens pass through as content (not jailed)
        // 2. Custom [[START]]/[[END]] markers trigger jailing
        // 3. No tool calls are extracted (because jailed content isn't valid XML)

        // Find chunk(s) containing the default tokens that passed through.
        let default_token_chunks: Vec<_> = results
            .iter()
            .filter_map(|r| {
                r.data
                    .as_ref()
2245
                    .and_then(|d| d.inner.choices.first())
2246
2247
2248
                    .and_then(|c| c.delta.content.as_ref())
            })
            .filter(|content| {
2249
2250
                test_utils::extract_text(content).contains("<tool_call>")
                    || test_utils::extract_text(content).contains("should not jail")
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
            })
            .collect();

        assert!(
            !default_token_chunks.is_empty(),
            "Default <tool_call> should pass through as content when manual sequences are set"
        );

        // Find chunk containing the jailed content that was released.
        let jailed_chunk = results
            .iter()
            .filter_map(|r| {
                r.data
                    .as_ref()
2265
                    .and_then(|d| d.inner.choices.first())
2266
2267
                    .and_then(|c| c.delta.content.as_ref())
            })
2268
2269
2270
2271
            .find(|content| {
                test_utils::extract_text(content).contains("[[START]]")
                    && test_utils::extract_text(content).contains("jailed content")
            });
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287

        assert!(
            jailed_chunk.is_some(),
            "Custom markers should trigger jailing and accumulated content should be released"
        );

        // Since the custom markers include non-XML content, the parser should not extract tool calls.
        // The accumulated content "[[START]]jailed content[[END]]", although compatible with the
        // way we configured `jail` above, is not consistent with what `qwen_coder` expects, and
        // there is (at time of writing) no way to pass a parser instance - only a string that
        // internally gets mapped to default way of instantiating a particular parser.
        let tool_call_count = results
            .iter()
            .filter(|r| {
                r.data
                    .as_ref()
2288
                    .and_then(|d| d.inner.choices.first())
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
                    .and_then(|c| c.delta.tool_calls.as_ref())
                    .map(|tc| !tc.is_empty())
                    .unwrap_or(false)
            })
            .count();

        assert_eq!(
            tool_call_count, 0,
            "Should have 0 tool calls because jailed content doesn't match XML format"
        );

        // Verify content reconstruction - all original content should be preserved.
        let reconstructed = test_utils::reconstruct_content(&results);
        assert!(
            reconstructed.contains("<tool_call>") && reconstructed.contains("should not jail"),
            "Reconstructed content should include default tokens that passed through"
        );
        assert!(
            reconstructed.contains("[[START]]") && reconstructed.contains("jailed content"),
            "Reconstructed content should include jailed content with custom markers"
        );
    }

2312
    #[tokio::test]
Ryan Olson's avatar
Ryan Olson committed
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
    async fn test_jailed_stream_mistral_false_positive_curly() {
        // Curly brace in normal text should not trigger tool call detection for mistral
        let chunks = vec![
            create_mock_response_chunk("Hey How".to_string(), 0),
            create_mock_response_chunk("are { you? ".to_string(), 0),
            create_final_response_chunk(0),
        ];

        let input_stream = stream::iter(chunks);
        let jail = JailedStream::builder().tool_call_parser("mistral").build();
2323
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357

        assert!(results.len() >= 2);
        assert_content(&results[0], "Hey How");
        assert!(
            results.iter().any(|r| extract_content(r) == "are { you? "),
            "Should preserve the literal text with curly brace"
        );
        for (i, r) in results.iter().enumerate() {
            assert!(
                !has_tool_call(r),
                "Result {} should not contain tool calls for false-positive text",
                i
            );
        }
    }

    #[tokio::test]
    #[ignore]
    // TODO: This needs to be fixed in parser library. P1 priority.
    async fn test_jailed_stream_mistral_false_positive_then_tool_calls_marker() {
        // Normal text with curly brace followed by explicit [TOOL_CALLS] marker should parse tool call
        let chunks = vec![
            create_mock_response_chunk("Hey How".to_string(), 0),
            create_mock_response_chunk("are { you? ".to_string(), 0),
            create_mock_response_chunk("[TOOL_CALLS]".to_string(), 0),
            create_mock_response_chunk(
                "[{\"name\": \"get_weather\", \"arguments\": {\"location\": \"San Francisco\", \"unit\": \"fahrenheit\"}}]"
                    .to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(chunks);
        let jail = JailedStream::builder().tool_call_parser("mistral").build();
2358
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
Ryan Olson's avatar
Ryan Olson committed
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382

        // Should preserve earlier content and also produce a tool call
        assert!(results.len() >= 2);

        assert!(
            results.iter().any(|r| extract_content(r) == "Hey How"),
            "Should include initial content"
        );
        assert!(
            results.iter().any(|r| extract_content(r) == "{ you? "),
            "Should include content preceding the marker"
        );

        let tool_call_idx = results
            .iter()
            .position(test_utils::has_tool_call)
            .expect("Should have a tool call result");
        test_utils::assert_tool_call(
            &results[tool_call_idx],
            "get_weather",
            json!({"location": "San Francisco", "unit": "fahrenheit"}),
        );
    }
}
2383
2384
2385
2386
2387
2388

// Comprehensive parallel tool calling jail tests
#[cfg(test)]
mod parallel_jail_tests {
    use super::tests::test_utils;
    use super::*;
2389
    use dynamo_protocols::types::ChatCompletionMessageContent;
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
    use futures::StreamExt;
    use futures::stream;
    use serde_json::json;

    /// Helper function to create a mock response chunk with multiple choices
    fn create_multi_choice_response_chunk(
        contents: Vec<String>,
    ) -> Annotated<NvCreateChatCompletionStreamResponse> {
        let choices: Vec<ChatChoiceStream> = contents
            .into_iter()
            .enumerate()
            .map(|(i, content)| {
                #[allow(deprecated)]
                ChatChoiceStream {
                    index: i as u32,
                    delta: ChatCompletionStreamResponseDelta {
                        role: Some(Role::Assistant),
2407
                        content: Some(ChatCompletionMessageContent::Text(content)),
2408
2409
2410
2411
2412
2413
                        tool_calls: None,
                        function_call: None,
                        refusal: None,
                        reasoning_content: None,
                    },
                    finish_reason: None,
2414
                    stop_reason: None,
2415
2416
2417
2418
2419
2420
                    logprobs: None,
                }
            })
            .collect();

        let response = NvCreateChatCompletionStreamResponse {
2421
            inner: dynamo_protocols::types::CreateChatCompletionStreamResponse {
2422
2423
2424
2425
2426
2427
2428
2429
2430
                id: "test-id".to_string(),
                choices,
                created: 1234567890,
                model: "test-model".to_string(),
                system_fingerprint: Some("test-fingerprint".to_string()),
                object: "chat.completion.chunk".to_string(),
                usage: None,
                service_tier: None,
            },
2431
            nvext: None,
2432
2433
2434
2435
2436
2437
2438
        };

        Annotated {
            data: Some(response),
            id: None,
            event: None,
            comment: None,
2439
            error: None,
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
        }
    }

    /// Helper function to validate parallel tool call results in streaming format
    fn validate_parallel_streaming_tool_calls(
        results: &[Annotated<NvCreateChatCompletionStreamResponse>],
        expected_tool_calls: &[(&str, serde_json::Value)],
    ) {
        // Find results with tool calls
        let tool_call_results: Vec<_> = results
            .iter()
            .filter(|r| {
                r.data
                    .as_ref()
2454
                    .is_some_and(|d| d.inner.choices.iter().any(|c| c.delta.tool_calls.is_some()))
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
            })
            .collect();

        assert!(
            !tool_call_results.is_empty(),
            "Should have at least one tool call result"
        );

        // Collect all tool calls from all results
        let mut all_tool_calls = Vec::new();
        for result in &tool_call_results {
            if let Some(ref data) = result.data {
2467
                for choice in &data.inner.choices {
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
                    if let Some(ref tool_calls) = choice.delta.tool_calls {
                        all_tool_calls.extend(tool_calls.iter());
                    }
                }
            }
        }

        assert_eq!(
            all_tool_calls.len(),
            expected_tool_calls.len(),
            "Expected {} tool calls, got {}",
            expected_tool_calls.len(),
            all_tool_calls.len()
        );

        // Validate each tool call
        for (i, (expected_name, expected_args)) in expected_tool_calls.iter().enumerate() {
            let tool_call = &all_tool_calls[i];
            assert!(tool_call.id.is_some(), "Tool call {} should have an ID", i);
2487
2488
2489
2490
2491
2492
2493

            assert_eq!(
                tool_call.index, i as u32,
                "Tool call {} should have index {}, got {}",
                i, i, tool_call.index
            );

2494
2495
            assert_eq!(
                tool_call.r#type,
2496
                Some(dynamo_protocols::types::FunctionType::Function),
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
                "Tool call {} should be of type 'function'",
                i
            );

            if let Some(ref function) = tool_call.function {
                assert_eq!(
                    function.name.as_deref(),
                    Some(*expected_name),
                    "Tool call {} name should be {}",
                    i,
                    expected_name
                );

                if let Some(ref args_str) = function.arguments {
                    let parsed_args: serde_json::Value =
                        serde_json::from_str(args_str).expect("Arguments should be valid JSON");
                    assert_eq!(
                        parsed_args, *expected_args,
                        "Tool call {} arguments should match expected",
                        i
                    );
                }
            }
        }
    }

    // =============================================================================
    // 1. PARALLEL TOOL CALLS IN SINGLE CHUNK
    // =============================================================================

    #[tokio::test]
    async fn test_parallel_tool_calls_single_chunk_nemotron() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(
                r#"<TOOLCALL>[
    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}
]</TOOLCALL>"#.to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
2544
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592

        // Should have tool call results
        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX", "unit": "fahrenheit"}),
            ),
            (
                "get_current_weather",
                json!({"city": "Orlando", "state": "FL", "unit": "fahrenheit"}),
            ),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);
    }

    #[tokio::test]
    async fn test_parallel_tool_calls_single_chunk_mistral() {
        let jail = JailedStream::builder().tool_call_parser("mistral").build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(
                r#"[TOOL_CALLS][{"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}}, {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}][/TOOL_CALLS]"#.to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX", "unit": "fahrenheit"}),
            ),
            (
                "get_current_weather",
                json!({"city": "Orlando", "state": "FL", "unit": "fahrenheit"}),
            ),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);
    }

2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
    /// Regression test for issue #6822:
    /// Hermes-style parallel tool calls in a single chunk must produce N tool call
    /// results, not 1 call + trailing raw XML text.
    #[tokio::test]
    async fn test_parallel_tool_calls_single_chunk_hermes() {
        let jail = JailedStream::builder().tool_call_parser("hermes").build();

        // Two parallel calls arrive in one streaming chunk (hermes uses JSON inside tags).
        let input_chunks = vec![test_utils::create_mock_response_chunk(
            "<tool_call>\n\
{\"name\": \"get_current_weather\", \"arguments\": {\"city\": \"Dallas\", \"state\": \"TX\"}}\n\
</tool_call>\n\
<tool_call>\n\
{\"name\": \"get_current_weather\", \"arguments\": {\"city\": \"Orlando\", \"state\": \"FL\"}}\n\
</tool_call>"
                .to_string(),
            0,
        )];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX"}),
            ),
            (
                "get_current_weather",
                json!({"city": "Orlando", "state": "FL"}),
            ),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);

        // Verify that raw XML does not leak as text content (the original bug).
        for result in &results {
            if let Some(ref data) = result.data {
                for choice in &data.inner.choices {
                    if let Some(ref content) = choice.delta.content {
                        let text = test_utils::extract_text(content);
                        assert!(
                            !text.contains("<tool_call>"),
                            "Raw XML must not leak as text content, got: {text:?}"
                        );
                    }
                }
            }
        }
    }

    /// Regression test for issue #6822:
    /// Qwen3Coder-style parallel tool calls in a single chunk must produce N tool
    /// call results (identical format to hermes, different parser name).
    #[tokio::test]
    async fn test_parallel_tool_calls_single_chunk_qwen3_coder() {
        let jail = JailedStream::builder()
            .tool_call_parser("qwen3_coder")
            .build();

        let input_chunks = vec![test_utils::create_mock_response_chunk(
            "<tool_call>\n\
<function=search>\n\
<parameter=query>Rust async</parameter>\n\
</function>\n\
</tool_call>\n\
<tool_call>\n\
<function=search>\n\
<parameter=query>Python async</parameter>\n\
</function>\n\
</tool_call>"
                .to_string(),
            0,
        )];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            ("search", json!({"query": "Rust async"})),
            ("search", json!({"query": "Python async"})),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);
    }

2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
    // =============================================================================
    // 2. PARALLEL TOOL CALLS ACROSS MULTIPLE CHUNKS (STREAMING)
    // =============================================================================

    #[tokio::test]
    async fn test_parallel_tool_calls_streaming_chunks() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk("<TOOLCALL>[".to_string(), 0),
            test_utils::create_mock_response_chunk(
                r#"    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},"#.to_string(),
                0,
            ),
            test_utils::create_mock_response_chunk(
                r#"    {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}"#.to_string(),
                0,
            ),
            test_utils::create_mock_response_chunk("]</TOOLCALL>".to_string(), 0),
        ];

        let input_stream = stream::iter(input_chunks);
2707
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743

        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX", "unit": "fahrenheit"}),
            ),
            (
                "get_current_weather",
                json!({"city": "Orlando", "state": "FL", "unit": "fahrenheit"}),
            ),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);
    }

    #[tokio::test]
    async fn test_parallel_tool_calls_with_normal_text_before_and_after() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk("I'll check the weather for both cities. ".to_string(), 0),
            test_utils::create_mock_response_chunk(
                r#"<TOOLCALL>[
    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}
]</TOOLCALL>"#.to_string(),
                0,
            ),
            test_utils::create_mock_response_chunk(" Let me get that information for you.".to_string(), 0),
        ];

        let input_stream = stream::iter(input_chunks);
2744
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
2745
2746
2747
2748
2749
2750

        assert!(!results.is_empty(), "Should have results");

        // Should have normal text before tool calls
        let normal_text_before = results.iter().find(|r| {
            r.data.as_ref().is_some_and(|d| {
2751
                d.inner.choices.iter().any(|c| {
2752
2753
2754
                    c.delta.content.as_ref().is_some_and(|content| {
                        test_utils::extract_text(content).contains("I'll check the weather")
                    })
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
                })
            })
        });
        assert!(
            normal_text_before.is_some(),
            "Should have normal text before tool calls"
        );

        // Should have tool calls
        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX", "unit": "fahrenheit"}),
            ),
            (
                "get_current_weather",
                json!({"city": "Orlando", "state": "FL", "unit": "fahrenheit"}),
            ),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);

        // Should have normal text after tool calls
        let normal_text_after = results.iter().find(|r| {
            r.data.as_ref().is_some_and(|d| {
2780
                d.inner.choices.iter().any(|c| {
2781
2782
2783
                    c.delta.content.as_ref().is_some_and(|content| {
                        test_utils::extract_text(content).contains("Let me get that information")
                    })
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
                })
            })
        });
        assert!(
            normal_text_after.is_some(),
            "Should have normal text after tool calls"
        );
    }

    // =============================================================================
    // 3. MULTIPLE CHOICES WITH PARALLEL TOOL CALLS
    // =============================================================================

    #[tokio::test]
    async fn test_multiple_choices_with_parallel_tool_calls() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .emission_mode(dynamo_llm::protocols::openai::chat_completions::jail::EmissionMode::SingleChoicePerChunk)
            .build();

        let input_chunks = vec![
            create_multi_choice_response_chunk(vec![
                r#"<TOOLCALL>[{"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}}]</TOOLCALL>"#.to_string(),
                r#"<TOOLCALL>[{"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}]</TOOLCALL>"#.to_string(),
            ]),
        ];

        let input_stream = stream::iter(input_chunks);
2812
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
2813
2814
2815
2816
2817
2818
2819
2820

        assert!(!results.is_empty(), "Should have results");

        // Should have tool calls from both choices
        let tool_call_count = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
2821
2822
                    d.inner
                        .choices
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
                        .iter()
                        .map(|c| c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len()))
                        .sum::<usize>()
                })
            })
            .sum::<usize>();

        assert!(
            tool_call_count >= 2,
            "Should have at least 2 tool calls from different choices"
        );
    }

    // =============================================================================
    // 4. MIXED TOOL TYPES IN PARALLEL CALLS
    // =============================================================================

    #[tokio::test]
    async fn test_parallel_mixed_tool_types_streaming() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(
                r#"<TOOLCALL>[
    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},
    {"name": "web_search", "arguments": {"query": "Orlando Florida attractions", "max_results": 5}},
    {"name": "get_user_location", "arguments": {"ip_address": "192.168.1.1"}}
]</TOOLCALL>"#.to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        let expected_calls = [
            (
                "get_current_weather",
                json!({"city": "Dallas", "state": "TX", "unit": "fahrenheit"}),
            ),
            (
                "web_search",
                json!({"query": "Orlando Florida attractions", "max_results": 5}),
            ),
            ("get_user_location", json!({"ip_address": "192.168.1.1"})),
        ];

        validate_parallel_streaming_tool_calls(&results, &expected_calls);
    }

    // =============================================================================
    // 5. LARGE SCALE PARALLEL CALLS (5+ TOOLS)
    // =============================================================================

    #[tokio::test]
    async fn test_large_scale_parallel_tool_calls() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(
                r#"<TOOLCALL>[
    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Seattle", "state": "WA", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Denver", "state": "CO", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Miami", "state": "FL", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Phoenix", "state": "AZ", "unit": "fahrenheit"}},
    {"name": "get_current_weather", "arguments": {"city": "Chicago", "state": "IL", "unit": "fahrenheit"}}
]</TOOLCALL>"#.to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        // Should have 7 tool calls
        let tool_call_count = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
2912
2913
                    d.inner
                        .choices
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
                        .iter()
                        .map(|c| c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len()))
                        .sum::<usize>()
                })
            })
            .sum::<usize>();

        assert_eq!(tool_call_count, 7, "Should have exactly 7 tool calls");
    }

    // =============================================================================
    // 6. COMPLEX NESTED ARGUMENTS IN PARALLEL CALLS
    // =============================================================================

    #[tokio::test]
    async fn test_parallel_complex_nested_arguments() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![test_utils::create_mock_response_chunk(
            r#"<TOOLCALL>[
    {
        "name": "get_weather_forecast",
        "arguments": {
            "location": {
                "city": "Dallas",
                "state": "TX",
                "country": "USA",
                "coordinates": {"lat": 32.7767, "lon": -96.7970}
            },
            "options": {
                "days": 7,
                "units": "fahrenheit",
                "include_hourly": true,
                "include_alerts": true,
                "metrics": ["temperature", "humidity", "wind_speed", "precipitation"]
            }
        }
    },
    {
        "name": "get_air_quality_data",
        "arguments": {
            "location": {
                "coordinates": {"lat": 32.7767, "lon": -96.7970},
                "radius_km": 25
            },
            "pollutants": ["pm2.5", "pm10", "ozone", "no2", "so2", "co"],
            "time_range": {
                "start": "2024-01-01T00:00:00Z",
                "end": "2024-01-07T23:59:59Z"
            }
        }
    }
]</TOOLCALL>"#
                .to_string(),
            0,
        )];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        // Should have 2 tool calls with complex nested arguments
        let tool_call_count = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
2983
2984
                    d.inner
                        .choices
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
                        .iter()
                        .map(|c| c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len()))
                        .sum::<usize>()
                })
            })
            .sum::<usize>();

        assert_eq!(tool_call_count, 2, "Should have exactly 2 tool calls");

        // Validate that complex nested structures are preserved
        let tool_call_results: Vec<_> = results
            .iter()
            .filter(|r| {
                r.data
                    .as_ref()
3000
                    .is_some_and(|d| d.inner.choices.iter().any(|c| c.delta.tool_calls.is_some()))
3001
3002
3003
3004
3005
3006
            })
            .collect();

        if let Some(result) = tool_call_results.first()
            && let Some(ref data) = result.data
        {
3007
            for choice in &data.inner.choices {
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
                if let Some(ref tool_calls) = choice.delta.tool_calls {
                    for tool_call in tool_calls {
                        if let Some(ref function) = tool_call.function
                            && let Some(args_str) = &function.arguments
                        {
                            let parsed_args: serde_json::Value = serde_json::from_str(args_str)
                                .expect("Arguments should be valid JSON");

                            // Verify nested structure is preserved
                            if function.name.as_deref() == Some("get_weather_forecast") {
                                assert!(parsed_args["location"]["coordinates"]["lat"].is_number());
                                assert!(parsed_args["options"]["metrics"].is_array());
                            } else if function.name.as_deref() == Some("get_air_quality_data") {
                                assert!(parsed_args["pollutants"].is_array());
                                assert!(parsed_args["time_range"]["start"].is_string());
                            }
                        }
                    }
                }
            }
        }
    }

    // =============================================================================
    // 7. ERROR HANDLING AND EDGE CASES
    // =============================================================================

    #[tokio::test]
    async fn test_parallel_partial_malformed_calls() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(
                r#"<TOOLCALL>[
    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},
    {"invalid": "malformed_call"},
    {"name": "get_current_weather", "arguments": {"city": "Orlando", "state": "FL", "unit": "fahrenheit"}}
]</TOOLCALL>"#.to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
3053
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
3054
3055
3056
3057
3058
3059
3060
3061

        assert!(!results.is_empty(), "Should have results");

        // Should still parse the valid tool calls despite the malformed one
        let tool_call_count = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
3062
3063
                    d.inner
                        .choices
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
                        .iter()
                        .map(|c| c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len()))
                        .sum::<usize>()
                })
            })
            .sum::<usize>();

        // Should have at least the valid tool calls
        assert!(
            tool_call_count >= 1,
            "Should have at least 1 valid tool call"
        );
    }

    #[tokio::test]
    async fn test_parallel_streaming_interrupted() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        // Simulate a stream that gets cut off mid-tool-call
        let input_chunks = vec![
            test_utils::create_mock_response_chunk("<TOOLCALL>[".to_string(), 0),
            test_utils::create_mock_response_chunk(
                r#"    {"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}},"#.to_string(),
                0,
            ),
            test_utils::create_mock_response_chunk(
                r#"    {"name": "get_current_weather", "arguments": {"city": "Orlando""#.to_string(),
                0,
            ),
            // Stream ends abruptly without closing the JSON array or TOOLCALL tag
        ];

        let input_stream = stream::iter(input_chunks);
3099
        let results: Vec<_> = jail.apply_with_finish_reason(input_stream).collect().await;
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109

        // Should still handle the incomplete stream gracefully
        assert!(
            !results.is_empty(),
            "Should have results even with incomplete stream"
        );

        // Should try to parse whatever content was accumulated
        let has_some_content = results.iter().any(|r| {
            r.data.as_ref().is_some_and(|d| {
3110
3111
                d.inner
                    .choices
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
                    .iter()
                    .any(|c| c.delta.content.is_some() || c.delta.tool_calls.is_some())
            })
        });

        assert!(
            has_some_content,
            "Should have some content despite incomplete stream"
        );
    }

    #[tokio::test]
    async fn test_parallel_empty_tool_calls_array() {
        let jail = JailedStream::builder()
            .tool_call_parser("nemotron_deci")
            .build();

        let input_chunks = vec![
            test_utils::create_mock_response_chunk("I'll help you with that. ".to_string(), 0),
            test_utils::create_mock_response_chunk("<TOOLCALL>[]</TOOLCALL>".to_string(), 0),
            test_utils::create_mock_response_chunk(
                " Actually, I don't need any tools for this.".to_string(),
                0,
            ),
        ];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = jail.apply(input_stream).collect().await;

        assert!(!results.is_empty(), "Should have results");

        // Should have normal text content but no tool calls
        let has_normal_text = results.iter().any(|r| {
            r.data.as_ref().is_some_and(|d| {
3146
                d.inner.choices.iter().any(|c| {
3147
                    c.delta.content.as_ref().is_some_and(|content| {
3148
3149
                        test_utils::extract_text(content).contains("I'll help you")
                            || test_utils::extract_text(content).contains("don't need any tools")
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
                    })
                })
            })
        });

        assert!(has_normal_text, "Should have normal text content");

        let tool_call_count = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
3161
3162
                    d.inner
                        .choices
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
                        .iter()
                        .map(|c| c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len()))
                        .sum::<usize>()
                })
            })
            .sum::<usize>();

        assert_eq!(
            tool_call_count, 0,
            "Should have no tool calls for empty array"
        );
    }
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345

    /// Regression test for #6821: tool_choice=required with qwen3_coder parser.
    ///
    /// When tool_choice=required AND a tool_call_parser (e.g. qwen3_coder) is
    /// configured, the jail must use marker-based mode so the parser handles the
    /// XML output.  Previously this fell through to Immediate JSON mode which
    /// could not parse qwen3_coder XML, causing raw XML to leak as content.
    #[tokio::test]
    async fn test_tool_choice_required_with_qwen3_coder_parser() {
        // Simulate qwen3_coder XML output for a single tool call
        let xml_output = r#"<tool_call>
<function=get_weather>
<parameter=city>
San Francisco
</parameter>
<parameter=unit>
fahrenheit
</parameter>
</function>
</tool_call>"#;

        let input_chunks = vec![test_utils::create_mock_response_chunk(
            xml_output.to_string(),
            0,
        )];

        let input_stream = stream::iter(input_chunks);
        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("qwen3_coder".to_string()),
            Some(ChatCompletionToolChoiceOption::Required),
            None,
            input_stream,
        )
        .collect()
        .await;

        // Should have parsed a tool call, not leaked raw XML as content
        let tool_call_count: usize = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
                    d.inner
                        .choices
                        .iter()
                        .map(|c: &ChatChoiceStream| {
                            c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len())
                        })
                        .sum::<usize>()
                })
            })
            .sum();

        assert!(
            tool_call_count >= 1,
            "tool_choice=required with qwen3_coder should produce at least one tool call, got {}",
            tool_call_count
        );

        // Verify the tool call was parsed correctly
        for r in &results {
            if let Some(data) = &r.data {
                for choice in &data.inner.choices {
                    if let Some(tool_calls) = &choice.delta.tool_calls {
                        for tc in tool_calls {
                            assert_eq!(
                                tc.function.as_ref().unwrap().name.as_deref(),
                                Some("get_weather"),
                                "Tool call name should be 'get_weather'"
                            );
                        }
                    }
                    // Content should be empty, not raw XML
                    if let Some(content) = &choice.delta.content {
                        let text = test_utils::extract_text(content);
                        assert!(
                            !text.contains("<tool_call>"),
                            "Raw XML should not leak as content, got: {}",
                            text
                        );
                    }
                }
            }
        }
    }

    /// Test for tool_choice=named with qwen3_coder parser and named_tool_filter.
    ///
    /// When tool_choice=named is used with a specific tool_name, the
    /// preprocessor decision logic should apply the named_tool_filter to ensure
    /// only the requested tool is parsed, even if the model emits other tools.
    #[tokio::test]
    async fn test_tool_choice_named_with_qwen3_coder_parser() {
        // Simulate qwen3_coder XML output for a single tool call
        let xml_output = r#"<tool_call>
<function=get_weather>
<parameter=city>
San Francisco
</parameter>
<parameter=unit>
fahrenheit
</parameter>
</function>
</tool_call>"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(xml_output.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let input_stream = stream::iter(input_chunks);

        // Apply tool_choice=named for get_weather
        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("qwen3_coder".to_string()),
            Some(ChatCompletionToolChoiceOption::Named(
                "get_weather".to_string().into(),
            )),
            None,
            input_stream,
        )
        .collect()
        .await;

        // Should have parsed the named tool call
        let tool_call_count: usize = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
                    d.inner
                        .choices
                        .iter()
                        .map(|c: &ChatChoiceStream| {
                            c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len())
                        })
                        .sum::<usize>()
                })
            })
            .sum();

        assert!(
            tool_call_count >= 1,
            "tool_choice=named with qwen3_coder should produce at least one tool call, got {}",
            tool_call_count
        );

        // Verify the tool call was parsed correctly and matches the named tool
        for r in &results {
            if let Some(data) = &r.data {
                for choice in &data.inner.choices {
                    if let Some(tool_calls) = &choice.delta.tool_calls {
                        for tc in tool_calls {
                            assert_eq!(
                                tc.function.as_ref().unwrap().name.as_deref(),
                                Some("get_weather"),
                                "Tool call name should match the named tool choice"
                            );
                        }
                    }
                    // Content should be empty, not raw XML
                    if let Some(content) = &choice.delta.content {
                        let text = test_utils::extract_text(content);
                        assert!(
                            !text.contains("<tool_call>"),
                            "Raw XML should not leak as content, got: {}",
                            text
                        );
                    }
                }
            }
        }

3346
3347
        // OpenAI spec: whenever tool_calls are emitted, finish_reason must be
        // ToolCalls — regardless of whether tool_choice was auto, required, or named.
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
        let finish_reasons: Vec<_> = results
            .iter()
            .filter_map(|r| {
                r.data
                    .as_ref()
                    .and_then(|d| d.inner.choices.first().and_then(|c| c.finish_reason))
            })
            .collect();

        assert!(
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
            finish_reasons.contains(&FinishReason::ToolCalls),
            "tool_choice=named with emitted tool_calls should have ToolCalls finish reason, got {:?}",
            finish_reasons
        );
    }

    /// tool_choice=required + parser configured + backend applied guided
    /// decoding → model emits a bare JSON array of tool calls.
    ///
    /// This is the minimax/SGLang-after-PR-#6620 regression: previously we
    /// fell through to the marker-based parser (looking for `<minimax:
    /// tool_call>` etc.) which cannot parse unmarked JSON, so tool_calls
    /// were empty and the JSON leaked into content/reasoning_content.
    /// The Immediate branch now routes through base_json_parser first.
    #[tokio::test]
    async fn test_tool_choice_required_with_parser_bare_json() {
        let bare_json = r#"[{"name":"get_weather","parameters":{"location":"San Francisco"}}]"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(bare_json.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("minimax_m2".to_string()),
            Some(ChatCompletionToolChoiceOption::Required),
            None,
            stream::iter(input_chunks),
        )
        .collect()
        .await;

        let tool_calls: Vec<_> = results
            .iter()
            .flat_map(|r| {
                r.data
                    .as_ref()
                    .into_iter()
                    .flat_map(|d| d.inner.choices.iter())
                    .flat_map(|c| c.delta.tool_calls.iter().flatten())
            })
            .cloned()
            .collect();

        assert_eq!(
            tool_calls.len(),
            1,
            "bare JSON array must be parsed by base_json_parser even when parser is set"
        );
        assert_eq!(
            tool_calls[0].function.as_ref().unwrap().name.as_deref(),
            Some("get_weather")
        );

        // finish_reason should be rewritten to ToolCalls (required path).
        let finish_reasons: Vec<_> = results
            .iter()
            .filter_map(|r| {
                r.data
                    .as_ref()
                    .and_then(|d| d.inner.choices.first().and_then(|c| c.finish_reason))
            })
            .collect();
        assert!(
            finish_reasons.contains(&FinishReason::ToolCalls),
            "tool_choice=required with tool_calls emitted should have ToolCalls finish_reason"
        );

        // No raw JSON leaked as content.
        for r in &results {
            if let Some(data) = &r.data {
                for choice in &data.inner.choices {
                    if let Some(content) = &choice.delta.content {
                        let text = test_utils::extract_text(content);
                        assert!(
                            !text.contains("get_weather"),
                            "tool call JSON should not leak as content, got: {}",
                            text
                        );
                    }
                }
            }
        }
    }

    /// tool_choice=required with the alternate `arguments` key (SGLang's
    /// JsonArrayParser and some vLLM paths emit this variant).  The
    /// base_json_parser accepts either `parameters` or `arguments`.
    #[tokio::test]
    async fn test_tool_choice_required_bare_json_with_arguments_key() {
        let bare_json = r#"[{"name":"get_weather","arguments":{"location":"Paris"}}]"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(bare_json.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("hermes".to_string()),
            Some(ChatCompletionToolChoiceOption::Required),
            None,
            stream::iter(input_chunks),
        )
        .collect()
        .await;

        let tool_calls: Vec<_> = results
            .iter()
            .flat_map(|r| {
                r.data
                    .as_ref()
                    .into_iter()
                    .flat_map(|d| d.inner.choices.iter())
                    .flat_map(|c| c.delta.tool_calls.iter().flatten())
            })
            .cloned()
            .collect();

        assert_eq!(
            tool_calls.len(),
            1,
            "base_json_parser must accept the `arguments` key variant"
        );
        let args = tool_calls[0]
            .function
            .as_ref()
            .and_then(|f| f.arguments.as_deref())
            .unwrap_or_default();
        assert!(
            args.contains("Paris"),
            "arguments should carry the parameters payload, got: {}",
            args
        );
    }

    /// tool_choice=named + parser configured + bare JSON array from guided
    /// decoding.  The call must be parsed (by base_json_parser) and the
    /// named-tool filter must accept a matching name; finish_reason stays
    /// Stop per OpenAI spec for named tool_choice.
    #[tokio::test]
    async fn test_tool_choice_named_with_parser_bare_json() {
        let bare_json = r#"[{"name":"get_weather","parameters":{"location":"Tokyo"}}]"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(bare_json.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("minimax_m2".to_string()),
            Some(ChatCompletionToolChoiceOption::Named(
                "get_weather".to_string().into(),
            )),
            None,
            stream::iter(input_chunks),
        )
        .collect()
        .await;

        let tool_calls: Vec<_> = results
            .iter()
            .flat_map(|r| {
                r.data
                    .as_ref()
                    .into_iter()
                    .flat_map(|d| d.inner.choices.iter())
                    .flat_map(|c| c.delta.tool_calls.iter().flatten())
            })
            .cloned()
            .collect();

        assert_eq!(tool_calls.len(), 1);
        assert_eq!(
            tool_calls[0].function.as_ref().unwrap().name.as_deref(),
            Some("get_weather")
        );

        // OpenAI spec: whenever tool_calls are emitted, finish_reason must be
        // ToolCalls — regardless of whether tool_choice was auto, required, or named.
        let finish_reasons: Vec<_> = results
            .iter()
            .filter_map(|r| {
                r.data
                    .as_ref()
                    .and_then(|d| d.inner.choices.first().and_then(|c| c.finish_reason))
            })
            .collect();
        assert!(
            finish_reasons.contains(&FinishReason::ToolCalls),
            "tool_choice=named with emitted tool_calls should be rewritten to ToolCalls, got {:?}",
            finish_reasons
        );
    }

    /// tool_choice=named + parser + bare JSON where the model emits a
    /// different tool than requested.  The named_tool_filter must drop
    /// the mismatched call so nothing is emitted as a tool call.
    #[tokio::test]
    async fn test_tool_choice_named_bare_json_wrong_tool_filtered() {
        let bare_json = r#"[{"name":"search","parameters":{"q":"foo"}}]"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(bare_json.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            Some("minimax_m2".to_string()),
            Some(ChatCompletionToolChoiceOption::Named(
                "get_weather".to_string().into(),
            )),
            None,
            stream::iter(input_chunks),
        )
        .collect()
        .await;

        let tool_call_count: usize = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
                    d.inner
                        .choices
                        .iter()
                        .map(|c: &ChatChoiceStream| {
                            c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len())
                        })
                        .sum::<usize>()
                })
            })
            .sum();

        assert_eq!(
            tool_call_count, 0,
            "named_tool_filter must drop tool calls whose name doesn't match the requested tool"
        );
    }

    #[tokio::test]
    async fn test_tool_choice_named_no_parser_bare_json_wrong_tool_filtered() {
        // Regression: with tool_choice=Named and NO parser, the base-JSON
        // parser (step 1 in create_tool_call_choice) can now parse arbitrary
        // JSON arrays. The named filter must still apply or a mismatched
        // tool name would leak to the client.
        let bare_json = r#"[{"name":"search","parameters":{"q":"foo"}}]"#;

        let input_chunks = vec![
            test_utils::create_mock_response_chunk(bare_json.to_string(), 0),
            test_utils::create_final_response_chunk(0),
        ];

        let results: Vec<_> = OpenAIPreprocessor::apply_tool_calling_jail(
            None,
            Some(ChatCompletionToolChoiceOption::Named(
                "get_weather".to_string().into(),
            )),
            None,
            stream::iter(input_chunks),
        )
        .collect()
        .await;

        let tool_call_count: usize = results
            .iter()
            .map(|r| {
                r.data.as_ref().map_or(0, |d| {
                    d.inner
                        .choices
                        .iter()
                        .map(|c: &ChatChoiceStream| {
                            c.delta.tool_calls.as_ref().map_or(0, |tc| tc.len())
                        })
                        .sum::<usize>()
                })
            })
            .sum();

        assert_eq!(
            tool_call_count, 0,
            "Named + no-parser: wrong-name tool call must be filtered"
        );

        // The filtered-out tool JSON must not leak as assistant content.
        let emitted_text: String = results
            .iter()
            .flat_map(|r| r.data.as_ref().map(|d| &d.inner.choices).into_iter())
            .flatten()
            .filter_map(|c| match c.delta.content.as_ref()? {
                ChatCompletionMessageContent::Text(t) => Some(t.as_str()),
                _ => None,
            })
            .collect();
        assert!(
            !emitted_text.contains("search"),
            "wrong-tool JSON leaked to content: {emitted_text:?}"
3653
3654
        );
    }
3655
}