test_vllm.py 16.4 KB
Newer Older
1
2
3
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

4
5
6
7
8
9
10
11
"""
Test Execution Times (Last Run: 2025-12-09):
- test_request_cancellation_vllm_aggregated: ~55s (gpu_1)
- test_request_cancellation_vllm_decode_cancel: ~53s (gpu_2)
- test_request_cancellation_vllm_prefill_cancel: ~53s (gpu_2)
- Total: 161.65s (0:02:41)
"""

12
13
14
15
16
17
import logging
import os
import shutil

import pytest

18
19
from tests.fault_tolerance.cancellation.utils import (
    DynamoFrontendProcess,
20
21
22
    poll_for_pattern,
    read_streaming_responses,
    send_cancellable_request,
23
)
Alec's avatar
Alec committed
24
from tests.utils.constants import FAULT_TOLERANCE_MODEL_NAME
25
from tests.utils.managed_process import ManagedProcess
26
from tests.utils.payloads import check_health_generate, check_models_api
27
from tests.utils.port_utils import allocate_port, deallocate_port
28
29
30

logger = logging.getLogger(__name__)

31
32
33
34
35
pytestmark = [
    pytest.mark.vllm,
    pytest.mark.gpu_1,
    pytest.mark.e2e,
    pytest.mark.model(FAULT_TOLERANCE_MODEL_NAME),
36
    pytest.mark.post_merge,  # post_merge to pinpoint failure commit
37
    pytest.mark.parametrize("request_plane", ["nats", "tcp"], indirect=True),
38
39
]

40
41
42
43

class DynamoWorkerProcess(ManagedProcess):
    """Process manager for Dynamo worker with vLLM backend"""

44
45
46
47
48
49
50
51
52
53
54
    def __init__(
        self,
        request,
        frontend_port: int,
        is_prefill: bool = False,
    ):
        # Allocate system port for this worker
        system_port = allocate_port(9100)
        self.system_port = system_port
        self.frontend_port = frontend_port

55
56
57
58
59
        command = [
            "python3",
            "-m",
            "dynamo.vllm",
            "--model",
Alec's avatar
Alec committed
60
            FAULT_TOLERANCE_MODEL_NAME,
61
62
63
64
            "--enforce-eager",
            "--gpu-memory-utilization",
            "0.45",
            "--max-model-len",
65
            "16384",
66
67
68
69
            "--migration-limit",
            "3",
        ]

70
        # Configure health check based on worker type
71
        if is_prefill:
72
            # Prefill workers check their own status endpoint
73
            command.append("--is-prefill-worker")
74
75
76
            health_check_urls = [
                (f"http://localhost:{system_port}/health", self.is_ready)
            ]
77
78
79
80
        else:
            # Decode workers should also check their own status endpoint first,
            # then verify the frontend sees the model
            health_check_urls = [
81
82
83
                (f"http://localhost:{system_port}/health", self.is_ready),
                (f"http://localhost:{frontend_port}/v1/models", check_models_api),
                (f"http://localhost:{frontend_port}/health", check_health_generate),
84
            ]
85

86
        # Set environment variables
87
        env = os.environ.copy()
88
89
        env["DYN_REQUEST_PLANE"] = request.getfixturevalue("request_plane")

90
        env["DYN_LOG"] = "debug"
91
92
93
94
95
        # Disable canary health check - these tests expect full control over requests
        # sent to the workers where canary health check intermittently sends dummy
        # requests to workers interfering with the test process which may cause
        # intermittent failures
        env["DYN_HEALTH_CHECK_ENABLED"] = "false"
96
        env["DYN_SYSTEM_USE_ENDPOINT_HEALTH_STATUS"] = '["generate"]'
97
98
        env["DYN_SYSTEM_PORT"] = str(system_port)
        env["DYN_HTTP_PORT"] = str(frontend_port)
99

100
101
102
        # Set KV event port and NIXL side channel port only for prefill worker
        # to avoid conflicts with decode worker
        if is_prefill:
103
104
105
106
            env["DYN_VLLM_KV_EVENT_PORT"] = "20082"  # TODO: use dynamic port allocation
            env[
                "VLLM_NIXL_SIDE_CHANNEL_PORT"
            ] = "5601"  # TODO: use dynamic port allocation
107

108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
        # Set log directory based on worker type
        worker_type = "prefill_worker" if is_prefill else "worker"
        log_dir = f"{request.node.name}_{worker_type}"

        # Clean up any existing log directory from previous runs
        try:
            shutil.rmtree(log_dir)
            logger.info(f"Cleaned up existing log directory: {log_dir}")
        except FileNotFoundError:
            # Directory doesn't exist, which is fine
            pass

        super().__init__(
            command=command,
            env=env,
123
            health_check_urls=health_check_urls,
124
125
126
            timeout=300,
            display_output=True,
            terminate_existing=False,
127
128
129
130
131
132
133
            # Ensure any orphaned vLLM engine cores or child helpers are cleaned up
            stragglers=[
                "VLLM::EngineCore",
            ],
            straggler_commands=[
                "-m dynamo.vllm",
            ],
134
135
136
137
138
139
140
141
142
            log_dir=log_dir,
        )

        self.is_prefill = is_prefill

    def get_pid(self):
        """Get the PID of the worker process"""
        return self.proc.pid if self.proc else None

143
144
145
146
147
148
149
150
151
152
    def __exit__(self, exc_type, exc_val, exc_tb):
        """Release allocated port when worker exits."""
        try:
            # system_port is always allocated in __init__
            deallocate_port(self.system_port)
        except Exception as e:
            logging.warning(f"Failed to release vLLM worker port: {e}")

        return super().__exit__(exc_type, exc_val, exc_tb)

153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
    def is_ready(self, response) -> bool:
        """Check the health of the worker process"""
        try:
            data = response.json()
            if data.get("status") == "ready":
                worker_type = "Prefill worker" if self.is_prefill else "Worker"
                logger.info(f"{worker_type} status is ready")
                return True
            worker_type = "Prefill worker" if self.is_prefill else "Worker"
            logger.warning(f"{worker_type} status is not ready: {data.get('status')}")
        except ValueError:
            worker_type = "Prefill worker" if self.is_prefill else "Worker"
            logger.warning(f"{worker_type} health response is not valid JSON")
        return False


169
@pytest.mark.timeout(110)  # 3x average
170
171
172
def test_request_cancellation_vllm_aggregated(
    request, runtime_services_dynamic_ports, predownload_models
):
173
    """
174
    End-to-end test for request cancellation functionality in aggregated mode.
175
176
177

    This test verifies that when a request is cancelled by the client,
    the system properly handles the cancellation and cleans up resources
178
    on the worker side in aggregated (single worker) mode. Tests three scenarios:
179
180
181
    1. Completion request
    2. Chat completion request (non-streaming)
    3. Chat completion request (streaming)
182
183
184
185
186

    Timing (Last Run: 2025-12-09): ~55s total
    - Engine initialization: ~15s
    - Testing 3 scenarios: ~38s (~12s each)
    - Teardown: ~2s
187
188
    """

189
    # Step 1: Start the frontend (allocates its own frontend_port)
190
191
192
    with DynamoFrontendProcess(request) as frontend:
        logger.info("Frontend started successfully")

193
194
        # Step 2: Start a single worker (allocates its own system_port)
        with DynamoWorkerProcess(request, frontend.frontend_port) as worker:
195
196
            logger.info(f"Worker PID: {worker.get_pid()}")

197
            # Step 3: Test request cancellation with polling approach
198
199
200
201
202
203
204
205
206
207
208
            frontend_log_offset, worker_log_offset = 0, 0

            test_scenarios = [
                ("completion", "Completion request cancellation"),
                ("chat_completion", "Chat completion request cancellation"),
                (
                    "chat_completion_stream",
                    "Chat completion stream request cancellation",
                ),
            ]

209
            for request_type, description in test_scenarios:
210
211
                logger.info(f"Testing {description.lower()}...")

212
                # Send the request (non-blocking)
213
214
215
                cancellable_req = send_cancellable_request(
                    frontend.frontend_port, request_type
                )
216

217
                # Poll for "Decode Request ID" pattern (vLLM v2 pattern)
218
219
                request_id, worker_log_offset = poll_for_pattern(
                    process=worker,
220
                    pattern="Decode Request ID: ",
221
222
                    log_offset=worker_log_offset,
                    match_type="contains",
223
                )
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244

                # For streaming, read 5 responses before cancelling
                if request_type == "chat_completion_stream":
                    read_streaming_responses(cancellable_req, expected_count=5)

                # Now cancel the request
                cancellable_req.cancel()
                logger.info(f"Cancelled request ID: {request_id}")

                # Poll for "Aborted Request ID" with matching ID
                _, worker_log_offset = poll_for_pattern(
                    process=worker,
                    pattern=f"Aborted Request ID: {request_id}",
                    log_offset=worker_log_offset,
                )

                # Verify frontend log has kill message
                _, frontend_log_offset = poll_for_pattern(
                    process=frontend,
                    pattern="issued control message Kill to sender",
                    log_offset=frontend_log_offset,
245
246
247
248
249
                )

                logger.info(f"{description} detected successfully")


250
@pytest.mark.timeout(150)  # 3x average
251
def test_request_cancellation_vllm_decode_cancel(
252
    request, runtime_services_dynamic_ports, set_ucx_tls_no_mm, predownload_models
Alec's avatar
Alec committed
253
):
254
    """
255
    End-to-end test for request cancellation during decode phase.
256

257
    This test verifies that when a request is cancelled by the client during the decode phase,
258
259
    the system properly handles the cancellation and cleans up resources
    on the decode worker side in a disaggregated setup.
260
261
262
263
264

    Timing (Last Run: 2025-12-09): ~53s total (requires 2 GPUs)
    - Engine initialization: ~23s (decode + prefill workers)
    - Testing stream cancellation during decode: ~28s
    - Teardown: ~2s
265
266
    """

267
    # Step 1: Start the frontend (allocates its own frontend_port)
268
269
270
    with DynamoFrontendProcess(request) as frontend:
        logger.info("Frontend started successfully")

271
272
273
274
        # Step 2: Start the prefill worker (allocates its own system_port)
        with DynamoWorkerProcess(
            request, frontend.frontend_port, is_prefill=True
        ) as prefill_worker:
275
276
            logger.info(f"Prefill Worker PID: {prefill_worker.get_pid()}")

277
278
279
280
            # Step 3: Start the decode worker (allocates its own system_port)
            with DynamoWorkerProcess(
                request, frontend.frontend_port, is_prefill=False
            ) as decode_worker:
281
282
                logger.info(f"Decode Worker PID: {decode_worker.get_pid()}")

283
                # Step 4: Test request cancellation for streaming scenario
284
                logger.info(
285
286
287
288
                    "Testing chat completion stream request cancellation in decode worker (decode phase)..."
                )

                # Send streaming request (non-blocking)
289
290
291
                cancellable_req = send_cancellable_request(
                    frontend.frontend_port, "chat_completion_stream"
                )
292

293
                # Poll for "Decode Request ID" pattern in decode worker (vLLM v2 pattern)
294
295
                request_id, decode_log_offset = poll_for_pattern(
                    process=decode_worker,
296
                    pattern="Decode Request ID: ",
297
298
299
                    match_type="contains",
                )

300
                # Verify same request ID reached prefill worker (as "Prefill Request ID")
301
302
                _, prefill_log_offset = poll_for_pattern(
                    process=prefill_worker,
303
                    pattern=f"Prefill Request ID: {request_id}",
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
                )

                # Read 5 streaming responses (decode phase)
                read_streaming_responses(cancellable_req, expected_count=5)

                # Now cancel the request
                cancellable_req.cancel()
                logger.info(f"Cancelled request ID: {request_id}")

                # Poll for "Aborted Request ID" in decode worker
                _, decode_log_offset = poll_for_pattern(
                    process=decode_worker,
                    pattern=f"Aborted Request ID: {request_id}",
                    log_offset=decode_log_offset,
                )

                # Verify frontend log has kill message
                _, frontend_log_offset = poll_for_pattern(
                    process=frontend,
                    pattern="issued control message Kill to sender",
324
325
326
                )

                logger.info(
327
                    "Chat completion stream cancellation in decode phase detected successfully"
328
329
330
                )


331
@pytest.mark.timeout(150)  # 3x average
332
def test_request_cancellation_vllm_prefill_cancel(
333
    request, runtime_services_dynamic_ports, set_ucx_tls_no_mm, predownload_models
334
):
335
    """
336
    End-to-end test for request cancellation during prefill phase.
337

338
    This test verifies that when a request is cancelled by the client during the prefill phase,
339
340
    the system properly handles the cancellation and cleans up resources
    on both the decode and prefill workers in a disaggregated setup.
341
342
343
344
345

    Timing (Last Run: 2025-12-09): ~53s total (requires 2 GPUs)
    - Engine initialization: ~23s (decode + prefill workers)
    - Testing cancellation during prefill: ~28s
    - Teardown: ~2s
346
    """
347

348
    # Step 1: Start the frontend (allocates its own frontend_port)
349
350
351
    with DynamoFrontendProcess(request) as frontend:
        logger.info("Frontend started successfully")

352
353
354
355
        # Step 2: Start the prefill worker (allocates its own system_port)
        with DynamoWorkerProcess(
            request, frontend.frontend_port, is_prefill=True
        ) as prefill_worker:
356
357
            logger.info(f"Prefill Worker PID: {prefill_worker.get_pid()}")

358
359
360
361
            # Step 3: Start the decode worker (allocates its own system_port)
            with DynamoWorkerProcess(
                request, frontend.frontend_port, is_prefill=False
            ) as decode_worker:
362
363
                logger.info(f"Decode Worker PID: {decode_worker.get_pid()}")

364
365
366
                # Step 4: Test request cancellation during prefill phase
                # Note: With the new architecture, prefill routing happens in the frontend,
                # so the request goes directly to the prefill worker first
367
                logger.info(
368
                    "Testing completion request cancellation during prefill phase..."
369
370
                )

371
372
                # Send request with long prompt (non-blocking)
                cancellable_req = send_cancellable_request(
373
                    frontend.frontend_port, "completion", use_long_prompt=True
374
                )
375

376
377
378
                # Poll for "Prefill Request ID" pattern in prefill worker (vLLM v2 pattern)
                # With new architecture, prefill is routed by frontend's internal router
                request_id, prefill_log_offset = poll_for_pattern(
379
                    process=prefill_worker,
380
381
                    pattern="Prefill Request ID: ",
                    match_type="contains",
382
383
384
385
                )

                # Cancel during prefill phase
                cancellable_req.cancel()
386
                logger.info(f"Cancelled request ID: {request_id} during prefill")
387

388
                # Poll for "Aborted Prefill Request ID" in prefill worker (where cancellation happens)
389
390
391
392
393
394
395
396
397
398
399
400
                _, prefill_log_offset = poll_for_pattern(
                    process=prefill_worker,
                    pattern=f"Aborted Prefill Request ID: {request_id}",
                    log_offset=prefill_log_offset,
                )

                # Verify frontend log has kill message
                _, frontend_log_offset = poll_for_pattern(
                    process=frontend,
                    pattern="issued control message Kill to sender",
                )

401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
                # Verify decode worker never received the request
                pattern = "Request ID: "
                try:
                    _, decode_log_offset = poll_for_pattern(
                        process=decode_worker,
                        pattern=pattern,
                        max_wait_ms=10,
                        match_type="contains",
                    )
                    pytest.fail(
                        "Decode worker received request cancelled during prefill phase"
                    )
                except AssertionError as e:
                    assert str(e).startswith(
                        f"Failed to find '{pattern}' pattern after 2 iterations "
                    ), f"Unexpected error: {e}"

418
                logger.info(
419
                    "Completion request cancellation during prefill phase detected successfully"
420
                )