endpoint.rs 11.6 KB
Newer Older
1
2
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
Ryan Olson's avatar
Ryan Olson committed
3

4
5
6
7
use std::sync::Arc;

use anyhow::Result;
use derive_builder::Builder;
Ryan Olson's avatar
Ryan Olson committed
8
use derive_getters::Dissolve;
9
use educe::Educe;
10
use tokio_util::sync::CancellationToken;
Ryan Olson's avatar
Ryan Olson committed
11

12
use crate::{
13
    component::{Endpoint, Instance, TransportType},
14
    distributed::RequestPlaneMode,
15
    pipeline::network::{PushWorkHandler, ingress::push_endpoint::PushEndpoint},
16
    protocols::EndpointId,
17
    traits::DistributedRuntimeProvider,
18
    transports::nats,
19
};
20

Ryan Olson's avatar
Ryan Olson committed
21
22
23
24
25
26
27
28
29
30
#[derive(Educe, Builder, Dissolve)]
#[educe(Debug)]
#[builder(pattern = "owned", build_fn(private, name = "build_internal"))]
pub struct EndpointConfig {
    #[builder(private)]
    endpoint: Endpoint,

    /// Endpoint handler
    #[educe(Debug(ignore))]
    handler: Arc<dyn PushWorkHandler>,
31

32
33
34
35
    /// Additional labels for metrics
    #[builder(default, setter(into))]
    metrics_labels: Option<Vec<(String, String)>>,

36
37
38
    /// Whether to wait for inflight requests to complete during shutdown
    #[builder(default = "true")]
    graceful_shutdown: bool,
39
40
41
42
43
44
45

    /// Health check payload for this endpoint
    /// This payload will be sent to the endpoint during health checks
    /// to verify it's responding properly
    #[educe(Debug(ignore))]
    #[builder(default, setter(into, strip_option))]
    health_check_payload: Option<serde_json::Value>,
Ryan Olson's avatar
Ryan Olson committed
46
47
48
49
50
51
52
}

impl EndpointConfigBuilder {
    pub(crate) fn from_endpoint(endpoint: Endpoint) -> Self {
        Self::default().endpoint(endpoint)
    }

53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
    /// Register an async engine in the local endpoint registry for direct in-process calls
    pub fn register_local_engine(
        self,
        engine: crate::local_endpoint_registry::LocalAsyncEngine,
    ) -> Result<Self> {
        if let Some(endpoint) = &self.endpoint {
            let registry = endpoint.drt().local_endpoint_registry();
            registry.register(endpoint.name.clone(), engine);
            tracing::debug!(
                "Registered engine for endpoint '{}' in local registry",
                endpoint.name
            );
        }
        Ok(self)
    }

Ryan Olson's avatar
Ryan Olson committed
69
    pub async fn start(self) -> Result<()> {
70
71
        let (endpoint, handler, metrics_labels, graceful_shutdown, health_check_payload) =
            self.build_internal()?.dissolve();
72
        let connection_id = endpoint.drt().connection_id();
73
        let endpoint_id = endpoint.id();
Ryan Olson's avatar
Ryan Olson committed
74

75
        tracing::debug!("Starting endpoint: {endpoint_id}");
Ryan Olson's avatar
Ryan Olson committed
76

77
78
79
        let metrics_labels: Option<Vec<(&str, &str)>> = metrics_labels
            .as_ref()
            .map(|v| v.iter().map(|(k, v)| (k.as_str(), v.as_str())).collect());
80
        // Add metrics to the handler. The endpoint provides additional information to the handler.
81
        handler.add_metrics(&endpoint, metrics_labels.as_deref())?;
82

83
84
85
        // This creates a child token of the runtime's endpoint_shutdown_token. That token is
        // cancelled first as part of graceful shutdown. See Runtime::shutdown.
        let endpoint_shutdown_token = endpoint.drt().child_token();
86

87
        let system_health = endpoint.drt().system_health();
88

89
90
91
        let request_plane_mode = endpoint.drt().request_plane();
        tracing::info!("Endpoint starting with request plane mode: {request_plane_mode}",);

92
93
94
95
96
97
98
99
100
101
102
        // Register with graceful shutdown tracker if needed
        if graceful_shutdown {
            tracing::debug!(
                "Registering endpoint '{}' with graceful shutdown tracker",
                endpoint.name
            );
            let tracker = endpoint.drt().graceful_shutdown_tracker();
            tracker.register_endpoint();
        } else {
            tracing::debug!("Endpoint '{}' has graceful_shutdown=false", endpoint.name);
        }
Ryan Olson's avatar
Ryan Olson committed
103

104
        // Launch endpoint based on request plane mode
105
106
107
108
109
110
111
        let tracker_clone = if graceful_shutdown {
            Some(endpoint.drt().graceful_shutdown_tracker())
        } else {
            None
        };

        // Create clones for the async closure
112
113
114
        let namespace_name_for_task = endpoint_id.namespace.clone();
        let component_name_for_task = endpoint_id.component.clone();
        let endpoint_name_for_task = endpoint_id.name.clone();
115

116
        // Get the unified request plane server
117
118
        let server = endpoint.drt().request_plane_server().await?;

119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
        // Register health check target in SystemHealth if provided
        if let Some(health_check_payload) = &health_check_payload {
            // Build transport based on request plane mode
            let transport = build_transport_type(&endpoint, &endpoint_id, connection_id).await?;

            let instance = Instance {
                component: endpoint_id.component.clone(),
                endpoint: endpoint_id.name.clone(),
                namespace: endpoint_id.namespace.clone(),
                instance_id: connection_id,
                transport,
            };
            tracing::debug!(endpoint_name = %endpoint.name, "Registering endpoint health check target");
            let guard = system_health.lock();
            guard.register_health_check_target(
                &endpoint.name,
                instance,
                health_check_payload.clone(),
            );
            if let Some(notifier) = guard.get_endpoint_health_check_notifier(&endpoint.name) {
                handler.set_endpoint_health_check_notifier(notifier)?;
            }
        }

143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
        tracing::info!(
            endpoint = %endpoint_name_for_task,
            transport = server.transport_name(),
            "Registering endpoint with request plane server"
        );

        // Register endpoint with the server (unified interface)
        server
            .register_endpoint(
                endpoint_name_for_task.clone(),
                handler,
                connection_id,
                namespace_name_for_task.clone(),
                component_name_for_task.clone(),
                system_health.clone(),
            )
            .await?;

        // Create cleanup task that unregisters on cancellation
        let endpoint_name_for_cleanup = endpoint_name_for_task.clone();
        let server_for_cleanup = server.clone();
        let cancel_token_for_cleanup = endpoint_shutdown_token.clone();

        let task: tokio::task::JoinHandle<anyhow::Result<()>> = tokio::spawn(async move {
            cancel_token_for_cleanup.cancelled().await;

            tracing::debug!(
                endpoint = %endpoint_name_for_cleanup,
                "Unregistering endpoint from request plane server"
            );

            // Unregister from server
            if let Err(e) = server_for_cleanup
                .unregister_endpoint(&endpoint_name_for_cleanup)
                .await
            {
                tracing::warn!(
                    endpoint = %endpoint_name_for_cleanup,
                    error = %e,
                    "Failed to unregister endpoint"
                );
            }
185
186
187

            // Unregister from graceful shutdown tracker
            if let Some(tracker) = tracker_clone {
188
                tracing::debug!("Unregister endpoint from graceful shutdown tracker");
189
190
191
                tracker.unregister_endpoint();
            }

192
            anyhow::Ok(())
193
        });
Ryan Olson's avatar
Ryan Olson committed
194

195
196
197
198
199
        // Register this endpoint instance in the discovery plane
        // The discovery interface abstracts storage backend (etcd, k8s, etc) and provides
        // consistent registration/discovery across the system.
        let discovery = endpoint.drt().discovery();

200
        // Build transport for discovery service based on request plane mode
201
        let transport = build_transport_type(&endpoint, &endpoint_id, connection_id).await?;
202

203
        let discovery_spec = crate::discovery::DiscoverySpec::Endpoint {
204
205
206
            namespace: endpoint_id.namespace.clone(),
            component: endpoint_id.component.clone(),
            endpoint: endpoint_id.name.clone(),
207
            transport,
Ryan Olson's avatar
Ryan Olson committed
208
209
        };

210
        if let Err(e) = discovery.register(discovery_spec).await {
211
            tracing::error!(
212
                %endpoint_id,
213
                error = %e,
214
215
                "Unable to register service for discovery"
            );
216
            endpoint_shutdown_token.cancel();
217
            anyhow::bail!(
218
                "Unable to register service for discovery. Check discovery service status"
219
            );
Ryan Olson's avatar
Ryan Olson committed
220
        }
221

Ryan Olson's avatar
Ryan Olson committed
222
223
224
225
226
        task.await??;

        Ok(())
    }
}
227

228
/// Build transport type based on request plane mode
229
///
230
231
232
233
234
/// This function handles both health check and discovery transport building.
/// All transport modes use consistent addressing:
/// - HTTP: Uses full URL path including endpoint name (e.g., http://host:port/v1/rpc/endpoint_name)
/// - TCP: Includes endpoint name for routing (e.g., host:port/endpoint_name)
/// - NATS: Uses subject-based addressing (unique per endpoint)
235
236
237
238
///
/// # Errors
/// Returns an error if TCP mode is used but the TCP server hasn't been started yet.
fn build_transport_type_inner(
239
    mode: RequestPlaneMode,
240
241
    endpoint_id: &EndpointId,
    connection_id: u64,
242
) -> Result<TransportType> {
243
244
245
246
247
248
249
250
251
252
253
    match mode {
        RequestPlaneMode::Http => {
            let http_host = crate::utils::get_http_rpc_host_from_env();
            let http_port = std::env::var("DYN_HTTP_RPC_PORT")
                .ok()
                .and_then(|p| p.parse::<u16>().ok())
                .unwrap_or(8888);
            let rpc_root =
                std::env::var("DYN_HTTP_RPC_ROOT_PATH").unwrap_or_else(|_| "/v1/rpc".to_string());

            let http_endpoint = format!(
254
255
                "http://{http_host}:{http_port}{rpc_root}/{}",
                endpoint_id.name
256
257
            );

258
            Ok(TransportType::Http(http_endpoint))
259
260
261
        }
        RequestPlaneMode::Tcp => {
            let tcp_host = crate::utils::get_tcp_rpc_host_from_env();
262
263
            // If a fixed port is explicitly configured, use it directly (no init ordering dependency).
            // Otherwise, use the actual bound port (set by TCP server after binding when port 0 is used).
264
265
266
            let tcp_port = std::env::var("DYN_TCP_RPC_PORT")
                .ok()
                .and_then(|p| p.parse::<u16>().ok())
267
                .unwrap_or(crate::pipeline::network::manager::get_actual_tcp_rpc_port()?);
268

269
270
            // Include endpoint name for proper TCP routing
            // TCP client parses this format and adds x-endpoint-path header for server-side routing
271
            let tcp_endpoint = format!("{}:{}/{}", tcp_host, tcp_port, endpoint_id.name);
272

273
            Ok(TransportType::Tcp(tcp_endpoint))
274
        }
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
        RequestPlaneMode::Nats => Ok(TransportType::Nats(nats::instance_subject(
            endpoint_id,
            connection_id,
        ))),
    }
}

/// Build transport type, ensuring TCP server is initialized when needed.
///
/// In TCP mode with an OS-assigned port (`DYN_TCP_RPC_PORT` unset or invalid), the server must bind
/// before we can construct a correct transport address. This helper ensures that initialization
/// occurs, then delegates to the internal builder.
pub async fn build_transport_type(
    endpoint: &Endpoint,
    endpoint_id: &EndpointId,
    connection_id: u64,
) -> Result<TransportType> {
    let mode = endpoint.drt().request_plane();

    if mode == RequestPlaneMode::Tcp {
        // Only force server init when we *don't* have a valid explicit port.
        let has_fixed_port = std::env::var("DYN_TCP_RPC_PORT")
            .ok()
            .and_then(|p| p.parse::<u16>().ok())
            .is_some();

        if !has_fixed_port {
            // Ensure request plane server is initialized before building transport.
            let _ = endpoint.drt().request_plane_server().await?;
304
        }
305
    }
306
307

    build_transport_type_inner(mode, endpoint_id, connection_id)
308
}