watcher.rs 13.2 KB
Newer Older
Ryan Olson's avatar
Ryan Olson committed
1
2
3
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

Ryan Olson's avatar
Ryan Olson committed
4
use std::sync::Arc;
5

6
use anyhow::Context as _;
7
use tokio::sync::{mpsc::Receiver, Notify};
Ryan Olson's avatar
Ryan Olson committed
8

Neelay Shah's avatar
Neelay Shah committed
9
use dynamo_runtime::{
10
    metrics::MetricsRegistry,
11
    pipeline::{
12
13
        network::egress::push_router::PushRouter, ManyOut, Operator, RouterMode, SegmentSource,
        ServiceBackend, SingleIn, Source,
14
    },
15
16
    protocols::annotated::Annotated,
    transports::etcd::{KeyValue, WatchEvent},
17
    DistributedRuntime,
18
};
Ryan Olson's avatar
Ryan Olson committed
19

20
21
use crate::{
    backend::Backend,
22
23
    entrypoint,
    kv_router::KvRouterConfig,
24
    model_type::ModelType,
25
26
27
28
29
30
31
32
33
34
    preprocessor::{OpenAIPreprocessor, PreprocessedEmbeddingRequest},
    protocols::{
        common::llm_backend::EmbeddingsEngineOutput,
        openai::{
            chat_completions::{
                NvCreateChatCompletionRequest, NvCreateChatCompletionStreamResponse,
            },
            completions::{NvCreateCompletionRequest, NvCreateCompletionResponse},
            embeddings::{NvCreateEmbeddingRequest, NvCreateEmbeddingResponse},
        },
35
36
    },
};
37

38
use super::{ModelEntry, ModelManager, MODEL_ROOT_PATH};
39

40
pub struct ModelWatcher {
41
    manager: Arc<ModelManager>,
42
    drt: DistributedRuntime,
43
    router_mode: RouterMode,
44
    notify_on_model: Notify,
45
    kv_router_config: Option<KvRouterConfig>,
Ryan Olson's avatar
Ryan Olson committed
46
47
}

48
impl ModelWatcher {
49
    pub fn new(
50
        runtime: DistributedRuntime,
51
        model_manager: Arc<ModelManager>,
52
        router_mode: RouterMode,
53
        kv_router_config: Option<KvRouterConfig>,
54
55
    ) -> ModelWatcher {
        Self {
56
            manager: model_manager,
57
            drt: runtime,
58
            router_mode,
59
            notify_on_model: Notify::new(),
60
            kv_router_config,
61
        }
62
    }
Ryan Olson's avatar
Ryan Olson committed
63

64
65
66
67
68
69
70
71
72
73
74
    /// Wait until we have at least one chat completions model and return it's name.
    pub async fn wait_for_chat_model(&self) -> String {
        // Loop in case it gets added and immediately deleted
        loop {
            if let Some(model_name) = self.manager.list_chat_completions_models().first() {
                return model_name.to_owned();
            }
            self.notify_on_model.notified().await
        }
    }

75
    pub async fn watch(&self, mut events_rx: Receiver<WatchEvent>) {
76
77
78
79
80
81
82
83
        tracing::debug!("model watcher started");

        while let Some(event) = events_rx.recv().await {
            match event {
                WatchEvent::Put(kv) => {
                    let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                        Ok(model_entry) => model_entry,
                        Err(err) => {
84
85
86
87
88
89
90
91
                            match kv.value_str() {
                                Ok(value) => {
                                    tracing::error!(%err, value, "Invalid JSON in model entry")
                                }
                                Err(value_str_err) => {
                                    tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                                }
                            }
92
93
94
                            continue;
                        }
                    };
95
96
97
98
99
100
101
102
103
                    let key = match kv.key_str() {
                        Ok(k) => k,
                        Err(err) => {
                            tracing::error!(%err, ?kv, "Invalid UTF-8 string in model entry key, skipping");
                            continue;
                        }
                    };
                    self.manager.save_model_entry(key, model_entry.clone());

104
                    if self.manager.has_model_any(&model_entry.name) {
105
                        tracing::trace!(name = model_entry.name, "New endpoint for existing model");
106
                        self.notify_on_model.notify_waiters();
107
108
109
                        continue;
                    }

110
                    match self.handle_put(&model_entry).await {
111
112
                        Ok(()) => {
                            tracing::info!(model_name = model_entry.name, "added model");
113
                            self.notify_on_model.notify_waiters();
114
                        }
115
116
117
118
119
120
                        Err(err) => {
                            tracing::error!(
                                error = format!("{err:#}"),
                                "error adding model {}",
                                model_entry.name
                            );
121
122
123
                        }
                    }
                }
124
125
                WatchEvent::Delete(kv) => match self.handle_delete(&kv).await {
                    Ok(Some(model_name)) => {
126
                        tracing::info!("removed model {}", model_name);
127
                    }
128
129
130
                    Ok(None) => {
                        // There are other instances running this model, nothing to do
                    }
131
                    Err(e) => {
132
                        tracing::error!("error removing model: {}", e);
133
                    }
134
                },
135
            }
Ryan Olson's avatar
Ryan Olson committed
136
137
138
        }
    }

139
140
141
    /// If the last instance running this model has gone delete it.
    /// Returns the name of the model we just deleted, if any.
    async fn handle_delete(&self, kv: &KeyValue) -> anyhow::Result<Option<String>> {
142
        let key = kv.key_str()?;
143
        let model_entry = match self.manager.remove_model_entry(key) {
144
145
146
147
148
            Some(entry) => entry,
            None => {
                anyhow::bail!("Missing ModelEntry for {key}");
            }
        };
149
150
151
152
153
154
155
156
        let model_name = model_entry.name;
        let active_instances = self
            .entries_for_model(&model_name)
            .await
            .with_context(|| model_name.clone())?;
        if !active_instances.is_empty() {
            return Ok(None);
        }
157

158
        // Ignore the errors because model could be either type
159
160
161
        let _ = self.manager.remove_chat_completions_model(&model_name);
        let _ = self.manager.remove_completions_model(&model_name);
        let _ = self.manager.remove_embeddings_model(&model_name);
162

163
        Ok(Some(model_name))
164
    }
Ryan Olson's avatar
Ryan Olson committed
165

166
167
    // Handles a PUT event from etcd, this usually means adding a new model to the list of served
    // models.
168
    async fn handle_put(&self, model_entry: &ModelEntry) -> anyhow::Result<()> {
169
        let endpoint_id = model_entry.endpoint.clone();
170
        let component = self
171
172
            .drt
            .namespace(&endpoint_id.namespace)?
173
174
            .component(&endpoint_id.component)
            .and_then(|c| c.add_labels(&[("model", &model_entry.name)]))?;
175
        let client = component.endpoint(&endpoint_id.name).client().await?;
176

177
178
179
180
        let Some(etcd_client) = self.drt.etcd_client() else {
            // Should be impossible because we only get here on an etcd event
            anyhow::bail!("Missing etcd_client");
        };
181
        let card = match model_entry.load_mdc(&etcd_client).await {
182
183
184
185
186
187
188
189
190
            Ok(card) => {
                tracing::debug!(card.display_name, "adding model");
                Some(card)
            }
            Err(err) => {
                tracing::info!(%err, "load_mdc did not complete");
                None
            }
        };
191

192
193
194
195
196
197
198
199
200
201
202
203
204
205
        match model_entry.model_type {
            ModelType::Backend => {
                // A Backend model expects pre-processed requests meaning it's up to us whether we
                // handle Chat or Completions requests, so handle both.

                let Some(mut card) = card else {
                    anyhow::bail!("Missing model deployment card");
                };
                // Download tokenizer.json etc to local disk
                // This cache_dir is a tempfile::TempDir will be deleted on drop. I _think_
                // OpenAIPreprocessor::new loads the files, so we can delete them after this
                // function. Needs checking carefully, possibly we need to store it in state.
                let _cache_dir = Some(card.move_from_nats(self.drt.nats_client()).await?);

206
207
208
                let kv_chooser = if self.router_mode == RouterMode::KV {
                    Some(
                        self.manager
209
210
211
212
                            .kv_chooser_for(
                                &model_entry.name,
                                &component,
                                card.kv_cache_block_size,
213
                                self.kv_router_config,
214
                            )
215
216
217
218
                            .await?,
                    )
                } else {
                    None
219
                };
220

221
222
223
224
225
226
                let chat_engine =
                    entrypoint::build_routed_pipeline::<
                        NvCreateChatCompletionRequest,
                        NvCreateChatCompletionStreamResponse,
                    >(&card, &client, self.router_mode, kv_chooser.clone())
                    .await?;
227
228
229
                self.manager
                    .add_chat_completions_model(&model_entry.name, chat_engine)?;

230
231
232
233
234
                let completions_engine =
                    entrypoint::build_routed_pipeline::<
                        NvCreateCompletionRequest,
                        NvCreateCompletionResponse,
                    >(&card, &client, self.router_mode, kv_chooser)
235
                    .await?;
236
237
238
239
240
241
242
243
244
245
246
247
248
249
                self.manager
                    .add_completions_model(&model_entry.name, completions_engine)?;
            }
            ModelType::Chat => {
                let push_router = PushRouter::<
                    NvCreateChatCompletionRequest,
                    Annotated<NvCreateChatCompletionStreamResponse>,
                >::from_client(client, Default::default())
                .await?;
                let engine = Arc::new(push_router);
                self.manager
                    .add_chat_completions_model(&model_entry.name, engine)?;
            }
            ModelType::Completion => {
250
251
                let push_router = PushRouter::<
                    NvCreateCompletionRequest,
252
                    Annotated<NvCreateCompletionResponse>,
253
254
                >::from_client(client, Default::default())
                .await?;
255
256
257
258
                let engine = Arc::new(push_router);
                self.manager
                    .add_completions_model(&model_entry.name, engine)?;
            }
259
            ModelType::Embedding => {
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
                let Some(mut card) = card else {
                    anyhow::bail!("Missing model deployment card for embedding model");
                };

                // Download tokenizer files to local disk
                let _cache_dir = Some(card.move_from_nats(self.drt.nats_client()).await?);

                // Create preprocessing pipeline similar to Backend
                let frontend = SegmentSource::<
                    SingleIn<NvCreateEmbeddingRequest>,
                    ManyOut<Annotated<NvCreateEmbeddingResponse>>,
                >::new();

                let preprocessor = OpenAIPreprocessor::new(card.clone()).await?.into_operator();
                let backend = Backend::from_mdc(card.clone()).await?.into_operator();

                let router = PushRouter::<
                    PreprocessedEmbeddingRequest,
                    Annotated<EmbeddingsEngineOutput>,
                >::from_client(client, self.router_mode)
280
                .await?;
281
282
283
284
285
286
287
288
289
290
291
292
293

                // Note: Embeddings don't need KV routing complexity
                let service_backend = ServiceBackend::from_engine(Arc::new(router));

                // Link the pipeline: frontend -> preprocessor -> backend -> service_backend -> backend -> preprocessor -> frontend
                let embedding_engine = frontend
                    .link(preprocessor.forward_edge())?
                    .link(backend.forward_edge())?
                    .link(service_backend)?
                    .link(backend.backward_edge())?
                    .link(preprocessor.backward_edge())?
                    .link(frontend)?;

294
                self.manager
295
                    .add_embeddings_model(&model_entry.name, embedding_engine)?;
296
            }
297
        }
Ryan Olson's avatar
Ryan Olson committed
298

299
300
        Ok(())
    }
301

302
    /// All the registered ModelEntry, one per instance
303
    pub async fn all_entries(&self) -> anyhow::Result<Vec<ModelEntry>> {
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
        let Some(etcd_client) = self.drt.etcd_client() else {
            anyhow::bail!("all_entries: Missing etcd client");
        };
        let kvs = etcd_client.kv_get_prefix(MODEL_ROOT_PATH).await?;
        let mut entries = Vec::with_capacity(kvs.len());
        for kv in kvs {
            let model_entry = match serde_json::from_slice::<ModelEntry>(kv.value()) {
                Ok(model_entry) => model_entry,
                Err(err) => {
                    match kv.value_str() {
                        Ok(value) => {
                            tracing::error!(%err, value, "Invalid JSON in model entry")
                        }
                        Err(value_str_err) => {
                            tracing::error!(original_error = %err, %value_str_err, "Invalid UTF-8 string in model entry, expected JSON")
                        }
                    }
                    continue;
                }
            };
            entries.push(model_entry);
325
        }
326
327
328
        Ok(entries)
    }

329
    pub async fn entries_for_model(&self, model_name: &str) -> anyhow::Result<Vec<ModelEntry>> {
330
331
332
        let mut all = self.all_entries().await?;
        all.retain(|entry| entry.name == model_name);
        Ok(all)
333
    }
Ryan Olson's avatar
Ryan Olson committed
334
}