kv_manager.rs 20.1 KB
Newer Older
1
// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
// SPDX-License-Identifier: Apache-2.0

//! # KV Manager
//! A synchronous implementation of a block manager that handles MoveBlock signals for caching KV blocks.
//!
//! ## Block Operations
//! The KV manager processes four types of MoveBlock signals:
//!
//! ### Use
//! - Checks if block exists in active pool → increment reference count
//! - If in inactive pool → move to active pool
//! - If neither → try evicting from inactive pool to make room
//! - If inactive pool is empty → pre-empt the oldest running request
//!
//! ### Destroy
//! - Removes the block from the active pool
//!
//! ### Deref
//! - Decrements reference count of a block in active pool
//! - If count reaches zero → move block to inactive pool
//!
//! ### Promote
//! - Converts a partial block (uuid) into a full block (global block hash)
//!
//! ## Preemption
//! If a Use operation fails (typically due to insufficient space), a false boolean signal
//! is returned to the scheduler for preemption. Initial KV block allocations for new requests
//! should not fail due to the watermark checking.
//!
//! ## NOTE
//! For simplicity (or non-simplicity), reference counting is tracked manually instead of using
//! the more idiomatic built-in Arc reference counter. This can be considered a shadow / mirror
//! implementation of the main block manager.

36
37
38
39
40
use crate::evictor::LRUEvictor;
use crate::protocols::{KvCacheEventSink, MoveBlock, PrefillCost};
use crate::sequence::ActiveSequence;
use derive_getters::Getters;
use dynamo_kv_router::protocols::{
Yan Ru Pei's avatar
Yan Ru Pei committed
41
42
43
    ExternalSequenceBlockHash, KvCacheEvent, KvCacheEventData, KvCacheRemoveData, KvCacheStoreData,
    KvCacheStoredBlockData, LocalBlockHash,
};
44
use dynamo_runtime::config::environment_names::mocker;
45
46
use dynamo_tokens::blocks::UniqueBlock;
use dynamo_tokens::{BlockHash, SequenceHash};
47
use std::collections::HashMap;
48
49
50
51
52
53
54
55
56
57
use std::env;
use std::sync::{Arc, LazyLock};
use std::time::{SystemTime, UNIX_EPOCH};

/// Check the env var to enable KV cache allocation/eviction trace logs.
static KV_CACHE_TRACE_ENABLED: LazyLock<bool> = LazyLock::new(|| {
    env::var(mocker::DYN_MOCKER_KV_CACHE_TRACE)
        .map(|v| v == "1" || v.eq_ignore_ascii_case("true"))
        .unwrap_or(false)
});
58
59
60
61
62
63
64

#[derive(Getters)]
pub struct KvManager {
    #[getter(copy)]
    max_capacity: usize,

    #[getter(copy)]
65
    block_size: usize,
66
67
68
69
70

    active_blocks: HashMap<UniqueBlock, usize>,

    inactive_blocks: LRUEvictor<UniqueBlock>,

71
    kv_event_sink: Option<Arc<dyn KvCacheEventSink>>,
Yan Ru Pei's avatar
Yan Ru Pei committed
72
73
74
75
76

    #[getter(copy)]
    dp_rank: u32,

    next_event_id: u64,
77
78
79
}

impl KvManager {
80
    pub fn new(max_capacity: usize, block_size: usize) -> Self {
81
        Self::new_with_event_sink(max_capacity, block_size, None, 0)
82
83
    }

84
    pub fn new_with_event_sink(
85
86
        max_capacity: usize,
        block_size: usize,
87
        kv_event_sink: Option<Arc<dyn KvCacheEventSink>>,
Yan Ru Pei's avatar
Yan Ru Pei committed
88
        dp_rank: u32,
89
    ) -> Self {
90
91
92
        let active_blocks = HashMap::new();
        let inactive_blocks = LRUEvictor::default();

93
        if kv_event_sink.is_some() {
Yan Ru Pei's avatar
Yan Ru Pei committed
94
            tracing::info!(
95
                "KvManager initialized with event sink for DP rank {dp_rank} with block_size {block_size}"
Yan Ru Pei's avatar
Yan Ru Pei committed
96
            );
97
        }
Yan Ru Pei's avatar
Yan Ru Pei committed
98

99
100
101
102
103
        KvManager {
            max_capacity,
            block_size,
            active_blocks,
            inactive_blocks,
104
            kv_event_sink,
Yan Ru Pei's avatar
Yan Ru Pei committed
105
106
            dp_rank,
            next_event_id: 0,
107
108
109
        }
    }

110
    /// Converts stored/removed blocks into KvCacheEventData and publishes if sink is available.
Yan Ru Pei's avatar
Yan Ru Pei committed
111
112
113
114
    fn publish_kv_event(
        &mut self,
        full_blocks: Vec<SequenceHash>,
        local_hashes: &[BlockHash],
115
        parent_hash: Option<u64>,
Yan Ru Pei's avatar
Yan Ru Pei committed
116
        is_store: bool,
117
    ) {
Yan Ru Pei's avatar
Yan Ru Pei committed
118
119
120
121
        if full_blocks.is_empty() {
            return;
        }

122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
        if *KV_CACHE_TRACE_ENABLED {
            let timestamp_ms = SystemTime::now()
                .duration_since(UNIX_EPOCH)
                .unwrap_or_default()
                .as_millis() as u64;
            let active_len = self.active_blocks.len();
            let inactive_len = self.inactive_blocks.len();
            let free_blocks = self
                .max_capacity
                .saturating_sub(active_len)
                .saturating_sub(inactive_len);
            let event = if is_store { "allocation" } else { "eviction" };
            tracing::info!(
                event,
                timestamp_ms,
                block_ids = ?&full_blocks,
                block_size = self.block_size,
                free_blocks_after = free_blocks,
                active_blocks = active_len,
                inactive_blocks = inactive_len,
                total_blocks = self.max_capacity,
                dp_rank = self.dp_rank,
                "KV cache trace"
            );
        }

148
149
150
151
        let Some(ref sink) = self.kv_event_sink else {
            return;
        };

Yan Ru Pei's avatar
Yan Ru Pei committed
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
        let event_data = if is_store {
            let num_blocks = full_blocks.len();
            let local_hashes_slice = &local_hashes[local_hashes
                .len()
                .checked_sub(num_blocks)
                .expect("local hashes fewer than stored blocks")..];

            KvCacheEventData::Stored(KvCacheStoreData {
                parent_hash: parent_hash.map(ExternalSequenceBlockHash),
                blocks: full_blocks
                    .into_iter()
                    .zip(local_hashes_slice.iter())
                    .map(|(global_hash, local_hash)| KvCacheStoredBlockData {
                        block_hash: ExternalSequenceBlockHash(global_hash),
                        tokens_hash: LocalBlockHash(*local_hash),
167
                        mm_extra_info: None,
Yan Ru Pei's avatar
Yan Ru Pei committed
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
                    })
                    .collect(),
            })
        } else {
            KvCacheEventData::Removed(KvCacheRemoveData {
                block_hashes: full_blocks
                    .into_iter()
                    .map(ExternalSequenceBlockHash)
                    .collect(),
            })
        };

        // Use incremental event ID starting from 0
        let event_id = self.next_event_id;
        self.next_event_id += 1;

        let event = KvCacheEvent {
            event_id,
            data: event_data,
            dp_rank: self.dp_rank,
        };

190
        if let Err(e) = sink.publish(event) {
Yan Ru Pei's avatar
Yan Ru Pei committed
191
            tracing::warn!("Failed to publish KV event: {e}");
192
193
194
195
196
197
        }
    }

    /// Process a MoveBlock instruction synchronously
    pub fn process(&mut self, event: &MoveBlock) -> bool {
        match event {
Yan Ru Pei's avatar
Yan Ru Pei committed
198
            MoveBlock::Use(hashes, local_hashes) => {
199
200
201
                let mut blocks_stored = Vec::<u64>::new();

                let mut parent_block: Option<&UniqueBlock> = None;
202
203
204
205
206
                for hash in hashes {
                    // First check if it already exists in active blocks
                    if let Some(ref_count) = self.active_blocks.get_mut(hash) {
                        // Block already active, just increment reference count
                        *ref_count += 1;
207
                        parent_block = Some(hash);
208
209
210
211
212
213
214
                        continue;
                    }

                    // Then check if it exists in inactive and move it to active if found
                    if self.inactive_blocks.remove(hash) {
                        // Insert into active with reference count 1
                        self.active_blocks.insert(hash.clone(), 1);
215
                        parent_block = Some(hash);
216
217
218
219
220
221
222
223
224
                        continue;
                    }

                    // Get counts for capacity check
                    let active_count = self.active_blocks.len();
                    let inactive_count = self.inactive_blocks.len();

                    // If at max capacity, evict the oldest entry from inactive blocks
                    if active_count + inactive_count >= self.max_capacity {
225
                        let Some(evicted) = self.inactive_blocks.evict() else {
226
                            return false;
227
                        };
Yan Ru Pei's avatar
Yan Ru Pei committed
228
229
230
231
                        tracing::trace!(
                            "Evicting block from inactive pool: {evicted:?}, dp_rank={}",
                            self.dp_rank
                        );
232
                        if let UniqueBlock::FullBlock(evicted_full_block) = evicted {
Yan Ru Pei's avatar
Yan Ru Pei committed
233
                            self.publish_kv_event(vec![evicted_full_block], &[], None, false);
234
235
236
237
238
                        }
                    }

                    // Now insert the new block in active blocks with reference count 1
                    self.active_blocks.insert(hash.clone(), 1);
239
240
                    // Track blocks for trace/event
                    if let UniqueBlock::FullBlock(stored_full_block) = hash {
241
                        blocks_stored.push(*stored_full_block);
242
                    }
243
                }
244
245
246
247
248
249

                let parent_hash = match parent_block {
                    None => None,
                    Some(UniqueBlock::FullBlock(block)) => Some(*block),
                    Some(UniqueBlock::PartialBlock(_)) => panic!("parent block cannot be partial"),
                };
Yan Ru Pei's avatar
Yan Ru Pei committed
250
                self.publish_kv_event(blocks_stored, local_hashes, parent_hash, true);
251
            }
252

253
            MoveBlock::Destroy(hashes) => {
254
255
                let mut blocks_destroyed = Vec::<u64>::new();

Yan Ru Pei's avatar
Yan Ru Pei committed
256
257
                // Process blocks in order (already reversed by caller if needed)
                for hash in hashes.iter() {
258
                    self.active_blocks.remove(hash).unwrap();
259
260

                    // Track blocks for batch sending
261
                    if let UniqueBlock::FullBlock(destroyed_full_block) = hash {
262
                        blocks_destroyed.push(*destroyed_full_block);
263
                    }
264
                }
265

Yan Ru Pei's avatar
Yan Ru Pei committed
266
                self.publish_kv_event(blocks_destroyed, &[], None, false);
267
            }
268

269
            MoveBlock::Deref(hashes) => {
Yan Ru Pei's avatar
Yan Ru Pei committed
270
271
                // Process blocks in order (already reversed by caller if needed)
                for hash in hashes.iter() {
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
                    // Decrement reference count and check if we need to move to inactive
                    if let Some(ref_count) = self.active_blocks.get_mut(hash) {
                        if *ref_count == 0 {
                            panic!("Negative reference count would be encountered after Deref.");
                        }
                        *ref_count -= 1;

                        // If reference count reaches zero, remove from active and move to inactive
                        if *ref_count == 0 {
                            self.active_blocks.remove(hash);
                            // Use the LRUEvictor's timing functionality
                            self.inactive_blocks.insert(hash.clone());
                        }
                    }
                }
            }
288

Yan Ru Pei's avatar
Yan Ru Pei committed
289
            MoveBlock::Promote(uuid, hash, parent_hash, local_hash) => {
290
291
292
                let uuid_block = UniqueBlock::PartialBlock(*uuid);
                let hash_block = UniqueBlock::FullBlock(*hash);

Yan Ru Pei's avatar
Yan Ru Pei committed
293
294
295
296
297
298
                assert_eq!(
                    self.active_blocks.remove(&uuid_block),
                    Some(1),
                    "uuid_block {uuid_block:?} should exist and be unique with ref_count=1"
                );

299
300
                let hash_ref_count = self.active_blocks.get(&hash_block).copied();
                let is_new = hash_ref_count.is_none() && !self.inactive_blocks.remove(&hash_block);
301

Yan Ru Pei's avatar
Yan Ru Pei committed
302
                self.active_blocks
303
304
305
306
307
                    .insert(hash_block.clone(), hash_ref_count.unwrap_or(0) + 1);

                if is_new {
                    self.publish_kv_event(vec![*hash], &[*local_hash], *parent_hash, true);
                }
308
309
310
311
312
313
314
            }
        }

        // Return true if we made it this far
        true
    }

315
    /// Get the count of blocks that aren't in active or inactive pools
316
317
318
    pub fn probe_new_blocks(&self, blocks: &[UniqueBlock]) -> usize {
        blocks
            .iter()
319
320
321
            .filter(|&block| {
                !self.active_blocks.contains_key(block) && !self.inactive_blocks.contains(block)
            })
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
            .count()
    }

    /// Get the current capacity (active blocks + inactive blocks)
    pub fn current_capacity(&self) -> usize {
        let active = self.active_blocks.len();
        let inactive = self.inactive_blocks.len();
        active + inactive
    }

    /// Get the current capacity as a percentage of the maximum capacity
    pub fn current_capacity_perc(&self) -> f64 {
        let current = self.current_capacity() as f64;
        current / self.max_capacity as f64
    }

    /// Get the number of active blocks
    pub fn num_active_blocks(&self) -> usize {
        self.active_blocks.len()
    }

343
344
345
346
347
    /// Get the percentage of active blocks relative to maximum capacity
    pub fn get_active_perc(&self) -> f64 {
        self.active_blocks.len() as f64 / self.max_capacity as f64
    }

348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
    /// Get the number of inactive blocks
    pub fn num_inactive_blocks(&self) -> usize {
        self.inactive_blocks.len()
    }

    /// Get the keys of inactive blocks
    pub fn get_inactive_blocks(&self) -> Vec<&UniqueBlock> {
        self.inactive_blocks.keys().collect()
    }

    /// Get the keys of active blocks
    pub fn get_active_blocks(&self) -> Vec<&UniqueBlock> {
        self.active_blocks.keys().collect()
    }

    /// Check if a sequence can be scheduled and calculate cost if possible
364
365
    pub fn get_prefill_cost(&self, sequence: &ActiveSequence) -> PrefillCost {
        let seq_blocks = sequence.unique_blocks();
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381

        // Find the longest prefix that exists in cache
        // We must stop at the first cache miss since KV states are computed sequentially
        let mut overlap_blocks = 0;
        for block in seq_blocks {
            if !self.active_blocks.contains_key(block) && !self.inactive_blocks.contains(block) {
                // First cache miss - can't use anything after this point
                break;
            }
            overlap_blocks += 1;
        }

        let new_blocks = seq_blocks.len() - overlap_blocks;
        // Clamp cached_tokens to handle partial blocks (last block may have < block_size tokens)
        let cached_tokens = (overlap_blocks * self.block_size).min(sequence.num_input_tokens());
        let new_tokens = sequence.num_input_tokens() - cached_tokens;
382

383
384
        PrefillCost {
            new_blocks,
385
            new_tokens,
386
        }
387
388
389
390
391
392
393
394
395
396
397
398
399
400
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_failure_on_max_capacity() {
        // Create a KvManager with 10 blocks capacity
        let mut manager = KvManager::new(10, 16);

        // Helper function to use multiple blocks that returns the response
        fn use_blocks(manager: &mut KvManager, ids: Vec<u64>) -> bool {
Yan Ru Pei's avatar
Yan Ru Pei committed
401
402
403
            let blocks: Vec<_> = ids.iter().map(|&id| UniqueBlock::FullBlock(id)).collect();
            let hashes: Vec<_> = ids.into_iter().collect();
            manager.process(&MoveBlock::Use(blocks, hashes))
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
        }

        // First use 10 blocks (0 to 9) in a batch
        let response = use_blocks(&mut manager, (0..10).collect());
        assert!(response, "Expected success response");

        // Verify we are at capacity
        assert_eq!(manager.current_capacity(), 10);

        // The 11th block should return false, not panic
        let response = use_blocks(&mut manager, vec![10]);
        assert!(
            !response,
            "Expected failure response when exceeding max capacity"
        );
    }

    #[test]
    fn test_block_lifecycle_stringent() {
Yan Ru Pei's avatar
Yan Ru Pei committed
423
424
        // Create a KvManager with 10 blocks capacity (no KV event publisher for tests)
        let mut manager = KvManager::new(10, 16);
425
426
427

        // Helper function to use multiple blocks
        fn use_blocks(manager: &mut KvManager, ids: Vec<u64>) {
Yan Ru Pei's avatar
Yan Ru Pei committed
428
429
430
            let blocks: Vec<_> = ids.iter().map(|&id| UniqueBlock::FullBlock(id)).collect();
            let hashes: Vec<_> = ids.into_iter().collect();
            manager.process(&MoveBlock::Use(blocks, hashes));
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
        }

        // Helper function to destroy multiple blocks
        fn destroy_blocks(manager: &mut KvManager, ids: Vec<u64>) {
            let blocks = ids.into_iter().map(UniqueBlock::FullBlock).collect();
            manager.process(&MoveBlock::Destroy(blocks));
        }

        // Helper function to deref multiple blocks
        fn deref_blocks(manager: &mut KvManager, ids: Vec<u64>) {
            let blocks = ids.into_iter().map(UniqueBlock::FullBlock).collect();
            manager.process(&MoveBlock::Deref(blocks));
        }

        // Helper function to check if active blocks contain expected blocks with expected ref counts
        fn assert_active_blocks(manager: &KvManager, expected_blocks: &[(u64, usize)]) {
            assert_eq!(
                manager.active_blocks().len(),
                expected_blocks.len(),
                "Active blocks count doesn't match expected"
            );

            for &(id, ref_count) in expected_blocks {
                let block = UniqueBlock::FullBlock(id);
                assert!(
                    manager.active_blocks().contains_key(&block),
457
                    "Block {id} not found in active blocks",
458
459
460
461
                );
                assert_eq!(
                    manager.active_blocks().get(&block),
                    Some(&ref_count),
462
                    "Block {id} has wrong reference count",
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
                );
            }
        }

        // Helper function to check if inactive blocks contain expected blocks
        fn assert_inactive_blocks(
            manager: &KvManager,
            expected_size: usize,
            expected_blocks: &[u64],
        ) {
            let inactive_blocks = manager.get_inactive_blocks();
            let inactive_blocks_count = manager.inactive_blocks().len();

            assert_eq!(
                inactive_blocks_count, expected_size,
                "Inactive blocks count doesn't match expected"
            );

            for &id in expected_blocks {
                let block = UniqueBlock::FullBlock(id);
                assert!(
                    inactive_blocks.iter().any(|&b| *b == block),
485
                    "Block {id} not found in inactive blocks",
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
                );
            }
        }

        // First use blocks 0, 1, 2, 3, 4 in a batch
        use_blocks(&mut manager, (0..5).collect());

        // Then use blocks 0, 1, 5, 6 in a batch
        use_blocks(&mut manager, vec![0, 1, 5, 6]);

        // Check that the blocks 0 and 1 are in active blocks, both with reference counts of 2
        assert_active_blocks(
            &manager,
            &[(0, 2), (1, 2), (2, 1), (3, 1), (4, 1), (5, 1), (6, 1)],
        );

        // Now destroy block 4
        destroy_blocks(&mut manager, vec![4]);

        // And deref blocks 3, 2, 1, 0 in this order as a batch
        deref_blocks(&mut manager, vec![0, 1, 2, 3]);

        // Check that the inactive_blocks is size 2 (via num_objects) and contains 3 and 2
        assert_inactive_blocks(&manager, 2, &[3, 2]);
        assert_active_blocks(&manager, &[(0, 1), (1, 1), (5, 1), (6, 1)]);

        // Now destroy block 6
        destroy_blocks(&mut manager, vec![6]);

        // And deref blocks 5, 1, 0 as a batch
        deref_blocks(&mut manager, vec![0, 1, 5]);

        // Check that the inactive_blocks is size 5, and contains 0, 1, 2, 3, 5
        assert_inactive_blocks(&manager, 5, &[0, 1, 2, 3, 5]);
        assert_active_blocks(&manager, &[]);

        // Now use 0, 1, 2, 7, 8, 9 as a batch
        use_blocks(&mut manager, vec![0, 1, 2, 7, 8, 9]);

        // Check that the inactive_blocks is size 2, and contains 3 and 5
        assert_inactive_blocks(&manager, 2, &[3, 5]);
        assert_active_blocks(&manager, &[(0, 1), (1, 1), (2, 1), (7, 1), (8, 1), (9, 1)]);

        // Test the new_blocks method - only block 4 should be new out of [0,1,2,3,4]
        let blocks_to_check: Vec<UniqueBlock> = vec![0, 1, 2, 3, 4]
            .into_iter()
            .map(UniqueBlock::FullBlock)
            .collect();
        assert_eq!(manager.probe_new_blocks(&blocks_to_check), 1);

        // Now use blocks 10, 11, 12 as a batch
        use_blocks(&mut manager, vec![10, 11, 12]);

        // Check that the inactive_blocks is size 1 and contains only 5
        assert_inactive_blocks(&manager, 1, &[5]);
541
542

        use_blocks(&mut manager, vec![13]);
543
544
    }
}