pool_test.go 10 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
/*
 * SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 * SPDX-License-Identifier: Apache-2.0
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package workerpool

import (
	"context"
	"errors"
	"fmt"
	"strings"
	"sync/atomic"
	"testing"
	"time"
)

func TestExecute(t *testing.T) {
	tests := []struct {
		name               string
		maxWorkers         int
		timeout            time.Duration
		taskCount          int
		taskDuration       time.Duration
		failingTaskIndices []int
		expectError        bool
		errorContains      string
	}{
		{
			name:        "empty task list",
			maxWorkers:  5,
			timeout:     time.Second,
			taskCount:   0,
			expectError: false,
		},
		{
			name:         "single task success",
			maxWorkers:   1,
			timeout:      time.Second,
			taskCount:    1,
			taskDuration: 10 * time.Millisecond,
			expectError:  false,
		},
		{
			name:         "multiple tasks success",
			maxWorkers:   5,
			timeout:      time.Second,
			taskCount:    10,
			taskDuration: 10 * time.Millisecond,
			expectError:  false,
		},
		{
			name:               "single task failure",
			maxWorkers:         5,
			timeout:            time.Second,
			taskCount:          5,
			taskDuration:       10 * time.Millisecond,
			failingTaskIndices: []int{2},
			expectError:        true,
			errorContains:      "1 task(s) failed",
		},
		{
			name:               "multiple task failures",
			maxWorkers:         5,
			timeout:            time.Second,
			taskCount:          10,
			taskDuration:       10 * time.Millisecond,
			failingTaskIndices: []int{1, 3, 5},
			expectError:        true,
			errorContains:      "3 task(s) failed",
		},
		{
			name:         "more tasks than workers",
			maxWorkers:   3,
			timeout:      time.Second,
			taskCount:    10,
			taskDuration: 10 * time.Millisecond,
			expectError:  false,
		},
		{
			name:         "more workers than tasks",
			maxWorkers:   10,
			timeout:      time.Second,
			taskCount:    3,
			taskDuration: 10 * time.Millisecond,
			expectError:  false,
		},
		{
			name:         "single worker multiple tasks",
			maxWorkers:   1,
			timeout:      time.Second,
			taskCount:    5,
			taskDuration: 10 * time.Millisecond,
			expectError:  false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			ctx := context.Background()

			// Create tasks
			tasks := make([]Task[int], tt.taskCount)
			failingSet := make(map[int]bool)
			for _, idx := range tt.failingTaskIndices {
				failingSet[idx] = true
			}

			for i := range tasks {
				taskIndex := i
				tasks[i] = Task[int]{
					Index: taskIndex,
					Work: func(ctx context.Context) (int, error) {
						// Simulate work
						if tt.taskDuration > 0 {
							time.Sleep(tt.taskDuration)
						}

						// Return error if this task should fail
						if failingSet[taskIndex] {
							return 0, fmt.Errorf("task %d failed", taskIndex)
						}

						return taskIndex * 2, nil
					},
				}
			}

			// Execute tasks
			results, err := Execute(ctx, tt.maxWorkers, tt.timeout, tasks)

			// Verify error expectation
			if tt.expectError {
				if err == nil {
					t.Error("expected error but got none")
				} else if tt.errorContains != "" && !strings.Contains(err.Error(), tt.errorContains) {
					t.Errorf("expected error to contain %q, got %v", tt.errorContains, err)
				}
			} else {
				if err != nil {
					t.Errorf("unexpected error: %v", err)
				}
			}

			// Verify result count
			if len(results) != tt.taskCount {
				t.Errorf("expected %d results, got %d", tt.taskCount, len(results))
			}

			// Verify successful task results
			for i, result := range results {
				if result.Index != i {
					t.Errorf("result %d has wrong index: expected %d, got %d", i, i, result.Index)
				}

				if !failingSet[i] {
					// Successful tasks should have correct value
					expectedValue := i * 2
					if result.Value != expectedValue {
						t.Errorf("result %d has wrong value: expected %d, got %d", i, expectedValue, result.Value)
					}
					if result.Err != nil {
						t.Errorf("result %d has unexpected error: %v", i, result.Err)
					}
				} else {
					// Failed tasks should have error
					if result.Err == nil {
						t.Errorf("result %d should have error but got none", i)
					}
				}
			}
		})
	}
}

func TestExecute_InvalidMaxWorkers(t *testing.T) {
	tests := []struct {
		name          string
		maxWorkers    int
		errorContains string
	}{
		{
			name:          "zero workers",
			maxWorkers:    0,
			errorContains: "maxWorkers must be at least 1",
		},
		{
			name:          "negative workers",
			maxWorkers:    -1,
			errorContains: "maxWorkers must be at least 1",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			ctx := context.Background()
			tasks := []Task[int]{
				{
					Index: 0,
					Work: func(ctx context.Context) (int, error) {
						return 0, nil
					},
				},
			}

			_, err := Execute(ctx, tt.maxWorkers, time.Second, tasks)

			if err == nil {
				t.Error("expected error but got none")
			} else if !strings.Contains(err.Error(), tt.errorContains) {
				t.Errorf("expected error to contain %q, got %v", tt.errorContains, err)
			}
		})
	}
}

func TestExecute_Timeout(t *testing.T) {
	ctx := context.Background()

	// Create tasks that take longer than the timeout
	tasks := []Task[int]{
		{
			Index: 0,
			Work: func(ctx context.Context) (int, error) {
				select {
				case <-time.After(2 * time.Second):
					return 0, nil
				case <-ctx.Done():
					return 0, ctx.Err()
				}
			},
		},
		{
			Index: 1,
			Work: func(ctx context.Context) (int, error) {
				select {
				case <-time.After(2 * time.Second):
					return 1, nil
				case <-ctx.Done():
					return 0, ctx.Err()
				}
			},
		},
	}

	// Execute with short timeout
	results, err := Execute(ctx, 2, 100*time.Millisecond, tasks)

	// Should get error because tasks timed out
	if err == nil {
		t.Error("expected timeout error but got none")
	}

	// Should still get results (with errors)
	if len(results) != 2 {
		t.Errorf("expected 2 results, got %d", len(results))
	}

	// All results should have context deadline exceeded error
	for i, result := range results {
		if result.Err == nil {
			t.Errorf("result %d should have timeout error but got none", i)
		}
	}
}

func TestExecute_Concurrency(t *testing.T) {
	ctx := context.Background()
	maxWorkers := 5
	taskCount := 20

	// Track concurrent execution
	var currentConcurrent int32
	var maxConcurrent int32

	tasks := make([]Task[int], taskCount)
	for i := range tasks {
		taskIndex := i
		tasks[i] = Task[int]{
			Index: taskIndex,
			Work: func(ctx context.Context) (int, error) {
				// Increment counter
				current := atomic.AddInt32(&currentConcurrent, 1)

				// Update max if needed
				for {
					max := atomic.LoadInt32(&maxConcurrent)
					if current <= max || atomic.CompareAndSwapInt32(&maxConcurrent, max, current) {
						break
					}
				}

				// Simulate work
				time.Sleep(50 * time.Millisecond)

				// Decrement counter
				atomic.AddInt32(&currentConcurrent, -1)

				return taskIndex, nil
			},
		}
	}

	_, err := Execute(ctx, maxWorkers, 5*time.Second, tasks)

	if err != nil {
		t.Errorf("unexpected error: %v", err)
	}

	// Verify concurrency stayed within bounds
	if maxConcurrent > int32(maxWorkers) {
		t.Errorf("expected max concurrent workers <= %d, got %d", maxWorkers, maxConcurrent)
	}

	// Verify we actually used concurrency (should be at least 2 concurrent)
	if maxConcurrent < 2 {
		t.Errorf("expected concurrent execution, but maxConcurrent was only %d", maxConcurrent)
	}
}

func TestExecute_ContextCancellation(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())

	// Create tasks that check for cancellation
	tasks := make([]Task[int], 5)
	for i := range tasks {
		taskIndex := i
		tasks[i] = Task[int]{
			Index: taskIndex,
			Work: func(ctx context.Context) (int, error) {
				select {
				case <-time.After(2 * time.Second):
					return taskIndex, nil
				case <-ctx.Done():
					return 0, ctx.Err()
				}
			},
		}
	}

	// Cancel context after short delay
	go func() {
		time.Sleep(100 * time.Millisecond)
		cancel()
	}()

	results, err := Execute(ctx, 3, 5*time.Second, tasks)

	// Should get error
	if err == nil {
		t.Error("expected cancellation error but got none")
	}

	// Should still get results
	if len(results) != 5 {
		t.Errorf("expected 5 results, got %d", len(results))
	}

	// All results should have cancellation error
	for i, result := range results {
		if result.Err == nil {
			t.Errorf("result %d should have cancellation error but got none", i)
		} else if !errors.Is(result.Err, context.Canceled) {
			t.Errorf("result %d expected context.Canceled, got %v", i, result.Err)
		}
	}
}

func TestExecute_ResultOrdering(t *testing.T) {
	ctx := context.Background()
	taskCount := 10

	// Create tasks that complete in reverse order
	tasks := make([]Task[int], taskCount)
	for i := range tasks {
		taskIndex := i
		tasks[i] = Task[int]{
			Index: taskIndex,
			Work: func(ctx context.Context) (int, error) {
				// Later tasks sleep less (complete faster)
				sleepDuration := time.Duration(taskCount-taskIndex) * 10 * time.Millisecond
				time.Sleep(sleepDuration)
				return taskIndex * 10, nil
			},
		}
	}

	results, err := Execute(ctx, 5, 5*time.Second, tasks)

	if err != nil {
		t.Errorf("unexpected error: %v", err)
	}

	// Verify results are in original order despite reverse completion
	for i, result := range results {
		if result.Index != i {
			t.Errorf("result %d has wrong index: expected %d, got %d", i, i, result.Index)
		}
		expectedValue := i * 10
		if result.Value != expectedValue {
			t.Errorf("result %d has wrong value: expected %d, got %d", i, expectedValue, result.Value)
		}
	}
}