config.py 39.3 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

16
import json
17
import logging
18
import math
19
import re
20
import shlex
21
from typing import Literal, Optional, Protocol
22

23
from pydantic import BaseModel
24

25
26
27
28
from benchmarks.profiler.utils.defaults import (
    DEFAULT_MODEL_NAME,
    DYNAMO_RUN_DEFAULT_PORT,
)
29
from dynamo.planner.defaults import WORKER_COMPONENT_NAMES, SubComponentType
30
31
32
33
34
35
36
37
38
39
40
41

logger = logging.getLogger(__name__)
logger.setLevel(logging.INFO)
console_handler = logging.StreamHandler()
console_handler.setLevel(logging.INFO)
formatter = logging.Formatter(
    "%(asctime)s - %(name)s - %(levelname)s - %(message)s", "%Y-%m-%d %H:%M:%S"
)
console_handler.setFormatter(formatter)
logger.addHandler(console_handler)


42
class Container(BaseModel):
43
44
    args: Optional[list[str]] = None
    model_config = {"extra": "allow"}
45
46
47


class PodSpec(BaseModel):
48
49
    mainContainer: Optional[Container] = None
    model_config = {"extra": "allow"}
50
51
52


class ServiceResources(BaseModel):
53
    requests: Optional[dict[str, str]] = None
54
55
56
57
    limits: Optional[dict[str, str]] = None


class Service(BaseModel):
58
59
60
    replicas: Optional[int] = None
    resources: Optional[ServiceResources] = None
    extraPodSpec: Optional[PodSpec] = None
61
    subComponentType: Optional[str] = None
62
    model_config = {"extra": "allow"}
63
64
65
66


class Services(BaseModel):
    Frontend: Service
67
    model_config = {"extra": "allow"}
68
69
70
71
72
73
74
75
76
77
78
79
80


class Spec(BaseModel):
    services: dict[str, Service]


class Metadata(BaseModel):
    name: str


class Config(BaseModel):
    metadata: Metadata
    spec: Spec
81
    model_config = {"extra": "allow"}
82
83


84
85
86
87
class MultinodeConfig(BaseModel):
    nodeCount: int


88
89
90
91
def break_arguments(args: list[str] | None) -> list[str]:
    ans: list[str] = []
    if args is None:
        return ans
92
    if isinstance(args, str):
93
94
        # Use shlex.split to properly handle quoted arguments and JSON values
        ans = shlex.split(args)
95
96
    else:
        for arg in args:
97
            if arg is not None:
98
99
                # Use shlex.split to properly handle quoted arguments
                ans.extend(shlex.split(arg))
100
    return ans
101
102


103
104
105
106
107
108
109
110
111
112
def remove_valued_arguments(args: list[str], key: str) -> list[str]:
    """Remove a valued argument (e.g., --key value) from the arguments list if exists."""
    if key in args:
        idx = args.index(key)
        if idx + 1 < len(args):
            del args[idx : idx + 2]

    return args


113
def join_arguments(args: list[str]) -> list[str]:
114
115
    # Use shlex.join to properly quote arguments that contain spaces or special characters
    return [shlex.join(args)]
116
117


118
119
120
121
122
123
124
def append_argument(args: list[str], to_append) -> list[str]:
    idx = find_arg_index(args)
    if isinstance(to_append, list):
        args[idx:idx] = to_append
    else:
        args.insert(idx, to_append)
    return args
125
126


127
128
129
def find_arg_index(args: list[str]) -> int:
    # find the correct index to insert an argument
    idx = len(args)
130

131
132
133
134
135
    try:
        new_idx = args.index("|")
        idx = min(idx, new_idx)
    except ValueError:
        pass
136

137
138
139
140
141
    try:
        new_idx = args.index("2>&1")
        idx = min(idx, new_idx)
    except ValueError:
        pass
142

143
    return idx
144
145


146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
def parse_override_engine_args(args: list[str]) -> tuple[dict, list[str]]:
    """
    Parse and extract --override-engine-args from argument list.

    Returns:
        tuple: (override_dict, modified_args) where override_dict is the parsed JSON
               and modified_args is the args list with --override-engine-args removed
    """
    override_dict = {}
    try:
        idx = args.index("--override-engine-args")
        if idx + 1 < len(args):
            # Parse existing override
            override_dict = json.loads(args[idx + 1])
            # Remove the old override args
            del args[idx : idx + 2]
    except (ValueError, json.JSONDecodeError):
        pass  # No existing override or invalid JSON

    return override_dict, args


168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
def set_multinode_config(worker_service, gpu_count: int, num_gpus_per_node: int):
    """Helper function to set multinode configuration based on GPU count and GPUs per node."""
    if gpu_count <= num_gpus_per_node:
        # Single node: remove multinode configuration if present
        if (
            hasattr(worker_service, "multinode")
            and worker_service.multinode is not None
        ):
            worker_service.multinode = None
    else:
        # Multi-node: set nodeCount = math.ceil(gpu_count / num_gpus_per_node)
        node_count = math.ceil(gpu_count / num_gpus_per_node)
        if not hasattr(worker_service, "multinode") or worker_service.multinode is None:
            # Create multinode configuration if it doesn't exist
            worker_service.multinode = MultinodeConfig(nodeCount=node_count)
        else:
            # Handle both dict (from YAML) and MultinodeConfig object cases
            if isinstance(worker_service.multinode, dict):
                worker_service.multinode["nodeCount"] = node_count
            else:
                worker_service.multinode.nodeCount = node_count


191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
def get_service_name_by_type(
    config: dict, backend: str, sub_component_type: SubComponentType
) -> str:
    """Helper function to get service name by subComponentType.

    First tries to find service by subComponentType, then falls back to component name.

    Args:
        config: Configuration dictionary (with spec.services structure)
        backend: Backend name (e.g., "sglang", "vllm", "trtllm")
        sub_component_type: The type of sub-component to look for (PREFILL or DECODE)

    Returns:
        The service name
    """
    # Check if config has the expected structure
    if (
        not isinstance(config, dict)
        or "spec" not in config
        or "services" not in config.get("spec", {})
    ):
        # Fall back to default name if structure is unexpected
        if sub_component_type == SubComponentType.DECODE:
            return WORKER_COMPONENT_NAMES[backend].decode_worker_k8s_name
        else:
            return WORKER_COMPONENT_NAMES[backend].prefill_worker_k8s_name

    # Look through services to find one with matching subComponentType
    services = config["spec"]["services"]
    for service_name, service_config in services.items():
        if (
            isinstance(service_config, dict)
            and service_config.get("subComponentType") == sub_component_type.value
        ):
            return service_name

    # Fall back to default component names
    if sub_component_type == SubComponentType.DECODE:
        default_name = WORKER_COMPONENT_NAMES[backend].decode_worker_k8s_name
    else:
        default_name = WORKER_COMPONENT_NAMES[backend].prefill_worker_k8s_name

    # Check if the default name exists in services
    if default_name in services:
        return default_name

    # Last resort: return the default name anyway
    return default_name


def get_worker_service_from_config(
    config: dict,
    backend: str = "sglang",
    sub_component_type: SubComponentType = SubComponentType.DECODE,
):
    """Helper function to get a worker service from config.

    First tries to find service by subComponentType, then falls back to component name.

    Args:
        config: Configuration dictionary
        backend: Backend name (e.g., "sglang", "vllm", "trtllm"). Defaults to "sglang".
        sub_component_type: The type of sub-component to look for (PREFILL or DECODE). Defaults to DECODE.

    Returns:
        The worker service from the configuration
    """
    if backend not in WORKER_COMPONENT_NAMES:
        raise ValueError(
            f"Unsupported backend: {backend}. Supported backends: {list(WORKER_COMPONENT_NAMES.keys())}"
        )

    # Get the service name using the type-aware logic
    service_name = get_service_name_by_type(config, backend, sub_component_type)

    # Get the actual service from the config
267
    cfg = Config.model_validate(config)
268
    return cfg.spec.services[service_name]
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299


def setup_worker_service_resources(
    worker_service, gpu_count: int, num_gpus_per_node: Optional[int] = None
):
    """Helper function to set up worker service resources (requests and limits)."""
    # Handle multinode configuration if num_gpus_per_node is provided
    if num_gpus_per_node is not None:
        set_multinode_config(worker_service, gpu_count, num_gpus_per_node)

    # Ensure resources exists
    if worker_service.resources is None:
        worker_service.resources = ServiceResources()

    # Ensure requests exists
    if worker_service.resources.requests is None:
        worker_service.resources.requests = {}

    # Set GPU requests
    gpu_value = (
        min(gpu_count, num_gpus_per_node)
        if num_gpus_per_node is not None
        else gpu_count
    )
    worker_service.resources.requests["gpu"] = str(gpu_value)

    # Update limits if they exist
    if worker_service.resources.limits is not None:
        worker_service.resources.limits["gpu"] = str(gpu_value)


300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
def validate_and_get_worker_args(worker_service, backend):
    """Helper function to validate worker service and get its arguments.

    Args:
        worker_service: Worker service object to validate
        backend: Backend name (e.g., "sglang", "vllm", "trtllm"). Defaults to "sglang".

    Returns:
        List of arguments from the worker service
    """
    if backend not in WORKER_COMPONENT_NAMES:
        raise ValueError(
            f"Unsupported backend: {backend}. Supported backends: {list(WORKER_COMPONENT_NAMES.keys())}"
        )

315
316
    if not worker_service.extraPodSpec or not worker_service.extraPodSpec.mainContainer:
        raise ValueError(
317
            f"Missing extraPodSpec or mainContainer in {backend} decode worker service '{WORKER_COMPONENT_NAMES[backend].decode_worker_k8s_name}'"
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
        )

    args = worker_service.extraPodSpec.mainContainer.args
    return break_arguments(args)


def set_argument_value(args: list, arg_name: str, value: str):
    """Helper function to set an argument value, adding it if not present."""
    try:
        idx = args.index(arg_name)
        args[idx + 1] = value
    except ValueError:
        args = append_argument(args, [arg_name, value])
    return args


334
335
class ConfigModifierProtocol(Protocol):
    @classmethod
336
337
338
339
340
341
    def convert_config(
        cls,
        config: dict,
        target: Literal["prefill", "decode"],
        is_moe_model: bool = False,
    ) -> dict:
342
343
344
345
346
347
        ...

    @classmethod
    def set_config_tp_size(cls, config: dict, tp_size: int) -> dict:
        ...

348
349
350
351
352
353
354
355
356
357
358
359
    @classmethod
    def set_config_tep_size(
        cls, config: dict, tep_size: int, num_gpus_per_node: int
    ) -> dict:
        ...

    @classmethod
    def set_config_dep_size(
        cls, config: dict, dep_size: int, num_gpus_per_node: int
    ) -> dict:
        ...

360
361
362
363
364
365
366
367
368
    @classmethod
    def get_model_name(cls, config: dict) -> str:
        ...

    @classmethod
    def get_port(cls, config: dict) -> int:
        ...

    @classmethod
369
370
371
    def get_kv_cache_size_from_dynamo_log(
        cls, dynamo_log_fn: str, attention_dp_size: int = 1
    ) -> int:
372
373
374
        ...


375
376
class VllmV1ConfigModifier:
    @classmethod
377
378
379
380
381
382
383
384
385
386
387
    def convert_config(
        cls,
        config: dict,
        target: Literal["prefill", "decode"],
        is_moe_model: bool = False,
    ) -> dict:
        if is_moe_model:
            raise NotImplementedError(
                "MoE model support is not implemented for VLLM backend"
            )

388
        cfg = Config.model_validate(config)
389

390
        # set metadata name
391
        cfg.metadata.name = "vllm-agg"
392

393
        # disable planner
394
395
        if "Planner" in cfg.spec.services:
            del cfg.spec.services["Planner"]
396
397

        if target == "prefill":
398
399
400
401
402
403
404
405
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "vllm", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "vllm", SubComponentType.DECODE
            )

406
            # convert prefill worker into decode worker
407
408
            cfg.spec.services[decode_service_name] = cfg.spec.services[
                prefill_service_name
409
            ]
410
            del cfg.spec.services[prefill_service_name]
411

412
413
            # Set subComponentType for aggregated mode (using decode worker for prefill-only)
            cfg.spec.services[decode_service_name].subComponentType = "decode"
414

415
416
417
418
419
420
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="vllm",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="vllm")
421
422
423
424
425
426
427
428
429
430
431
            args = break_arguments(args)

            # remove --is-prefill-worker flag
            args.remove("--is-prefill-worker")

            # disable prefix caching
            if "--enable-prefix-caching" in args:
                args.remove("--enable-prefix-caching")
            if "--no-enable-prefix-caching" not in args:
                args = append_argument(args, "--no-enable-prefix-caching")

432
            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
433

434
        elif target == "decode":
435
436
437
438
439
440
441
442
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "vllm", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "vllm", SubComponentType.DECODE
            )

443
            # delete prefill worker
444
            del cfg.spec.services[prefill_service_name]
445

446
447
            # Set subComponentType for aggregated decode-only mode
            cfg.spec.services[decode_service_name].subComponentType = "decode"
448

449
450
451
452
453
454
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="vllm",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="vllm")
455
            args = break_arguments(args)
456

457
458
459
460
461
462
            # enable prefix caching
            if "--enable-prefix-caching" not in args:
                args = append_argument(args, "--enable-prefix-caching")
            if "--no-enable-prefix-caching" in args:
                args.remove("--no-enable-prefix-caching")

463
            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
464
465

        # set num workers to 1
466
467
468
469
470
        # Use the inferred decode service name
        final_decode_service_name = get_service_name_by_type(
            cfg.model_dump(), "vllm", SubComponentType.DECODE
        )
        decode_worker_config = cfg.spec.services[final_decode_service_name]
471
        decode_worker_config.replicas = 1
472

473
        return cfg.model_dump()
474
475
476

    @classmethod
    def set_config_tp_size(cls, config: dict, tp_size: int):
477
        cfg = Config.model_validate(config)
478
        worker_service = get_worker_service_from_config(config, backend="vllm")
479

480
481
        # Set up resources
        setup_worker_service_resources(worker_service, tp_size)
482

483
484
        # Get and validate args
        args = validate_and_get_worker_args(worker_service, backend="vllm")
485
486
487
488
489
490
491
492
        args = break_arguments(args)

        try:
            idx = args.index("--tensor-parallel-size")
            args[idx + 1] = str(tp_size)
        except ValueError:
            args = append_argument(args, ["--tensor-parallel-size", str(tp_size)])

493
        worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
494

495
        return cfg.model_dump()
496

497
498
499
500
501
502
503
504
505
506
507
508
    @classmethod
    def set_config_tep_size(cls, config: dict, tep_size: int, num_gpus_per_node: int):
        raise NotImplementedError(
            "TEP (Tensor Expert Parallelism) is not implemented for VLLM backend"
        )

    @classmethod
    def set_config_dep_size(cls, config: dict, dep_size: int, num_gpus_per_node: int):
        raise NotImplementedError(
            "DEP (Data Expert Parallelism) is not implemented for VLLM backend"
        )

509
510
    @classmethod
    def get_model_name(cls, config: dict) -> str:
511
512
513
514
        try:
            worker_service = get_worker_service_from_config(config, backend="vllm")
            args = validate_and_get_worker_args(worker_service, backend="vllm")
        except (ValueError, KeyError):
515
            logger.warning(
516
                f"Worker service missing or invalid, using default model name: {DEFAULT_MODEL_NAME}"
517
518
            )
            return DEFAULT_MODEL_NAME
519
520
521
522
523
524
525
526
527
528

        args = break_arguments(args)
        for i, arg in enumerate(args):
            if arg == "--model" and i + 1 < len(args):
                return args[i + 1]

        logger.warning(
            f"Model name not found in configuration args, using default model name: {DEFAULT_MODEL_NAME}"
        )
        return DEFAULT_MODEL_NAME
529
530
531

    @classmethod
    def get_port(cls, config: dict) -> int:
532
        cfg = Config.model_validate(config)
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
        frontend_service = cfg.spec.services.get("Frontend")
        if (
            not frontend_service
            or not frontend_service.extraPodSpec
            or not frontend_service.extraPodSpec.mainContainer
        ):
            logger.warning(
                f"Frontend service or container not found, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

        args = frontend_service.extraPodSpec.mainContainer.args
        if not args:
            logger.warning(
                f"No args found in Frontend configuration, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

551
552
553
554
        args = break_arguments(args)
        try:
            idx = args.index("--http-port")
            return int(args[idx + 1])
555
        except (ValueError, IndexError):
556
557
558
559
            logger.warning(
                f"Port not found in configuration args, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT
560
561

    @classmethod
562
563
564
    def get_kv_cache_size_from_dynamo_log(
        cls, dynamo_log_fn: str, attention_dp_size: int = 1
    ) -> int:
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
        try:
            with open(dynamo_log_fn, "r") as f:
                for line in f:
                    if "Maximum concurrency for" in line:
                        line = line.strip().split("Maximum concurrency for ")[1]
                        token_count = int(
                            line.split(" tokens per request: ")[0].replace(",", "")
                        )
                        concurrency = float(line.split(" tokens per request: ")[1][:-1])

                        logger.info(
                            f"Found KV cache info: {token_count} x {concurrency} = {int(token_count * concurrency)}"
                        )
                        return int(token_count * concurrency)
        except Exception as e:
            logger.warning(
                f"Failed to parse KV cache size from line: {line}. Error: {e}"
            )
        return 0


586
587
class SGLangConfigModifier:
    @classmethod
588
589
590
591
592
593
    def convert_config(
        cls,
        config: dict,
        target: Literal["prefill", "decode"],
        is_moe_model: bool = False,
    ) -> dict:
594
        cfg = Config.model_validate(config)
595
596

        # set metadata name
597
        cfg.metadata.name = "sglang-agg"
598
599

        # disable planner
600
601
        if "Planner" in cfg.spec.services:
            del cfg.spec.services["Planner"]
602
603

        if target == "prefill":
604
605
606
607
608
609
610
611
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "sglang", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "sglang", SubComponentType.DECODE
            )

612
            # convert prefill worker into decode worker
613
614
            cfg.spec.services[decode_service_name] = cfg.spec.services[
                prefill_service_name
615
            ]
616
            del cfg.spec.services[prefill_service_name]
617

618
619
            # Set subComponentType for aggregated mode (using decode worker for prefill-only)
            cfg.spec.services[decode_service_name].subComponentType = "decode"
620

621
622
623
624
625
626
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="sglang",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="sglang")
627
628
            args = break_arguments(args)

629
            # remove disagg flags
630
631
            args = remove_valued_arguments(args, "--disaggregation-mode")
            args = remove_valued_arguments(args, "--disaggregation-transfer-backend")
632
            args = remove_valued_arguments(args, "--disaggregation-bootstrap-port")
633
634
635
636
637

            # disable prefix caching
            if "--disable-radix-cache" not in args:
                args = append_argument(args, "--disable-radix-cache")

638
            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
639
640

        elif target == "decode":
641
642
643
644
645
646
647
648
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "sglang", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "sglang", SubComponentType.DECODE
            )

649
            # delete prefill worker
650
            del cfg.spec.services[prefill_service_name]
651

652
653
            # Set subComponentType for aggregated decode-only mode
            cfg.spec.services[decode_service_name].subComponentType = "decode"
654

655
656
657
658
659
660
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="sglang",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="sglang")
661
662
            args = break_arguments(args)

663
            # remove disagg flags
664
665
            args = remove_valued_arguments(args, "--disaggregation-mode")
            args = remove_valued_arguments(args, "--disaggregation-transfer-backend")
666
            args = remove_valued_arguments(args, "--disaggregation-bootstrap-port")
667
668
669
670
671

            # enable prefix caching
            if "--disable-radix-cache" in args:
                args.remove("--disable-radix-cache")

672
673
674
675
676
677
678
679
680
681
            if is_moe_model:
                # need to use round_robin dp attention routing for MoE models to ensure kv reuse can skip prefill
                if "--load-balance-method" in args:
                    idx = args.index("--load-balance-method")
                    args[idx + 1] = "round_robin"
                else:
                    args = append_argument(
                        args, ["--load-balance-method", "round_robin"]
                    )

682
            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
683
684

        # set num workers to 1
685
686
687
688
689
690
        # Use the inferred decode service name
        final_decode_service_name = get_service_name_by_type(
            cfg.model_dump(), "sglang", SubComponentType.DECODE
        )
        decode_worker_config = cfg.spec.services[final_decode_service_name]
        decode_worker_config.replicas = 1
691

692
        return cfg.model_dump()
693
694
695

    @classmethod
    def set_config_tp_size(cls, config: dict, tp_size: int):
696
        cfg = Config.model_validate(config)
697
        worker_service = get_worker_service_from_config(config, backend="sglang")
698

699
700
        # Set up resources
        setup_worker_service_resources(worker_service, tp_size)
701

702
        # Get and validate args
703
        args = validate_and_get_worker_args(worker_service, backend="sglang")
704

705
706
        # Set --tp argument
        args = set_argument_value(args, "--tp", str(tp_size))
707

708
709
        worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
        return cfg.model_dump()
710

711
712
713
    @classmethod
    def set_config_tep_size(cls, config: dict, tep_size: int, num_gpus_per_node: int):
        cfg = Config.model_validate(config)
714
        worker_service = get_worker_service_from_config(config, backend="sglang")
715

716
717
        # Set up resources with multinode configuration
        setup_worker_service_resources(worker_service, tep_size, num_gpus_per_node)
718

719
        # Get and validate args
720
        args = validate_and_get_worker_args(worker_service, backend="sglang")
721

722
723
724
725
726
727
728
729
730
731
732
733
        # 1. Set --tp=tep_size, if not present add it
        args = set_argument_value(args, "--tp", str(tep_size))

        # 2. Set --ep-size=tep_size, if not present add it
        args = set_argument_value(args, "--ep-size", str(tep_size))

        # 3. Remove --dp if present
        args = remove_valued_arguments(args, "--dp")

        # 4. Remove --enable-dp-attention if present
        if "--enable-dp-attention" in args:
            args.remove("--enable-dp-attention")
734

735
        worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
736
737
738
739
740
        return cfg.model_dump()

    @classmethod
    def set_config_dep_size(cls, config: dict, dep_size: int, num_gpus_per_node: int):
        cfg = Config.model_validate(config)
741
        worker_service = get_worker_service_from_config(config, backend="sglang")
742
743
744
745
746

        # Set up resources with multinode configuration
        setup_worker_service_resources(worker_service, dep_size, num_gpus_per_node)

        # Get and validate args
747
        args = validate_and_get_worker_args(worker_service, backend="sglang")
748
749
750
751
752
753
754
755
756
757

        # 1. Set --tp=dep_size
        args = set_argument_value(args, "--tp", str(dep_size))

        # 2. Set --dp=dep_size (data parallelism across experts)
        args = set_argument_value(args, "--dp", str(dep_size))

        # 3. Enable --enable-dp-attention
        if "--enable-dp-attention" not in args:
            args = append_argument(args, "--enable-dp-attention")
758

759
760
761
762
        # 4. Set --ep-size=dep_size (expert parallelism size)
        args = set_argument_value(args, "--ep-size", str(dep_size))

        worker_service.extraPodSpec.mainContainer.args = join_arguments(args)
763
        return cfg.model_dump()
764
765
766

    @classmethod
    def get_model_name(cls, config: dict) -> str:
767
768
769
770
        try:
            worker_service = get_worker_service_from_config(config, backend="sglang")
            args = validate_and_get_worker_args(worker_service, backend="sglang")
        except (ValueError, KeyError):
771
            logger.warning(
772
                f"Worker service missing or invalid, using default model name: {DEFAULT_MODEL_NAME}"
773
774
            )
            return DEFAULT_MODEL_NAME
775
776
777
778
779
780
781
782
783
784
785
786
787

        args = break_arguments(args)
        for i, arg in enumerate(args):
            if arg == "--served-model-name" and i + 1 < len(args):
                return args[i + 1]

        logger.warning(
            f"Model name not found in configuration args, using default model name: {DEFAULT_MODEL_NAME}"
        )
        return DEFAULT_MODEL_NAME

    @classmethod
    def get_port(cls, config: dict) -> int:
788
        cfg = Config.model_validate(config)
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
        frontend_service = cfg.spec.services.get("Frontend")
        if (
            not frontend_service
            or not frontend_service.extraPodSpec
            or not frontend_service.extraPodSpec.mainContainer
        ):
            logger.warning(
                f"Frontend service or container not found, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

        args = frontend_service.extraPodSpec.mainContainer.args
        if not args:
            logger.warning(
                f"No args found in Frontend configuration, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

807
808
809
810
        args = break_arguments(args)
        try:
            idx = args.index("--http-port")
            return int(args[idx + 1])
811
        except (ValueError, IndexError):
812
813
814
815
816
817
            logger.warning(
                f"Port not found in configuration args, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

    @classmethod
818
819
820
    def get_kv_cache_size_from_dynamo_log(
        cls, dynamo_log_fn: str, attention_dp_size: int = 1
    ) -> int:
821
822
823
824
825
826
827
        try:
            with open(dynamo_log_fn, "r") as f:
                for line in f:
                    if "KV Cache is allocated" in line and "#tokens:" in line:
                        # Extract the number after "#tokens:"
                        match = re.search(r"#tokens:\s*(\d+)", line)
                        if match:
828
                            return int(match.group(1)) * attention_dp_size
829
830
831
832
833
        except Exception as e:
            logger.warning(f"Failed to parse KV cache size from log file. Error: {e}")
        return 0


834
835
class TrtllmConfigModifier:
    @classmethod
836
837
838
839
840
841
842
843
844
845
846
    def convert_config(
        cls,
        config: dict,
        target: Literal["prefill", "decode"],
        is_moe_model: bool = False,
    ) -> dict:
        if is_moe_model:
            raise NotImplementedError(
                "MoE model support is not implemented for TrtLLM backend"
            )

847
848
849
850
851
852
853
854
855
856
        cfg = Config.model_validate(config)

        # set metadata name
        cfg.metadata.name = "trtllm-agg"

        # disable planner
        if "Planner" in cfg.spec.services:
            del cfg.spec.services["Planner"]

        if target == "prefill":
857
858
859
860
861
862
863
864
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "trtllm", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "trtllm", SubComponentType.DECODE
            )

865
            # Convert to prefill-only aggregated setup
866
867
868
869
870
871
872
873
            # Rename prefill worker to decode worker name
            cfg.spec.services[decode_service_name] = cfg.spec.services[
                prefill_service_name
            ]
            del cfg.spec.services[prefill_service_name]

            # Set subComponentType for aggregated mode (using decode worker for prefill-only)
            cfg.spec.services[decode_service_name].subComponentType = "decode"
874

875
876
877
878
879
880
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="trtllm",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="trtllm")
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
            args = break_arguments(args)

            # Remove disaggregation args
            args = remove_valued_arguments(args, "--disaggregation-mode")
            args = remove_valued_arguments(args, "--disaggregation-strategy")

            # Keep the original extra-engine-args (prefill.yaml) which may contain user settings
            # Check if user already has override-engine-args and merge with our changes
            override_dict, args = parse_override_engine_args(args)

            # Merge our overrides for converting prefill-only disagg to aggregated:
            # - Disable enable_block_reuse (no KV reuse for prefill-only)
            # - Enable overlap scheduler (disabled in prefill.yaml but needed for agg)
            # - Remove cache_transceiver_config (not needed in agg mode)
            if "kv_cache_config" not in override_dict:
                override_dict["kv_cache_config"] = {}
            override_dict["kv_cache_config"]["enable_block_reuse"] = False
            override_dict[
                "disable_overlap_scheduler"
            ] = False  # Enable overlap scheduler for agg
            override_dict[
                "cache_transceiver_config"
            ] = None  # Remove cache transceiver for agg

            override_str = json.dumps(override_dict)
            args = append_argument(args, ["--override-engine-args", override_str])

            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)

        elif target == "decode":
911
912
913
914
915
916
917
            # Get service names by inferring from subComponentType first
            prefill_service_name = get_service_name_by_type(
                config, "trtllm", SubComponentType.PREFILL
            )
            decode_service_name = get_service_name_by_type(
                config, "trtllm", SubComponentType.DECODE
            )
918

919
            # Convert to decode-only aggregated setup
920
            # Remove prefill worker if exists
921
            del cfg.spec.services[prefill_service_name]
922

923
924
925
926
927
928
929
930
931
932
            # Set subComponentType for aggregated decode-only mode
            cfg.spec.services[decode_service_name].subComponentType = "decode"

            # Decode worker already has the correct name
            worker_service = get_worker_service_from_config(
                cfg.model_dump(),
                backend="trtllm",
                sub_component_type=SubComponentType.DECODE,
            )
            args = validate_and_get_worker_args(worker_service, backend="trtllm")
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
            args = break_arguments(args)

            # Remove disaggregation args
            args = remove_valued_arguments(args, "--disaggregation-mode")
            args = remove_valued_arguments(args, "--disaggregation-strategy")

            # Keep the original extra-engine-args (decode.yaml) which may contain user settings
            # Check if user already has override-engine-args and merge with our changes
            override_dict, args = parse_override_engine_args(args)

            # Merge our overrides for converting decode-only disagg to aggregated:
            # - Enable enable_block_reuse (to skip prefill in decode-only)
            # - Remove cache_transceiver_config (not needed in agg mode)
            if "kv_cache_config" not in override_dict:
                override_dict["kv_cache_config"] = {}
            override_dict["kv_cache_config"]["enable_block_reuse"] = True
            override_dict[
                "cache_transceiver_config"
            ] = None  # Remove cache transceiver for agg

            override_str = json.dumps(override_dict)
            args = append_argument(args, ["--override-engine-args", override_str])

            worker_service.extraPodSpec.mainContainer.args = join_arguments(args)

        # Set num workers to 1
959
960
961
962
963
        # Use the inferred decode service name
        final_decode_service_name = get_service_name_by_type(
            cfg.model_dump(), "trtllm", SubComponentType.DECODE
        )
        worker_config = cfg.spec.services[final_decode_service_name]
964
965
966
967
968
969
970
971
        worker_config.replicas = 1

        return cfg.model_dump()

    @classmethod
    def set_config_tp_size(cls, config: dict, tp_size: int):
        cfg = Config.model_validate(config)

972
973
974
        # Get the worker service using helper function
        # This assumes convert_config has been called, so the service is named decode_worker_k8s_name
        worker_service = get_worker_service_from_config(config, backend="trtllm")
975

976
977
        # Set up resources
        setup_worker_service_resources(worker_service, tp_size)
978

979
980
        # Validate and get args
        args = validate_and_get_worker_args(worker_service, backend="trtllm")
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997

        # Break arguments to handle both joined strings and lists
        args = break_arguments(args)

        # For TRT-LLM, we need to update the override-engine-args
        # to set the tensor_parallel_size
        override_dict, args = parse_override_engine_args(args)

        # Add/update tensor_parallel_size in the override
        override_dict["tensor_parallel_size"] = tp_size
        override_str = json.dumps(override_dict)
        args = append_argument(args, ["--override-engine-args", override_str])

        worker_service.extraPodSpec.mainContainer.args = join_arguments(args)

        return cfg.model_dump()

998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
    @classmethod
    def set_config_tep_size(cls, config: dict, tep_size: int, num_gpus_per_node: int):
        raise NotImplementedError(
            "TEP (Tensor Expert Parallelism) is not implemented for TrtLLM backend"
        )

    @classmethod
    def set_config_dep_size(cls, config: dict, dep_size: int, num_gpus_per_node: int):
        raise NotImplementedError(
            "DEP (Data Expert Parallelism) is not implemented for TrtLLM backend"
        )

1010
1011
    @classmethod
    def get_model_name(cls, config: dict) -> str:
1012
1013
1014
1015
        try:
            worker_service = get_worker_service_from_config(config, backend="trtllm")
            args = validate_and_get_worker_args(worker_service, backend="trtllm")
        except (ValueError, KeyError):
1016
            logger.warning(
1017
                f"Worker service missing or invalid, using default model name: {DEFAULT_MODEL_NAME}"
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
            )
            return DEFAULT_MODEL_NAME

        args = break_arguments(args)
        for i, arg in enumerate(args):
            if arg == "--served-model-name" and i + 1 < len(args):
                return args[i + 1]

        logger.warning(
            f"Model name not found in configuration args, using default model name: {DEFAULT_MODEL_NAME}"
        )
        return DEFAULT_MODEL_NAME

    @classmethod
    def get_port(cls, config: dict) -> int:
        cfg = Config.model_validate(config)
        frontend_service = cfg.spec.services.get("Frontend")
        if (
            not frontend_service
            or not frontend_service.extraPodSpec
            or not frontend_service.extraPodSpec.mainContainer
        ):
            logger.warning(
                f"Frontend service or container not found, using default port: {DYNAMO_RUN_DEFAULT_PORT}"
            )
            return DYNAMO_RUN_DEFAULT_PORT

        # TRT-LLM frontend doesn't have args, it uses the default port
        return DYNAMO_RUN_DEFAULT_PORT

    @classmethod
1049
1050
1051
    def get_kv_cache_size_from_dynamo_log(
        cls, dynamo_log_fn: str, attention_dp_size: int = 1
    ) -> int:
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
        # TRT-LLM log parsing for KV cache size
        # Format: [TensorRT-LLM][INFO] [MemUsageChange] Allocated XX GiB for max tokens in paged KV cache (XXXXXX).
        try:
            with open(dynamo_log_fn, "r") as f:
                for line in f:
                    # Look for the specific TRT-LLM KV cache allocation log
                    if (
                        "Allocated" in line
                        and "for max tokens in paged KV cache" in line
                    ):
                        # Extract the number in parentheses at the end
                        match = re.search(r"paged KV cache \((\d+)\)", line)
                        if match:
                            max_tokens = int(match.group(1))
                            logger.info(
                                f"Found TRT-LLM KV cache max tokens: {max_tokens}"
                            )
                            return max_tokens
        except Exception as e:
            logger.warning(f"Failed to parse KV cache size from log file. Error: {e}")

        # Return a reasonable default if we couldn't find the KV cache size in logs
        logger.warning(
            "Could not find KV cache size in TRT-LLM logs, using default value of 100000"
        )
        return 100000  # Default fallback value for TRT-LLM


1080
CONFIG_MODIFIERS: dict[str, type[ConfigModifierProtocol]] = {
1081
    "vllm": VllmV1ConfigModifier,
1082
    "sglang": SGLangConfigModifier,
1083
    "trtllm": TrtllmConfigModifier,
1084
}
1085
1086
1087

# Re-export WORKER_COMPONENT_NAMES for profile_sla.py
__all__ = ["CONFIG_MODIFIERS", "WORKER_COMPONENT_NAMES"]