model_manager.rs 18.3 KB
Newer Older
1
2
3
// SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

4
5
use std::{
    collections::{HashMap, HashSet},
6
    sync::Arc,
7
8
};

9
use parking_lot::{Mutex, RwLock};
10
use tokio::sync::oneshot;
11

12
use dynamo_runtime::prelude::DistributedRuntimeProvider;
13
14
15
16
use dynamo_runtime::{
    component::{Component, Endpoint},
    storage::key_value_store::Key,
};
17
18

use crate::{
19
20
21
    discovery::KV_ROUTERS_ROOT_PATH,
    kv_router::{KvRouter, KvRouterConfig, scheduler::DefaultWorkerSelector},
    model_card::ModelDeploymentCard,
22
    model_type::ModelType,
23
24
25
26
27
28
29
30
    types::{
        generic::tensor::TensorStreamingEngine,
        openai::{
            chat_completions::OpenAIChatCompletionsStreamingEngine,
            completions::OpenAICompletionsStreamingEngine,
            embeddings::OpenAIEmbeddingsStreamingEngine,
        },
    },
31
};
32

33
34
35
36
37
38
39
40
/// State for prefill router activation rendezvous
enum PrefillActivationState {
    /// Decode model registered, waiting for prefill endpoint
    DecodeWaiting(oneshot::Sender<Endpoint>),
    /// Prefill endpoint arrived, waiting for decode model to register
    PrefillReady(oneshot::Receiver<Endpoint>),
}

41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
#[derive(Debug, thiserror::Error)]
pub enum ModelManagerError {
    #[error("Model not found: {0}")]
    ModelNotFound(String),

    #[error("Model already exists: {0}")]
    ModelAlreadyExists(String),
}

// Don't implement Clone for this, put it in an Arc instead.
pub struct ModelManager {
    // We read a lot and write rarely, so these three are RwLock
    completion_engines: RwLock<ModelEngines<OpenAICompletionsStreamingEngine>>,
    chat_completion_engines: RwLock<ModelEngines<OpenAIChatCompletionsStreamingEngine>>,
    embeddings_engines: RwLock<ModelEngines<OpenAIEmbeddingsStreamingEngine>>,
56
    tensor_engines: RwLock<ModelEngines<TensorStreamingEngine>>,
57
58
    // Prefill models don't have engines - they're only tracked for discovery/lifecycle
    prefill_engines: RwLock<ModelEngines<()>>,
59

60
    // These are Mutex because we read and write rarely and equally
61
    cards: Mutex<HashMap<String, ModelDeploymentCard>>,
62
63
    kv_choosers: Mutex<HashMap<String, Arc<KvRouter>>>, // Key: component service_name
    prefill_router_activators: Mutex<HashMap<String, PrefillActivationState>>,
64
65
66
67
68
69
70
71
72
73
74
75
76
77
}

impl Default for ModelManager {
    fn default() -> Self {
        Self::new()
    }
}

impl ModelManager {
    pub fn new() -> Self {
        Self {
            completion_engines: RwLock::new(ModelEngines::default()),
            chat_completion_engines: RwLock::new(ModelEngines::default()),
            embeddings_engines: RwLock::new(ModelEngines::default()),
78
            tensor_engines: RwLock::new(ModelEngines::default()),
79
            prefill_engines: RwLock::new(ModelEngines::default()),
80
            cards: Mutex::new(HashMap::new()),
81
            kv_choosers: Mutex::new(HashMap::new()),
82
            prefill_router_activators: Mutex::new(HashMap::new()),
83
84
85
        }
    }

86
87
88
89
90
91
92
93
94
95
96
97
98
    pub fn is_valid_checksum(
        &self,
        model_type: ModelType,
        model_name: &str,
        candidate_checksum: &str,
    ) -> Option<bool> {
        let mut results = vec![];
        for unit in model_type.units() {
            let maybe_valid_checksum = match unit {
                ModelType::Chat => self.chat_completion_engines.read().checksum(model_name),
                ModelType::Completions => self.completion_engines.read().checksum(model_name),
                ModelType::Embedding => self.embeddings_engines.read().checksum(model_name),
                ModelType::TensorBased => self.tensor_engines.read().checksum(model_name),
99
                ModelType::Prefill => self.prefill_engines.read().checksum(model_name),
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
                _ => {
                    continue;
                }
            };
            if let Some(is_valid) = maybe_valid_checksum.map(|valid_checksum| {
                tracing::debug!(
                    model_name,
                    valid_checksum,
                    candidate_checksum,
                    "is_valid_checksum: check case"
                );
                valid_checksum == candidate_checksum
            }) {
                results.push(is_valid)
            }
        }
        if results.is_empty() {
            None
        } else {
            // The checksum is valid if it is correct for all the ModelType in the bitflag.
            Some(results.into_iter().all(|x| x))
        }
    }

124
125
    pub fn get_model_cards(&self) -> Vec<ModelDeploymentCard> {
        self.cards.lock().values().cloned().collect()
126
127
    }

128
    pub fn has_model_any(&self, model: &str) -> bool {
129
130
        self.chat_completion_engines.read().contains(model)
            || self.completion_engines.read().contains(model)
131
132
    }

133
134
135
136
137
    pub fn model_display_names(&self) -> HashSet<String> {
        self.list_chat_completions_models()
            .into_iter()
            .chain(self.list_completions_models())
            .chain(self.list_embeddings_models())
138
            .chain(self.list_tensor_models())
139
            .chain(self.list_prefill_models())
140
141
142
            .collect()
    }

143
    pub fn list_chat_completions_models(&self) -> Vec<String> {
144
        self.chat_completion_engines.read().list()
145
146
147
    }

    pub fn list_completions_models(&self) -> Vec<String> {
148
        self.completion_engines.read().list()
149
150
151
    }

    pub fn list_embeddings_models(&self) -> Vec<String> {
152
        self.embeddings_engines.read().list()
153
154
    }

155
156
157
158
    pub fn list_tensor_models(&self) -> Vec<String> {
        self.tensor_engines.read().list()
    }

159
160
161
162
    pub fn list_prefill_models(&self) -> Vec<String> {
        self.prefill_engines.read().list()
    }

163
164
165
    pub fn add_completions_model(
        &self,
        model: &str,
166
        card_checksum: &str,
167
168
        engine: OpenAICompletionsStreamingEngine,
    ) -> Result<(), ModelManagerError> {
169
        let mut clients = self.completion_engines.write();
170
        clients.add(model, card_checksum, engine)
171
172
173
174
175
    }

    pub fn add_chat_completions_model(
        &self,
        model: &str,
176
        card_checksum: &str,
177
178
        engine: OpenAIChatCompletionsStreamingEngine,
    ) -> Result<(), ModelManagerError> {
179
        let mut clients = self.chat_completion_engines.write();
180
        clients.add(model, card_checksum, engine)
181
182
183
184
185
    }

    pub fn add_embeddings_model(
        &self,
        model: &str,
186
        card_checksum: &str,
187
188
        engine: OpenAIEmbeddingsStreamingEngine,
    ) -> Result<(), ModelManagerError> {
189
        let mut clients = self.embeddings_engines.write();
190
        clients.add(model, card_checksum, engine)
191
192
    }

193
194
195
    pub fn add_tensor_model(
        &self,
        model: &str,
196
        card_checksum: &str,
197
198
199
        engine: TensorStreamingEngine,
    ) -> Result<(), ModelManagerError> {
        let mut clients = self.tensor_engines.write();
200
        clients.add(model, card_checksum, engine)
201
202
    }

203
204
205
206
207
208
    pub fn add_prefill_model(
        &self,
        model: &str,
        card_checksum: &str,
    ) -> Result<(), ModelManagerError> {
        let mut clients = self.prefill_engines.write();
209
        clients.add(model, card_checksum, ())
210
211
    }

212
    pub fn remove_completions_model(&self, model: &str) -> Result<(), ModelManagerError> {
213
        let mut clients = self.completion_engines.write();
214
215
216
217
        clients.remove(model)
    }

    pub fn remove_chat_completions_model(&self, model: &str) -> Result<(), ModelManagerError> {
218
        let mut clients = self.chat_completion_engines.write();
219
220
221
222
        clients.remove(model)
    }

    pub fn remove_embeddings_model(&self, model: &str) -> Result<(), ModelManagerError> {
223
        let mut clients = self.embeddings_engines.write();
224
225
226
        clients.remove(model)
    }

227
228
229
230
231
    pub fn remove_tensor_model(&self, model: &str) -> Result<(), ModelManagerError> {
        let mut clients = self.tensor_engines.write();
        clients.remove(model)
    }

232
233
234
235
236
    pub fn remove_prefill_model(&self, model: &str) -> Result<(), ModelManagerError> {
        let mut clients = self.prefill_engines.write();
        clients.remove(model)
    }

237
    pub fn get_embeddings_engine(
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
        &self,
        model: &str,
    ) -> Result<OpenAIEmbeddingsStreamingEngine, ModelManagerError> {
        self.embeddings_engines
            .read()
            .get(model)
            .cloned()
            .ok_or(ModelManagerError::ModelNotFound(model.to_string()))
    }

    pub fn get_completions_engine(
        &self,
        model: &str,
    ) -> Result<OpenAICompletionsStreamingEngine, ModelManagerError> {
        self.completion_engines
            .read()
            .get(model)
            .cloned()
            .ok_or(ModelManagerError::ModelNotFound(model.to_string()))
    }

    pub fn get_chat_completions_engine(
        &self,
        model: &str,
    ) -> Result<OpenAIChatCompletionsStreamingEngine, ModelManagerError> {
        self.chat_completion_engines
            .read()
            .get(model)
            .cloned()
            .ok_or(ModelManagerError::ModelNotFound(model.to_string()))
    }

270
271
272
273
274
275
276
277
278
279
280
    pub fn get_tensor_engine(
        &self,
        model: &str,
    ) -> Result<TensorStreamingEngine, ModelManagerError> {
        self.tensor_engines
            .read()
            .get(model)
            .cloned()
            .ok_or(ModelManagerError::ModelNotFound(model.to_string()))
    }

281
282
283
284
285
    /// Save a ModelDeploymentCard from an instance's ModelDeploymentCard key so we can fetch it later when the key is
    /// deleted.
    pub fn save_model_card(&self, key: &str, card: ModelDeploymentCard) -> anyhow::Result<()> {
        self.cards.lock().insert(key.to_string(), card);
        Ok(())
286
287
    }

288
289
290
    /// Remove and return model card for this instance's etcd key. We do this when the instance stops.
    pub fn remove_model_card(&self, key: &str) -> Option<ModelDeploymentCard> {
        self.cards.lock().remove(key)
291
292
293
294
295
    }

    pub async fn kv_chooser_for(
        &self,
        component: &Component,
296
        kv_cache_block_size: u32,
297
        kv_router_config: Option<KvRouterConfig>,
298
    ) -> anyhow::Result<Arc<KvRouter>> {
299
300
301
        let service_name = component.service_name();

        if let Some(kv_chooser) = self.get_kv_chooser(&service_name) {
302
303
304
            // Check if the existing router has a different block size
            if kv_chooser.block_size() != kv_cache_block_size {
                tracing::warn!(
305
                    component = %service_name,
306
307
                    existing_block_size = %kv_chooser.block_size(),
                    requested_block_size = %kv_cache_block_size,
308
                    "KV Router block size mismatch! Component is requesting a different kv_cache_block_size than the existing router. \
309
310
311
                     This will cause routing to fail silently. Consider using the same block size or restarting the router."
                );
            }
312
313
314
            return Ok(kv_chooser);
        }

315
316
317
318
        let store = component.drt().store();
        let router_bucket = store
            .get_or_create_bucket(KV_ROUTERS_ROOT_PATH, None)
            .await?;
319
        let router_uuid = uuid::Uuid::new_v4();
320
321
322
323
        let router_key = Key::from_raw(format!("{}/{router_uuid}", component.path()));
        let json_router_config = serde_json::to_vec_pretty(&kv_router_config.unwrap_or_default())?;
        router_bucket
            .insert(&router_key, json_router_config.into(), 0)
324
325
            .await?;

326
        let selector = Box::new(DefaultWorkerSelector::new(kv_router_config));
327
328
329
330
        let chooser = KvRouter::new(
            component.clone(),
            kv_cache_block_size,
            Some(selector),
331
            kv_router_config,
332
            router_uuid.to_string(),
333
334
        )
        .await?;
335
336
337
        let new_kv_chooser = Arc::new(chooser);
        self.kv_choosers
            .lock()
338
            .insert(service_name, new_kv_chooser.clone());
339
340
        Ok(new_kv_chooser)
    }
341

342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
    fn get_kv_chooser(&self, service_name: &str) -> Option<Arc<KvRouter>> {
        self.kv_choosers.lock().get(service_name).cloned()
    }

    /// Register a prefill router for a decode model. Returns a receiver that will be
    /// activated when the corresponding prefill model is discovered.
    /// Returns None if the decode model was already registered.
    pub fn register_prefill_router(
        &self,
        model_name: String,
    ) -> Option<oneshot::Receiver<Endpoint>> {
        let mut activators = self.prefill_router_activators.lock();

        match activators.remove(&model_name) {
            Some(PrefillActivationState::PrefillReady(rx)) => {
                // Prefill endpoint already arrived - rx will immediately resolve
                tracing::debug!(
                    model_name = %model_name,
                    "Prefill endpoint already available, returning receiver with endpoint"
                );
                Some(rx)
            }
            Some(PrefillActivationState::DecodeWaiting(tx)) => {
                // Decode already registered - this shouldn't happen, restore state and return None
                tracing::error!(
                    model_name = %model_name,
                    "Decode model already registered for this prefill router"
                );
                activators.insert(model_name, PrefillActivationState::DecodeWaiting(tx));
                None
            }
            None => {
                // New registration: create tx/rx pair, store sender and return receiver
                let (tx, rx) = oneshot::channel();
                activators.insert(
                    model_name.clone(),
                    PrefillActivationState::DecodeWaiting(tx),
                );
                tracing::debug!(
                    model_name = %model_name,
                    "No prefill endpoint available yet, storing sender for future activation"
                );
                Some(rx)
            }
        }
    }

    /// Activate a prefill router by sending the endpoint through the oneshot channel.
    /// If no decode model has registered yet, stores the endpoint for future retrieval.
    pub fn activate_prefill_router(
        &self,
        model_name: &str,
        endpoint: Endpoint,
    ) -> anyhow::Result<()> {
        let mut activators = self.prefill_router_activators.lock();

        match activators.remove(model_name) {
            Some(PrefillActivationState::DecodeWaiting(sender)) => {
                // Decode model already registered
                sender.send(endpoint).map_err(|_| {
                    anyhow::anyhow!(
                        "Failed to send endpoint to prefill router activator for model: {}",
                        model_name
                    )
                })?;

                tracing::info!(
                    model_name = %model_name,
                    "Activated prefill router for already-registered decode model"
                );

                Ok(())
            }
            Some(PrefillActivationState::PrefillReady(_)) => {
                // Prefill already activated - this shouldn't happen
                anyhow::bail!("Prefill router for model {} already activated", model_name);
            }
            None => {
                // Decode model not registered yet - create pair and immediately send endpoint
                let (tx, rx) = oneshot::channel();

                tx.send(endpoint).map_err(|_| {
                    anyhow::anyhow!("Failed to send endpoint for prefill model: {}", model_name)
                })?;

                // Store the receiver for when decode model registers
                activators.insert(
                    model_name.to_string(),
                    PrefillActivationState::PrefillReady(rx),
                );

                tracing::info!(
                    model_name = %model_name,
                    "Stored prefill endpoint for future decode model registration"
                );

                Ok(())
            }
        }
441
442
    }

443
    pub fn get_model_tool_call_parser(&self, model: &str) -> Option<String> {
444
        self.cards
445
446
            .lock()
            .values()
447
448
            .find(|c| c.display_name == model)
            .and_then(|c| c.runtime_config.tool_call_parser.as_ref())
449
            .map(|parser| parser.to_string())
450
    }
451
452
453
454
455
456
457
458
459

    /// Creates parsing options with tool call parser and reasoning parser for the specified model.
    /// Currently reasoning parser is not implemented (returns None).
    pub fn get_parsing_options(&self, model: &str) -> crate::protocols::openai::ParsingOptions {
        let tool_call_parser = self.get_model_tool_call_parser(model);
        let reasoning_parser = None; // TODO: Implement reasoning parser

        crate::protocols::openai::ParsingOptions::new(tool_call_parser, reasoning_parser)
    }
460
461
462
463
464
465
}

pub struct ModelEngines<E> {
    /// Optional default model name
    default: Option<String>,
    engines: HashMap<String, E>,
466
467
468
    /// Key: Model name, value: Checksum of the ModelDeploymentCard. New instances must have the
    /// same card.
    checksums: HashMap<String, String>,
469
470
471
472
473
474
475
}

impl<E> Default for ModelEngines<E> {
    fn default() -> Self {
        Self {
            default: None,
            engines: HashMap::new(),
476
            checksums: HashMap::new(),
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
        }
    }
}

impl<E> ModelEngines<E> {
    #[allow(dead_code)]
    fn set_default(&mut self, model: &str) {
        self.default = Some(model.to_string());
    }

    #[allow(dead_code)]
    fn clear_default(&mut self) {
        self.default = None;
    }

492
    fn add(&mut self, model: &str, checksum: &str, engine: E) -> Result<(), ModelManagerError> {
493
494
495
496
        if self.engines.contains_key(model) {
            return Err(ModelManagerError::ModelAlreadyExists(model.to_string()));
        }
        self.engines.insert(model.to_string(), engine);
497
498
        self.checksums
            .insert(model.to_string(), checksum.to_string());
499
500
501
502
503
504
505
        Ok(())
    }

    fn remove(&mut self, model: &str) -> Result<(), ModelManagerError> {
        if self.engines.remove(model).is_none() {
            return Err(ModelManagerError::ModelNotFound(model.to_string()));
        }
506
        let _ = self.checksums.remove(model);
507
508
509
510
511
512
513
514
515
516
517
518
519
520
        Ok(())
    }

    fn get(&self, model: &str) -> Option<&E> {
        self.engines.get(model)
    }

    fn contains(&self, model: &str) -> bool {
        self.engines.contains_key(model)
    }

    pub fn list(&self) -> Vec<String> {
        self.engines.keys().map(|k| k.to_owned()).collect()
    }
521
522
523
524
525
526

    /// Returns a newly allocated String for called convenience. All the places I use
    /// this I need a String.
    pub fn checksum(&self, model: &str) -> Option<String> {
        self.checksums.get(model).map(|s| s.to_string())
    }
527
}