1. 23 Jan, 2025 1 commit
    • Kishore Venkateshan's avatar
      4/N Batchify EdgeGrad · 910228e6
      Kishore Venkateshan authored
      Summary:
      # Problem
      In CT / State Encoding, we expect a scenario where we would like to render a batch of topologies where each of them would have different number of vertices and triangles. Currently the only way to support this with DRTK is to iterate over the batch in a for loop for each topology and render it.
      In a series of diffs we would like to solve this issue by making drtk consume a batch of triangles as opposed to just 1 set of triangles. However, we would like to achieve this behavior without affecting the most common single topology case by a lot.
      
      # How do we pass in multiple topologies in a single batch?
      We will provide a TopologyBatch structure in xrcia/lib/graphics/structures where we will provide functionality to create a Batch x MaxTriangles x 3 and Batch x MaxVertices x 3.
      Padded vertices will be 0s and padded triangles will have MaxVertices - 1 as their value. But these will discarded as degenerate in rasterization / rendering.
      
      # In this diff
      - Extend `edge_grad_estimator` to support a batch dimension as default.
      - `edge_grad_kernel` will now unsqueeze the batch dimension when using a single topo
      - We access the vertex indices of triangles by walking an additional `batch stride * n` in the triangles data pointer.
      - Add an extra condition to check to see if the triangles are degenerate; this happens when padding the batch.
      - We show that the optimization continues to produce the same results as in D68538236
      
      Reviewed By: podgorskiy
      
      Differential Revision: D68534639
      
      fbshipit-source-id: 4f0ed24075d71b73b9313ecc61296e9567219b0d
      910228e6
  2. 26 Sep, 2024 1 commit
    • Stanislav Pidhorskyi's avatar
      Licence change to MIT · 36eb2e83
      Stanislav Pidhorskyi authored
      Summary: Got legal approval 🥳
      
      Reviewed By: una-dinosauria
      
      Differential Revision: D63428775
      
      fbshipit-source-id: 7568ef2861ef10c2bd0367a7195cbbedf96ec8be
      36eb2e83
  3. 08 Jun, 2024 1 commit