1. 28 Sep, 2019 2 commits
    • Da Zheng's avatar
      Sort csr (#886) · 65e1ba4f
      Da Zheng authored
      * sort
      
      * sort in parallel.
      
      * fix a bug in sorting adj
      
      * rename.
      
      * add more comments.
      
      * accelerate GetData
      
      * fix tests.
      
      * avoid sorting multiple times.
      
      * add test.
      
      * change back.
      
      * sort.
      
      * add sort_csr.
      
      * Fix a bug.
      
      * fix.
      
      * revert modifcation.
      
      * rename
      
      * speed up EdgeIds.
      65e1ba4f
    • VoVAllen's avatar
      [Fix] Fix serialize NDArray when shape is 0 (#884) · 54e1ef2e
      VoVAllen authored
      * fix
      
      * fix bugs
      54e1ef2e
  2. 26 Sep, 2019 2 commits
  3. 23 Sep, 2019 1 commit
  4. 22 Sep, 2019 1 commit
  5. 17 Sep, 2019 1 commit
    • Minjie Wang's avatar
      [Hetero] New syntax (#824) · 9b4d6079
      Minjie Wang authored
      * WIP. remove graph arg in NodeBatch and EdgeBatch
      
      * refactor: use graph adapter for scheduler
      
      * WIP: recv
      
      * draft impl
      
      * stuck at bipartite
      
      * bipartite->unitgraph; support dsttype == srctype
      
      * pass test_query
      
      * pass test_query
      
      * pass test_view
      
      * test apply
      
      * pass udf message passing tests
      
      * pass quan's test using builtins
      
      * WIP: wildcard slicing
      
      * new construct methods
      
      * broken
      
      * good
      
      * add stack cross reducer
      
      * fix bug; fix mx
      
      * fix bug in csrmm2 when the CSR is not square
      
      * lint
      
      * removed FlattenedHeteroGraph class
      
      * WIP
      
      * prop nodes, prop edges, filter nodes/edges
      
      * add DGLGraph tests to heterograph. Fix several bugs
      
      * finish nx<->hetero graph conversion
      
      * create bipartite from nx
      
      * more spec on hetero/homo conversion
      
      * silly fixes
      
      * check node and edge types
      
      * repr
      
      * to api
      
      * adj APIs
      
      * inc
      
      * fix some lints and bugs
      
      * fix some lints
      
      * hetero/homo conversion
      
      * fix flatten test
      
      * more spec in hetero_from_homo and test
      
      * flatten using concat names
      
      * WIP: creators
      
      * rewrite hetero_from_homo in a more efficient way
      
      * remove useless variables
      
      * fix lint
      
      * subgraphs and typed subgraphs
      
      * lint & removed heterosubgraph class
      
      * lint x2
      
      * disable heterograph mutation test
      
      * docstring update
      
      * add edge id for nx graph test
      
      * fix mx unittests
      
      * fix bug
      
      * try fix
      
      * fix unittest when cross_reducer is stack
      
      * fix ci
      
      * fix nx bipartite bug; docstring
      
      * fix scipy creation bug
      
      * lint
      
      * fix bug when converting heterograph from homograph
      
      * fix bug in hetero_from_homo about ntype order
      
      * trailing white
      
      * docstring fixes for add_foo and data views
      
      * docstring for relation slice
      
      * to_hetero and to_homo with feature support
      
      * lint
      
      * lint
      
      * DGLGraph compatibility
      
      * incidence matrix & docstring fixes
      
      * example string fixes
      
      * feature in hetero_from_relations
      
      * deduplication of edge types in to_hetero
      
      * fix lint
      
      * fix
      9b4d6079
  6. 14 Sep, 2019 1 commit
    • xiang song(charlie.song)'s avatar
      [Feature] x_dot_x builtin kernel support (#831) · 0a56d652
      xiang song(charlie.song) authored
      * upd
      
      * fig edgebatch edges
      
      * add test
      
      * trigger
      
      * Update README.md for pytorch PinSage example.
      
      Add noting that the PinSage model example under
      example/pytorch/recommendation only work with Python 3.6+
      as its dataset loader depends on stanfordnlp package
      which work only with Python 3.6+.
      
      * Provid a frame agnostic API to test nn modules on both CPU and CUDA side.
      
      1. make dgl.nn.xxx frame agnostic
      2. make test.backend include dgl.nn modules
      3. modify test_edge_softmax of test/mxnet/test_nn.py and
          test/pytorch/test_nn.py work on both CPU and GPU
      
      * Fix style
      
      * Delete unused code
      
      * Make agnostic test only related to tests/backend
      
      1. clear all agnostic related code in dgl.nn
      2. make test_graph_conv agnostic to cpu/gpu
      
      * Fix code style
      
      * fix
      
      * doc
      
      * Make all test code under tests.mxnet/pytorch.test_nn.py
      work on both CPU and GPU.
      
      * Fix syntex
      
      * Remove rand
      
      * Start implementing masked-mm kernel.
      
      Add base control flow code.
      
      * Add masked dot declare
      
      * Update func/variable name
      
      * Skeleton compile OK
      
      * Update Implement. Unify BinaryDot with BinaryReduce
      
      * New Impl of x_dot_x, reuse binary reduce template
      
      * Compile OK.
      
      TODO:
      1. make sure x_add_x, x_sub_x, x_mul_x, x_div_x work
      2. let x_dot_x work
      3. make sure backward of x_add_x, x_sub_x, x_mul_x, x_div_x work
      4. let x_dot_x backward work
      
      * Fix code style
      
      * Now we can pass the tests/compute/test_kernel.py for add/sub/mul/div forward and backward
      
      * Fix mxnet test code
      
      * Add u_dot_v, u_dot_e, v_dot_e unitest.
      
      * Update doc
      
      * Now also support v_dot_u, e_dot_u, e_dot_v
      
      * Add unroll for some loop
      
      * Add some Opt for cuda backward of dot builtin.
      
      Backward is still slow for dot
      
      * Apply UnravelRavel opt for broadcast backward
      
      * update docstring
      0a56d652
  7. 11 Sep, 2019 2 commits
    • Da Zheng's avatar
      [Feature] add PBG's negative edge sampling. (#836) · 4297e6d6
      Da Zheng authored
      * PBG negative edge sampler.
      
      * add a positive edge to make it regular, handle last batch.
      
      * exclude all positive edges in the parent graph.
      
      * just uniformly sample negative nodes.
      
      * fix lint.
      
      * shuffle one-side nodes of positive edges.
      
      * just uniformly sample negative nodes.
      
      * change the data type.
      
      * address comment.
      
      * remove commented code.
      4297e6d6
    • Chao Ma's avatar
      [KVStore] Distributed kvstore (#851) · 77822769
      Chao Ma authored
      * update
      
      * speedup
      
      * add some comments
      77822769
  8. 10 Sep, 2019 1 commit
    • VoVAllen's avatar
      [Fix on Mac] Data format (#848) · 4e0e6697
      VoVAllen authored
      * Add serialization
      
      * add serialization
      
      * add serialization
      
      * lalalalalalalala
      
      * lalalalalalalala
      
      * serialize
      
      * serialize
      
      * nnn
      
      * WIP: import tvm runtime node system
      
      * WIP: object system
      
      * containers
      
      * tested basic container composition
      
      * tested custom object
      
      * tmp
      
      * fix setattr bug
      
      * tested object container return
      
      * fix lint
      
      * some comments about get/set state
      
      * fix lint
      
      * fix lint
      
      * update cython
      
      * fix cython
      
      * ffi doc
      
      * fix doc
      
      * WIP: using object system for graph
      
      * c++ side refactoring done; compiled
      
      * remove stale apis
      
      * fix bug in DGLGraphCreate; passed test_graph.py
      
      * fix bug in python modify; passed utest for pytorch/cpu
      
      * fix lint
      
      * Add serialization
      
      * Add serialization
      
      * fix
      
      * fix typo
      
      * serialize with new ffi
      
      * commit
      
      * commit
      
      * commit
      
      * save
      
      * save
      
      * save
      
      * save
      
      * commit
      
      * clean
      
      * Delete tt2.py
      
      * fix lint
      
      * Add serialization
      
      * fix lint 2
      
      * fix lint
      
      * fix lint
      
      * fix lint
      
      * fix lint
      
      * Fix Lint
      
      * Add serialization
      
      * Change to Macro
      
      * fix
      
      * fix
      
      * fix bugs
      
      * refactor
      
      * refactor
      
      * updating dmlc-core to include force flag
      
      * trying tempfile
      
      * delete leaked pointer
      
      * Fix assert
      
      * fix assert
      
      * add comment and test case
      
      * add graph labels
      
      * add load labels
      
      * lint
      
      * lint
      
      * add graph labels
      
      * lint
      
      *  fix windows
      
      * fix
      
      * update dmlc-core to latest
      
      * fix
      
      * fix camel naming
      
      * fix
      
      * poke ci
      4e0e6697
  9. 09 Sep, 2019 1 commit
    • VoVAllen's avatar
      [Feature] Data format (#728) · 0fb13f7b
      VoVAllen authored
      * Add serialization
      
      * add serialization
      
      * add serialization
      
      * lalalalalalalala
      
      * lalalalalalalala
      
      * serialize
      
      * serialize
      
      * nnn
      
      * WIP: import tvm runtime node system
      
      * WIP: object system
      
      * containers
      
      * tested basic container composition
      
      * tested custom object
      
      * tmp
      
      * fix setattr bug
      
      * tested object container return
      
      * fix lint
      
      * some comments about get/set state
      
      * fix lint
      
      * fix lint
      
      * update cython
      
      * fix cython
      
      * ffi doc
      
      * fix doc
      
      * WIP: using object system for graph
      
      * c++ side refactoring done; compiled
      
      * remove stale apis
      
      * fix bug in DGLGraphCreate; passed test_graph.py
      
      * fix bug in python modify; passed utest for pytorch/cpu
      
      * fix lint
      
      * Add serialization
      
      * Add serialization
      
      * fix
      
      * fix typo
      
      * serialize with new ffi
      
      * commit
      
      * commit
      
      * commit
      
      * save
      
      * save
      
      * save
      
      * save
      
      * commit
      
      * clean
      
      * Delete tt2.py
      
      * fix lint
      
      * Add serialization
      
      * fix lint 2
      
      * fix lint
      
      * fix lint
      
      * fix lint
      
      * fix lint
      
      * Fix Lint
      
      * Add serialization
      
      * Change to Macro
      
      * fix
      
      * fix
      
      * fix bugs
      
      * refactor
      
      * refactor
      
      * updating dmlc-core to include force flag
      
      * trying tempfile
      
      * delete leaked pointer
      
      * Fix assert
      
      * fix assert
      
      * add comment and test case
      
      * add graph labels
      
      * add load labels
      
      * lint
      
      * lint
      
      * add graph labels
      
      * lint
      
      *  fix windows
      
      * fix
      
      * update dmlc-core to latest
      
      * fix
      
      * fix camel naming
      0fb13f7b
  10. 08 Sep, 2019 1 commit
    • xiang song(charlie.song)'s avatar
      [Kernel][Perf] Message builtin with broadcasting performance optimization (#815) · bcd33e0a
      xiang song(charlie.song) authored
      * upd
      
      * fig edgebatch edges
      
      * add test
      
      * trigger
      
      * Update README.md for pytorch PinSage example.
      
      Add noting that the PinSage model example under
      example/pytorch/recommendation only work with Python 3.6+
      as its dataset loader depends on stanfordnlp package
      which work only with Python 3.6+.
      
      * Provid a frame agnostic API to test nn modules on both CPU and CUDA side.
      
      1. make dgl.nn.xxx frame agnostic
      2. make test.backend include dgl.nn modules
      3. modify test_edge_softmax of test/mxnet/test_nn.py and
          test/pytorch/test_nn.py work on both CPU and GPU
      
      * Fix style
      
      * Delete unused code
      
      * Make agnostic test only related to tests/backend
      
      1. clear all agnostic related code in dgl.nn
      2. make test_graph_conv agnostic to cpu/gpu
      
      * Fix code style
      
      * fix
      
      * doc
      
      * Make all test code under tests.mxnet/pytorch.test_nn.py
      work on both CPU and GPU.
      
      * Fix syntex
      
      * Remove rand
      
      * Add TAGCN nn.module and example
      
      * Now tagcn can run on CPU.
      
      * Add unitest for TGConv
      
      * Fix style
      
      * For pubmed dataset, using --lr=0.005 can achieve better acc
      
      * Fix style
      
      * Fix some descriptions
      
      * Test performance of udf
      
      * trigger
      
      * Fix doc
      
      * Add nn.TGConv and example
      
      * Update test code
      
      * Fix bug
      
      * Update data in mxnet.tagcn test acc.
      
      * Fix some comments and code
      
      * delete useless code
      
      * Fix namming
      
      * Fix bug
      
      * Fix bug
      
      * Add test for mxnet TAGCov
      
      * Add test code for mxnet TAGCov
      
      * Update some docs
      
      * Fix some code
      
      * Update docs dgl.nn.mxnet
      
      * Update weight init
      
      * Fix
      
      * Minor opt for URRevel
      
      * Delete test code
      
      * Update code style and notes.
      
      * Fix func name
      bcd33e0a
  11. 23 Aug, 2019 1 commit
    • Quan (Andy) Gan's avatar
      [Hetero][RFC] Heterogeneous graph Python interfaces & Message Passing (#752) · 52d4535b
      Quan (Andy) Gan authored
      * moving heterograph index to another file
      
      * node view
      
      * python interfaces
      
      * heterograph init
      
      * bug fixes
      
      * docstring for readonly
      
      * more docstring
      
      * unit tests & lint
      
      * oops
      
      * oops x2
      
      * removed node/edge addition
      
      * addressed comments
      
      * lint
      
      * rw on frames with one node/edge type
      
      * homograph with underlying heterograph demo
      
      * view is not necessary
      
      * bugfix
      
      * replace
      
      * scheduler, builtins not working yet
      
      * moving bipartite.h to header
      
      * moving back bipartite to bipartite.h
      
      * oops
      
      * asbits and copyto for bipartite
      
      * tested update_all and send_and_recv
      
      * lightweight node & edge type retrieval
      
      * oops
      
      * sorry
      
      * removing obsolete code
      
      * oops
      
      * lint
      
      * various bug fixes & more tests
      
      * UDF tests
      
      * multiple type number_of_nodes and number_of_edges
      
      * docstring fixes
      
      * more tests
      
      * going for dict in initialization
      
      * lint
      
      * updated api as per discussions
      
      * lint
      
      * bug
      
      * bugfix
      
      * moving back bipartite impl to cc
      
      * note on views
      
      * fix
      52d4535b
  12. 22 Aug, 2019 1 commit
    • Da Zheng's avatar
      [Feature] Add edge sampling for link prediction (#780) · 66971c1a
      Da Zheng authored
      * add edge sampler.
      
      * add test and run.
      
      * add negative sampling.
      
      * remap the edge subgraph vid.
      
      * negative graph excludes edges of positive edgs.
      
      * remove print.
      
      * avoid sampling NodeFlow when expand_factor or num_hops is 0.
      
      * fix a bug when excluding nodes in negative graph.
      
      * support multigraph.
      
      * exclude positive edges.
      
      * fix memory leak.
      
      * return subgraph object directly.
      
      * fix many problems.
      
      * add comments.
      
      * address comments
      66971c1a
  13. 21 Aug, 2019 1 commit
  14. 18 Aug, 2019 1 commit
  15. 07 Aug, 2019 2 commits
    • Chao Ma's avatar
      [Fix] Hold NDArray reference during send() (#740) · 747a8bee
      Chao Ma authored
      * fix NDArray reference
      
      * fix lint
      
      * capture NDArray in the closure
      747a8bee
    • Quan (Andy) Gan's avatar
      [NodeFlow] Non-uniform neighbor sampling (#711) · 16061925
      Quan (Andy) Gan authored
      * nonuniform sampler
      
      * unit test
      
      * test on out neighbors
      
      * error checks
      
      * lint
      
      * fix
      
      * clarification
      
      * use macro switcher
      
      * use empty array for uniform sampling
      
      * oops
      
      * Revert "oops"
      
      This reverts commit a11f9ae707aaeb67fb5921c887a17d3711d5b04a.
      
      * Revert "use empty array for uniform sampling"
      
      This reverts commit 8526ce4cade89f2c1b09a08aca8830375ebafb31.
      
      * re-reverting
      
      * use a method
      16061925
  16. 05 Aug, 2019 1 commit
    • Chao Ma's avatar
      [Network] Refactoring Communicator (#679) · c3516f1a
      Chao Ma authored
      * Refactoring Communicator
      
      * fix lint
      
      * change non-const reference
      
      * add header file
      
      * use MemoryBuffer
      
      * update PR
      
      * fix bug on csr shape
      
      * zero-copy msg_queue
      
      * fix lint
      
      * fix lint
      
      * fix lint
      
      * add header file
      
      * fix windows build error
      
      * fix windows build error
      
      * update
      
      * fix lint
      
      * update
      
      * fix lint
      
      * fix lint
      
      * add more test
      
      * fix windows test
      
      * update windows test
      
      * update windows test
      
      * update windows test
      
      * update
      
      * fix lint
      
      * fix lint
      
      * update
      
      * update
      
      * update
      
      * update
      
      * use STATUS code
      
      * update test
      
      * remove mem_cpy
      
      * fix lint
      
      * update
      
      * finish
      
      * ConstructNFTensor
      
      * add test for deallocator
      
      * update
      
      * fix lint
      c3516f1a
  17. 31 Jul, 2019 1 commit
    • Quan (Andy) Gan's avatar
      [Refactor] C random number generator (#729) · e9e587b6
      Quan (Andy) Gan authored
      * rng refactor
      
      * fix bugs
      
      * unit test
      
      * remove setsize
      
      * lint
      
      * fix test
      
      * use explicit instantiation instead of inlining
      
      * stricter test
      
      * use tvm solution
      
      * moved python interface to dgl.random
      
      * lint
      
      * address comments
      
      * make getthreadid an inline function
      e9e587b6
  18. 27 Jul, 2019 1 commit
    • Minjie Wang's avatar
      [Hetero] Heterograph C++ implementation; Bipartite and Python wrapper (#725) · 7ad663c3
      Minjie Wang authored
      * finish bipartite graph implementation; compiled
      
      * finished heterograph implementation; compiled
      
      * WIP: apis
      
      * C API codes
      
      * compiled
      
      * WIP: python
      
      * HeteroGraphIndex
      
      * WIP: test
      
      * add DGLContext support in ffi
      
      * fix bug in has edge
      
      * unittests except edge subgraph
      
      * edge subgraph
      
      * fix lint
      
      * address comments
      
      * poke ci
      
      * try fix
      
      * fix msvc
      7ad663c3
  19. 23 Jul, 2019 1 commit
    • Minjie Wang's avatar
      [Refactor] Use object system for all CAPIs (#716) · 67dc1197
      Minjie Wang authored
      * WIP: using object system for graph
      
      * c++ side refactoring done; compiled
      
      * remove stale apis
      
      * fix bug in DGLGraphCreate; passed test_graph.py
      
      * fix bug in python modify; passed utest for pytorch/cpu
      
      * fix lint
      
      * address comments
      67dc1197
  20. 17 Jul, 2019 1 commit
    • Minjie Wang's avatar
      [Refactor] Separating graph and sparse matrix operations (#699) · b0d9e7aa
      Minjie Wang authored
      * WIP: array refactoring
      
      * WIP: implementation
      
      * wip
      
      * most csr part
      
      * WIP: on coo
      
      * WIP: coo
      
      * finish refactoring immutable graph
      
      * compiled
      
      * fix undefined ndarray copy bug; add COOToCSR when coo has no data array
      
      * fix bug in COOToCSR
      
      * fix bug in CSR constructor
      
      * fix bug in in_edges(vid)
      
      * fix OutEdges bug
      
      * pass test_graph
      
      * pass test_graph
      
      * fix bug in CSR constructor
      
      * fix bug in CSR constructor
      
      * fix bug in CSR constructor
      
      * fix stupid bug
      
      * pass gpu test
      
      * remove debug printout
      
      * fix lint
      
      * rm biparate grpah
      
      * fix lint
      
      * address comments
      
      * fix bug in Clone
      
      * cpp utests
      b0d9e7aa
  21. 01 Jul, 2019 1 commit
    • Minjie Wang's avatar
      [FFI] FFI container support, custom structure extension via Object (#693) · 90e78c58
      Minjie Wang authored
      * WIP: import tvm runtime node system
      
      * WIP: object system
      
      * containers
      
      * tested basic container composition
      
      * tested custom object
      
      * fix setattr bug
      
      * tested object container return
      
      * fix lint
      
      * some comments about get/set state
      
      * fix lint
      
      * fix lint
      
      * update cython
      
      * fix cython
      
      * ffi doc
      
      * fix doc
      90e78c58
  22. 27 Jun, 2019 1 commit
  23. 12 Jun, 2019 1 commit
  24. 11 Jun, 2019 1 commit
  25. 10 Jun, 2019 1 commit
  26. 08 Jun, 2019 2 commits
  27. 07 Jun, 2019 2 commits
  28. 06 Jun, 2019 1 commit
    • Lingfan Yu's avatar
      [Feature][Kernel] DGL kernel support (#596) · 653428bd
      Lingfan Yu authored
      * [Kernel] Minigun integration and fused kernel support (#519)
      
      * kernel interface
      
      * add minigun
      
      * Add cuda build
      
      * functors
      
      * working on binary elewise
      
      * binary reduce
      
      * change kernel interface
      
      * WIP
      
      * wip
      
      * fix minigun
      
      * compile
      
      * binary reduce kernels
      
      * compile
      
      * simple test passed
      
      * more reducers
      
      * fix thrust problem
      
      * fix cmake
      
      * fix cmake; add proper guard for atomic
      
      * WIP: bcast
      
      * WIP
      
      * bcast kernels
      
      * update to new minigun pass-by-value practice
      
      * broadcasting dim
      
      * add copy src and copy edge
      
      * fix linking
      
      * fix none array problem
      
      * fix copy edge
      
      * add device_type and device_id to backend operator
      
      * cache csr adj, remove cache for adjmat and incmat
      
      * custom ops in backend and pytorch impl
      
      * change dgl-mg kernel python interface
      
      * add id_mapping var
      
      * clean up plus v2e spmv schedule
      
      * spmv schedule & clean up fall back
      
      * symbolic message and reduce func, remove bundle func
      
      * new executors
      
      * new backend interface for dgl kernels and pytorch impl
      
      * minor fix
      
      * fix
      
      * fix docstring, comments, func names
      
      * nodeflow
      
      * fix message id mapping and bugs...
      
      * pytorch test case & fix
      
      * backward binary reduce
      
      * fix bug
      
      * WIP: cusparse
      
      * change to int32 csr for cusparse workaround
      
      * disable cusparse
      
      * change back to int64
      
      * broadcasting backward
      
      * cusparse; WIP: add rev_csr
      
      * unit test for kernels
      
      * pytorch backward with dgl kernel
      
      * edge softmax
      
      * fix backward
      
      * improve softmax
      
      * cache edge on device
      
      * cache mappings on device
      
      * fix partial forward code
      
      * cusparse done
      
      * copy_src_sum with cusparse
      
      * rm id getter
      
      * reduce grad for broadcast
      
      * copy edge reduce backward
      
      * kernel unit test for broadcasting
      
      * full kernel unit test
      
      * add cpu kernels
      
      * edge softmax unit test
      
      * missing ref
      
      * fix compile and small bugs
      
      * fix bug in bcast
      
      * Add backward both
      
      * fix torch utests
      
      * expose infershape
      
      * create out tensor in python
      
      * fix c++ lint
      
      * [Kernel] Add GPU utest and kernel utest (#524)
      
      * fix gpu utest
      
      * cuda utest runnable
      
      * temp disable test nodeflow; unified test for kernel
      
      * cuda test kernel done
      
      * [Kernel] Update kernel branch (#550)
      
      * [Model] add multiprocessing training with sampling. (#484)
      
      * reorganize sampling code.
      
      * add multi-process training.
      
      * speed up gcn_cv
      
      * fix graphsage_cv.
      
      * add new API in graph store.
      
      * update barrier impl.
      
      * support both local and distributed training.
      
      * fix multiprocess train.
      
      * fix.
      
      * fix barrier.
      
      * add script for loading data.
      
      * multiprocessing sampling.
      
      * accel training.
      
      * replace pull with spmv for speedup.
      
      * nodeflow copy from parent with context.
      
      * enable GPU.
      
      * fix a bug in graph store.
      
      * enable multi-GPU training.
      
      * fix lint.
      
      * add comments.
      
      * rename to run_store_server.py
      
      * fix gcn_cv.
      
      * fix a minor bug in sampler.
      
      * handle error better in graph store.
      
      * improve graphsage_cv for distributed mode.
      
      * update README.
      
      * fix.
      
      * update.
      
      * [Tutorial] add sampling tutorial. (#522)
      
      * add sampling tutorial.
      
      * add readme
      
      * update author list.
      
      * fix indent in the code.
      
      * rename the file.
      
      * update tutorial.
      
      * fix the last API.
      
      * update image.
      
      * [BUGFIX] fix the problems in the sampling tutorial. (#523)
      
      * add index.
      
      * update.
      
      * update tutorial.
      
      * fix gpu utest
      
      * cuda utest runnable
      
      * temp disable test nodeflow; unified test for kernel
      
      * cuda test kernel done
      
      * Fixing typo in JTNN after interface change (#536)
      
      * [BugFix] Fix getting src and dst id of ALL edges in NodeFlow.apply_block (#515)
      
      * [Bug Fix] Fix inplace op at backend (#546)
      
      * Fix inplace operation
      
      * fix line seprator
      
      * [Feature] Add batch and unbatch for immutable graph (#539)
      
      * Add batch and unbatch for immutable graph
      
      * fix line seprator
      
      * fix lintr
      
      * remove unnecessary include
      
      * fix code review
      
      * [BUGFix] Improve multi-processing training (#526)
      
      * fix.
      
      * add comment.
      
      * remove.
      
      * temp fix.
      
      * initialize for shared memory.
      
      * fix graphsage.
      
      * fix gcn.
      
      * add more unit tests.
      
      * add more tests.
      
      * avoid creating shared-memory exclusively.
      
      * redefine remote initializer.
      
      * improve initializer.
      
      * fix unit test.
      
      * fix lint.
      
      * fix lint.
      
      * initialize data in the graph store server properly.
      
      * fix test.
      
      * fix test.
      
      * fix test.
      
      * small fix.
      
      * add comments.
      
      * cleanup server.
      
      * test graph store with a random port.
      
      * print.
      
      * print to stderr.
      
      * test1
      
      * test2
      
      * remove comment.
      
      * adjust the initializer signature.
      
      * [API] update graph store API. (#549)
      
      * add init_ndata and init_edata in DGLGraph.
      
      * adjust SharedMemoryGraph API.
      
      * print warning.
      
      * fix comment.
      
      * update example
      
      * fix.
      
      * fix examples.
      
      * add unit tests.
      
      * add comments.
      
      * [Refactor] Immutable graph index (#543)
      
      * WIP
      
      * header
      
      * WIP .cc
      
      * WIP
      
      * transpose
      
      * wip
      
      * immutable graph .h and .cc
      
      * WIP: nodeflow.cc
      
      * compile
      
      * remove all tmp dl managed ctx; they caused refcount issue
      
      * one simple test
      
      * WIP: testing
      
      * test_graph
      
      * fix graph index
      
      * fix bug in sampler; pass pytorch utest
      
      * WIP on mxnet
      
      * fix lint
      
      * fix mxnet unittest w/ unfortunate workaround
      
      * fix msvc
      
      * fix lint
      
      * SliceRows and test_nodeflow
      
      * resolve reviews
      
      * resolve reviews
      
      * try fix win ci
      
      * try fix win ci
      
      * poke win ci again
      
      * poke
      
      * lazy multigraph flag; stackoverflow error
      
      * revert node subgraph test
      
      * lazy object
      
      * try fix win build
      
      * try fix win build
      
      * poke ci
      
      * fix build script
      
      * fix compile
      
      * add a todo
      
      * fix reviews
      
      * fix compile
      
      * [Kernel] Update kernel branch (#576)
      
      * [Model] add multiprocessing training with sampling. (#484)
      
      * reorganize sampling code.
      
      * add multi-process training.
      
      * speed up gcn_cv
      
      * fix graphsage_cv.
      
      * add new API in graph store.
      
      * update barrier impl.
      
      * support both local and distributed training.
      
      * fix multiprocess train.
      
      * fix.
      
      * fix barrier.
      
      * add script for loading data.
      
      * multiprocessing sampling.
      
      * accel training.
      
      * replace pull with spmv for speedup.
      
      * nodeflow copy from parent with context.
      
      * enable GPU.
      
      * fix a bug in graph store.
      
      * enable multi-GPU training.
      
      * fix lint.
      
      * add comments.
      
      * rename to run_store_server.py
      
      * fix gcn_cv.
      
      * fix a minor bug in sampler.
      
      * handle error better in graph store.
      
      * improve graphsage_cv for distributed mode.
      
      * update README.
      
      * fix.
      
      * update.
      
      * [Tutorial] add sampling tutorial. (#522)
      
      * add sampling tutorial.
      
      * add readme
      
      * update author list.
      
      * fix indent in the code.
      
      * rename the file.
      
      * update tutorial.
      
      * fix the last API.
      
      * update image.
      
      * [BUGFIX] fix the problems in the sampling tutorial. (#523)
      
      * add index.
      
      * update.
      
      * update tutorial.
      
      * fix gpu utest
      
      * cuda utest runnable
      
      * temp disable test nodeflow; unified test for kernel
      
      * cuda test kernel done
      
      * Fixing typo in JTNN after interface change (#536)
      
      * [BugFix] Fix getting src and dst id of ALL edges in NodeFlow.apply_block (#515)
      
      * [Bug Fix] Fix inplace op at backend (#546)
      
      * Fix inplace operation
      
      * fix line seprator
      
      * [Feature] Add batch and unbatch for immutable graph (#539)
      
      * Add batch and unbatch for immutable graph
      
      * fix line seprator
      
      * fix lintr
      
      * remove unnecessary include
      
      * fix code review
      
      * [BUGFix] Improve multi-processing training (#526)
      
      * fix.
      
      * add comment.
      
      * remove.
      
      * temp fix.
      
      * initialize for shared memory.
      
      * fix graphsage.
      
      * fix gcn.
      
      * add more unit tests.
      
      * add more tests.
      
      * avoid creating shared-memory exclusively.
      
      * redefine remote initializer.
      
      * improve initializer.
      
      * fix unit test.
      
      * fix lint.
      
      * fix lint.
      
      * initialize data in the graph store server properly.
      
      * fix test.
      
      * fix test.
      
      * fix test.
      
      * small fix.
      
      * add comments.
      
      * cleanup server.
      
      * test graph store with a random port.
      
      * print.
      
      * print to stderr.
      
      * test1
      
      * test2
      
      * remove comment.
      
      * adjust the initializer signature.
      
      * [API] update graph store API. (#549)
      
      * add init_ndata and init_edata in DGLGraph.
      
      * adjust SharedMemoryGraph API.
      
      * print warning.
      
      * fix comment.
      
      * update example
      
      * fix.
      
      * fix examples.
      
      * add unit tests.
      
      * add comments.
      
      * [Refactor] Immutable graph index (#543)
      
      * WIP
      
      * header
      
      * WIP .cc
      
      * WIP
      
      * transpose
      
      * wip
      
      * immutable graph .h and .cc
      
      * WIP: nodeflow.cc
      
      * compile
      
      * remove all tmp dl managed ctx; they caused refcount issue
      
      * one simple test
      
      * WIP: testing
      
      * test_graph
      
      * fix graph index
      
      * fix bug in sampler; pass pytorch utest
      
      * WIP on mxnet
      
      * fix lint
      
      * fix mxnet unittest w/ unfortunate workaround
      
      * fix msvc
      
      * fix lint
      
      * SliceRows and test_nodeflow
      
      * resolve reviews
      
      * resolve reviews
      
      * try fix win ci
      
      * try fix win ci
      
      * poke win ci again
      
      * poke
      
      * lazy multigraph flag; stackoverflow error
      
      * revert node subgraph test
      
      * lazy object
      
      * try fix win build
      
      * try fix win build
      
      * poke ci
      
      * fix build script
      
      * fix compile
      
      * add a todo
      
      * fix reviews
      
      * fix compile
      
      * all demo use python-3 (#555)
      
      * [DEMO] Reproduce numbers of distributed training in AMLC giant graph paper (#556)
      
      * update
      
      * update
      
      * update
      
      * update num_hops
      
      * fix bug
      
      * update
      
      * report numbers of distributed training in AMLC giant graph paper
      
      * [DEMO] Remove duplicate code for sampling (#557)
      
      * update
      
      * update
      
      * re-use single-machine code
      
      * update
      
      * use relative path
      
      * update
      
      * update
      
      * update
      
      * add __init__.py
      
      * add __init__.py
      
      * import sys, os
      
      * fix typo
      
      * update
      
      * [Perf] Improve performance of graph store. (#554)
      
      * fix.
      
      * use inplace.
      
      * move to shared memory graph store.
      
      * fix.
      
      * add more unit tests.
      
      * fix.
      
      * fix test.
      
      * fix test.
      
      * disable test.
      
      * fix.
      
      * [BUGIFX] fix a bug in edge_ids (#560)
      
      * add test.
      
      * fix compute.
      
      * fix test.
      
      * turn on test.
      
      * fix a bug.
      
      * add test.
      
      * fix.
      
      * disable test.
      
      * [DEMO] Add Pytorch demo for distributed sampler (#562)
      
      * update
      
      * update
      
      * update
      
      * add sender
      
      * update
      
      * remove duplicate cpde
      
      * [Test] Add gtest to project (#547)
      
      * add gtest module
      
      * add gtest
      
      * fix
      
      * Update CMakeLists.txt
      
      * Update README.md
      
      * [Perf] lazily create msg_index. (#563)
      
      * lazily create msg_index.
      
      * update test.
      
      * [BUGFIX] fix bugs for running GCN on giant graphs. (#561)
      
      * load mxnet csr.
      
      * enable load large csr.
      
      * fix
      
      * fix.
      
      * fix int overflow.
      
      * fix test.
      
      * [BugFix] Fix error when bfs_level = 0 in Entity Classification with RGCN (#559)
      
      * [DEMO] Update demo of distributed sampler (#564)
      
      * update
      
      * update
      
      * update demo
      
      * add network cpp test (#565)
      
      * Add unittest for C++ RPC (#566)
      
      * [CI] Fix CI for cpp test (#570)
      
      * fix CI for cpp test
      
      * update port number
      
      * [Docker] update docker image (#575)
      
      * update docker image
      
      * specify lint version
      
      * rm torch import from unified tests
      
      * [Kernel][Scheduler][MXNet] Scheduler for DGL kernels and MXNet backend support (#541)
      
      * [Model] add multiprocessing training with sampling. (#484)
      
      * reorganize sampling code.
      
      * add multi-process training.
      
      * speed up gcn_cv
      
      * fix graphsage_cv.
      
      * add new API in graph store.
      
      * update barrier impl.
      
      * support both local and distributed training.
      
      * fix multiprocess train.
      
      * fix.
      
      * fix barrier.
      
      * add script for loading data.
      
      * multiprocessing sampling.
      
      * accel training.
      
      * replace pull with spmv for speedup.
      
      * nodeflow copy from parent with context.
      
      * enable GPU.
      
      * fix a bug in graph store.
      
      * enable multi-GPU training.
      
      * fix lint.
      
      * add comments.
      
      * rename to run_store_server.py
      
      * fix gcn_cv.
      
      * fix a minor bug in sampler.
      
      * handle error better in graph store.
      
      * improve graphsage_cv for distributed mode.
      
      * update README.
      
      * fix.
      
      * update.
      
      * [Tutorial] add sampling tutorial. (#522)
      
      * add sampling tutorial.
      
      * add readme
      
      * update author list.
      
      * fix indent in the code.
      
      * rename the file.
      
      * update tutorial.
      
      * fix the last API.
      
      * update image.
      
      * [BUGFIX] fix the problems in the sampling tutorial. (#523)
      
      * add index.
      
      * update.
      
      * update tutorial.
      
      * fix gpu utest
      
      * cuda utest runnable
      
      * temp disable test nodeflow; unified test for kernel
      
      * cuda test kernel done
      
      * edge softmax module
      
      * WIP
      
      * Fixing typo in JTNN after interface change (#536)
      
      * mxnet backend support
      
      * improve reduce grad
      
      * add max to unittest backend
      
      * fix kernel unittest
      
      * [BugFix] Fix getting src and dst id of ALL edges in NodeFlow.apply_block (#515)
      
      * lint
      
      * lint
      
      * win build
      
      * [Bug Fix] Fix inplace op at backend (#546)
      
      * Fix inplace operation
      
      * fix line seprator
      
      * [Feature] Add batch and unbatch for immutable graph (#539)
      
      * Add batch and unbatch for immutable graph
      
      * fix line seprator
      
      * fix lintr
      
      * remove unnecessary include
      
      * fix code review
      
      * [BUGFix] Improve multi-processing training (#526)
      
      * fix.
      
      * add comment.
      
      * remove.
      
      * temp fix.
      
      * initialize for shared memory.
      
      * fix graphsage.
      
      * fix gcn.
      
      * add more unit tests.
      
      * add more tests.
      
      * avoid creating shared-memory exclusively.
      
      * redefine remote initializer.
      
      * improve initializer.
      
      * fix unit test.
      
      * fix lint.
      
      * fix lint.
      
      * initialize data in the graph store server properly.
      
      * fix test.
      
      * fix test.
      
      * fix test.
      
      * small fix.
      
      * add comments.
      
      * cleanup server.
      
      * test graph store with a random port.
      
      * print.
      
      * print to stderr.
      
      * test1
      
      * test2
      
      * remove comment.
      
      * adjust the initializer signature.
      
      * try
      
      * fix
      
      * fix
      
      * fix
      
      * fix
      
      * fix
      
      * try
      
      * test
      
      * test
      
      * test
      
      * try
      
      * try
      
      * try
      
      * test
      
      * fix
      
      * try gen_target
      
      * fix gen_target
      
      * fix msvc var_args expand issue
      
      * fix
      
      * [API] update graph store API. (#549)
      
      * add init_ndata and init_edata in DGLGraph.
      
      * adjust SharedMemoryGraph API.
      
      * print warning.
      
      * fix comment.
      
      * update example
      
      * fix.
      
      * fix examples.
      
      * add unit tests.
      
      * add comments.
      
      * [Refactor] Immutable graph index (#543)
      
      * WIP
      
      * header
      
      * WIP .cc
      
      * WIP
      
      * transpose
      
      * wip
      
      * immutable graph .h and .cc
      
      * WIP: nodeflow.cc
      
      * compile
      
      * remove all tmp dl managed ctx; they caused refcount issue
      
      * one simple test
      
      * WIP: testing
      
      * test_graph
      
      * fix graph index
      
      * fix bug in sampler; pass pytorch utest
      
      * WIP on mxnet
      
      * fix lint
      
      * fix mxnet unittest w/ unfortunate workaround
      
      * fix msvc
      
      * fix lint
      
      * SliceRows and test_nodeflow
      
      * resolve reviews
      
      * resolve reviews
      
      * try fix win ci
      
      * try fix win ci
      
      * poke win ci again
      
      * poke
      
      * lazy multigraph flag; stackoverflow error
      
      * revert node subgraph test
      
      * lazy object
      
      * try fix win build
      
      * try fix win build
      
      * poke ci
      
      * fix build script
      
      * fix compile
      
      * add a todo
      
      * fix reviews
      
      * fix compile
      
      * WIP
      
      * WIP
      
      * all demo use python-3 (#555)
      
      * ToImmutable and CopyTo
      
      * [DEMO] Reproduce numbers of distributed training in AMLC giant graph paper (#556)
      
      * update
      
      * update
      
      * update
      
      * update num_hops
      
      * fix bug
      
      * update
      
      * report numbers of distributed training in AMLC giant graph paper
      
      * [DEMO] Remove duplicate code for sampling (#557)
      
      * update
      
      * update
      
      * re-use single-machine code
      
      * update
      
      * use relative path
      
      * update
      
      * update
      
      * update
      
      * add __init__.py
      
      * add __init__.py
      
      * import sys, os
      
      * fix typo
      
      * update
      
      * [Perf] Improve performance of graph store. (#554)
      
      * fix.
      
      * use inplace.
      
      * move to shared memory graph store.
      
      * fix.
      
      * add more unit tests.
      
      * fix.
      
      * fix test.
      
      * fix test.
      
      * disable test.
      
      * fix.
      
      * [BUGIFX] fix a bug in edge_ids (#560)
      
      * add test.
      
      * fix compute.
      
      * fix test.
      
      * turn on test.
      
      * fix a bug.
      
      * add test.
      
      * fix.
      
      * disable test.
      
      * DGLRetValue DGLContext conversion
      
      * [DEMO] Add Pytorch demo for distributed sampler (#562)
      
      * update
      
      * update
      
      * update
      
      * add sender
      
      * update
      
      * remove duplicate cpde
      
      * [Test] Add gtest to project (#547)
      
      * add gtest module
      
      * add gtest
      
      * fix
      
      * Update CMakeLists.txt
      
      * Update README.md
      
      * Add support to convert immutable graph to 32 bits
      
      * [Perf] lazily create msg_index. (#563)
      
      * lazily create msg_index.
      
      * update test.
      
      * fix binary reduce following new minigun template
      
      * enable both int64 and int32 kernels
      
      * [BUGFIX] fix bugs for running GCN on giant graphs. (#561)
      
      * load mxnet csr.
      
      * enable load large csr.
      
      * fix
      
      * fix.
      
      * fix int overflow.
      
      * fix test.
      
      * new kernel interface done for CPU
      
      * docstring
      
      * rename & docstring
      
      * copy reduce and backward
      
      * [BugFix] Fix error when bfs_level = 0 in Entity Classification with RGCN (#559)
      
      * [DEMO] Update demo of distributed sampler (#564)
      
      * update
      
      * update
      
      * update demo
      
      * adapt cuda kernels to the new interface
      
      * add network cpp test (#565)
      
      * fix bug
      
      * Add unittest for C++ RPC (#566)
      
      * [CI] Fix CI for cpp test (#570)
      
      * fix CI for cpp test
      
      * update port number
      
      * [Docker] update docker image (#575)
      
      * update docker image
      
      * specify lint version
      
      * rm torch import from unified tests
      
      * remove pytorch-specific test_function
      
      * fix unittest
      
      * fix
      
      * fix unittest backend bug in converting tensor to numpy array
      
      * fix
      
      * mxnet version
      
      * [BUGFIX] fix for MXNet 1.5. (#552)
      
      * remove clone.
      
      * turn on numpy compatible.
      
      * Revert "remove clone."
      
      This reverts commit 17bbf76ed72ff178df6b3f35addc428048672457.
      
      * revert format changes
      
      * fix mxnet api name
      
      * revert mistakes in previous revert
      
      * roll back CI to 20190523 build
      
      * fix unittest
      
      * disable test_shared_mem_store.py for now
      
      * remove mxnet/test_specialization.py
      
      * sync win64 test script
      
      * fix lowercase
      
      * missing backend in gpu unit test
      
      * transpose to get forward graph
      
      * pass update all
      
      * add sanity check
      
      * passing test_specialization.py
      
      * fix and pass test_function
      
      * fix check
      
      * fix pytorch softmax
      
      * mxnet kernels
      
      * c++ lint
      
      * pylint
      
      * try
      
      * win build
      
      * fix
      
      * win
      
      * ci enable gpu build
      
      * init submodule recursively
      
      * backend docstring
      
      * try
      
      * test win dev
      
      * doc string
      
      * disable pytorch test_nn
      
      * try to fix windows issue
      
      * bug fixed, revert changes
      
      * [Test] fix CI. (#586)
      
      * disable unit test in mxnet tutorial.
      
      * retry socket connection.
      
      * roll back to set_np_compat
      
      * try to fix multi-processing test hangs when it fails.
      
      * fix test.
      
      * fix.
      
      * doc string
      
      * doc string and clean up
      
      * missing field in ctypes
      
      * fix node flow schedule and unit test
      
      * rename
      
      * pylint
      
      * copy from parent default context
      
      * fix unit test script
      
      * fix
      
      * demo bug in nodeflow gpu test
      
      * [Kernel][Bugfix] fix nodeflow bug (#604)
      
      * fix nodeflow bug
      
      * remove debug code
      
      * add build gtest option
      
      * fix cmake; fix graph index bug in spmv.py
      
      * remove clone
      
      * fix div rhs grad bug
      
      * [Kernel] Support full builtin method, edge softmax and unit tests (#605)
      
      * add full builtin support
      
      * unit test
      
      * unit test backend
      
      * edge softmax
      
      * apply edge with builtin
      
      * fix kernel unit test
      
      * disable mxnet test_shared_mem_store
      
      * gen builtin reduce
      
      * enable mxnet gpu unittest
      
      * revert some changes
      
      * docstring
      
      * add note for the hack
      
      * [Kernel][Unittest][CI] Fix MXNet GPU CI (#607)
      
      * update docker image for MXNet GPU CI
      
      * force all dgl graph input and output on CPU
      
      * fix gpu unittest
      
      * speedup compilation
      
      * add some comments
      
      * lint
      
      * add more comments
      
      * fix as requested
      
      * add some comments
      
      * comment
      
      * lint
      
      * lint
      
      * update pylint
      
      * fix as requested
      
      * lint
      
      * lint
      
      * lint
      
      * docstrings of python DGL kernel entries
      
      * disable lint warnings on arguments in kernel.py
      
      * fix docstring in scheduler
      
      * fix some bug in unittest; try again
      
      * Revert "Merge branch 'kernel' of github.com:zzhang-cn/dgl into kernel"
      
      This reverts commit 1d2299e68b004182ea6130b088de1f1122b18a49, reversing
      changes made to ddc97fbf1bec2b7815c0da7c74f7ecb2f428889b.
      
      * Revert "fix some bug in unittest; try again"
      
      This reverts commit ddc97fbf1bec2b7815c0da7c74f7ecb2f428889b.
      
      * more comprehensive kernel test
      
      * remove shape check in test_specialization
      653428bd
  29. 02 Jun, 2019 1 commit
    • Minjie Wang's avatar
      [Graph] Add API to convert graph to simple graph (#587) · 01a4cc5b
      Minjie Wang authored
      * to simple
      
      * WIP: multigraph flag
      
      * graph index refactor; pass basic testing
      
      * graph index refactor; pass basic testing
      
      * fix bug in to_simple; pass torch test
      
      * fix mx utest
      
      * fix example
      
      * fix lint
      
      * fix ci
      
      * poke ci
      
      * poke ci
      
      * WIP
      
      * poke ci
      
      * poke ci
      
      * poke ci
      
      * change ci workspace
      
      * poke ci
      
      * poke ci
      
      * poke ci
      
      * poke ci
      
      * delete ci
      
      * use enum for multigraph flag
      01a4cc5b
  30. 26 May, 2019 1 commit
  31. 25 May, 2019 1 commit
  32. 21 May, 2019 1 commit
    • Minjie Wang's avatar
      [Refactor] Immutable graph index (#543) · 605b5185
      Minjie Wang authored
      * WIP
      
      * header
      
      * WIP .cc
      
      * WIP
      
      * transpose
      
      * wip
      
      * immutable graph .h and .cc
      
      * WIP: nodeflow.cc
      
      * compile
      
      * remove all tmp dl managed ctx; they caused refcount issue
      
      * one simple test
      
      * WIP: testing
      
      * test_graph
      
      * fix graph index
      
      * fix bug in sampler; pass pytorch utest
      
      * WIP on mxnet
      
      * fix lint
      
      * fix mxnet unittest w/ unfortunate workaround
      
      * fix msvc
      
      * fix lint
      
      * SliceRows and test_nodeflow
      
      * resolve reviews
      
      * resolve reviews
      
      * try fix win ci
      
      * try fix win ci
      
      * poke win ci again
      
      * poke
      
      * lazy multigraph flag; stackoverflow error
      
      * revert node subgraph test
      
      * lazy object
      
      * try fix win build
      
      * try fix win build
      
      * poke ci
      
      * fix build script
      
      * fix compile
      
      * add a todo
      
      * fix reviews
      
      * fix compile
      605b5185
  33. 20 May, 2019 2 commits
    • Da Zheng's avatar
      [BUGFix] Improve multi-processing training (#526) · cdfca992
      Da Zheng authored
      * fix.
      
      * add comment.
      
      * remove.
      
      * temp fix.
      
      * initialize for shared memory.
      
      * fix graphsage.
      
      * fix gcn.
      
      * add more unit tests.
      
      * add more tests.
      
      * avoid creating shared-memory exclusively.
      
      * redefine remote initializer.
      
      * improve initializer.
      
      * fix unit test.
      
      * fix lint.
      
      * fix lint.
      
      * initialize data in the graph store server properly.
      
      * fix test.
      
      * fix test.
      
      * fix test.
      
      * small fix.
      
      * add comments.
      
      * cleanup server.
      
      * test graph store with a random port.
      
      * print.
      
      * print to stderr.
      
      * test1
      
      * test2
      
      * remove comment.
      
      * adjust the initializer signature.
      cdfca992
    • VoVAllen's avatar
      [Feature] Add batch and unbatch for immutable graph (#539) · 4b761571
      VoVAllen authored
      * Add batch and unbatch for immutable graph
      
      * fix line seprator
      
      * fix lintr
      
      * remove unnecessary include
      
      * fix code review
      4b761571