[CUDA] Fix issue about integer overflow (#6586)

bfde1422 · Muhammed Fatih BALIN · GitHub · ee6dc9b6 · bfde1422
Unverified Commit bfde1422 authored Nov 22, 2023 by Muhammed Fatih BALIN Committed by GitHub Nov 22, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

src/array/cuda/utils.h src/array/cuda/utils.h +4 -2

No files found.
--- a/src/array/cuda/utils.h
+++ b/src/array/cuda/utils.h
@@ -46,11 +46,13 @@ int _NumberOfBits(const T& range) {
  }

  int bits = 1;
-  while (bits < static_cast<int>(sizeof(T) * 8) && (1 << bits) < range) {
+  while (bits < static_cast<int>(sizeof(T) * 8) && (1ull << bits) < range) {
    ++bits;
  }

-  CHECK_EQ((range - 1) >> bits, 0);
+  if (bits < static_cast<int>(sizeof(T) * 8)) {
+    CHECK_EQ((range - 1) >> bits, 0);
+  }
  CHECK_NE((range - 1) >> (bits - 1), 0);

  return bits;