Unverified Commit fedd0386 authored by Jeff Rasley's avatar Jeff Rasley Committed by GitHub
Browse files

add quotes around user argument values (#267)

parent 9fcdc885
...@@ -329,7 +329,10 @@ def main(args=None): ...@@ -329,7 +329,10 @@ def main(args=None):
"--master_addr={}".format(args.master_addr), "--master_addr={}".format(args.master_addr),
"--master_port={}".format(args.master_port) "--master_port={}".format(args.master_port)
] ]
cmd = pdsh_cmd_args + deepspeed_launch + [args.user_script] + args.user_args user_args = list(
map(lambda x: x if x.startswith("-") else "'{}'".format(x),
args.user_args))
cmd = pdsh_cmd_args + deepspeed_launch + [args.user_script] + user_args
logger.info("cmd={}".format(cmd)) logger.info("cmd={}".format(cmd))
result = subprocess.Popen(cmd, env=env) result = subprocess.Popen(cmd, env=env)
result.wait() result.wait()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment