- 30 Mar, 2021 1 commit
-
-
Sam Tsai authored
Summary: Separate unit tests into individual folder based on functionality. Reviewed By: wat3rBro Differential Revision: D27132567 fbshipit-source-id: 9a8200be530ca14c7ef42191d59795b05b9800cc
-
- 24 Mar, 2021 1 commit
-
-
Kai Zhang authored
Summary: Given that the way to create D2 (https://github.com/facebookresearch/d2go/commit/465cdb842513eb910aa20fcedea1d2edd15dc7b7)go runner and Lightning task are different, get_class was introduced so that in application we could do: ``` if is Lightning: task_cls = get_class(classname) task = task_cls(cfg) else: runner = create_runner(classname) ``` It turns out that we could need to do that in many places: workflow, binaries. This diff revert `get_class` and return class in `create_runner` if the class is a Lightning module. Reviewed By: newstzpz Differential Revision: D26676595 fbshipit-source-id: c3ce2016d09fe073af4c2dd9f98eea4e59ca621b
-
- 20 Mar, 2021 1 commit
-
-
Yanghan Wang authored
Summary: Not d2go.tests is not a library for oss, move utils code to d2go.utils.testing Reviewed By: zhanghang1989 Differential Revision: D26706933 fbshipit-source-id: 85767b66bbb6c67db05e11823beb4840220b2aa3
-
- 18 Mar, 2021 1 commit
-
-
Ananth Subramaniam authored
Summary: `checkpoint_callback` is being phased out. Initially, it was a special way to configure checkpoints, but it makes more sense for those callbacks to be included in the general `callbacks` trainer argument. In 1.2.X, `checkpoint_callback` is expected to be a boolean value only. If `checkpoint_callback=False` **and** an instance of `ModelCheckpoint` is passed in the trainer's `callbacks` arguments, Lightning raises a [misconfiguration error](https://github.com/PyTorchLightning/pytorch-lightning/blob/2f6ce1ae7fff34d16d3707571f6a9a7b0fb0c50a/pytorch_lightning/trainer/connectors/callback_connector.py#L66-L70) Reviewed By: newstzpz Differential Revision: D27139315 fbshipit-source-id: 07ad5ea520583a2e46a9cb2a938f98968265c932
-
- 11 Mar, 2021 1 commit
-
-
Kai Zhang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/17 Use PyTorch Lightning checkpoint in the test. Reviewed By: zhanghang1989 Differential Revision: D26962697 fbshipit-source-id: abe635e374c3ada130243f0eaadff34204f04fa1
-
- 03 Mar, 2021 1 commit
-
-
facebook-github-bot authored
fbshipit-source-id: f4a8ba78691d8cf46e003ef0bd2e95f170932778
-