- 27 Jul, 2022 5 commits
-
-
Mircea Cimpoi authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/344 we need access to the modeling hooks in EMA, e.g. build trainer. Reviewed By: wat3rBro Differential Revision: D37997773 fbshipit-source-id: bf4372cd310605fa35aa70f0604b084b047001d8
-
Peizhao Zhang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/278 Allow skipping do_test after do_train. Reviewed By: wat3rBro Differential Revision: D36786790 fbshipit-source-id: 785556b5743ee9af2abfe6c0e9e78c7055697048
-
Mircea Cimpoi authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/348 Add testcase to ensure loading from config in eval_only is covered. Reviewed By: wat3rBro Differential Revision: D38001319 fbshipit-source-id: e6a2edb5001ae87606a3bf48e1355037aee0f9a0
-
Kevin Chih-Yao Ma authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/342 Add a cfg option to control the frequency of the writers. Currently, the default writers include: ``` writers = [ CommonMetricPrinter(max_iter), JSONWriter(os.path.join(cfg.OUTPUT_DIR, "metrics.json")), tbx_writer, ] ``` Reviewed By: wat3rBro Differential Revision: D38065583 fbshipit-source-id: ebdc20aab71e03b4e18772af78b410f17ba4216d
-
Hongyu Fu authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/347 land the fbnet architectures for video logo detection project in RCNN, FCOS and YOLO Reviewed By: wat3rBro Differential Revision: D38139055 fbshipit-source-id: 6ba21f482ed067c52d438e0c217e523896c2131c
-
- 26 Jul, 2022 2 commits
-
-
Vasilis Vryniotis authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/322 TorchVision has recently added the AugMix Augmentantion. This diff adds support of the specific transform to D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb)go Reviewed By: newstzpz Differential Revision: D37578243 fbshipit-source-id: b793715ccb24a3bd999a40c51d8c9a75f22110a3
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/345 Reviewed By: xiecong Differential Revision: D38086885 fbshipit-source-id: 808e104ee50c8870ae091533ac67b440e1bb8351
-
- 25 Jul, 2022 1 commit
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/343 Reviewed By: miqueljubert Differential Revision: D38077850 fbshipit-source-id: a79541d899ce2b49a30c7f2a81a616f76321026f
-
- 22 Jul, 2022 1 commit
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/340 Reviewed By: miqueljubert Differential Revision: D37968017 fbshipit-source-id: a3953fdbb2c48ceaffcf94df081c0b3253d247d5
-
- 19 Jul, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/339 add is_qat to lightning codepath Reviewed By: jerryzh168 Differential Revision: D37937336 fbshipit-source-id: 68debe57c7f7dcf8647fad6ab9e34eff2aaa851c
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/338 Now we should've separated all the `prepare_for_quant` for eager and FX mode, we can remove this branch. Reviewed By: jerryzh168 Differential Revision: D37865628 fbshipit-source-id: cd8f3aa7c90201f44bcfdbd65eb2edf5eded0e0c
-
- 14 Jul, 2022 4 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/336 Reviewed By: jerryzh168 Differential Revision: D37860495 fbshipit-source-id: 1ce0bc7bc8071d3bfbe53cd61ed180da62e29327
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/335 Manually remove `example_input` from eager-mode-only `prepare_for_quant`. Reviewed By: jerryzh168 Differential Revision: D37838155 fbshipit-source-id: 2d98e0264fc0c40dcf1b6f28f7fc635c52acd75e
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/333 Follow D36916149. Reviewed By: jerryzh168 Differential Revision: D37830568 fbshipit-source-id: dbeb204ccf96dd2e90a6509f24a2864503083f60
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/332 Solve: "we have decoupled qat with `.training` in quantization, maybe we should use some flags in `cfg` instead of checking this attribute here as well" Reviewed By: jerryzh168 Differential Revision: D37801241 fbshipit-source-id: ed9884d7b462da195ed2e07c42634acfe5beefb2
-
- 13 Jul, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/330 - re-enable the `test_qat` - remove `example_input` from `DetMetaArchForTest`, since its `custom_prepare_fx` just create a tensor for avgpool. Reviewed By: jerryzh168 Differential Revision: D37793260 fbshipit-source-id: ec7a825c61292d9c6d792f910a957c1c27832336
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/331 - remove `example_input` from `default_prepare_for_quant` since now it's eager mode only. - rename `apply_prepare_for_quant` to `convert_to_fake_quant_model` to reflect what it's doing. Reviewed By: jerryzh168 Differential Revision: D37794085 fbshipit-source-id: e6f12098976272d979a3aac66287d9b95432dcc8
-
- 09 Jul, 2022 1 commit
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/328 Reviewed By: jerryzh168 Differential Revision: D37695452 fbshipit-source-id: 744b1085365d1e155ea9e9fe51a6237994d90fa7
-
- 08 Jul, 2022 3 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/326 since prepare_for_quant_convert/custom_convert_fx is FX only, we can remove eager mode code from it. Also adjust the logic in `d2go/export/exporter.py` accordingly to reflect this. Reviewed By: jerryzh168 Differential Revision: D37676977 fbshipit-source-id: ebd05082ee81bc1ac32fcc2a87bc0dfaacedd5bd
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/325 `prepare_for_quant_convert` is a confusing name because it only does `convert`, there's no "prepare" in it. It's actually for fx only, because eager mode always calls `torch.quantization.convert`, there's no way to customize it. So just call this `custom_convert_fx`. The new name is also unique in fbcode, so easy to do codemod later on. This diff simply does the renaming by biggrep + replace. Reviewed By: jerryzh168 Differential Revision: D37676717 fbshipit-source-id: e7d05eaafddc383dd432986267c945c8ebf94df4
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/327 Fix the bug for not leaving avgpool quantized when its input is quantized. This is not captured by CI because currently we set `small_pooler_resolution` to True to make test running faster, but this skips the `avgpool` everytime. Reviewed By: jerryzh168 Differential Revision: D37706151 fbshipit-source-id: fde9a190324a23b97ba803e000f4caa54f6f3738
-
- 06 Jul, 2022 2 commits
-
-
Mircea Cimpoi authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/324 Fixes bug introduced in D37600026 (https://github.com/facebookresearch/d2go/commit/1a18ba3420e3c823accf731a11c0a91dc3babd85) -- forgot to fix imports after moving modelinghook to registry/builtin.py Differential Revision: D37646330 fbshipit-source-id: cb763d65e7bbfd07eea6eff61727a42a6fcfbc88
-
Mircea Cimpoi authored
Summary: Moving MODELING_HOOK_REGISTRY to `d2go/registry/builtin.py`, so that bootstrap works with modeling hook registry. This fixes the detectron2 vs mobile_cv registry. Reviewed By: wat3rBro Differential Revision: D37600026 fbshipit-source-id: 7aa8cdec3b5eaea89d9db6fc35c7389cc9fb3193
-
- 02 Jul, 2022 1 commit
-
-
Jerry Zhang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/321 Following up the bc-breaking change from fx graph mode quantization: https://github.com/pytorch/pytorch/pull/76496 that added example_inputs to prepare_fx and prepare_qat_fx, we fixes the callsite related to mobile-vision and exposed extra example_inputs in some apis Reviewed By: wat3rBro Differential Revision: D37163018 fbshipit-source-id: 9f0bb56659345d174a39b6d3bb4408caa553b88d
-
- 30 Jun, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/320 MCV/D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb)Go's `launch` now supports `kwargs`, which matches elastic launch. Let's always use `args=(cfg, output_dir, runner_name)` for all the binaries, and use `kwargs` for remaining binary arguments (which matches the `extra_args` in FBL's OperatorArgument). Reviewed By: sstsai-adl Differential Revision: D37535145 fbshipit-source-id: 9767e8d71421d2262aee1fd4b9019758aa4a6bbd
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/319 follow up on D37500599 (https://github.com/facebookresearch/d2go/commit/668b7ac29b0afb55d5923e72fe4f6428e5c85cbd), move lightning_train_net part of D37367360 to this diff. Reviewed By: sstsai-adl Differential Revision: D37534370 fbshipit-source-id: 7f48942a14ce16a9a9540b189441b540ce4f4b25
-
- 29 Jun, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/318 Reviewed By: mcimpoi Differential Revision: D37501246 fbshipit-source-id: 6dbe5dcbaf7454f451d4a3bb3fa2d856cc87d5cc
-
Sam Tsai authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/317 1. Add eval-only only option in similar fashion with train_net 2. Use output_dir from config is not specified via command line Reviewed By: wenliangzhao2018 Differential Revision: D37500599 fbshipit-source-id: 00c5804d08a449def3cc15fff49e27066d01f229
-
- 28 Jun, 2022 2 commits
-
-
Bo (YANG, Bo) Yang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/316 As title. Reviewed By: wenliangzhao2018 Differential Revision: D37259150 fbshipit-source-id: 6b69d4bcc8706bf50dbbe3655b306d1d9cbfbdca
-
Yanghan Wang authored
Summary: X-link: https://github.com/facebookresearch/mobile-vision/pull/92 Pull Request resolved: https://github.com/facebookresearch/d2go/pull/314 We may import d2go first, which populates some builtin meta archs in registry, then do the bootstrap. Reviewed By: mcimpoi Differential Revision: D37427101 fbshipit-source-id: 00e53bf0d2e327a90d5dfbc23ef2f4daa6ddfc63
-
- 27 Jun, 2022 1 commit
-
-
Mik Vyatskov authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/315 This method is no longer needed given the there's a better alternative: save/load_binary_output. Reviewed By: tglik, wat3rBro Differential Revision: D37307668 fbshipit-source-id: 598a6d7aeb68f65fa6b42a230175c37d19fd7798
-
- 24 Jun, 2022 3 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/313 It's not natural to put runner's default config functions under `d2go/utils/`, move them to `d2go/runner/config_defaults.py` and clean things up. This also reduce the inter-sub-package dependencies. Reviewed By: mattcyu1 Differential Revision: D37407078 fbshipit-source-id: 432644bee4f12306a14bac3dba76ced08b3683aa
-
Mik Vyatskov authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/309 Right now multiple machines can try to write to the same output file, since they get the same argument. Additionally, on the same machine, several outputs can be saved which requires unncessary unpacking. This change makes train_net only write output of the rank 0 trainer. Reviewed By: wat3rBro Differential Revision: D37310084 fbshipit-source-id: 9d5352a274e8fb1d2043393b12896d402333c17b
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/312 As discussed, we decided to not use runner instance outside of `main`, previous diffs already solved the prerequisites, this diff mainly does the renaming. - Use runner name (str) in the fblearner, ML pipeline. - Use runner name (str) in FBL operator, MAST and binary operator. - Use runner class as the interface of main, it can be either the name of class (str) or actual class. The main usage should be using `str`, so that the importing of class happens inside `main`. But it's also a common use case to import runner class and call `main` for things like ad-hoc scripts or tests, supporting actual class makes it easier modify code for those cases (eg. some local test class doesn't have a name, so it's not feasible to use runner name). Reviewed By: newstzpz Differential Revision: D37060338 fbshipit-source-id: 879852d41902b87d6db6cb9d7b3e8dc55dc4b976
-
- 22 Jun, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/310 One step towards using runner class across board. This is also need for supporting LazyConfig (which is runner-less) Reviewed By: mcimpoi Differential Revision: D37294926 fbshipit-source-id: f6dfc0a1103bac328ac7b337ce3aaefd5d8d85b4
-
Matthew Yu authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/311 Update d2go default configs to load the distillation configs. Reviewed By: newstzpz Differential Revision: D36820131 fbshipit-source-id: 010c4f64547fa66b97cb83637a0f20d3d841738a
-
- 21 Jun, 2022 2 commits
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/303 Reviewed By: mcimpoi Differential Revision: D37220449 fbshipit-source-id: 04985a4b0129ef37aa42534cdb5f3f8d3f6abf00
-
Andrew Or authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/308 D37088095 made BC breaking changes in PyTorch, but missed fixing a few callsites. This is the second diff to fix the affected tests. Reviewed By: jerryzh168, wat3rBro Differential Revision: D37282853 fbshipit-source-id: 945c3628f53cefd2fbc2526630d1567a2b1cee25
-
- 20 Jun, 2022 1 commit
-
-
Yanghan Wang authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/305 One benefit of having separate registries for D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb) and D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb)Go's meta-arch is that there's no need to patch original D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb)'s meta arch because we can just register new meta arch in D2 (https://github.com/facebookresearch/d2go/commit/87374efb134e539090e0b5c476809dc35bf6aedb)Go directly. This diff removes the `patch_d2_meta_arch` and makes things simpler. Reviewed By: mcimpoi Differential Revision: D37246483 fbshipit-source-id: c8b7adef1fa7a5ff2f89c376c7e3b39bec8f19ee
-
- 18 Jun, 2022 1 commit
-
-
Tsahi Glik authored
Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/297 X-link: https://github.com/facebookresearch/mobile-vision/pull/84 Add command line arg to specify whether and where to save results. This is useful where binaries are being launched from another process, or remotely on another machine. Reviewed By: wat3rBro Differential Revision: D37157955 fbshipit-source-id: 2a48cf967f6cf928049f2be41952834e1dd2a04d
-