1. 20 Jan, 2022 1 commit
    • Sam Tsai's avatar
      fix pickling issue in EnlargeBoundingBox · 189d83d7
      Sam Tsai authored
      Summary:
      Pull Request resolved: https://github.com/facebookresearch/d2go/pull/166
      
      Pickling of transform functions seems to have changed (did not dig into it) in December, breaking the support for this augmentation. This error happens when training with multiple dataloaders. Using partial functions instead.
      
      Differential Revision: D33665177
      
      fbshipit-source-id: 4dfd41b92f3a6fea549b6e7a79bf0bf14a3cceaa
      189d83d7
  2. 18 Jan, 2022 1 commit
    • Miquel Jubert Hermoso's avatar
      Fix type signature of create_runner · c74e23b0
      Miquel Jubert Hermoso authored
      Summary: The type signature of create_runner is not accurate. We expect lightning runners to follow DefaultTask. Also change setup.py to not import directly, which was causing circular dependencies together with the change.
      
      Reviewed By: wat3rBro
      
      Differential Revision: D32792069
      
      fbshipit-source-id: 0fbb55eb269dd681dbc8df49d71c9635f56293b8
      c74e23b0
  3. 14 Jan, 2022 1 commit
  4. 13 Jan, 2022 2 commits
    • Tsahi Glik's avatar
      Add support for custom training step via meta_arch · b6e244d2
      Tsahi Glik authored
      Summary:
      Add support in the default lightning task to run a custom training step from Meta Arch if exists.
      The goal is to allow custom training step without the need to inherit from the default lightning task class and override it. This will allow us to use a signle lightning task and still allow users to customize the training step. In the long run this will be further encapsulated in modeling hook, making it more modular and compositable with other custom code.
      
      This change is a follow up from discussion in  https://fburl.com/diff/yqlsypys
      
      Reviewed By: wat3rBro
      
      Differential Revision: D33534624
      
      fbshipit-source-id: 560f06da03f218e77ad46832be9d741417882c56
      b6e244d2
    • Tsahi Glik's avatar
      Person segmentation using torch lightning · c687fb83
      Tsahi Glik authored
      Summary:
      Add option to train Person Instance Segmentation using lightning instead of D2 (https://github.com/facebookresearch/d2go/commit/7992f91324aee6ae59795063a007c6837e60cdb8).
      This is needed because we want to try PIS with SuperNet and our SuperNet based training is implemented in d2go lightning task
      
      Reviewed By: zhanghang1989
      
      Differential Revision: D33281437
      
      fbshipit-source-id: e1b6567f3c77ce51240fb50d81350bc97735713a
      c687fb83
  5. 12 Jan, 2022 1 commit
  6. 10 Jan, 2022 1 commit
  7. 08 Jan, 2022 2 commits
  8. 07 Jan, 2022 1 commit
    • Tsahi Glik's avatar
      Fix EMA model training with lightning · 6cff7737
      Tsahi Glik authored
      Summary:
      Current implementation of d2go lightning default task fails when running a model training with EMA.
      The error is :
      ```
      RuntimeError: Expected to have finished reduction in the prior iteration before starting a new one. This error indicates that your module has parameters that were not used in producing loss.
      ```
      The error is due the fact the d2go lightning task create a copy of the ema model for evaluation that does not included in the training, which raise the error that there are unused params.
      This is solved by moving the copy creation to after training and to when evaluation starts.
      
      Reviewed By: kazhang
      
      Differential Revision: D33442690
      
      fbshipit-source-id: e9e469e33811de0b4171a64293cc16a8157af08c
      6cff7737
  9. 06 Jan, 2022 1 commit
    • Binh Tang's avatar
      Rename `DDPPlugin` to `DDPStrategy` (#11142) · aeb15613
      Binh Tang authored
      Summary:
      ### New commit log messages
        b64dea9dc Rename `DDPPlugin` to `DDPStrategy` (#11142)
      
      Reviewed By: jjenniferdai
      
      Differential Revision: D33259306
      
      fbshipit-source-id: b4608c6b96b4a7977eaa4ed3f03c4b824882aef0
      aeb15613
  10. 05 Jan, 2022 1 commit
    • Hang Zhang's avatar
      Try LSJ on Faster RCNN with FBNet · 21ae9538
      Hang Zhang authored
      Summary: Try LSJ with Faster RCNN with FBNet backbone
      
      Reviewed By: newstzpz
      
      Differential Revision: D32054932
      
      fbshipit-source-id: 4fdb30e7b1258d6f167f2c2fd331209aad1b599a
      21ae9538
  11. 30 Dec, 2021 2 commits
  12. 29 Dec, 2021 3 commits
  13. 22 Dec, 2021 1 commit
    • Sam Tsai's avatar
      registry and copy keys for extended coco load · bfd78461
      Sam Tsai authored
      Summary:
      1. Add registry for coco injection to allow for easier overriding of cococ injections
      2. Coco loading currently is limited to certain keys. Adding option to allow for copying certain keys from the outputs.
      
      Reviewed By: zhanghang1989
      
      Differential Revision: D33132517
      
      fbshipit-source-id: 57ac4994a66f9c75457cada7e85fb15da4818f3e
      bfd78461
  14. 20 Dec, 2021 1 commit
  15. 18 Dec, 2021 1 commit
    • Tsahi Glik's avatar
      enable overloading get_data_loader_vis_wrapper · 914054ac
      Tsahi Glik authored
      Summary:
      Currently the lightning task rely on the default runner for the vis wrapper logic. This does not allow to overload the get_data_loader_vis_wrapper is subclasses of the lightning task class.
      This diff fixes this issue and properly take the vis wrapper given by the overloaded get_data_loader_vis_wrapper functions in the runner.
      
      Reviewed By: zhanghang1989
      
      Differential Revision: D33190410
      
      fbshipit-source-id: 48cb3a8fa4b11df41d025d115d21002991549ced
      914054ac
  16. 14 Dec, 2021 1 commit
  17. 02 Dec, 2021 1 commit
  18. 01 Dec, 2021 1 commit
  19. 29 Nov, 2021 2 commits
  20. 28 Nov, 2021 1 commit
    • Hang Zhang's avatar
      Add FBNet VT backbone · 51b7be17
      Hang Zhang authored
      Summary:
      Experimental models from Xiaoliang [D31749820]
      
      Pretrained weights:
      fbnet_vit_tiny_v3_lepe n/a
      fbnet_deit_v0 f298782311
      
      Reviewed By: XiaoliangDai
      
      Differential Revision: D32054949
      
      fbshipit-source-id: 7c2aa0679a545ed814ba1db421408a5f9a59a2c8
      51b7be17
  21. 25 Nov, 2021 1 commit
  22. 21 Nov, 2021 1 commit
  23. 20 Nov, 2021 1 commit
    • Haroun Habeeb's avatar
      support building d2go transform list from a list of strings instead of just config · 997bb727
      Haroun Habeeb authored
      Summary:
      for sythetic data, we want to enable having different transforms for different dataloaders.
      
      To do that, we need to be able to construct different kinds of transforms.
      
      This means that using the cfg's hard-coded location isn't convenient - we'd have to edit the cfg during run time and call the build function multiple times
      
      Differential Revision: D32486576
      
      fbshipit-source-id: 767b63c5c787e31a67dbf8710ab9bab84a0651db
      997bb727
  24. 18 Nov, 2021 1 commit
    • Ananth Subramaniam's avatar
      remove deprecated train_loop (#10482) · bb49d171
      Ananth Subramaniam authored
      Summary:
      ### New commit log messages
        fa0ed17f8 remove deprecated train_loop (#10482)
      
      Reviewed By: kandluis
      
      Differential Revision: D32454980
      
      fbshipit-source-id: a35237dde06cc9ddac5373b75992ce88a6771c76
      bb49d171
  25. 12 Nov, 2021 1 commit
    • Yanghan Wang's avatar
      fix import prof test · 598486d6
      Yanghan Wang authored
      Reviewed By: newstzpz
      
      Differential Revision: D32301322
      
      fbshipit-source-id: a9e951b9de600012125b8b94c0c1ace929b491b8
      598486d6
  26. 09 Nov, 2021 4 commits
    • Sam Tsai's avatar
      not block if assertion error when counting flops · 9c1c356c
      Sam Tsai authored
      Summary:
      fvcore flops calculator throws on this error:
      
      KeyError: 'Only support flattening dictionaries if keys are str.'
      
      Setting flops to some value so it doesn't enter pdb mode.
      
      Reviewed By: stephenyan1231
      
      Differential Revision: D32144492
      
      fbshipit-source-id: 604cd4660cea9ffbfb3f1da35d32e06ccf607a50
      9c1c356c
    • Yuxin Wu's avatar
      DPE d2go async loader · afbd4558
      Yuxin Wu authored
      Reviewed By: newstzpz
      
      Differential Revision: D31209906
      
      fbshipit-source-id: 0be4e3c1db623e3c1fba8ba4259840d34192a77e
      afbd4558
    • Albert Pumarola's avatar
      Extend Pix2Pix to allow for input extra data · b6c93a74
      Albert Pumarola authored
      Summary: Extended Pix2Pix to allow for input extra data
      
      Reviewed By: tax313
      
      Differential Revision: D31469054
      
      fbshipit-source-id: 790543f214ea9fa0158e509acb27193916bf17ce
      b6c93a74
    • CodemodService Bot's avatar
      Daily `arc lint --take BLACK` · 980d614b
      CodemodService Bot authored
      Reviewed By: zertosh
      
      Differential Revision: D32270982
      
      fbshipit-source-id: 8767b469fe5404a882257c0c5209b34ed0c327dc
      980d614b
  27. 08 Nov, 2021 3 commits
    • Yanghan Wang's avatar
      remove dead code for AdelaiDet configs · eaeb4cc2
      Yanghan Wang authored
      Summary: code was kept for short term to support loading old training jobs during the period when the default config is polluted; now it should be safe to remove this BC support and dead code
      
      Differential Revision: D32218217
      
      fbshipit-source-id: 3772477653151ccbcb4ae7098b9414853b581ad1
      eaeb4cc2
    • Yanghan Wang's avatar
      rename @legacy to @c2_ops · 95ab768e
      Yanghan Wang authored
      Reviewed By: sstsai-adl
      
      Differential Revision: D32216605
      
      fbshipit-source-id: bebee1edae85e940c7dcc6a64dbe341a2fde36a2
      95ab768e
    • Tim Hatch's avatar
      Remove unused imports that are later redefined · 70e99867
      Tim Hatch authored
      Reviewed By: jreese, ppwwyyxx
      
      Differential Revision: D32191010
      
      fbshipit-source-id: 1e40b7a090be3a0e25b930fb908ec177719fce50
      70e99867
  28. 04 Nov, 2021 1 commit
  29. 29 Oct, 2021 1 commit
    • Owen Wang's avatar
      allow reading .npy files for seg masks · 9c326bb3
      Owen Wang authored
      Summary: Allow reading `.npy` format binary masks shaped (H, W,) in addition to `.png` image masks shaped (H, W, C).
      
      Reviewed By: wat3rBro
      
      Differential Revision: D30136542
      
      fbshipit-source-id: 56df5a766ab15b6808a1327815857e5d38eac910
      9c326bb3