Commit cc3e0e4d authored by Miquel Jubert Hermoso's avatar Miquel Jubert Hermoso Committed by Facebook GitHub Bot
Browse files

Set logger level to info for d2go tools which do not have it set

Summary: Pull Request resolved: https://github.com/facebookresearch/d2go/pull/388

Reviewed By: wat3rBro

Differential Revision: D40377653

fbshipit-source-id: 3f99d30480a801c794665e67bb2b0d28c7c5b0e5
parent 729682ff
...@@ -35,6 +35,21 @@ from mobile_cv.common.misc.py import FolderLock, MultiprocessingPdb, post_mortem ...@@ -35,6 +35,21 @@ from mobile_cv.common.misc.py import FolderLock, MultiprocessingPdb, post_mortem
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
def setup_root_logger(logging_level: int = logging.DEBUG) -> None:
"""
Sets up the D2Go root logger. When a new logger is created, it lies in a tree.
If the logger being used does not have a specific level being specified, it
will default to using its parent logger. In this case, by setting the root
logger level to debug, or what is given, we change the default behaviour
for all loggers.
See https://docs.python.org/3/library/logging.html for a more in-depth
description
"""
root_logger = logging.getLogger()
root_logger.setLevel(logging_level)
def basic_argument_parser( def basic_argument_parser(
distributed=True, distributed=True,
requires_output_dir=True, requires_output_dir=True,
......
...@@ -24,7 +24,9 @@ from d2go.setup import ( ...@@ -24,7 +24,9 @@ from d2go.setup import (
prepare_for_launch, prepare_for_launch,
setup_after_launch, setup_after_launch,
setup_before_launch, setup_before_launch,
setup_root_logger,
) )
from d2go.utils.misc import print_metrics_table from d2go.utils.misc import print_metrics_table
from mobile_cv.predictor.api import create_predictor from mobile_cv.predictor.api import create_predictor
...@@ -119,4 +121,5 @@ def cli(args=None): ...@@ -119,4 +121,5 @@ def cli(args=None):
if __name__ == "__main__": if __name__ == "__main__":
setup_root_logger()
cli() cli()
...@@ -23,6 +23,7 @@ from d2go.setup import ( ...@@ -23,6 +23,7 @@ from d2go.setup import (
prepare_for_launch, prepare_for_launch,
setup_after_launch, setup_after_launch,
setup_before_launch, setup_before_launch,
setup_root_logger,
) )
...@@ -147,4 +148,5 @@ def cli(args=None): ...@@ -147,4 +148,5 @@ def cli(args=None):
if __name__ == "__main__": if __name__ == "__main__":
setup_root_logger()
cli() cli()
...@@ -20,6 +20,7 @@ from d2go.setup import ( ...@@ -20,6 +20,7 @@ from d2go.setup import (
prepare_for_launch, prepare_for_launch,
setup_after_launch, setup_after_launch,
setup_before_launch, setup_before_launch,
setup_root_logger,
) )
from d2go.trainer.api import TrainNetOutput from d2go.trainer.api import TrainNetOutput
from d2go.utils.misc import ( from d2go.utils.misc import (
...@@ -148,4 +149,5 @@ def build_cli_args( ...@@ -148,4 +149,5 @@ def build_cli_args(
if __name__ == "__main__": if __name__ == "__main__":
setup_root_logger()
cli() cli()
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment