Implement a central helper for converting arguments to CLI args

Summary:
Pull Request resolved: https://github.com/facebookresearch/d2go/pull/301

This is a follow-up of earlier work to extract part responsible for the
centrally defined parameters from the helper in train_net closer to where the
parameters are defined.

Reviewed By: tglik

Differential Revision: D37176212

fbshipit-source-id: 226415f36f4872ac3d9ba41541b4389a18cc11e6

d2go/setup.py

@@ -6,7 +6,7 @@ import argparse
 import logging
 import os
 import time
-from typing import Optional, Type, Union
+from typing import List, Optional, Type, Union
 
 import detectron2.utils.comm as comm
 import torch
@@ -81,6 +81,42 @@ def basic_argument_parser(
     return parser
 
 
+def build_basic_cli_args(
+    config_path: Optional[str] = None,
+    output_dir: Optional[str] = None,
+    runner_name: Optional[str] = None,
+    num_processes: Optional[Union[int, str]] = None,
+    num_machines: Optional[Union[int, str]] = None,
+    machine_rank: Optional[Union[int, str]] = None,
+    dist_url: Optional[str] = None,
+    dist_backend: Optional[str] = None,
+) -> List[str]:
+    """
+    Returns parameters in the form of CLI arguments for the binary using
+    basic_argument_parser to set up its argument parser.
+
+    For the parameters definition and meaning, see basic_argument_parser.
+    """
+    args: List[str] = []
+    if config_path is not None:
+        args += ["--config-file", config_path]
+    if output_dir is not None:
+        args += ["--output-dir", output_dir]
+    if runner_name is not None:
+        args += ["--runner", runner_name]
+    if num_processes is not None:
+        args += ["--num-processes", str(num_processes)]
+    if num_machines is not None:
+        args += ["--num-machines", str(num_machines)]
+    if machine_rank is not None:
+        args += ["--machine-rank", str(machine_rank)]
+    if dist_url is not None:
+        args += ["--dist-url", str(dist_url)]
+    if dist_backend is not None:
+        args += ["--dist-backend", str(dist_backend)]
+    return args
+
+
 def prepare_for_launch(args):
     """
     Load config, figure out working directory, create runner.

tools/train_net.py

@@ -7,12 +7,13 @@ Detection Training Script.
 
 import logging
 import sys
-from typing import List, Optional, Union
+from typing import List
 
 import detectron2.utils.comm as comm
 from d2go.distributed import launch
 from d2go.setup import (
     basic_argument_parser,
+    build_basic_cli_args,
     post_mortem_if_fail_for_main,
     prepare_for_launch,
     setup_after_launch,
@@ -105,36 +106,14 @@ def cli(args):
 
 
 def build_cli_args(
-    config_path: str,
-    output_dir: str,
-    runner_name: Optional[str] = None,
-    num_processes: Optional[Union[int, str]] = None,
-    num_machines: Optional[Union[int, str]] = None,
-    machine_rank: Optional[Union[int, str]] = None,
-    dist_url: Optional[str] = None,
-    dist_backend: Optional[str] = None,
     eval_only: bool = False,
     resume: bool = False,
+    **kwargs,
 ) -> List[str]:
-    """Returns parameters in the form of CLI arguments for train_net binary."""
-    args = [
-        "--config-file",
-        config_path,
-        "--output-dir",
-        output_dir,
-    ]
-    if runner_name is not None:
-        args += ["--runner", runner_name]
-    if num_processes is not None:
-        args += ["--num-processes", str(num_processes)]
-    if num_machines is not None:
-        args += ["--num-machines", str(num_machines)]
-    if machine_rank is not None:
-        args += ["--machine-rank", str(machine_rank)]
-    if dist_url is not None:
-        args += ["--dist-url", str(dist_url)]
-    if dist_backend is not None:
-        args += ["--dist-backend", str(dist_backend)]
+    """Returns parameters in the form of CLI arguments for train_net binary.
+
+    For the list of non-train_net-specific parameters, see build_basic_cli_args."""
+    args = build_basic_cli_args(**kwargs)
     if eval_only:
         args += ["--eval-only"]
     if resume: