Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
bitsandbytes
Commits
af034309
"csrc/pythonInterface.cpp" did not exist on "4cd7ea62b2f51c68aacde2f62e7141765e476111"
Commit
af034309
authored
Mar 09, 2023
by
Phil Wang
Browse files
fix weight decay for lion to be decoupled, using a switch
parent
ead570a4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
24 additions
and
4 deletions
+24
-4
csrc/kernels.cu
csrc/kernels.cu
+24
-4
No files found.
csrc/kernels.cu
View file @
af034309
...
@@ -1328,8 +1328,19 @@ kOptimizerStatic8bit1State(T* p, T* const g, unsigned char* state1,
...
@@ -1328,8 +1328,19 @@ kOptimizerStatic8bit1State(T* p, T* const g, unsigned char* state1,
{
{
g_val
=
float
(
g_vals
[
j
]);
g_val
=
float
(
g_vals
[
j
]);
g_val
*=
gnorm_scale
;
g_val
*=
gnorm_scale
;
if
(
weight_decay
>
0.0
f
)
g_val
+=
((
float
)
p_vals
[
j
])
*
weight_decay
;
if
(
weight_decay
>
0.0
f
)
{
switch
(
OPTIMIZER
)
{
case
MOMENTUM
:
case
RMSPROP
:
g_val
+=
((
float
)
p_vals
[
j
])
*
weight_decay
;
break
;
case
LION
:
p_vals
[
j
]
=
((
float
)
p_vals
[
j
])
*
(
1.0
f
-
lr
*
weight_decay
);
break
;
}
}
s1_vals
[
j
]
=
smem_quantiles1
[
c1s
[
j
]]
*
max1
[
0
];
s1_vals
[
j
]
=
smem_quantiles1
[
c1s
[
j
]]
*
max1
[
0
];
switch
(
OPTIMIZER
)
switch
(
OPTIMIZER
)
...
@@ -1677,8 +1688,17 @@ kOptimizerStatic8bit1StateBlockwise(T* p, T* __restrict__ const g, unsigned char
...
@@ -1677,8 +1688,17 @@ kOptimizerStatic8bit1StateBlockwise(T* p, T* __restrict__ const g, unsigned char
g_val
*=
gnorm_scale
;
g_val
*=
gnorm_scale
;
if
(
!
skip_zeros
||
(
skip_zeros
&&
((
float
)
g_vals
[
j
]
!=
0.0
f
)))
if
(
!
skip_zeros
||
(
skip_zeros
&&
((
float
)
g_vals
[
j
]
!=
0.0
f
)))
{
{
if
(
weight_decay
>
0.0
f
)
if
(
weight_decay
>
0.0
f
)
{
g_val
+=
((
float
)
p_vals
[
j
])
*
weight_decay
;
switch
(
OPTIMIZER
)
{
case
MOMENTUM
:
case
RMSPROP
:
g_val
+=
((
float
)
p_vals
[
j
])
*
weight_decay
;
break
;
case
LION
:
p_vals
[
j
]
=
((
float
)
p_vals
[
j
])
*
(
1.0
f
-
lr
*
weight_decay
);
break
;
}
}
s1_vals
[
j
]
=
smem_quantiles1
[
lane_id
][
c1s
[
j
]]
*
absmax1
[
i
/
BLOCK_SIZE
];
s1_vals
[
j
]
=
smem_quantiles1
[
lane_id
][
c1s
[
j
]]
*
absmax1
[
i
/
BLOCK_SIZE
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment