Do a full checkout instead of .git checkout

common_utils.sh

@@ -256,8 +256,8 @@ function fill_submodule {
     [ -d "$git_loc" ] && return
     # Need to recreate .git directory for submodule
     local origin_url=$(cd "$repo_dir" && git config --get remote.origin.url)
-    git clone --recursive --mirror "$repo_dir" "$repo_dir/.git-full"
-    rm "$git_loc"
-    mv "$repo_dir/.git-full" "$git_loc"
+    git clone --recursive "$repo_dir" "${repo_dir}-copy"
+    rm -rf "$repo_dir"
+    mv "${repo_dir}-copy" "$repo_dir"
     (cd "$repo_dir" && git remote set-url origin $origin_url)
 }

tests/test_fill_submodule.sh

@@ -27,6 +27,8 @@ cd project
 [ "$(git log --format="%s")" == "first project" ] || ingest "bad after filling"
 [ -d .git ] || ingest "expecting .git to be a directory"
 [ "$(git config --get remote.origin.url)" == "$remote_url" ] || ingest "bad remote"
+# Check we can do a checkout
+git checkout master
 cd ..
 # Intervene again (has .git directory now)
 fill_submodule project