Unverified Commit 2f102729 authored by Isuru Fernando's avatar Isuru Fernando Committed by GitHub
Browse files

Apply suggestions from code review


Co-authored-by: default avatarAndrew Murray <3112309+radarhere@users.noreply.github.com>
parent 2d2f3c29
......@@ -436,7 +436,7 @@ To use these scripts
There are two ways to build ``universal2`` builds.
1. Build with ``-arch x86_64 -arch arm64``.
These flags instruct the C/C++ compiler to compile twice and create a
fat object/executable/library. This is the easiest, but have several
fat object/executable/library. This is the easiest, but has several
drawbacks. If you are using C/C++ libraries that are built using
library_builders, it's highly likely that they don't build correctly
because most build systems and packages don't support building fat binaries.
......
......@@ -466,7 +466,7 @@ function fuse_macos_intel_arm64 {
if [[ -f "${whl_base}macosx_11_0_arm64.whl" ]]; then
delocate-fuse $whl "${whl_base}macosx_11_0_arm64.whl" -w tmp_fused_wheelhouse
mv tmp_fused_wheelhouse/$(basename $whl) $wheelhouse/$(basename ${whl_base})macosx_${py_osx_ver}_universal2.whl
# Since we want one wheel thats installable for testing we are deleting the *_x86_64 wheel.
# Since we want one wheel that's installable for testing we are deleting the *_x86_64 wheel.
# We are not deleting arm64 wheel because the size is lower and homebrew/conda-forge python
# will use them by default
rm $whl
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment