Commit 077c066f authored by Rob Buckley's avatar Rob Buckley
Browse files

swap args 2 and 3 for get_macpython_environment() for back compat

parent 061c1c06
...@@ -314,9 +314,6 @@ function get_macpython_environment { ...@@ -314,9 +314,6 @@ function get_macpython_environment {
# Parameters: # Parameters:
# $version : [implementation-]major[.minor[.patch]] # $version : [implementation-]major[.minor[.patch]]
# The Python implementation to install, e.g. "3.6" or "pypy-5.4" # The Python implementation to install, e.g. "3.6" or "pypy-5.4"
# $py_osx_ver: {major.minor | not defined}
# if defined, the macosx version that python is built for, e.g.
# "10.6" or "10.9", if not defined, uses the default MACPYTHON_DEFAULT_OSX
# $venv_dir : {directory_name|not defined} # $venv_dir : {directory_name|not defined}
# If defined - make virtualenv in this directory, set python / pip # If defined - make virtualenv in this directory, set python / pip
# commands accordingly # commands accordingly
...@@ -331,13 +328,13 @@ function get_macpython_environment { ...@@ -331,13 +328,13 @@ function get_macpython_environment {
# If $venv_dir defined, Sets $VIRTUALENV_CMD to virtualenv executable # If $venv_dir defined, Sets $VIRTUALENV_CMD to virtualenv executable
# Puts directory of $PYTHON_EXE on $PATH # Puts directory of $PYTHON_EXE on $PATH
local version=$1 local version=$1
local py_osx_ver=$2 local venv_dir=$2
local venv_dir=$3 local py_osx_ver=${3:-$MB_PYTHON_OSX_VER}
if [ "$USE_CCACHE" == "1" ]; then if [ "$USE_CCACHE" == "1" ]; then
activate_ccache activate_ccache
fi fi
remove_travis_ve_pip remove_travis_ve_pip
install_macpython $version $py_osx_ver install_macpython $version $py_osx_ver
install_pip install_pip
...@@ -394,4 +391,4 @@ function activate_ccache { ...@@ -394,4 +391,4 @@ function activate_ccache {
# Prove to the developer that ccache is activated # Prove to the developer that ccache is activated
echo "Using C compiler: $(which clang)" echo "Using C compiler: $(which clang)"
} }
\ No newline at end of file
...@@ -8,7 +8,7 @@ source tests/test_common_utils.sh ...@@ -8,7 +8,7 @@ source tests/test_common_utils.sh
source tests/test_fill_submodule.sh source tests/test_fill_submodule.sh
if [ -n "$IS_OSX" ]; then if [ -n "$IS_OSX" ]; then
source osx_utils.sh source osx_utils.sh
get_macpython_environment $PYTHON_VERSION ${MB_PYTHON_OSX_VER:-""} $VENV get_macpython_environment $PYTHON_VERSION ${VENV:-""} $MB_PYTHON_OSX_VER
source tests/test_python_install.sh source tests/test_python_install.sh
source tests/test_fill_pyver.sh source tests/test_fill_pyver.sh
source tests/test_fill_pypy_ver.sh source tests/test_fill_pypy_ver.sh
......
...@@ -21,7 +21,7 @@ function before_install { ...@@ -21,7 +21,7 @@ function before_install {
brew cask uninstall oclint || true brew cask uninstall oclint || true
export CC=clang export CC=clang
export CXX=clang++ export CXX=clang++
get_macpython_environment $MB_PYTHON_VERSION ${MB_PYTHON_OSX_VER:-""} venv get_macpython_environment $MB_PYTHON_VERSION venv
source venv/bin/activate source venv/bin/activate
pip install --upgrade pip wheel pip install --upgrade pip wheel
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment