Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
zhaoyu6
sglang
Commits
4319978c
"notebooks/Comparing TF and PT models_MLM_NSP.ipynb" did not exist on "8c932e37f9bb86efe6c08c7ef4f280a14455794f"
Unverified
Commit
4319978c
authored
May 10, 2025
by
Lianmin Zheng
Committed by
GitHub
May 10, 2025
Browse files
Fix data parallel perf regression (#6183)
parent
03dd785c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
7 deletions
+4
-7
.github/workflows/execute-notebook.yml
.github/workflows/execute-notebook.yml
+2
-5
python/sglang/srt/managers/data_parallel_controller.py
python/sglang/srt/managers/data_parallel_controller.py
+2
-2
No files found.
.github/workflows/execute-notebook.yml
View file @
4319978c
...
...
@@ -22,11 +22,6 @@ jobs:
-
name
:
Checkout code
uses
:
actions/checkout@v4
-
name
:
Set up Python
uses
:
actions/setup-python@v4
with
:
python-version
:
'
3.9'
-
name
:
Install dependencies
run
:
|
bash scripts/ci_install_dependency.sh
...
...
@@ -35,6 +30,8 @@ jobs:
apt-get install -y pandoc
apt-get update && apt-get install -y parallel retry
ln -sf "$(which python3)" /usr/bin/python
-
name
:
Setup Jupyter Kernel
run
:
|
python -m ipykernel install --user --name python3 --display-name "Python 3"
...
...
python/sglang/srt/managers/data_parallel_controller.py
View file @
4319978c
...
...
@@ -17,13 +17,13 @@ import logging
import
multiprocessing
as
mp
import
signal
import
threading
import
time
from
enum
import
Enum
,
auto
import
psutil
import
setproctitle
import
zmq
from
sglang.srt.disaggregation.utils
import
DisaggregationMode
from
sglang.srt.layers.dp_attention
import
compute_dp_attention_world_info
from
sglang.srt.managers.io_struct
import
(
TokenizedEmbeddingReqInput
,
...
...
@@ -158,7 +158,7 @@ class DataParallelController:
# This thread cannot be closed because otherwise the `kill_itself_when_parent_died`
# function in scheduler.py will kill the scheduler.
while
True
:
pass
time
.
sleep
(
30
*
24
*
3600
)
def
launch_dp_attention_schedulers
(
self
,
server_args
,
port_args
):
self
.
launch_tensor_parallel_group
(
server_args
,
port_args
,
0
,
None
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment