Commit 7203f37f authored by Gennadiy Civil's avatar Gennadiy Civil
Browse files

Merge pull request #2137 from ngie-eign:clang-ignore-sign-conversion

PiperOrigin-RevId: 235012245
parents 1411d27a fcf59ca7
...@@ -56,6 +56,7 @@ Google test has been used on a variety of platforms: ...@@ -56,6 +56,7 @@ Google test has been used on a variety of platforms:
* MinGW * MinGW
* Windows Mobile * Windows Mobile
* Symbian * Symbian
* PlatformIO
## Who Is Using Google Test? ## ## Who Is Using Google Test? ##
......
...@@ -252,7 +252,7 @@ command line. Generally, these macros are named like `GTEST_XYZ` and you define ...@@ -252,7 +252,7 @@ command line. Generally, these macros are named like `GTEST_XYZ` and you define
them to either 1 or 0 to enable or disable a certain feature. them to either 1 or 0 to enable or disable a certain feature.
We list the most frequently used macros below. For a complete list, see file We list the most frequently used macros below. For a complete list, see file
[include/gtest/internal/gtest-port.h](https://github.com/google/googletest/blob/master/include/gtest/internal/gtest-port.h). [include/gtest/internal/gtest-port.h](https://github.com/google/googletest/blob/master/googletest/include/gtest/internal/gtest-port.h).
### Multi-threaded Tests ### Multi-threaded Tests
......
...@@ -78,7 +78,7 @@ macro(config_compiler_and_linker) ...@@ -78,7 +78,7 @@ macro(config_compiler_and_linker)
# http://stackoverflow.com/questions/3232669 explains the issue. # http://stackoverflow.com/questions/3232669 explains the issue.
set(cxx_base_flags "${cxx_base_flags} -wd4702") set(cxx_base_flags "${cxx_base_flags} -wd4702")
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
set(cxx_base_flags "-Wall -Wshadow -Werror") set(cxx_base_flags "-Wall -Wshadow -Werror -Wno-error=sign-conversion")
set(cxx_exception_flags "-fexceptions") set(cxx_exception_flags "-fexceptions")
set(cxx_no_exception_flags "-fno-exceptions") set(cxx_no_exception_flags "-fno-exceptions")
elseif (CMAKE_COMPILER_IS_GNUCXX) elseif (CMAKE_COMPILER_IS_GNUCXX)
......
...@@ -1198,7 +1198,7 @@ also supports per-test-suite set-up/tear-down. To use it: ...@@ -1198,7 +1198,7 @@ also supports per-test-suite set-up/tear-down. To use it:
1. Outside your test fixture class (typically just below it), define those 1. Outside your test fixture class (typically just below it), define those
member variables, optionally giving them initial values. member variables, optionally giving them initial values.
1. In the same test fixture class, define a `static void SetUpTestSuite()` 1. In the same test fixture class, define a `static void SetUpTestSuite()`
function (remember not to spell it as **`SetUpTestSuite`** with a small `u`!) function (remember not to spell it as **`SetupTestSuite`** with a small `u`!)
to set up the shared resources and a `static void TearDownTestSuite()` to set up the shared resources and a `static void TearDownTestSuite()`
function to tear them down. function to tear them down.
...@@ -2430,7 +2430,7 @@ could generate this report: ...@@ -2430,7 +2430,7 @@ could generate this report:
"failures": 1, "failures": 1,
"errors": 0, "errors": 0,
"time": "0.035s", "time": "0.035s",
"timestamp": "2011-10-31T18:52:42Z" "timestamp": "2011-10-31T18:52:42Z",
"name": "AllTests", "name": "AllTests",
"testsuites": [ "testsuites": [
{ {
...@@ -2447,11 +2447,11 @@ could generate this report: ...@@ -2447,11 +2447,11 @@ could generate this report:
"classname": "", "classname": "",
"failures": [ "failures": [
{ {
"message": "Value of: add(1, 1)\x0A Actual: 3\x0AExpected: 2", "message": "Value of: add(1, 1)\n Actual: 3\nExpected: 2",
"type": "" "type": ""
}, },
{ {
"message": "Value of: add(1, -1)\x0A Actual: 1\x0AExpected: 0", "message": "Value of: add(1, -1)\n Actual: 1\nExpected: 0",
"type": "" "type": ""
} }
] ]
...@@ -2463,7 +2463,7 @@ could generate this report: ...@@ -2463,7 +2463,7 @@ could generate this report:
"classname": "" "classname": ""
} }
] ]
} },
{ {
"name": "LogicTest", "name": "LogicTest",
"tests": 1, "tests": 1,
...@@ -2517,4 +2517,3 @@ environment variable to `0`, or use the `--gtest_catch_exceptions=0` flag when ...@@ -2517,4 +2517,3 @@ environment variable to `0`, or use the `--gtest_catch_exceptions=0` flag when
running the tests. running the tests.
**Availability**: Linux, Windows, Mac. **Availability**: Linux, Windows, Mac.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment