Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
yangql
googletest
Commits
24696c39
Commit
24696c39
authored
Aug 14, 2017
by
Che-Hsun Liu
Committed by
GitHub
Aug 14, 2017
Browse files
Merge branch 'master' into master
parents
509f7fe8
673c975a
Changes
85
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
8 deletions
+8
-8
googletest/test/gtest_test_utils.py
googletest/test/gtest_test_utils.py
+1
-1
googletest/test/gtest_unittest.cc
googletest/test/gtest_unittest.cc
+2
-2
googletest/test/gtest_xml_outfiles_test.py
googletest/test/gtest_xml_outfiles_test.py
+1
-1
googletest/test/gtest_xml_output_unittest.py
googletest/test/gtest_xml_output_unittest.py
+1
-1
googletest/xcode/Scripts/versiongenerate.py
googletest/xcode/Scripts/versiongenerate.py
+3
-3
No files found.
googletest/test/gtest_test_utils.py
View file @
24696c39
...
...
@@ -245,7 +245,7 @@ class Subprocess:
p
=
subprocess
.
Popen
(
command
,
stdout
=
subprocess
.
PIPE
,
stderr
=
stderr
,
cwd
=
working_dir
,
universal_newlines
=
True
,
env
=
env
)
# communicate returns a tuple with the file obect for the child's
# communicate returns a tuple with the file ob
j
ect for the child's
# output.
self
.
output
=
p
.
communicate
()[
0
]
self
.
_return_code
=
p
.
returncode
...
...
googletest/test/gtest_unittest.cc
View file @
24696c39
...
...
@@ -1388,7 +1388,7 @@ class TestResultTest : public Test {
delete
r2
;
}
// Helper that compares two
two
TestPartResults.
// Helper that compares two TestPartResults.
static
void
CompareTestPartResult
(
const
TestPartResult
&
expected
,
const
TestPartResult
&
actual
)
{
EXPECT_EQ
(
expected
.
type
(),
actual
.
type
());
...
...
@@ -3689,7 +3689,7 @@ TEST(AssertionTest, ASSERT_EQ) {
TEST
(
AssertionTest
,
ASSERT_EQ_NULL
)
{
// A success.
const
char
*
p
=
NULL
;
// Some older GCC versions may issue a spurious waring in this or the next
// Some older GCC versions may issue a spurious war
n
ing in this or the next
// assertion statement. This warning should not be suppressed with
// static_cast since the test verifies the ability to use bare NULL as the
// expected parameter to the macro.
...
...
googletest/test/gtest_xml_outfiles_test.py
View file @
24696c39
...
...
@@ -105,7 +105,7 @@ class GTestXMLOutFilesTest(gtest_xml_test_utils.GTestXMLTestCase):
# TODO(wan@google.com): libtool causes the built test binary to be
# named lt-gtest_xml_outfiles_test_ instead of
# gtest_xml_outfiles_test_. To account for this possibil
l
ity, we
# gtest_xml_outfiles_test_. To account for this possibility, we
# allow both names in the following code. We should remove this
# hack when Chandler Carruth's libtool replacement tool is ready.
output_file_name1
=
test_name
+
".xml"
...
...
googletest/test/gtest_xml_output_unittest.py
View file @
24696c39
...
...
@@ -237,7 +237,7 @@ class GTestXMLOutputUnitTest(gtest_xml_test_utils.GTestXMLTestCase):
'--shut_down_xml'
]
p
=
gtest_test_utils
.
Subprocess
(
command
)
if
p
.
terminated_by_signal
:
# p.signal is avalable only if p.terminated_by_signal is True.
# p.signal is ava
i
lable only if p.terminated_by_signal is True.
self
.
assertFalse
(
p
.
terminated_by_signal
,
'%s was killed by signal %d'
%
(
GTEST_PROGRAM_NAME
,
p
.
signal
))
...
...
googletest/xcode/Scripts/versiongenerate.py
View file @
24696c39
...
...
@@ -42,7 +42,7 @@
1. The AC_INIT macro will be contained within the first 1024 characters
of configure.ac
2. The version string will be 3 integers separated by periods and will be
surrounded by squre brackets, "[" and "]" (e.g. [1.0.1]). The first
surrounded by squ
a
re brackets, "[" and "]" (e.g. [1.0.1]). The first
segment represents the major version, the second represents the minor
version and the third represents the fix version.
3. No ")" character exists between the opening "(" and closing ")" of
...
...
@@ -68,7 +68,7 @@ config_file.close()
# Extract the version string from the AC_INIT macro
# The following init_expression means:
# Extract three integers separated by periods and surrounded by squre
# Extract three integers separated by periods and surrounded by squ
a
re
# brackets(e.g. "[1.0.1]") between "AC_INIT(" and ")". Do not be greedy
# (*? is the non-greedy flag) since that would pull in everything between
# the first "(" and the last ")" in the file.
...
...
@@ -88,7 +88,7 @@ file_data = """//
// is executed in a "Run Script" build phase when creating gtest.framework. This
// header file is not used during compilation of C-source. Rather, it simply
// defines some version strings for substitution in the Info.plist. Because of
// this, we are not
not
restricted to C-syntax nor are we using include guards.
// this, we are not restricted to C-syntax nor are we using include guards.
//
#define GTEST_VERSIONINFO_SHORT %s.%s
...
...
Prev
1
2
3
4
5
Next
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment