Enhance parameter parsing to allow spaces in value (#397)

Enhance parameter parsing to support string like `"--arg1 value --arg2 'a long string with spaces'"`.

superbench/benchmarks/base.py

@@ -3,6 +3,7 @@
 
 """Module of the base class."""
 
+import shlex
 import signal
 import traceback
 import argparse
@@ -39,7 +40,7 @@ def __init__(self, name, parameters=''):
             parameters (str): benchmark parameters.
         """
         self._name = name
-        self._argv = list(filter(None, parameters.split(' '))) if parameters is not None else list()
+        self._argv = list(filter(None, shlex.split(parameters))) if parameters is not None else list()
         self._benchmark_type = None
         self._parser = argparse.ArgumentParser(
             add_help=False,

tests/benchmarks/micro_benchmarks/test_cublas_function.py

@@ -50,7 +50,7 @@ def test_cublas_functions():
     context = BenchmarkRegistry.create_benchmark_context(
         'cublas-function',
         platform=Platform.CUDA,
-        parameters='--num_warmup 10 --num_steps 10 --num_in_step 100 --config_json_str ' + custom_config_str
+        parameters=f"--num_warmup 10 --num_steps 10 --num_in_step 100 --config_json_str '{custom_config_str}'"
     )
 
     assert (BenchmarkRegistry.is_benchmark_context_valid(context))

tests/benchmarks/micro_benchmarks/test_cudnn_function.py

@@ -54,7 +54,7 @@ def test_cudnn_functions():
     context = BenchmarkRegistry.create_benchmark_context(
         'cudnn-function',
         platform=Platform.CUDA,
-        parameters='--num_warmup 10 --num_steps 10 --num_in_step 100 --config_json_str ' + custom_config_str
+        parameters=f"--num_warmup 10 --num_steps 10 --num_in_step 100 --config_json_str '{custom_config_str}'"
     )
 
     assert (BenchmarkRegistry.is_benchmark_context_valid(context))

tests/benchmarks/micro_benchmarks/test_ib_traffic_performance.py

@@ -178,14 +178,14 @@ def test_ib_traffic_performance(self, mock_gpu):
         assert (ret is True)
 
         # Generate config
-        parameters = '--ib_dev mlx5_0 --iters 2000 --msg_size 33554432 --hostfile hostfile'
+        parameters = '--ib_dev "$(echo mlx5_0)" --iters 2000 --msg_size 33554432 --hostfile hostfile'
         benchmark = benchmark_class(benchmark_name, parameters=parameters)
         os.environ['OMPI_COMM_WORLD_SIZE'] = '4'
         ret = benchmark._preprocess()
         Path('config.txt').unlink()
         assert (ret)
         expect_command = "ib_validation --cmd_prefix '" + benchmark._args.bin_dir + \
-            "/ib_write_bw -F -n 2000 -d mlx5_0 -s 33554432 --report_gbits' " + \
+            "/ib_write_bw -F -n 2000 -d $(echo mlx5_0) -s 33554432 --report_gbits' " + \
             f'--timeout 120 --hostfile hostfile --input_config {os.getcwd()}/config.txt'
         command = benchmark._bin_name + benchmark._commands[0].split(benchmark._bin_name)[1]
         assert (command == expect_command)