Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
tsoc
openmm
Commits
d5fa8d74
Commit
d5fa8d74
authored
Jan 18, 2016
by
jchodera
Browse files
Number of monovalent ions added is now correctly determined from ionic strength.
parent
2acba7ad
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
4 deletions
+5
-4
wrappers/python/simtk/openmm/app/modeller.py
wrappers/python/simtk/openmm/app/modeller.py
+5
-4
No files found.
wrappers/python/simtk/openmm/app/modeller.py
View file @
d5fa8d74
...
@@ -264,7 +264,7 @@ class Modeller(object):
...
@@ -264,7 +264,7 @@ class Modeller(object):
2. Water molecules are removed if their distance to any solute atom is less than the sum of their van der Waals radii.
2. Water molecules are removed if their distance to any solute atom is less than the sum of their van der Waals radii.
3. If the solute is charged and neutralize=True, enough positive or negative ions are added to neutralize it. Each ion is added by
3. If the solute is charged and neutralize=True, enough positive or negative ions are added to neutralize it. Each ion is added by
randomly selecting a water molecule and replacing it with the ion.
randomly selecting a water molecule and replacing it with the ion.
4. Ion pairs are added to give the requested total ionic strength.
4. Ion pairs are added to give the requested total ionic strength.
Note that only monovalent ions are currently supported.
The box size can be specified in any of several ways:
The box size can be specified in any of several ways:
...
@@ -298,6 +298,7 @@ class Modeller(object):
...
@@ -298,6 +298,7 @@ class Modeller(object):
ionicStrength : concentration=0*molar
ionicStrength : concentration=0*molar
the total concentration of ions (both positive and negative) to add. This
the total concentration of ions (both positive and negative) to add. This
does not include ions that are added to neutralize the system.
does not include ions that are added to neutralize the system.
Note that only monovalent ions are currently supported.
neutralize : bool=True
neutralize : bool=True
whether to add ions to neutralize the system
whether to add ions to neutralize the system
"""
"""
...
@@ -522,7 +523,7 @@ class Modeller(object):
...
@@ -522,7 +523,7 @@ class Modeller(object):
# Add ions based on the desired ionic strength.
# Add ions based on the desired ionic strength.
numIons
=
len
(
addedWaters
)
*
ionicStrength
/
(
55.4
*
molar
)
# Pure water is about 55.4 molar (depending on temperature)
numIons
=
len
(
addedWaters
)
*
ionicStrength
/
(
55.4
*
molar
)
# Pure water is about 55.4 molar (depending on temperature)
numPairs
=
int
(
floor
(
numIons
/
2
+
0.5
))
numPairs
=
int
(
floor
(
numIons
+
0.5
))
for
i
in
range
(
numPairs
):
for
i
in
range
(
numPairs
):
addIon
(
positiveElement
)
addIon
(
positiveElement
)
for
i
in
range
(
numPairs
):
for
i
in
range
(
numPairs
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment